Re: Discuss [VOTE] Release Apache Log4j Transformation Tools 0.1.0

I'm not willing to do anything on any hill here either and I'd rather gel with the team consensus, I've said my bits ;-) Gary On Tue, May 2, 2023 at 4:10 PM Volkan Yazıcı wrote: > > Email archives are irrelevant for the provenance of sources; an arbitrary > tag/commit not sealed with `rel/`

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

I am not able to follow: 88 LoC with ad-hoc exclusions . > Maven Assembly Plugin has reproducible builds. :-) You got me there. `git ls-tree | zip` requires an extra

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

Hi Volkan, On Tue, 2 May 2023 at 22:22, Volkan Yazıcı wrote: > Regarding `maven-assembly-plugin`... I simply don't get the motivation > behind replacing `git ls-files | zip` with hundreds of lines of XML > containing ad-hoc include/exclude statements in a module that needs to be > excluded in

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

What is the thing exactly cluttering here? It is as transparent as it can possibly get. Regarding `maven-assembly-plugin`... I simply don't get the motivation behind replacing `git ls-files | zip` with hundreds of lines of XML containing ad-hoc include/exclude statements in a module that needs to

Re: Discuss [VOTE] Release Apache Log4j Transformation Tools 0.1.0

Email archives are irrelevant for the provenance of sources; an arbitrary tag/commit not sealed with `rel/` prefix might disappear and we will lose the context to "what was proposed/rejected for release" . We don't have hundreds of releases with dozens of RCs for each. I would rather see my `git

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

Uh? It should NOT contain an exact copy of a git repository, what do I need a ".github" folder for in order to build the project? I don't, it just clutter things up for no good reason. None of the Apache projects I've seen do this. It sounds like a convenience because it's easy as opposed to

Re: Discuss [VOTE] Release Apache Log4j Transformation Tools 0.1.0

What you are proposing IMO is confusing and clutters up the release tag space: "rel" stands for "releases", not for "candidates for releases that may be completely broken" :-( It is of zero use to downstream users, and it is only being proposed out of the convenience because some tool does it,

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

I completely disagree. Generated ZIP archive contains _an exact copy_ of the repository snapshot used to generate the release. (In a nutshell, it is `git ls-files | zip` output.) Contrast this with Log4j, which bundles everything out there using the provided configuration composed of dozens of

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

I agree that we should share the link to the `KEYS` file, granted that we also share the signing key's public ID. As a side note, the shared link is not a random one; it is the one used by Nexus to verify the signatures. (Yes, I am aware that Nexus is not recognized as an official distribution

Re: Discuss [VOTE] Release Apache Log4j Transformation Tools 0.1.0

I support the idea of using `rel/`-prefixed tags both for releases and RCs (release candidates). It matters for provenance, which is of subject for RCs too, in particular, the downvoted ones. Next to that, it is intuitive, one doesn't need to remember two different patterns to access releases and

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

I don’t see release notes or a download link at that site. Personally, I think the side nav link should be under a new “related projects” heading rather than making it appear that it is a component of Log4j2 itself. FWIW, I am leaving this under the vote thread since it sounds like you are

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

+1 Tests the src zip, asc and SHA file OK despite the SHA file being broken as Ralph noted (there should not be a target folder in the name). mvn clean verify OK with: Apache Maven 3.9.1 (2e178502fcdbffc201671fb2537d0cb4b4cc58f8) Maven home: C:\java\apache-maven-3.9.1 Java version: 17.0.7,

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

HI Ralph: Nitpicking: I'm pretty sure you're supposed to test the src zip, not the repo. In theory these two are different because the zip should not contain extra non-source junk like the .github folder. Gary On 2023/05/02 04:29:22 Ralph Goers wrote: > +1 > > I checked out the tag and built

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

Another needed clean-up (not a blocker): The zip file has all sorts of git junk: a .github folder, a .gitignore file, and a .mvn folder (I certainly don't want extra maven junk either but that's just me)? There should only _sources_, not a snapshot of all files in the github repo. For example,

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

Note: > Signing key: > https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0=on=index A random link on the internet is irrelevant, what matters is what is in our KEYS file at: https://downloads.apache.org/logging/KEYS Gary On 2023/05/01 19:09:37 "Piotr P.

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

Hi, On Mon, 1 May 2023 at 21:09, Piotr P. Karwasz wrote: > * [LOG4J2-3638]: Adds a bytecode transformation tool to provide > location information without reflection. There is a small but pesky restriction in the Maven plugin: there is no includes/excludes setting. While not a problem for the

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

Hi, On Mon, 1 May 2023 at 21:09, Piotr P. Karwasz wrote: > Source repository: https://github.com/apache/logging-log4j-transform > Tag: rel/0.1.0-rc2 > Commit: 7bb767c1466cd9faebfeeffa8136b231bf2b6fae > Artifacts: > https://dist.apache.org/repos/dist/dev/logging/log4j-transform/0.1.0 > Nexus

Re: Discuss [VOTE] Release Apache Log4j Transformation Tools 0.1.0

Hi Ralph, On Tue, 2 May 2023 at 06:31, Ralph Goers wrote: > > One more issue. I see no reference to a web site containing release notes and > a download page. At a minimum the download page is required to send the > announcement email. Sorry, I forgot to give the link in the vote e-mail. The

Re: Discuss [VOTE] Release Apache Log4j Transformation Tools 0.1.0

Hi Ralph, On Tue, 2 May 2023 at 00:09, Ralph Goers wrote: > > 1. As noted below you tagged with red/0.1.0-rc2. You really shouldn’t be > using rel/ as a tag for candidates. Instead use something like tools-1.0-rc2. > rel tags are treated special by Infra and are meant for ONLY the “real” >

Re: Discuss [VOTE] Release Apache Log4j Transformation Tools 0.1.0

One more issue. I see no reference to a web site containing release notes and a download page. At a minimum the download page is required to send the announcement email. Ralph > On May 1, 2023, at 8:41 PM, Ralph Goers wrote: > > Regarding item 2. I found build.log and am tailing it and I

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

+1 I checked out the tag and built the transformer and then ran it against one of my projects at work and verified it generated some Log4j2Cache classes. I verified the signature. I verified the checksum. While it is a good checksum the file name included in the .sha512 file is

Re: Discuss [VOTE] Release Apache Log4j Transformation Tools 0.1.0

Regarding item 2. I found build.log and am tailing it and I see that it is downloading a ton of dependencies for running its. I am tailing the log and as long as it keeps moving I guess it is OK. Ralph > On May 1, 2023, at 3:09 PM, Ralph Goers wrote: > > 1. As noted below you tagged with

Re: Discuss [VOTE] Release Apache Log4j Transformation Tools 0.1.0

To refine Ralph's point, once the vote passes, you create the rel/ tag which should point to the SAME commit as the successful RC tag. Gary On Mon, May 1, 2023, 18:09 Ralph Goers wrote: > 1. As noted below you tagged with red/0.1.0-rc2. You really shouldn’t be > using rel/ as a tag for

Discuss [VOTE] Release Apache Log4j Transformation Tools 0.1.0

1. As noted below you tagged with red/0.1.0-rc2. You really shouldn’t be using rel/ as a tag for candidates. Instead use something like tools-1.0-rc2. rel tags are treated special by Infra and are meant for ONLY the “real” release tags (in this case 1.0). 2. I checked out the tag and ran the

[VOTE] Release Apache Log4j Transformation Tools 0.1.0

The Apache Log4j Transformation Tools 0.1.0 release is now available for voting. This is the first release and it contains two modules: * [LOG4J2-3638]: Adds a bytecode transformation tool to provide location information without reflection. * [LOG4J2-673]: Adds a resource transformer for the