Re: Misconfigured gradle rat inputs?

2021-05-25 Thread Dawid Weiss
Yep, looks like missing inputs and the task is skipped. Good catch, Alan. I can look a this later too, Uwe (just create an issue and assign to me). On Tue, May 25, 2021 at 7:40 PM Uwe Schindler wrote: > Hi, > > the problem is that the RAT task has only some patterns for filenames as > input,

Re: Misconfigured gradle rat inputs?

2021-05-25 Thread Alan Woodward
I will defer to the sophisticated gradle policeman on this! > On 25 May 2021, at 18:40, Uwe Schindler wrote: > > Hi, > > the problem is that the RAT task has only some patterns for filenames as > input, but no actual @InputDirectory. If the files change, nothing changes > from Gradle's point

RE: Misconfigured gradle rat inputs?

2021-05-25 Thread Uwe Schindler
Hi, the problem is that the RAT task has only some patterns for filenames as input, but no actual @InputDirectory. If the files change, nothing changes from Gradle's point of view. The validation/rat-sources.gradle and its inner class "RatTask" must at least declare @InputDirectory with a

Misconfigured gradle rat inputs?

2021-05-25 Thread Alan Woodward
There’s a subject line I never thought I’d type :) Firstly: can I say how much I appreciate all the work that’s gone into the gradle build? I’ve been doing lots of small PRs for the spans-to-queries work and being able to run checks multiple times in an extremely efficient manner has been a

Re: Circuit Breakers -- SOLR-15056

2021-05-25 Thread Walter Underwood
Has anyone had a chance to look at this for 8.9? wunder Walter Underwood wun...@wunderwood.org http://observer.wunderwood.org/ (my blog) > On May 6, 2021, at 10:03 AM, Walter Underwood wrote: > > Understood, getting well is more important. > > wunder > Walter Underwood >

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-05-25 Thread Colvin Cowie
Hello, Eric was going to have a look at the PR. But if it isn't done in time then I don't think it needs to block the release Thanks On Tue, 25 May 2021 at 15:50, Mayya Sharipova wrote: > Hello Colvin, > I am wondering if you still want to merge SOLR-15410 for the Lucene/Solr > 8.9 release? >

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-05-25 Thread Mayya Sharipova
Hello Colvin, I am wondering if you still want to merge SOLR-15410 for the Lucene/Solr 8.9 release? Should we have a deadline for feature freeze? Say May 30th (Sunday)? Thank you. On Tue, May 18, 2021 at 8:49 AM Noble Paul wrote: > +1 > > > On Tue, May 18, 2021 at 9:30 PM Colvin Cowie >

Re: Should segment order impact hit count estimation?

2021-05-25 Thread Michael McCandless
Great, thanks for the explanation Adrien! I still learn something new about Lucene every day ;) Mike McCandless http://blog.mikemccandless.com On Mon, May 24, 2021 at 1:38 PM Adrien Grand wrote: > Indeed collectors keep state about the minimum required score for a hit to > be competitive,

Re: What is the status and what are the next steps re k-nn search?

2021-05-25 Thread Michael McCandless
Awesome, thanks Michael! Mike McCandless http://blog.mikemccandless.com On Mon, May 24, 2021 at 2:57 PM Michael Wechner wrote: > Hi Michael > > Thanks very much for your feedback! > > I have added a FAQ > > >

Re: Lucene 9.0 snapshot names

2021-05-25 Thread Dawid Weiss
> On a different note, does gradle use the same configuration for when we do > actual releases? I’m still confused as to why it wanted my GPG password in > plaintext in a file somewhere. > I don't think we've done a proper release with gradle workflow. I can't remember doing much in that area -

Re: Lucene 9.0 snapshot names

2021-05-25 Thread Alan Woodward
> On 25 May 2021, at 11:24, Dawid Weiss > wrote: > > > Ok. In that case we can make it simpler by not adding the signing plugin to > that (local) maven publication? Unless it makes sense to have it. Let me > know, this is a trivial change. +1, that would be

Re: Lucene 9.0 snapshot names

2021-05-25 Thread Dawid Weiss
Ok. In that case we can make it simpler by not adding the signing plugin to that (local) maven publication? Unless it makes sense to have it. Let me know, this is a trivial change. D. On Tue, May 25, 2021 at 8:36 AM Uwe Schindler wrote: > Maven consumers only needs checksums to work correctly.

Re: Lucene 9.0 snapshot names

2021-05-25 Thread Uwe Schindler
Maven consumers only needs checksums to work correctly. The signatures are optional. Uwe Am May 25, 2021 6:16:08 AM UTC schrieb Dawid Weiss : >These signatures are what makes a Maven repository a Maven repository >though. Even when you "deploy" to a local folder, it preserves the >files

Re: Lucene 9.0 snapshot names

2021-05-25 Thread Dawid Weiss
These signatures are what makes a Maven repository a Maven repository though. Even when you "deploy" to a local folder, it preserves the files required for other Maven-toolchain tools. I'm not sure how it behaves without signatures. It is entirely doable to create a non-maven-task based assembly