[
https://issues.apache.org/jira/browse/LUCENE-5345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827920#comment-13827920
]
Shai Erera commented on LUCENE-5345:
I don't think that's the case (but I'm not near
[
https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13828524#comment-13828524
]
Shai Erera commented on LUCENE-5189:
You're right Simon. The updates are buffered
[
https://issues.apache.org/jira/browse/LUCENE-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13826570#comment-13826570
]
Shai Erera commented on LUCENE-5339:
{quote}
Hmm, that's iffy. First off, IW also
+1 smoke tester happy.
Shai
On Tue, Nov 19, 2013 at 7:11 PM, Adrien Grand jpou...@gmail.com wrote:
+1
--
Adrien
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13825408#comment-13825408
]
Shai Erera commented on LUCENE-5339:
Thanks Mike! Currently, int and float
[
https://issues.apache.org/jira/browse/LUCENE-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13824833#comment-13824833
]
Shai Erera commented on LUCENE-5339:
{quote}
I'm not sure how this can work, since
[
https://issues.apache.org/jira/browse/LUCENE-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13823466#comment-13823466
]
Shai Erera commented on LUCENE-5339:
I don't think it's 100% wrong - look at all
I think it would be useful if the release notes (both core solr) made
some descriptive comment about what's different in the new Lucene46Codec -
not just that Lucene46FieldInfosFormat and Lucene46SegmentInfosFormat are
new, but why/how they are different/better then the previous version.
[
https://issues.apache.org/jira/browse/LUCENE-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13824407#comment-13824407
]
Shai Erera commented on LUCENE-5339:
About IntEncoder, one thing it lets us do today
[
https://issues.apache.org/jira/browse/LUCENE-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13822273#comment-13822273
]
Shai Erera commented on LUCENE-5339:
About FacetIndexWriter, it will need to take
Smoke tester passes for me. +1!
Shai
On Thu, Nov 14, 2013 at 11:37 AM, Simon Willnauer simon.willna...@gmail.com
wrote:
Please vote for the first Release Candidate for Lucene/Solr 4.6.0
you can download it here:
[
https://issues.apache.org/jira/browse/LUCENE-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13822450#comment-13822450
]
Shai Erera commented on LUCENE-5339:
About the patch:
* I think FacetField should
[
https://issues.apache.org/jira/browse/LUCENE-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5215.
Resolution: Fixed
Fix Version/s: 5.0
4.6
Committed to 4x under LUCENE
[
https://issues.apache.org/jira/browse/LUCENE-5216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5216.
Resolution: Fixed
Fix Version/s: 5.0
4.6
Assignee: Shai Erera
[
https://issues.apache.org/jira/browse/LUCENE-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5248.
Resolution: Fixed
Fix Version/s: 5.0
4.6
Committed to 4x under LUCENE
[
https://issues.apache.org/jira/browse/LUCENE-5246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5246.
Resolution: Fixed
Fix Version/s: 5.0
4.6
Committed to 4x under LUCENE
[
https://issues.apache.org/jira/browse/LUCENE-5216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13822561#comment-13822561
]
Shai Erera commented on LUCENE-5216:
Thanks Steve, will try to keep that in mind. I
[
https://issues.apache.org/jira/browse/LUCENE-5216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13822567#comment-13822567
]
Shai Erera commented on LUCENE-5216:
Cool!
Fix SegmentInfo.attributes when updates
Congratulations Uwe!
Shai
On Fri, Nov 15, 2013 at 6:34 AM, Shalin Shekhar Mangar
shalinman...@gmail.com wrote:
Many congratulations Uwe!
On Fri, Nov 15, 2013 at 1:41 AM, Uwe Schindler u...@thetaphi.de wrote:
The PMC Chair is going to marry tomorrow... Simon has to come here and
not
do
[
https://issues.apache.org/jira/browse/LUCENE-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13823304#comment-13823304
]
Shai Erera commented on LUCENE-5339:
bq. I think that's an acceptable risk
[
https://issues.apache.org/jira/browse/LUCENE-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821139#comment-13821139
]
Shai Erera commented on LUCENE-5339:
Some comments about the patch:
* You have
[
https://issues.apache.org/jira/browse/LUCENE-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821296#comment-13821296
]
Shai Erera commented on LUCENE-5316:
Can we finish the Map with int[] approach? I
[
https://issues.apache.org/jira/browse/LUCENE-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13822232#comment-13822232
]
Shai Erera commented on LUCENE-5339:
bq. Can we rename CategoryPath to FacetLabel
[
https://issues.apache.org/jira/browse/LUCENE-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818801#comment-13818801
]
Shai Erera commented on LUCENE-5333:
I talked with Gilad about it and he suggested
[
https://issues.apache.org/jira/browse/LUCENE-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5333:
---
Attachment: LUCENE-5333.patch
Patch add AllDimensionsFacetResultsHandler as a quick prototype
[
https://issues.apache.org/jira/browse/LUCENE-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818844#comment-13818844
]
Shai Erera commented on LUCENE-5333:
Actually, if we move FacetResultsHandler
[
https://issues.apache.org/jira/browse/LUCENE-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818394#comment-13818394
]
Shai Erera commented on LUCENE-5327:
I don't think the API isn't useful, just
[
https://issues.apache.org/jira/browse/LUCENE-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818443#comment-13818443
]
Shai Erera commented on LUCENE-5316:
Mike, I looked at the different runs results
[
https://issues.apache.org/jira/browse/LUCENE-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818466#comment-13818466
]
Shai Erera commented on LUCENE-5333:
bq. Well, I think the facet module already has
[
https://issues.apache.org/jira/browse/LUCENE-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818494#comment-13818494
]
Shai Erera commented on LUCENE-5316:
Gilad still hasn't uploaded a new patch w
[
https://issues.apache.org/jira/browse/LUCENE-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5333:
---
Attachment: LUCENE-5333.patch
Here's the simple way I thought about - AllFacetsAccumulator takes
[
https://issues.apache.org/jira/browse/LUCENE-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818525#comment-13818525
]
Shai Erera commented on LUCENE-5333:
There's also a third option:
* We add
[
https://issues.apache.org/jira/browse/LUCENE-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818375#comment-13818375
]
Shai Erera commented on LUCENE-5327:
I think it will look odd to have DV API
[
https://issues.apache.org/jira/browse/LUCENE-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818379#comment-13818379
]
Shai Erera commented on LUCENE-5333:
Why is it an overkill? Same AllFacetsAccumulator
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13817138#comment-13817138
]
Shai Erera commented on LUCENE-5325:
bq. Shai Erera, have you already started
[
https://issues.apache.org/jira/browse/LUCENE-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13817327#comment-13817327
]
Shai Erera commented on LUCENE-5333:
Duh, good point! :).
I think
[
https://issues.apache.org/jira/browse/LUCENE-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13816282#comment-13816282
]
Shai Erera commented on LUCENE-5333:
A simple way to achieve that is to write
[
https://issues.apache.org/jira/browse/LUCENE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5297:
---
Attachment: LUCENE-5297.patch
Handled the nocommits (improved javadocs). All range tests pass and I
[
https://issues.apache.org/jira/browse/LUCENE-5326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812721#comment-13812721
]
Shai Erera commented on LUCENE-5326:
Why does the app need to explicitly add
Fixed.
Shai
On Mon, Nov 4, 2013 at 11:59 AM, Apache Jenkins Server
jenk...@builds.apache.org wrote:
Build: https://builds.apache.org/job/Lucene-Solr-Tests-4.x-Java6/2134/
1 tests failed.
REGRESSION:
org.apache.lucene.demo.facet.TestExpressionAggregationFacetsExample.testSimple
Error
[
https://issues.apache.org/jira/browse/LUCENE-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812786#comment-13812786
]
Shai Erera commented on LUCENE-5316:
Thanks for doing this Mike! (it's not trivial
[
https://issues.apache.org/jira/browse/LUCENE-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812790#comment-13812790
]
Shai Erera commented on LUCENE-5316:
I looked at ParallelArraysChildrenIterator and I
[
https://issues.apache.org/jira/browse/LUCENE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5297.
Resolution: Fixed
Fix Version/s: 5.0
4.6
Assignee: Shai Erera
[
https://issues.apache.org/jira/browse/LUCENE-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812294#comment-13812294
]
Shai Erera commented on LUCENE-5316:
Few comments
[
https://issues.apache.org/jira/browse/LUCENE-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812315#comment-13812315
]
Shai Erera commented on LUCENE-5316:
{quote}
I'm not sure .getChildren() should
[
https://issues.apache.org/jira/browse/LUCENE-5298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5298:
---
Attachment: LUCENE-5298.patch
Patch adds ValueSourceFacetRequest which takes a ValueSource
[
https://issues.apache.org/jira/browse/LUCENE-5298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5298:
---
Attachment: LUCENE-5298.patch
Same patch only renamed to SumValueSourceFacetRequest and improved
[
https://issues.apache.org/jira/browse/LUCENE-5298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812441#comment-13812441
]
Shai Erera commented on LUCENE-5298:
In order to compile, we need to have ValueSource
Shai Erera created LUCENE-5325:
--
Summary: Move ValueSource and FunctionValues under core/
Key: LUCENE-5325
URL: https://issues.apache.org/jira/browse/LUCENE-5325
Project: Lucene - Core
Issue
[
https://issues.apache.org/jira/browse/LUCENE-5298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812463#comment-13812463
]
Shai Erera commented on LUCENE-5298:
ok I opened LUCENE-5325.
Allow aggregating
[
https://issues.apache.org/jira/browse/LUCENE-5298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5298.
Resolution: Fixed
Fix Version/s: 5.0
4.6
Assignee: Shai Erera
[
https://issues.apache.org/jira/browse/LUCENE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5297:
---
Attachment: LUCENE-5297.patch
Patch extends RangeFacetRequest to take also a ValueSource
[
https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5189.
Resolution: Fixed
Fix Version/s: 5.0
4.6
Finished backporting
[
https://issues.apache.org/jira/browse/LUCENE-5321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5321:
---
Attachment: LUCENE-5321.patch
I ended up removing everything under o.a.l.facet.codecs/, including
[
https://issues.apache.org/jira/browse/LUCENE-5321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812089#comment-13812089
]
Shai Erera commented on LUCENE-5321:
I'll add the test back with the assumeTrue. I'm
[
https://issues.apache.org/jira/browse/LUCENE-5321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5321.
Resolution: Fixed
Fix Version/s: 5.0
4.6
Assignee: Shai Erera
[
https://issues.apache.org/jira/browse/LUCENE-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812112#comment-13812112
]
Shai Erera commented on LUCENE-5316:
Using NO_PARENTS is not that simple decision
[
https://issues.apache.org/jira/browse/LUCENE-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812260#comment-13812260
]
Shai Erera commented on LUCENE-5316:
How about if you make up a hierarchical category
[
https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13811070#comment-13811070
]
Shai Erera commented on LUCENE-5189:
Backported to 4x. I'll handle the TODO
[
https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5189:
---
Attachment: LUCENE-5189-renames.patch
Handle TODO (DVU_RENAME) comments. It's really a rote
[
https://issues.apache.org/jira/browse/LUCENE-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13811269#comment-13811269
]
Shai Erera commented on LUCENE-5296:
Now that we have this codec, does it make sense
Shai Erera created LUCENE-5320:
--
Summary: Create SearcherTaxonomyManager over Directory
Key: LUCENE-5320
URL: https://issues.apache.org/jira/browse/LUCENE-5320
Project: Lucene - Core
Issue Type
Shai Erera created LUCENE-5321:
--
Summary: Remove Facet42DocValuesFormat
Key: LUCENE-5321
URL: https://issues.apache.org/jira/browse/LUCENE-5321
Project: Lucene - Core
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/LUCENE-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13811866#comment-13811866
]
Shai Erera commented on LUCENE-5296:
+1. I opened LUCENE-5321 since I want to address
[
https://issues.apache.org/jira/browse/LUCENE-5308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13806157#comment-13806157
]
Shai Erera commented on LUCENE-5308:
It's a nice idea. You could probably do
[
https://issues.apache.org/jira/browse/LUCENE-5308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13806158#comment-13806158
]
Shai Erera commented on LUCENE-5308:
Another comment -- instead of per dimension
[
https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5189:
---
Attachment: LUCENE-5189-4x.patch
Patch covers the work from all the issues, ported to 4x (created w
Is there any reason to rush? We've released 4.5.0 just 3 weeks ago.
Shai
On Thu, Oct 24, 2013 at 4:54 PM, Adrien Grand jpou...@gmail.com wrote:
+1
--
Adrien
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
OK, thanks for giving the heads up so early then!
Shai
On Thu, Oct 24, 2013 at 5:14 PM, Adrien Grand jpou...@gmail.com wrote:
On Thu, Oct 24, 2013 at 4:03 PM, Shai Erera ser...@gmail.com wrote:
Is there any reason to rush? We've released 4.5.0 just 3 weeks ago.
I don't think there is any
[
https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13804246#comment-13804246
]
Shai Erera commented on LUCENE-5189:
I think it's ready to backport to 4x.
Numeric
[
https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5189:
---
Attachment: LUCENE-5189-segdv.patch
I reviewed the issue and noticed I forgot to handle
[
https://issues.apache.org/jira/browse/LUCENE-5303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13803196#comment-13803196
]
Shai Erera commented on LUCENE-5303:
Good catch!
I guess we should use a compound
[
https://issues.apache.org/jira/browse/LUCENE-5303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5303:
---
Attachment: LUCENE-5303.patch
Patch changes the map to be a WeakHashMapObject,MapString,CachedOrds
[
https://issues.apache.org/jira/browse/LUCENE-5303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5303.
Resolution: Fixed
Assignee: Shai Erera (was: Michael McCandless)
Lucene Fields
currently not many stored
fields in each document, but I might look at using FieldSelector to ensure
I only read the field I’m looking for.
** **
Thanks for looking at this,
Steve
** **
** **
*From:* Shai Erera [mailto:ser...@gmail.com]
*Sent:* Friday, 18 October 2013 8:28 PM
Shai Erera created LUCENE-5297:
--
Summary: Allow rang faceting on any ValueSource
Key: LUCENE-5297
URL: https://issues.apache.org/jira/browse/LUCENE-5297
Project: Lucene - Core
Issue Type: New
Shai Erera created LUCENE-5298:
--
Summary: Allow aggregating facets by any ValueSource
Key: LUCENE-5298
URL: https://issues.apache.org/jira/browse/LUCENE-5298
Project: Lucene - Core
Issue Type
Hi Stephen,
The code seems correct in general (I have some comments below). The
ordinals that you get are those that are associated with that document
(docID). I assume this is not the newest Lucene though, right?
Can you boil this down to a simple testcase adding a couple of documents
with the
[
https://issues.apache.org/jira/browse/LUCENE-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13796511#comment-13796511
]
Shai Erera commented on LUCENE-5248:
Committed this to trunk after a night's
Then when you want to rerun your test and limit to that
particular method you need to glob somehow because these descriptions
no longer correspond to raw method names
I think it is related but not sure, yet it bugs me. When I want to run same
method with iterations I need to specify
, as repeatLuceneTest.py does what
tests.iters and tests.dups do together -- multiple JVMs and each JVM gets
to pick its own seed.
Shai
On Tue, Oct 15, 2013 at 3:06 PM, Robert Muir rcm...@gmail.com wrote:
On Tue, Oct 15, 2013 at 7:38 AM, Shai Erera ser...@gmail.com wrote:
I think it is related but not sure, yet
That's what I've seen too -- it picks the master seed once and then all
iters pick their own derivative seeds. So if the test is random at the
before/after/test level, it usually was enough to find bugs after many
iterations.
Shai
On Tue, Oct 15, 2013 at 4:26 PM, Dawid Weiss
Hi
If you run something like ant test -Dtestcase=TestFoo where there's no
TestFoo.java, or ant test -Dtestcase=TestBar -Dtests.method=testFoo where
there's TestBar.java but no testFoo() method, the build currently passes as
SUCCESSFUL. Though, the report says 0 suits or 1 suits, 0 tests.
I
[
https://issues.apache.org/jira/browse/LUCENE-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5248:
---
Attachment: LUCENE-5248.patch
Patch tracks docsWithFields in a parallel bitset to the docs/values
executed. I don't see thr benefit of failing the build.
In any case, this would belong to the runner.
D.
On Oct 14, 2013 2:17 PM, Shai Erera ser...@gmail.com wrote:
Hi
If you run something like ant test -Dtestcase=TestFoo where there's no
TestFoo.java, or ant test -Dtestcase=TestBar
I see, didn't think about that usecase. Ok so let's not do it.
Shai
On Mon, Oct 14, 2013 at 4:27 PM, Robert Muir rcm...@gmail.com wrote:
On Mon, Oct 14, 2013 at 9:11 AM, Shai Erera ser...@gmail.com wrote:
What's the harm of failing the build in that case?
because i should be able
[
https://issues.apache.org/jira/browse/LUCENE-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794195#comment-13794195
]
Shai Erera commented on LUCENE-5248:
We can even move the test to TestIWExceptions
Welcome Ryan!
On Oct 14, 2013 9:56 PM, Simon Willnauer simon.willna...@gmail.com
wrote:
Welcome Ryan!
On Mon, Oct 14, 2013 at 8:54 PM, Shawn Heisey s...@elyograg.org wrote:
On 10/14/2013 11:27 AM, Adrien Grand wrote:
I'm pleased to announce that Ryan Ernst has accepted to join our ranks
[
https://issues.apache.org/jira/browse/LUCENE-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5272.
Resolution: Fixed
Fix Version/s: 5.0
4.6
Assignee: Shai Erera
[
https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793579#comment-13793579
]
Shai Erera commented on LUCENE-5189:
Thanks for the comments Mike, I fixed the code
[
https://issues.apache.org/jira/browse/LUCENE-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5277.
Resolution: Fixed
Fix Version/s: 5.0
4.6
Lucene Fields: New,Patch
[
https://issues.apache.org/jira/browse/LUCENE-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793637#comment-13793637
]
Shai Erera commented on LUCENE-5272:
I was about to post an updated patch when I
[
https://issues.apache.org/jira/browse/LUCENE-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793686#comment-13793686
]
Shai Erera commented on LUCENE-5272:
I don't think we need to deprecate anything
[
https://issues.apache.org/jira/browse/LUCENE-5281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera reassigned LUCENE-5281:
--
Assignee: Shai Erera
NPE: TestDirectoryTaxonomyReader.testGetChildren
[
https://issues.apache.org/jira/browse/LUCENE-5281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793695#comment-13793695
]
Shai Erera commented on LUCENE-5281:
Thanks for reporting, I'll check.
NPE
[
https://issues.apache.org/jira/browse/LUCENE-5281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793709#comment-13793709
]
Shai Erera commented on LUCENE-5281:
It was a test bug. I'll commit a fix shortly
[
https://issues.apache.org/jira/browse/LUCENE-5281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5281.
Resolution: Fixed
Fix Version/s: 5.0
4.6
Committed to trunk and 4x
[
https://issues.apache.org/jira/browse/LUCENE-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5272:
---
Attachment: LUCENE-5272.patch
I didn't fix all the issues that I raised because I'm not sure what's
[
https://issues.apache.org/jira/browse/LUCENE-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793217#comment-13793217
]
Shai Erera commented on LUCENE-5277:
I thought of that ... it started in LUCENE-5248
[
https://issues.apache.org/jira/browse/LUCENE-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793221#comment-13793221
]
Shai Erera commented on LUCENE-5248:
bq. Do we have test coverage of updating
901 - 1000 of 4461 matches
Mail list logo
