[jira] [Resolved] (LUCENE-5272) OpenBitSet.ensureCapacity does not modify numBits

2013-10-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5272. Resolution: Fixed Fix Version/s: 5.0 4.6 Assignee: Shai Erera

[jira] [Commented] (LUCENE-5248) Improve the data structure used in ReaderAndLiveDocs to hold the updates

2013-10-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13794195#comment-13794195 ] Shai Erera commented on LUCENE-5248: We can even move the test to TestIWExceptions, b

[jira] [Updated] (LUCENE-5248) Improve the data structure used in ReaderAndLiveDocs to hold the updates

2013-10-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5248: --- Attachment: LUCENE-5248.patch Patch tracks docsWithFields in a parallel bitset to the docs/values ar

[jira] [Updated] (LUCENE-5272) OpenBitSet.ensureCapacity does not modify numBits

2013-10-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5272: --- Attachment: LUCENE-5272.patch I didn't fix all the issues that I raised because I'm not sure what's

[jira] [Resolved] (LUCENE-5281) NPE: TestDirectoryTaxonomyReader.testGetChildren

2013-10-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5281. Resolution: Fixed Fix Version/s: 5.0 4.6 Committed to trunk and 4x (but

[jira] [Commented] (LUCENE-5281) NPE: TestDirectoryTaxonomyReader.testGetChildren

2013-10-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793709#comment-13793709 ] Shai Erera commented on LUCENE-5281: It was a test bug. I'll commit a fix shortly. >

[jira] [Commented] (LUCENE-5281) NPE: TestDirectoryTaxonomyReader.testGetChildren

2013-10-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793695#comment-13793695 ] Shai Erera commented on LUCENE-5281: Thanks for reporting, I'll check. > NPE: TestDi

[jira] [Assigned] (LUCENE-5281) NPE: TestDirectoryTaxonomyReader.testGetChildren

2013-10-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera reassigned LUCENE-5281: -- Assignee: Shai Erera > NPE: TestDirectoryTaxonomyReader.testGetChildren >

[jira] [Commented] (LUCENE-5272) OpenBitSet.ensureCapacity does not modify numBits

2013-10-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793686#comment-13793686 ] Shai Erera commented on LUCENE-5272: I don't think we need to deprecate anything as t

[jira] [Commented] (LUCENE-5272) OpenBitSet.ensureCapacity does not modify numBits

2013-10-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793637#comment-13793637 ] Shai Erera commented on LUCENE-5272: I was about to post an updated patch when I real

[jira] [Resolved] (LUCENE-5277) Modify FixedBitSet copy constructor to take numBits to allow grow/shrink the new bitset

2013-10-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5277. Resolution: Fixed Fix Version/s: 5.0 4.6 Lucene Fields: New,Patch Ava

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-12 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793579#comment-13793579 ] Shai Erera commented on LUCENE-5189: Thanks for the comments Mike, I fixed the code.

[jira] [Updated] (LUCENE-5189) Numeric DocValues Updates

2013-10-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5189: --- Attachment: LUCENE-5189-no-lost-updates.patch Add field updates to TestIndexWriterDelete.testNoLostD

[jira] [Commented] (LUCENE-5248) Improve the data structure used in ReaderAndLiveDocs to hold the updates

2013-10-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793224#comment-13793224 ] Shai Erera commented on LUCENE-5248: bq. I added a unit test which reproduces and the

[jira] [Commented] (LUCENE-5248) Improve the data structure used in ReaderAndLiveDocs to hold the updates

2013-10-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793221#comment-13793221 ] Shai Erera commented on LUCENE-5248: bq. Do we have test coverage of updating with nu

[jira] [Commented] (LUCENE-5277) Modify FixedBitSet copy constructor to take numBits to allow grow/shrink the new bitset

2013-10-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793217#comment-13793217 ] Shai Erera commented on LUCENE-5277: I thought of that ... it started in LUCENE-5248

[jira] [Updated] (LUCENE-5277) Modify FixedBitSet copy constructor to take numBits to allow grow/shrink the new bitset

2013-10-10 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5277: --- Attachment: LUCENE-5277.patch Patch adds the extra parameter and tests. I think it's ok to not depre

[jira] [Created] (LUCENE-5277) Modify FixedBitSet copy constructor to take numBits to allow grow/shrink the new bitset

2013-10-10 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5277: -- Summary: Modify FixedBitSet copy constructor to take numBits to allow grow/shrink the new bitset Key: LUCENE-5277 URL: https://issues.apache.org/jira/browse/LUCENE-5277 P

[jira] [Updated] (LUCENE-5272) OpenBitSet.ensureCapacity does not modify numBits

2013-10-10 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5272: --- Attachment: LUCENE-5272.patch Progress thus far: fixes ensureCapacity(Words) to set numBits correctl

[jira] [Commented] (LUCENE-5272) OpenBitSet.ensureCapacity does not modify numBits

2013-10-10 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13792338#comment-13792338 ] Shai Erera commented on LUCENE-5272: After fixing the bug, I realized that the API of

[jira] [Created] (LUCENE-5272) OpenBitSet.ensureCapacity does not modify numBits

2013-10-09 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5272: -- Summary: OpenBitSet.ensureCapacity does not modify numBits Key: LUCENE-5272 URL: https://issues.apache.org/jira/browse/LUCENE-5272 Project: Lucene - Core Issue T

[jira] [Commented] (LUCENE-5248) Improve the data structure used in ReaderAndLiveDocs to hold the updates

2013-10-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13791146#comment-13791146 ] Shai Erera commented on LUCENE-5248: bq. should UpdatesIterator implement DISI? It se

[jira] [Updated] (LUCENE-5248) Improve the data structure used in ReaderAndLiveDocs to hold the updates

2013-10-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5248: --- Attachment: LUCENE-5248.patch Patch replaces MapNumericFieldUpdates with PackedNumericFieldUpdates w

[jira] [Commented] (LUCENE-5263) Deletes may be silently lost if an IOException is hit and later not hit (e.g., disk fills up and then frees up)

2013-10-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13789159#comment-13789159 ] Shai Erera commented on LUCENE-5263: Patch looks great. * I like IOUtils.reThrow - t

[jira] [Commented] (LUCENE-5263) Deletes may be silently lost if disk fills up and then frees up

2013-10-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13789009#comment-13789009 ] Shai Erera commented on LUCENE-5263: I ported this test to verify NDV updates aren't

[jira] [Commented] (LUCENE-5263) Deletes may be silently lost if disk fills up and then frees up

2013-10-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13789001#comment-13789001 ] Shai Erera commented on LUCENE-5263: One other comment -- I think you can move the ne

[jira] [Commented] (LUCENE-5263) Deletes may be silently lost if disk fills up and then frees up

2013-10-07 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788959#comment-13788959 ] Shai Erera commented on LUCENE-5263: These are nice catches :). Few comments: * This

[jira] [Resolved] (LUCENE-5262) StandardDirectoryReader should decRef readers on exception, not close them

2013-10-07 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5262. Resolution: Fixed Fix Version/s: 4.6 5.0 Lucene Fields: New,Patch Ava

[jira] [Updated] (LUCENE-5262) StandardDirectoryReader should decRef readers on exception, not close them

2013-10-07 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5262: --- Attachment: LUCENE-5262.patch Patch adds testNRTOpenExceptions to TestIndexWriterReader which simula

[jira] [Created] (LUCENE-5262) StandardDirectoryReader should decRef readers on exception, not close them

2013-10-07 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5262: -- Summary: StandardDirectoryReader should decRef readers on exception, not close them Key: LUCENE-5262 URL: https://issues.apache.org/jira/browse/LUCENE-5262 Project: Lucen

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787730#comment-13787730 ] Shai Erera commented on LUCENE-5189: bq. If SR itself doesnt need ref-counting, perha

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787688#comment-13787688 ] Shai Erera commented on LUCENE-5189: bq. because there isn't a single DVP that all SR

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787683#comment-13787683 ] Shai Erera commented on LUCENE-5189: Let me explain: SCR is still used for all the sh

[jira] [Updated] (LUCENE-5248) Improve the data structure used in ReaderAndLiveDocs to hold the updates

2013-10-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5248: --- Attachment: LUCENE-5248.patch Patch adds following changes: * NumericFieldUpdates abstraction for h

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787576#comment-13787576 ] Shai Erera commented on LUCENE-5189: Committed a fix to SegmentReader (r1529611) to c

[jira] [Commented] (LUCENE-5228) IndexWriter.addIndexes copies raw files but acquires no locks

2013-10-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13786107#comment-13786107 ] Shai Erera commented on LUCENE-5228: The problem is with Directories that don't suppo

[jira] [Updated] (LUCENE-5189) Numeric DocValues Updates

2013-10-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5189: --- Attachment: LUCENE-5189-updates-order.patch As I continued to work on LUCENE-5248, I realized that t

[jira] [Updated] (LUCENE-5189) Numeric DocValues Updates

2013-10-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5189: --- Attachment: LUCENE-5189-updates-order.patch While debugging LUCENE-5248, I've hit a bug when same te

[jira] [Comment Edited] (LUCENE-5248) Improve the data structure used in ReaderAndLiveDocs to hold the updates

2013-10-01 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783697#comment-13783697 ] Shai Erera edited comment on LUCENE-5248 at 10/2/13 6:24 AM: -

[jira] [Commented] (LUCENE-5248) Improve the data structure used in ReaderAndLiveDocs to hold the updates

2013-10-01 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783697#comment-13783697 ] Shai Erera commented on LUCENE-5248: Hmm, maybe the problem is not RUE, but the fact

[jira] [Commented] (LUCENE-5248) Improve the data structure used in ReaderAndLiveDocs to hold the updates

2013-10-01 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783691#comment-13783691 ] Shai Erera commented on LUCENE-5248: Forgot to mention, I tried to use RamUsageEstima

[jira] [Updated] (LUCENE-5248) Improve the data structure used in ReaderAndLiveDocs to hold the updates

2013-10-01 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5248: --- Attachment: LUCENE-5248.patch Patch improves the test and also hacks a solution -- in BufferedDelet

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-01 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782802#comment-13782802 ] Shai Erera commented on LUCENE-5189: Looks good. Thanks Simon. > Numeric DocValues U

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-01 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782782#comment-13782782 ] Shai Erera commented on LUCENE-5189: Thanks Simon, good catch. I think there's no tes

[jira] [Commented] (LUCENE-5248) Improve the data structure used in ReaderAndLiveDocs to hold the updates

2013-10-01 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782768#comment-13782768 ] Shai Erera commented on LUCENE-5248: One thing to note though, is if we never buffer

[jira] [Updated] (LUCENE-5248) Improve the data structure used in ReaderAndLiveDocs to hold the updates

2013-09-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5248: --- Attachment: LUCENE-5248.patch Patch with testTonsOfUpdates: it's a real nasty test with which I hit

[jira] [Commented] (LUCENE-5248) Improve the data structure used in ReaderAndLiveDocs to hold the updates

2013-09-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782227#comment-13782227 ] Shai Erera commented on LUCENE-5248: I discussed that w/ Mike on chat and here's the

[jira] [Commented] (LUCENE-5248) Improve the data structure used in ReaderAndLiveDocs to hold the updates

2013-09-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781966#comment-13781966 ] Shai Erera commented on LUCENE-5248: I thought about it some more ... perhaps there's

[jira] [Commented] (LUCENE-5248) Improve the data structure used in ReaderAndLiveDocs to hold the updates

2013-09-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781933#comment-13781933 ] Shai Erera commented on LUCENE-5248: Another option, maybe even unrelated to this iss

[jira] [Commented] (LUCENE-5248) Improve the data structure used in ReaderAndLiveDocs to hold the updates

2013-09-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781924#comment-13781924 ] Shai Erera commented on LUCENE-5248: I discussed briefly the details of the first dat

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781914#comment-13781914 ] Shai Erera commented on LUCENE-5189: I opened LUCENE-5248 to handle the data structur

[jira] [Created] (LUCENE-5248) Improve the data structure used in ReaderAndLiveDocs to hold the updates

2013-09-30 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5248: -- Summary: Improve the data structure used in ReaderAndLiveDocs to hold the updates Key: LUCENE-5248 URL: https://issues.apache.org/jira/browse/LUCENE-5248 Project: Lucene

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781868#comment-13781868 ] Shai Erera commented on LUCENE-5189: I don't mind if we backport the whole thing in o

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781797#comment-13781797 ] Shai Erera commented on LUCENE-5189: I wrote (somewhere, don't remember where) that I

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781731#comment-13781731 ] Shai Erera commented on LUCENE-5189: I don't understand - why can't it live in 4x and

[jira] [Updated] (LUCENE-5189) Numeric DocValues Updates

2013-09-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5189: --- Attachment: LUCENE-5189-4x.patch Backported all the changes related to this issue to 4x. All tests p

[jira] [Commented] (LUCENE-5216) Fix SegmentInfo.attributes when updates are involved

2013-09-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781486#comment-13781486 ] Shai Erera commented on LUCENE-5216: Committed to trunk. Will backport to 4x after I

[jira] [Commented] (LUCENE-5246) SegmentInfoPerCommit continues to list unneeded updatesFiles

2013-09-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781455#comment-13781455 ] Shai Erera commented on LUCENE-5246: Committed this to trunk. Keeping open until the

[jira] [Commented] (LUCENE-5215) Add support for FieldInfos generation

2013-09-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781397#comment-13781397 ] Shai Erera commented on LUCENE-5215: Thanks Han, though I wish the commit message was

[jira] [Commented] (LUCENE-5215) Add support for FieldInfos generation

2013-09-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781391#comment-13781391 ] Shai Erera commented on LUCENE-5215: Why didn't I get any error though while running

[jira] [Updated] (LUCENE-5246) SegmentInfoPerCommit continues to list unneeded updatesFiles

2013-09-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5246: --- Attachment: LUCENE-5246.patch Thanks for the comments Mike. I modified the test to do atLeast(100) o

[jira] [Updated] (LUCENE-5246) SegmentInfoPerCommit continues to list unneeded updatesFiles

2013-09-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5246: --- Attachment: LUCENE-5246.patch Patch fixes SIPC to only track the files that are used by the differen

[jira] [Created] (LUCENE-5246) SegmentInfoPerCommit continues to list unneeded updatesFiles

2013-09-29 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5246: -- Summary: SegmentInfoPerCommit continues to list unneeded updatesFiles Key: LUCENE-5246 URL: https://issues.apache.org/jira/browse/LUCENE-5246 Project: Lucene - Core

[jira] [Updated] (LUCENE-5216) Fix SegmentInfo.attributes when updates are involved

2013-09-28 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5216: --- Attachment: LUCENE-5216.patch Patch for trunk: * Remove SegmentInfo.attributes() and related method

[jira] [Commented] (LUCENE-5215) Add support for FieldInfos generation

2013-09-27 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13780722#comment-13780722 ] Shai Erera commented on LUCENE-5215: Committed to trunk. I'll move on to LUCENE-5216

[jira] [Commented] (LUCENE-5215) Add support for FieldInfos generation

2013-09-26 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778764#comment-13778764 ] Shai Erera commented on LUCENE-5215: bq. As long as its just bound by #formats and no

[jira] [Updated] (LUCENE-5215) Add support for FieldInfos generation

2013-09-25 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5215: --- Attachment: LUCENE-5215.patch Fixed some places which referenced Lucene45 (javadocs, comments etc.).

[jira] [Commented] (LUCENE-5215) Add support for FieldInfos generation

2013-09-25 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13777279#comment-13777279 ] Shai Erera commented on LUCENE-5215: bq. e.g. search for 4.5, Lucene45, such strings

[jira] [Updated] (LUCENE-5242) DirectoryTaxonomyWriter.replaceTaxonomy did not fully reset its state

2013-09-24 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5242: --- Summary: DirectoryTaxonomyWriter.replaceTaxonomy did not fully reset its state (was: DirectoryTaxon

[jira] [Resolved] (LUCENE-5242) DirectoryTaxonomyWriter.replaceTaxonomy did not fully reset its state

2013-09-24 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5242. Resolution: Fixed Fix Version/s: 4.6 5.0 Committed to trunk and 4x.

[jira] [Updated] (LUCENE-5242) DirectoryTaxonomyWriter.replaceTaxonomy does not nullify taxoArrays

2013-09-24 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5242: --- Attachment: LUCENE-5242.patch Patch adds a test + fixes the bug. This could also result in wrong ord

[jira] [Created] (LUCENE-5242) DirectoryTaxonomyWriter.replaceTaxonomy does not nullify taxoArrays

2013-09-24 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5242: -- Summary: DirectoryTaxonomyWriter.replaceTaxonomy does not nullify taxoArrays Key: LUCENE-5242 URL: https://issues.apache.org/jira/browse/LUCENE-5242 Project: Lucene - Cor

[jira] [Commented] (LUCENE-5239) Scary TestSearcherManager failure

2013-09-24 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776321#comment-13776321 ] Shai Erera commented on LUCENE-5239: It did reproduce with the seed. But because the

[jira] [Commented] (LUCENE-5239) Scary TestSearcherManager failure

2013-09-24 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776226#comment-13776226 ] Shai Erera commented on LUCENE-5239: Thanks for fixing Mike! I ran 1600 iters and the

[jira] [Resolved] (LUCENE-5237) StemmerUtil.deleteN may delete too many characters

2013-09-24 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5237. Resolution: Fixed Fix Version/s: 4.6 5.0 Lucene Fields: New,Patch Ava

[jira] [Updated] (LUCENE-5239) Scary TestSearcherManager failure

2013-09-24 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5239: --- Attachment: TestSearcherManager.testSearcherManager.0.t1.log LUCENE-5239.patch I've

[jira] [Commented] (LUCENE-5237) StemmerUtil.deleteN may delete too many characters

2013-09-24 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776089#comment-13776089 ] Shai Erera commented on LUCENE-5237: OK will do. Thanks! > StemmerUt

[jira] [Updated] (LUCENE-5215) Add support for FieldInfos generation

2013-09-23 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5215: --- Attachment: LUCENE-5215.patch bq. could we remove SCR.fieldInfos entirely? Done. bq. I mean techni

[jira] [Updated] (LUCENE-5237) StemmerUtil.deleteN may delete too many characters

2013-09-23 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5237: --- Attachment: LUCENE-5237.patch Added asserts to both methods as well as \@lucene.internal. Also added

[jira] [Commented] (LUCENE-5237) StemmerUtil.deleteN may delete too many characters

2013-09-23 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13774485#comment-13774485 ] Shai Erera commented on LUCENE-5237: bq. You called delete. By definition, this short

[jira] [Commented] (LUCENE-5237) StemmerUtil.deleteN may delete too many characters

2013-09-23 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13774446#comment-13774446 ] Shai Erera commented on LUCENE-5237: let me clarify something -- if the code that's u

[jira] [Commented] (LUCENE-5237) StemmerUtil.deleteN may delete too many characters

2013-09-23 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1377#comment-1377 ] Shai Erera commented on LUCENE-5237: bq. assertion would also be ok I think ok that'

[jira] [Commented] (LUCENE-5237) StemmerUtil.deleteN may delete too many characters

2013-09-23 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13774443#comment-13774443 ] Shai Erera commented on LUCENE-5237: bq. I'd rather have some warning that the stemme

[jira] [Commented] (LUCENE-5237) StemmerUtil.deleteN may delete too many characters

2013-09-23 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13774442#comment-13774442 ] Shai Erera commented on LUCENE-5237: bq. This isn't a bug: if you delete the last cha

[jira] [Updated] (LUCENE-5237) StemmerUtil.deleteN may delete too many characters

2013-09-23 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5237: --- Attachment: LUCENE-5237.patch Fixed the bug, I also handled the TODO in deleteN. >

[jira] [Created] (LUCENE-5237) StemmerUtil.deleteN may delete too many characters

2013-09-23 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5237: -- Summary: StemmerUtil.deleteN may delete too many characters Key: LUCENE-5237 URL: https://issues.apache.org/jira/browse/LUCENE-5237 Project: Lucene - Core Issue

[jira] [Updated] (LUCENE-5234) Clarify FieldCache API around the use of NumericDocValues fields

2013-09-21 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5234: --- Attachment: LUCENE-5234.patch Patch improves the javadocs of Int/Float/Long/DoubleFieldSource as wel

[jira] [Commented] (LUCENE-5232) Remove doMaxScore from indexsearcher, collector specializations, etc

2013-09-20 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13773730#comment-13773730 ] Shai Erera commented on LUCENE-5232: Well, maybe start with why computing maxScore at

[jira] [Updated] (LUCENE-5234) Clarify FieldCache API around the use of NumericDocValues fields

2013-09-20 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5234: --- Attachment: LUCENE-5234.patch Initial patch improving "longs" javadocs. I think same improvements ca

[jira] [Created] (LUCENE-5234) Clarify FieldCache API around the use of NumericDocValues fields

2013-09-20 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5234: -- Summary: Clarify FieldCache API around the use of NumericDocValues fields Key: LUCENE-5234 URL: https://issues.apache.org/jira/browse/LUCENE-5234 Project: Lucene - Core

[jira] [Commented] (LUCENE-5232) Remove doMaxScore from indexsearcher, collector specializations, etc

2013-09-20 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13773721#comment-13773721 ] Shai Erera commented on LUCENE-5232: Maybe we can fix the API by making maxScore priv

[jira] [Updated] (LUCENE-5215) Add support for FieldInfos generation

2013-09-20 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5215: --- Attachment: LUCENE-5215.patch Patch with --show-copies-as-adds > Add support for Fi

[jira] [Commented] (LUCENE-5232) Remove doMaxScore from indexsearcher, collector specializations, etc

2013-09-20 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13773708#comment-13773708 ] Shai Erera commented on LUCENE-5232: bq. just have a HuperDuperTopFieldCollector.crea

[jira] [Commented] (LUCENE-5229) remove Collector specializations

2013-09-20 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13773097#comment-13773097 ] Shai Erera commented on LUCENE-5229: bq. nuke doMaxScores. its implicit from doScores

[jira] [Updated] (LUCENE-5215) Add support for FieldInfos generation

2013-09-20 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5215: --- Attachment: LUCENE-5215.patch Fixed BasePostingsFormatTestCase to initialize Lucene46Codec (not 45).

[jira] [Updated] (LUCENE-5215) Add support for FieldInfos generation

2013-09-19 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5215: --- Attachment: LUCENE-5215.patch Patch removes Facet45Codec, updates jdocs and updates to latest trunk

[jira] [Updated] (LUCENE-5215) Add support for FieldInfos generation

2013-09-16 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5215: --- Attachment: LUCENE-5215.patch Patch adds FieldInfos generation: * SegmentInfoPerCommit manages fiel

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-16 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768274#comment-13768274 ] Shai Erera commented on LUCENE-5189: Jenkins reported this failure, which I'm unable

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-16 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768271#comment-13768271 ] Shai Erera commented on LUCENE-5189: bq. SegmentWriteState flushState; in DWPT is unu

[jira] [Commented] (LUCENE-5215) Add support for FieldInfos generation

2013-09-15 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768107#comment-13768107 ] Shai Erera commented on LUCENE-5215: Ok I'll add just segmentSuffix

<    4   5   6   7   8   9   10   11   12   13   >