[jira] [Commented] (LUCENE-5404) Add support to get number of entries a Suggester Lookup was built with and minor refactorings

2014-02-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13895026#comment-13895026 ] ASF subversion and git services commented on LUCENE-5404: - Commit

[jira] [Commented] (LUCENE-5404) Add support to get number of entries a Suggester Lookup was built with and minor refactorings

2014-02-07 Thread Areek Zillur (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13895035#comment-13895035 ] Areek Zillur commented on LUCENE-5404: -- Minor change made count is long (was int).

[jira] [Commented] (LUCENE-5404) Add support to get number of entries a Suggester Lookup was built with and minor refactorings

2014-02-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13895027#comment-13895027 ] ASF subversion and git services commented on LUCENE-5404: - Commit

[jira] [Commented] (LUCENE-5404) Add support to get number of entries a Suggester Lookup was built with and minor refactorings

2014-02-05 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13891977#comment-13891977 ] Michael McCandless commented on LUCENE-5404: +1, patch looks great, thanks

[jira] [Commented] (LUCENE-5404) Add support to get number of entries a Suggester Lookup was built with and minor refactorings

2014-02-05 Thread Areek Zillur (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13892656#comment-13892656 ] Areek Zillur commented on LUCENE-5404: -- Thanks for the review Micheal! I will commit

[jira] [Commented] (LUCENE-5404) Add support to get number of entries a Suggester Lookup was built with and minor refactorings

2014-02-03 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13889408#comment-13889408 ] Michael McCandless commented on LUCENE-5404: Thanks Areek. {quote} Regarding

[jira] [Commented] (LUCENE-5404) Add support to get number of entries a Suggester Lookup was built with and minor refactorings

2014-02-02 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1399#comment-1399 ] Michael McCandless commented on LUCENE-5404: I think it's a little strange to

[jira] [Commented] (LUCENE-5404) Add support to get number of entries a Suggester Lookup was built with and minor refactorings

2014-02-02 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13888982#comment-13888982 ] Robert Muir commented on LUCENE-5404: - {quote} Or, we can keep the .getCount, but

[jira] [Commented] (LUCENE-5404) Add support to get number of entries a Suggester Lookup was built with and minor refactorings

2014-02-02 Thread Areek Zillur (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13889069#comment-13889069 ] Areek Zillur commented on LUCENE-5404: -- Thanks for the feedback :) I was thinking

[jira] [Commented] (LUCENE-5404) Add support to get number of entries a Suggester Lookup was built with and minor refactorings

2014-01-29 Thread Areek Zillur (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885833#comment-13885833 ] Areek Zillur commented on LUCENE-5404: -- I like this idea, I can see how the count

[jira] [Commented] (LUCENE-5404) Add support to get number of entries a Suggester Lookup was built with and minor refactorings

2014-01-26 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882575#comment-13882575 ] Robert Muir commented on LUCENE-5404: - I guess mainly I wonder if we should just add

[jira] [Commented] (LUCENE-5404) Add support to get number of entries a Suggester Lookup was built with and minor refactorings

2014-01-25 Thread Areek Zillur (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882105#comment-13882105 ] Areek Zillur commented on LUCENE-5404: -- [~rcmuir] Any thoughts on the proposed API

[jira] [Commented] (LUCENE-5404) Add support to get number of entries a Suggester Lookup was built with and minor refactorings

2014-01-18 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875611#comment-13875611 ] Michael McCandless commented on LUCENE-5404: Thanks Areek, this looks great.

[jira] [Commented] (LUCENE-5404) Add support to get number of entries a Suggester Lookup was built with and minor refactorings

2014-01-18 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875736#comment-13875736 ] Robert Muir commented on LUCENE-5404: - I'm a little confused with the count() being