[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745085#comment-16745085
]
ASF subversion and git services commented on LUCENE-8581:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745080#comment-16745080
]
ASF subversion and git services commented on LUCENE-8581:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745072#comment-16745072
]
ASF subversion and git services commented on LUCENE-8581:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744792#comment-16744792
]
Adrien Grand commented on LUCENE-8581:
--
+1
> Change LatLonShape encoding to use 4 BYTES Per
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734770#comment-16734770
]
David Smiley commented on LUCENE-8581:
--
I attached a patch about this.
> Change LatLonShape
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726177#comment-16726177
]
David Smiley commented on LUCENE-8581:
--
It may be that there is some logic/encoding/decoding that
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726112#comment-16726112
]
Adrien Grand commented on LUCENE-8581:
--
bq. Why is Rectangle2D referring to LatLonShape.BYTES ?
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725086#comment-16725086
]
David Smiley commented on LUCENE-8581:
--
Great work!
I was looking through the code and found some
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724781#comment-16724781
]
Adrien Grand commented on LUCENE-8581:
--
According to luceneutil this change gives 8% faster box
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724186#comment-16724186
]
Adrien Grand commented on LUCENE-8581:
--
+1
> Change LatLonShape encoding to use 4 BYTES Per
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724178#comment-16724178
]
Nicholas Knize commented on LUCENE-8581:
Thanks for all of your work on this [~ivera]. This
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723352#comment-16723352
]
Nicholas Knize commented on LUCENE-8581:
Everything's looking good. +1 to merge once these last
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723224#comment-16723224
]
Nicholas Knize commented on LUCENE-8581:
{quote}Then let's also rename constants so that they
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723189#comment-16723189
]
Adrien Grand commented on LUCENE-8581:
--
Then let's also rename constants so that they enumerate
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723186#comment-16723186
]
Nicholas Knize commented on LUCENE-8581:
{quote}I got you, new patch rotates edges and indeed
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721336#comment-16721336
]
Adrien Grand commented on LUCENE-8581:
--
+1 Let's get [~nknize]'s opinion about whether to go with
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719097#comment-16719097
]
Adrien Grand commented on LUCENE-8581:
--
bq. The last thing remaining is which orientation should we
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718189#comment-16718189
]
Lucene/Solr QA commented on LUCENE-8581:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710425#comment-16710425
]
Lucene/Solr QA commented on LUCENE-8581:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709022#comment-16709022
]
Nicholas Knize commented on LUCENE-8581:
{quote}Just for my curiosity. when creating a triangle
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1670#comment-1670
]
Ignacio Vera commented on LUCENE-8581:
--
{quote}it seems that giving all triangles the same
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708520#comment-16708520
]
Adrien Grand commented on LUCENE-8581:
--
It seems that giving all triangles the same orientation
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708434#comment-16708434
]
Ignacio Vera commented on LUCENE-8581:
--
{quote}I think it would be good to keep the calls to
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707612#comment-16707612
]
Nicholas Knize commented on LUCENE-8581:
Thanks [~ivera]
{{setTriangleValue((aLon), (aLat),
24 matches
Mail list logo
