[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959936#comment-13959936
]
Dawid Weiss commented on SOLR-5914:
---
I've committed some cleanups to the branch but I
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955025#comment-13955025
]
Dawid Weiss commented on SOLR-5914:
---
Anyway, we always seem to have been on the same
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954720#comment-13954720
]
Mark Miller commented on SOLR-5914:
---
bq. I looked at the current state of the branch,
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954725#comment-13954725
]
Mark Miller commented on SOLR-5914:
---
bq. This is not possible.
I didn't put that there
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954731#comment-13954731
]
Mark Miller commented on SOLR-5914:
---
Just to make things simpler, take what I'm looking
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954735#comment-13954735
]
Mark Miller commented on SOLR-5914:
---
To be explicit about the main work to do on that
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954759#comment-13954759
]
ASF subversion and git services commented on SOLR-5914:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954447#comment-13954447
]
Dawid Weiss commented on SOLR-5914:
---
I looked at the current state of the branch, Mark,
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954456#comment-13954456
]
Dawid Weiss commented on SOLR-5914:
---
Just looking at the diff file:
{code}
+
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950467#comment-13950467
]
Dawid Weiss commented on SOLR-5914:
---
Uh, damn, I just noticed you already merged, Mark.
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950465#comment-13950465
]
Dawid Weiss commented on SOLR-5914:
---
Hey. I don't know if I'll be able to go back to
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950470#comment-13950470
]
Dawid Weiss commented on SOLR-5914:
---
Just a quick follow-up -- is there any other reason
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950651#comment-13950651
]
Mark Miller commented on SOLR-5914:
---
bq. is there any other reason for dataDir to exist
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951034#comment-13951034
]
ASF subversion and git services commented on SOLR-5914:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949126#comment-13949126
]
Dawid Weiss commented on SOLR-5914:
---
I've looked at refactoring it a bit. The temporary
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949145#comment-13949145
]
Dawid Weiss commented on SOLR-5914:
---
I've created a branch at
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949297#comment-13949297
]
Mark Miller commented on SOLR-5914:
---
You can't fix them easily - that's why I created the
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949300#comment-13949300
]
Mark Miller commented on SOLR-5914:
---
(At least the spellcheck ones - I don't know what
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949305#comment-13949305
]
Dawid Weiss commented on SOLR-5914:
---
They won't pass on the branch -- the criterion of
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949328#comment-13949328
]
Uwe Schindler commented on SOLR-5914:
-
I think the most important thing in the new
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949333#comment-13949333
]
Dawid Weiss commented on SOLR-5914:
---
Yep. I think so. Try it.
Almost all Solr tests no
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949342#comment-13949342
]
Uwe Schindler commented on SOLR-5914:
-
bq. we should add deleteOnExit to forbidden APIs
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949385#comment-13949385
]
Uwe Schindler commented on SOLR-5914:
-
bq. Yeah, so it looks like we are just trying to
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949378#comment-13949378
]
Mark Miller commented on SOLR-5914:
---
bq. It looks better now, but its still generating 2
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949403#comment-13949403
]
Mark Miller commented on SOLR-5914:
---
Yeah, I'm fine with David's work as a longer term
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949441#comment-13949441
]
Uwe Schindler commented on SOLR-5914:
-
I would not think thats needed. In his branch
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949451#comment-13949451
]
Mark Miller commented on SOLR-5914:
---
bq. In his branch only 11 tests were initially not
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949592#comment-13949592
]
Dawid Weiss commented on SOLR-5914:
---
sounds like he calling it quits for now though,
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949641#comment-13949641
]
ASF subversion and git services commented on SOLR-5914:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949655#comment-13949655
]
Dawid Weiss commented on SOLR-5914:
---
{code}
-File tmpdir = File.createTempFile(test,
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949672#comment-13949672
]
Mark Miller commented on SOLR-5914:
---
I'm moving the reference to TEMP_DIR to one spot -
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949684#comment-13949684
]
Mark Miller commented on SOLR-5914:
---
bq. Seems like we're doubling efforts here.
I'm not
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949687#comment-13949687
]
Dawid Weiss commented on SOLR-5914:
---
I think my patch has benefits over the previous
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949691#comment-13949691
]
Dawid Weiss commented on SOLR-5914:
---
I'm not sure - I do know that it took me about 5
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949697#comment-13949697
]
Dawid Weiss commented on SOLR-5914:
---
Also: I can easily make those 11 tests still leave
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949700#comment-13949700
]
Mark Miller commented on SOLR-5914:
---
We can just merge up the branch - it's pretty easy.
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949701#comment-13949701
]
ASF subversion and git services commented on SOLR-5914:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949711#comment-13949711
]
Mark Miller commented on SOLR-5914:
---
I've got a meeting or two - give me a bit of time.
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949736#comment-13949736
]
Dawid Weiss commented on SOLR-5914:
---
I don't. But I don't see how you intend to keep your
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949780#comment-13949780
]
Mark Miller commented on SOLR-5914:
---
bq. (and I preferred my version, to be honest) .
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949864#comment-13949864
]
Dawid Weiss commented on SOLR-5914:
---
You see it depends on what you consider wrong.
Is
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949893#comment-13949893
]
Mark Miller commented on SOLR-5914:
---
bq. So I still argue that my commit was a better
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949932#comment-13949932
]
Mark Miller commented on SOLR-5914:
---
{noformat}
One clear evidence how broken it was is
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949971#comment-13949971
]
Mark Miller commented on SOLR-5914:
---
{noformat}One clear evidence how broken it was is
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950011#comment-13950011
]
Mark Miller commented on SOLR-5914:
---
bq. You see it depends on what you consider wrong.
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950013#comment-13950013
]
Mark Miller commented on SOLR-5914:
---
Oh yeah, I also fixed some other stuff that was
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950130#comment-13950130
]
Uwe Schindler commented on SOLR-5914:
-
Hi,
the last Jenkins run was successful.
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950139#comment-13950139
]
Mark Miller commented on SOLR-5914:
---
Thanks - I'll address the solrj test.
I'll also
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950161#comment-13950161
]
ASF subversion and git services commented on SOLR-5914:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950166#comment-13950166
]
Uwe Schindler commented on SOLR-5914:
-
I fixed the ContentStreamTest suite (the Reader
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950163#comment-13950163
]
ASF subversion and git services commented on SOLR-5914:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950227#comment-13950227
]
ASF subversion and git services commented on SOLR-5914:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950230#comment-13950230
]
Mark Miller commented on SOLR-5914:
---
{quote}I would also change the message to no longer
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950245#comment-13950245
]
ASF subversion and git services commented on SOLR-5914:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950244#comment-13950244
]
Mark Miller commented on SOLR-5914:
---
Okay - good stuff I think.
If you guys have ideas
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950257#comment-13950257
]
ASF subversion and git services commented on SOLR-5914:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13947784#comment-13947784
]
Dawid Weiss commented on SOLR-5914:
---
Perhaps we should change and instead of a warning
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13947830#comment-13947830
]
Erick Erickson commented on SOLR-5914:
--
[~thetaphi] Wait, are you saying this is
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13947868#comment-13947868
]
Dawid Weiss commented on SOLR-5914:
---
No fingerpointing :)
Let's try to make the tests
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13947892#comment-13947892
]
Uwe Schindler commented on SOLR-5914:
-
bq. Or just referencing one of my more stellar
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13947907#comment-13947907
]
Mark Miller commented on SOLR-5914:
---
Dawid Weiss added a comment - Today 10:32
Perhaps we
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13947911#comment-13947911
]
Yonik Seeley commented on SOLR-5914:
bq. Perhaps we should change and instead of a
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13947914#comment-13947914
]
Dawid Weiss commented on SOLR-5914:
---
I'll try to look into it.
Almost all Solr tests no
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13947959#comment-13947959
]
Uwe Schindler commented on SOLR-5914:
-
I think we just have to change the warning
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948025#comment-13948025
]
Mark Miller commented on SOLR-5914:
---
Looking at a couple tests real quick, I've seen
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948195#comment-13948195
]
Mark Miller commented on SOLR-5914:
---
bq. Looking at a couple tests real quick, I've seen
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948409#comment-13948409
]
ASF subversion and git services commented on SOLR-5914:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948414#comment-13948414
]
ASF subversion and git services commented on SOLR-5914:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948415#comment-13948415
]
Mark Miller commented on SOLR-5914:
---
That's a good start - my Windows VM likes it so far.
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948432#comment-13948432
]
Uwe Schindler commented on SOLR-5914:
-
Thanks Mark.
Is it ok to remove the forceful
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948441#comment-13948441
]
Mark Miller commented on SOLR-5914:
---
Yeah, we should have proper cleanup, except for the
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948615#comment-13948615
]
Uwe Schindler commented on SOLR-5914:
-
Hi Mark,
thanks. I started a new build. It
[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948617#comment-13948617
]
Uwe Schindler commented on SOLR-5914:
-
After cleanup: {{6,854,742,016 bytes free}}
73 matches
Mail list logo