Re: Issue with 6.5.1 RC2

2017-04-20 Thread Joel Bernstein
And sure start the vote whenever you're ready. Joel Bernstein http://joelsolr.blogspot.com/ On Thu, Apr 20, 2017 at 6:52 PM, Joel Bernstein wrote: > I think it's still RC2. > > Joel Bernstein > http://joelsolr.blogspot.com/ > > On Thu, Apr 20, 2017 at 4:58 PM, jim ferenczi

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Joel Bernstein
I think it's still RC2. Joel Bernstein http://joelsolr.blogspot.com/ On Thu, Apr 20, 2017 at 4:58 PM, jim ferenczi wrote: > Thanks Joel ! I can also start the vote when the release candidate is > ready if you want. > Is it still an RC2 or should I name it RC3 ? > >

Re: Issue with 6.5.1 RC2

2017-04-20 Thread jim ferenczi
Thanks Joel ! I can also start the vote when the release candidate is ready if you want. Is it still an RC2 or should I name it RC3 ? 2017-04-20 22:52 GMT+02:00 Joel Bernstein : > Ok Jim, it's all yours. Thanks for stepping in. I'll delete RC2 from svn > when it finishes

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Joel Bernstein
Ok Jim, it's all yours. Thanks for stepping in. I'll delete RC2 from svn when it finishes uploading. Joel Bernstein http://joelsolr.blogspot.com/ On Thu, Apr 20, 2017 at 4:46 PM, jim ferenczi wrote: > I can do it Joel. As Mike said, this is a bad bug that can lead to

Re: Issue with 6.5.1 RC2

2017-04-20 Thread jim ferenczi
I can do it Joel. As Mike said, this is a bad bug that can lead to data lost... 2017-04-20 22:43 GMT+02:00 Joel Bernstein : > I'm just uploading RC2 now. We can respin, but I won't be available for a > respin this evening or tomorrow. If someone else wants to step in thats

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Joel Bernstein
I'm just uploading RC2 now. We can respin, but I won't be available for a respin this evening or tomorrow. If someone else wants to step in thats ok. Joel Bernstein http://joelsolr.blogspot.com/ On Thu, Apr 20, 2017 at 4:28 PM, Michael McCandless < luc...@mikemccandless.com> wrote: > Hi Joel, >

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Michael McCandless
Hi Joel, LUCENE-7791 is actually quite a bad bug, and the patch looks low risk and committable; maybe we should merge it for 6.5.1? Mike McCandless http://blog.mikemccandless.com On Thu, Apr 20, 2017 at 3:25 PM, Steve Rowe wrote: > Joel, > > I’ve created

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Steve Rowe
Joel, I’ve created and to add precommit checking (or the equivalent) to buildAndPushRelease.py and smokeTestRelease.py, respectively. -- Steve www.lucidworks.com > On Apr 20, 2017, at

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Steve Rowe
FYI my macOS tests with Python 3.5.1 were on 10.12.4 (Sierra). -- Steve www.lucidworks.com > On Apr 20, 2017, at 2:03 PM, Joel Bernstein wrote: > > I'm on 10.10.5 (Yosemite). > > It could be related to the platform or just something odd with python 3.6.1 > > > > Joel

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Steve Rowe
OK, thanks. -- Steve www.lucidworks.com > On Apr 20, 2017, at 2:28 PM, Joel Bernstein wrote: > > I've changed the files locally and will push them out. > > Joel Bernstein > http://joelsolr.blogspot.com/ > > On Thu, Apr 20, 2017 at 2:06 PM, Joel Bernstein

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Joel Bernstein
I've changed the files locally and will push them out. Joel Bernstein http://joelsolr.blogspot.com/ On Thu, Apr 20, 2017 at 2:06 PM, Joel Bernstein wrote: > Steve, > > It looks like you haven't pushed out you changes yet, reverting my changes. > > Joel Bernstein >

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Joel Bernstein
Steve, It looks like you haven't pushed out you changes yet, reverting my changes. Joel Bernstein http://joelsolr.blogspot.com/ On Thu, Apr 20, 2017 at 2:03 PM, Joel Bernstein wrote: > I'm on 10.10.5 (Yosemite). > > It could be related to the platform or just something odd

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Joel Bernstein
I'm on 10.10.5 (Yosemite). It could be related to the platform or just something odd with python 3.6.1 Joel Bernstein http://joelsolr.blogspot.com/ On Thu, Apr 20, 2017 at 2:00 PM, Steve Rowe wrote: > FYI I got SUCCESS! [0:36:33.390707] from my reverted-SSL-changes >

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Joel Bernstein
Ok, it works for me with Python 3.4.3. So the issue is with Python 3.6.1. I will pull and respin. Joel Bernstein http://joelsolr.blogspot.com/ On Thu, Apr 20, 2017 at 1:54 PM, Joel Bernstein wrote: > I just ran the smoke tester and it failed in the part of code that I >

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Steve Rowe
FYI I got SUCCESS! [0:36:33.390707] from my reverted-SSL-changes smokeTestRelease.py on Python 3.4.2 against the 6.5.1RC2 URL. (macOS/Python 3.5.1 reverted smoke tester is still running.) It may be the case that you’re missing root certificates that I have (on both Linux and macOS), and

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Joel Bernstein
I just ran the smoke tester and it failed in the part of code that I hadn't suppressed the SSL validation. So it's still an issue with my setup. I could try another version of python and see if that is the issue. Joel Bernstein http://joelsolr.blogspot.com/ On Thu, Apr 20, 2017 at 1:47 PM,

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Steve Rowe
AFAICT that error occurs very early in the smoke test process, with the first attempt to download the directory listing at the release URL. I’m running the reverted-SSL-changes smokeTestRelease.py on both Python 3.4.2 (Linux) and 3.5.1 (macOS), and both are way past that. Would you mind

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Joel Bernstein
Here is the error from the smoke test: Traceback (most recent call last): File "dev-tools/scripts/smokeTestRelease.py", line 1483, in main() File "dev-tools/scripts/smokeTestRelease.py", line 1427, in main smokeTest(c.java, c.url, c.revision, c.version, c.tmp_dir, c.is_signed, '

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Steve Rowe
That’s the error you posted for buildAndPushRelease.py - are you saying that you got identical errors for both? -- Steve www.lucidworks.com > On Apr 20, 2017, at 1:28 PM, Joel Bernstein wrote: > > Python 3.6.1 > > > Joel Bernstein > http://joelsolr.blogspot.com/ > > On

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Joel Bernstein
Shall we just start the vote then? Joel Bernstein http://joelsolr.blogspot.com/ On Thu, Apr 20, 2017 at 1:28 PM, Joel Bernstein wrote: > Python 3.6.1 > > Joel Bernstein > http://joelsolr.blogspot.com/ > > On Thu, Apr 20, 2017 at 1:27 PM, Joel Bernstein

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Joel Bernstein
Python 3.6.1 Joel Bernstein http://joelsolr.blogspot.com/ On Thu, Apr 20, 2017 at 1:27 PM, Joel Bernstein wrote: > This was the error: > > File > "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/urllib/request.py", > line 504, in _call_chain > >

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Joel Bernstein
This was the error: File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/urllib/request.py", line 504, in _call_chain result = func(*args) File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/urllib/request.py", line 1361, in https_open

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Steve Rowe
Joel, I’ve reverted your SSL changes to smokeTestRelease.py, and I don’t see any problems so far when I run it with my Python 3.4.2 with the 6.5.1RC2 URL. (Still in progress; Lucene distributions have downloaded so far.) What was the error that caused you to make the SSL changes to

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Steve Rowe
I have Python 3.4.2 on my Linux box, and apparently 3.4.3 is the first that supports the changes you made, so the smoke tester is failing for me: - File "dev-tools/scripts/smokeTestRelease.py", line 165, in load content = urllib.request.urlopen(urlString,

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Joel Bernstein
thanks Joel Bernstein http://joelsolr.blogspot.com/ On Thu, Apr 20, 2017 at 12:50 PM, Steve Rowe wrote: > I’ll take a look. > > -- > Steve > www.lucidworks.com > > > On Apr 20, 2017, at 12:46 PM, Joel Bernstein wrote: > > > > I've uploaded the RC2 here

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Steve Rowe
I’ll take a look. -- Steve www.lucidworks.com > On Apr 20, 2017, at 12:46 PM, Joel Bernstein wrote: > > I've uploaded the RC2 here > https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-6.5.1-RC2-revdfc0dd67f7fe45fbf62d88652952ec3e2b3e0070/. > > But the smoke test

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Joel Bernstein
I've uploaded the RC2 here https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-6.5.1-RC2-revdfc0dd67f7fe45fbf62d88652952ec3e2b3e0070/ . But the smoke test breaks with SSL error in different spot when you smoke test from this URL. It's failing with a different command this time so the fix I

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Steve Rowe
I was thinking that if buildAndPushRelease.py can identify problems early, the RM won’t have to later redo work when a problem is found, e.g. by the smoke tester. IMHO the extra 10 minutes (on my laptop anyway) from auto-running precommit would be worth it. But I agree that the smoke tester

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Joel Bernstein
They are both quite long processes. Perhaps we should look at eliminating some of the overlap? Since the smokeTesters is run by those voting on the release maybe this should be the heavier of the two. Joel Bernstein http://joelsolr.blogspot.com/ On Thu, Apr 20, 2017 at 10:00 AM, Steve Rowe

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Steve Rowe
Also, I think buildAndPushRelease.py should invoke “precommit" too, (near) where it runs 'ant clean test'. -- Steve www.lucidworks.com > On Apr 20, 2017, at 9:51 AM, Steve Rowe wrote: > > That’s bizarre. > > The smoke tester runs ‘ant validate’, which does *not* include >

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Joel Bernstein
yep Joel Bernstein http://joelsolr.blogspot.com/ On Thu, Apr 20, 2017 at 9:51 AM, Steve Rowe wrote: > That’s bizarre. > > The smoke tester runs ‘ant validate’, which does *not* include > "documentation-lint” (which includes "-ecj-javadoc-lint”, where unused > imports are

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Steve Rowe
That’s bizarre. The smoke tester runs ‘ant validate’, which does *not* include "documentation-lint” (which includes "-ecj-javadoc-lint”, where unused imports are looked for). By contrast, ‘ant precommit’ runs “check-working-copy”, “validate”, and “documentation-lint”. Jenkins caught this not

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Joel Bernstein
OK, I've pulled the branch again and starting rebuilding the RC. Joel Bernstein http://joelsolr.blogspot.com/ On Thu, Apr 20, 2017 at 9:29 AM, Joel Bernstein wrote: > Smoke testes passed as well > > > Joel Bernstein > http://joelsolr.blogspot.com/ > > On Thu, Apr 20, 2017

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Joel Bernstein
Smoke testes passed as well Joel Bernstein http://joelsolr.blogspot.com/ On Thu, Apr 20, 2017 at 9:21 AM, Steve Rowe wrote: > I guess precommit is only run as part of the smoke tester. > > > On Apr 20, 2017, at 9:20 AM, Joel Bernstein wrote: > > > >

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Steve Rowe
I guess precommit is only run as part of the smoke tester. > On Apr 20, 2017, at 9:20 AM, Joel Bernstein wrote: > > Interesting the entire release process completed without complaining. > > Joel Bernstein > http://joelsolr.blogspot.com/ > > On Thu, Apr 20, 2017 at 9:10

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Joel Bernstein
I'll pull and run precommit before creating the RC. Joel Bernstein http://joelsolr.blogspot.com/ On Thu, Apr 20, 2017 at 9:20 AM, Joel Bernstein wrote: > Interesting the entire release process completed without complaining. > > Joel Bernstein > http://joelsolr.blogspot.com/

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Joel Bernstein
Interesting the entire release process completed without complaining. Joel Bernstein http://joelsolr.blogspot.com/ On Thu, Apr 20, 2017 at 9:10 AM, Steve Rowe wrote: > The unused import was the only problem; I’ve removed it on branch_6_5. > > Sorry, hope I didn’t cause a

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Steve Rowe
The unused import was the only problem; I’ve removed it on branch_6_5. Sorry, hope I didn’t cause a delay in the release process. -- Steve www.lucidworks.com > On Apr 20, 2017, at 8:57 AM, Steve Rowe wrote: > > Crap, Jenkins found an unused import in my commit on

Re: Issue with 6.5.1 RC2

2017-04-20 Thread Steve Rowe
Crap, Jenkins found an unused import in my commit on branch_6_5 :(. I forgot to run precommit. Doing so now. -- Steve www.lucidworks.com > On Apr 19, 2017, at 8:07 PM, Steve Rowe wrote: > > Done. > > -- > Steve > www.lucidworks.com > >> On Apr 19, 2017, at 7:49 PM, Steve

Re: Issue with 6.5.1 RC2

2017-04-19 Thread Steve Rowe
Done. -- Steve www.lucidworks.com > On Apr 19, 2017, at 7:49 PM, Steve Rowe wrote: > > Woohoo! Thanks Joel. Running all tests on branch_6_5 now. > > -- > Steve > www.lucidworks.com > >> On Apr 19, 2017, at 7:20 PM, Joel Bernstein wrote: >> >> I'm OK

Re: Issue with 6.5.1 RC2

2017-04-19 Thread Steve Rowe
Woohoo! Thanks Joel. Running all tests on branch_6_5 now. -- Steve www.lucidworks.com > On Apr 19, 2017, at 7:20 PM, Joel Bernstein wrote: > > I'm OK with restarting RC2. Let me know when you finish the back port. > > Joel Bernstein > http://joelsolr.blogspot.com/ > >

Re: Issue with 6.5.1 RC2

2017-04-19 Thread Joel Bernstein
I'm OK with restarting RC2. Let me know when you finish the back port. Joel Bernstein http://joelsolr.blogspot.com/ On Wed, Apr 19, 2017 at 7:11 PM, Steve Rowe wrote: > Joel, > > I know you’re in-process with RC2, but if you have to restart for some > reason, I’d like to

Re: Issue with 6.5.1 RC2

2017-04-19 Thread Steve Rowe
Joel, I know you’re in-process with RC2, but if you have to restart for some reason, I’d like to include SOLR-10527. -- Steve www.lucidworks.com > On Apr 19, 2017, at 6:57 PM, Joel Bernstein wrote: > > I also had to change the smoke tester because of the SSL issue. Which

Re: Issue with 6.5.1 RC2

2017-04-19 Thread Joel Bernstein
I also had to change the smoke tester because of the SSL issue. Which in theory means everyone else will have to as well. I'm pushing out my changes to branch_6_5, so people can just update their branch before running the smoke tester. Joel Bernstein http://joelsolr.blogspot.com/ On Wed, Apr 19,

Re: Issue with 6.5.1 RC2

2017-04-19 Thread Joel Bernstein
Ok, I had to push out three changes to the branch but I seemed to have moved passed this issue. Joel Bernstein http://joelsolr.blogspot.com/ On Wed, Apr 19, 2017 at 4:50 PM, Joel Bernstein wrote: > I'll push out the changes and then revert. Hopefully the changes will do >

Re: Issue with 6.5.1 RC2

2017-04-19 Thread Joel Bernstein
I'll push out the changes and then revert. Hopefully the changes will do the trick after they've been pushed. Joel Bernstein http://joelsolr.blogspot.com/ On Wed, Apr 19, 2017 at 4:37 PM, Steve Rowe wrote: > Yeah, that is a sucky part of this: you want to make modifications

Re: Issue with 6.5.1 RC2

2017-04-19 Thread Steve Rowe
Yeah, that is a sucky part of this: you want to make modifications on the release branch, but you can’t test unless you commit (and push). Another alternative: make modifications in another checkout, then invoke the script with from an unmodified source tree. e.g.: cd .. cp -r lucene-solr

Re: Issue with 6.5.1 RC2

2017-04-19 Thread Joel Bernstein
Ha, that doesn't work either. Now I get this error: RuntimeError: There are unpushed commits - "git log origin/branch_6_5.." output is: So, I'm going to have to push this out. Let's first decide if this makes sense as the way forward. Joel Bernstein http://joelsolr.blogspot.com/ On Wed, Apr

Re: Issue with 6.5.1 RC2

2017-04-19 Thread Joel Bernstein
Steve, when I change the script to turn off verification I get the following error: RuntimeError: git clone is dirty: So as part of the work around I think I'm going to have to commit locally and then revert locally. Does that make sense to you as the way forward? Joel Bernstein

Re: Issue with 6.5.1 RC2

2017-04-19 Thread Alexandre Rafalovitch
Could it be anything to do with the fact that the signer is Semantic and they are being actively distrusted by - at least - Google: http://www.securityweek.com/google-stops-trusting-symantec-issued-certificates Regards, Alex. http://www.solr-start.com/ - Resources for Solr users, new and

Re: Issue with 6.5.1 RC2

2017-04-19 Thread Joel Bernstein
Ok, I'll turn off the cert verification. I wasn't sure if cert verification was something that was integral to the process. Joel Bernstein http://joelsolr.blogspot.com/ On Wed, Apr 19, 2017 at 4:18 PM, Steve Rowe wrote: > Hi Joel, > > Not sure why this is suddenly an issue -

Re: Issue with 6.5.1 RC2

2017-04-19 Thread Steve Rowe
Hi Joel, Not sure why this is suddenly an issue - I guess “SNI” has been enabled on archive.apache.org? Some useful info here (about a “requests” lib, AFAICT an alternative to urllib):

Re: Issue with 6.5.1 RC2

2017-04-19 Thread Joel Bernstein
It appears that it's failing on verifying the SSL cert for https://archive.apache.org/dist/lucene/java/. Joel Bernstein http://joelsolr.blogspot.com/ On Wed, Apr 19, 2017 at 3:36 PM, Joel Bernstein wrote: > I started working on 6.5.1 RC2. I ran the following: > > python3