[JENKINS] Lucene-Solr-trunk-Solaris (64bit/jdk1.8.0) - Build # 356 - Still Failing!

2016-01-25 Thread Policeman Jenkins Server
Build: http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-Solaris/356/ Java: 64bit/jdk1.8.0 -XX:-UseCompressedOops -XX:+UseParallelGC 1 tests failed. FAILED: org.apache.solr.cloud.CollectionReloadTest.testReloadedLeaderStateAfterZkSessionLoss Error Message: java.util.concurrent.TimeoutException:

[jira] [Updated] (SOLR-8459) NPE using TermVectorComponent in combinition with ExactStatsCache

2016-01-25 Thread Cao Manh Dat (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cao Manh Dat updated SOLR-8459: --- Attachment: SOLR-8459.patch Update file patch : - Execute TermVectorComponent on ShardRequest.PURPOSE_G

[jira] [Updated] (SOLR-8512) Implement minimal set of get* methods in ResultSetImpl for column indices

2016-01-25 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-8512: - Fix Version/s: 6.0 > Implement minimal set of get* methods in ResultSetImpl for column indices > --

[jira] [Resolved] (SOLR-8512) Implement minimal set of get* methods in ResultSetImpl for column indices

2016-01-25 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein resolved SOLR-8512. -- Resolution: Implemented > Implement minimal set of get* methods in ResultSetImpl for column indic

[jira] [Updated] (SOLR-8512) Implement minimal set of get* methods in ResultSetImpl for column indices

2016-01-25 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-8512: - Affects Version/s: (was: Trunk) 6.0 > Implement minimal set of get* meth

[jira] [Commented] (SOLR-8512) Implement minimal set of get* methods in ResultSetImpl for column indices

2016-01-25 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116629#comment-15116629 ] Joel Bernstein commented on SOLR-8512: -- commit: https://github.com/apache/lucene-solr

[jira] [Commented] (SOLR-8512) Implement minimal set of get* methods in ResultSetImpl for column indices

2016-01-25 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116616#comment-15116616 ] Joel Bernstein commented on SOLR-8512: -- Patch looks great. Running precommit now. > I

[JENKINS] Lucene-Solr-NightlyTests-5.x - Build # 1083 - Still Failing

2016-01-25 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/Lucene-Solr-NightlyTests-5.x/1083/ 2 tests failed. FAILED: org.apache.solr.hadoop.MorphlineBasicMiniMRTest.mrRun Error Message: Failed on local exception: java.io.IOException: Connection reset by peer; Host Details : local host is: "lucene1-us-west/10.41.0.5

[jira] [Commented] (SOLR-8518) Implement ResultSetMetaDataImpl getColumnType and getColumnTypeName

2016-01-25 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116584#comment-15116584 ] Joel Bernstein commented on SOLR-8518: -- Using the approach where we look at the column

[jira] [Commented] (SOLR-8502) Improve Solr JDBC Driver to support SQL Clients like DBVisualizer

2016-01-25 Thread Kevin Risden (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116566#comment-15116566 ] Kevin Risden commented on SOLR-8502: SOLR-8518 has a patch available as well once SOLR-

[jira] [Updated] (SOLR-8518) Implement ResultSetMetaDataImpl getColumnType and getColumnTypeName

2016-01-25 Thread Kevin Risden (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-8518: --- Attachment: SOLR-8518.patch Implemented SOLR-8518 based on [~joel.bernstein]'s suggestion of using the

[jira] [Updated] (SOLR-8518) Implement ResultSetMetaDataImpl getColumnType and getColumnTypeName

2016-01-25 Thread Kevin Risden (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-8518: --- Flags: Patch > Implement ResultSetMetaDataImpl getColumnType and getColumnTypeName > --

[jira] [Updated] (SOLR-8512) Implement minimal set of get* methods in ResultSetImpl for column indices

2016-01-25 Thread Kevin Risden (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-8512: --- Attachment: SOLR-8512.patch Patch that takes into account changes from SOLR-8517 > Implement minimal s

[jira] [Updated] (SOLR-8517) Implement minimal set of get* methods in ResultSetImpl for column names

2016-01-25 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-8517: - Affects Version/s: (was: Trunk) 6.0 > Implement minimal set of get* meth

[jira] [Updated] (SOLR-8517) Implement minimal set of get* methods in ResultSetImpl for column names

2016-01-25 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-8517: - Fix Version/s: 6.0 > Implement minimal set of get* methods in ResultSetImpl for column names >

[jira] [Resolved] (SOLR-8517) Implement minimal set of get* methods in ResultSetImpl for column names

2016-01-25 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein resolved SOLR-8517. -- Resolution: Implemented > Implement minimal set of get* methods in ResultSetImpl for column names

[jira] [Commented] (SOLR-8517) Implement minimal set of get* methods in ResultSetImpl for column names

2016-01-25 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116533#comment-15116533 ] Joel Bernstein commented on SOLR-8517: -- Commit: https://github.com/apache/lucene-solr

[jira] [Commented] (SOLR-8517) Implement minimal set of get* methods in ResultSetImpl for column names

2016-01-25 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116530#comment-15116530 ] Joel Bernstein commented on SOLR-8517: -- Working with this patch now. I made some chang

[JENKINS] Lucene-Solr-trunk-MacOSX (64bit/jdk1.8.0) - Build # 3038 - Failure!

2016-01-25 Thread Policeman Jenkins Server
Build: http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-MacOSX/3038/ Java: 64bit/jdk1.8.0 -XX:-UseCompressedOops -XX:+UseParallelGC 2 tests failed. FAILED: org.apache.lucene.queries.CommonTermsQueryTest.testMinShouldMatch Error Message: Stack Trace: java.lang.AssertionError at __rando

Re: Merge vs Rebase

2016-01-25 Thread Erick Erickson
P.S. with attribution re: the hadoop committer guide. On Mon, Jan 25, 2016 at 4:49 PM, Erick Erickson wrote: > OK, I'm _really tempted_ to just steal the Hadoop guide verbatim as a > start and we can refine as necessary. > > I'll put big banners about "PRELIMINARY" in it, and add bits about > thi

Re: Merge vs Rebase

2016-01-25 Thread Erick Erickson
OK, I'm _really tempted_ to just steal the Hadoop guide verbatim as a start and we can refine as necessary. I'll put big banners about "PRELIMINARY" in it, and add bits about this being recommended not required. Thoughts? On Mon, Jan 25, 2016 at 4:36 PM, Uwe Schindler wrote: > Hi, > >> Another

RE: Merge vs Rebase

2016-01-25 Thread Uwe Schindler
Hi, > Another chore we do is on adding new files is > svn propset svn:eol-style native > > do we have an equivalent for that in git? Per-file properties like eol-style or MIME-type don't exist. Git has some set of internal file extensions it treats as text files and does the newlines automagi

RE: Merge vs Rebase

2016-01-25 Thread Uwe Schindler
Hi, > > The example of the conflict between my commit and Mike’s is just a > “normal usecase”. It was meant as a conflict in workflow (two people committing at almost same time). And that happens quite often. Uwe - To unsubsc

[jira] [Comment Edited] (SOLR-8522) ImplicitSnitch to support IPv4 fragment and host name fragment tags

2016-01-25 Thread Arcadius Ahouansou (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116328#comment-15116328 ] Arcadius Ahouansou edited comment on SOLR-8522 at 1/26/16 12:08 AM: -

[jira] [Commented] (SOLR-8522) ImplicitSnitch to support IPv4 fragment and host name fragment tags

2016-01-25 Thread Arcadius Ahouansou (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116328#comment-15116328 ] Arcadius Ahouansou commented on SOLR-8522: -- Hello again [~noble.paul] Thank you ve

[JENKINS] Lucene-Solr-trunk-Windows (64bit/jdk1.8.0_66) - Build # 5570 - Failure!

2016-01-25 Thread Policeman Jenkins Server
Build: http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-Windows/5570/ Java: 64bit/jdk1.8.0_66 -XX:+UseCompressedOops -XX:+UseG1GC 2 tests failed. FAILED: org.apache.lucene.queries.CommonTermsQueryTest.testMinShouldMatch Error Message: Stack Trace: java.lang.AssertionError at __randomi

[jira] [Updated] (SOLR-8522) ImplicitSnitch to support IPv4 fragment and host name fragment tags

2016-01-25 Thread Arcadius Ahouansou (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arcadius Ahouansou updated SOLR-8522: - Attachment: SOLR-8522.patch > ImplicitSnitch to support IPv4 fragment and host name fragme

Re: Shard splitting blocks the overseer queue for duration of split

2016-01-25 Thread Scott Blum
Looking deeper, it's entirely possible my experience is out of date; we're running a Solr ~5.2.1 installation, and I'm 100% sure that in 5.2.1 a split shard command completely blocks overseer. Even OVERSEERSTATUS times out while a split shard is happening. Perhaps this was fixed as part of SOLR-7

[JENKINS-EA] Lucene-Solr-5.x-Linux (64bit/jdk-9-ea+95) - Build # 15351 - Still Failing!

2016-01-25 Thread Policeman Jenkins Server
Build: http://jenkins.thetaphi.de/job/Lucene-Solr-5.x-Linux/15351/ Java: 64bit/jdk-9-ea+95 -XX:+UseCompressedOops -XX:+UseSerialGC -XX:-CompactStrings 3 tests failed. FAILED: junit.framework.TestSuite.org.apache.solr.cloud.SaslZkACLProviderTest Error Message: 5 threads leaked from SUITE scope a

[jira] [Commented] (LUCENE-6956) TestBKDTree.testRandomMedium() failure: some hits were wrong

2016-01-25 Thread Nicholas Knize (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116246#comment-15116246 ] Nicholas Knize commented on LUCENE-6956: bq. Hmm I hit this failure with the patc

[jira] [Updated] (LUCENE-6956) TestBKDTree.testRandomMedium() failure: some hits were wrong

2016-01-25 Thread Nicholas Knize (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Knize updated LUCENE-6956: --- Attachment: LUCENE-6956.patch Updated patch to address comments. Note: distance size restric

[jira] [Created] (LUCENE-6994) GeoUtils Distance accuracy degrades with irregular rectangles

2016-01-25 Thread Nicholas Knize (JIRA)
Nicholas Knize created LUCENE-6994: -- Summary: GeoUtils Distance accuracy degrades with irregular rectangles Key: LUCENE-6994 URL: https://issues.apache.org/jira/browse/LUCENE-6994 Project: Lucene - C

[jira] [Commented] (SOLR-8595) Use BinaryRequestWriter by default in HttpSolrClient and ConcurrentUpdateSolrClient

2016-01-25 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116182#comment-15116182 ] David Smiley commented on SOLR-8595: +1. Side note (separate issue): It'd be nice if

[JENKINS] Lucene-Solr-trunk-Solaris (64bit/jdk1.8.0) - Build # 355 - Still Failing!

2016-01-25 Thread Policeman Jenkins Server
Build: http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-Solaris/355/ Java: 64bit/jdk1.8.0 -XX:-UseCompressedOops -XX:+UseSerialGC 1 tests failed. FAILED: org.apache.solr.update.AutoCommitTest.testMaxDocs Error Message: Exception during query Stack Trace: java.lang.RuntimeException: Exception du

Re: Shard splitting blocks the overseer queue for duration of split

2016-01-25 Thread Anshum Gupta
Hi Scott, Shard splitting shouldn't block unrelated tasks. Here's the current definition of 'unrelated': anything that involves a different collection. Right now, the Overseer only processes one collection specific task at a time, however, you should certainly be able to split shards from other co

Re: Merge vs Rebase

2016-01-25 Thread Shai Erera
Thanks Dawid. I'll try for sport to not amend commits for a while, see how that works out for me :). I'll admit that I already ran into needing to revert a local change cause it didn't work, but I didn't have the "history" to revert to ... I don't mind typing 'git push origin HEAD:master'. I prefe

[JENKINS-EA] Lucene-Solr-5.x-Linux (64bit/jdk-9-ea+95) - Build # 15350 - Failure!

2016-01-25 Thread Policeman Jenkins Server
Build: http://jenkins.thetaphi.de/job/Lucene-Solr-5.x-Linux/15350/ Java: 64bit/jdk-9-ea+95 -XX:-UseCompressedOops -XX:+UseSerialGC -XX:-CompactStrings 3 tests failed. FAILED: junit.framework.TestSuite.org.apache.solr.cloud.SaslZkACLProviderTest Error Message: 5 threads leaked from SUITE scope a

Re: Merge vs Rebase

2016-01-25 Thread Dawid Weiss
> I'll admit Dawid that I obviously still have a lot to learn about working > with Git, but what I wrote above reflects my workflow on another project, > where we also use Gerrit for doing the code reviews. I'm not a git expert too, but I've grown to like it for its, surprisingly, simplicity. If y

Shard splitting blocks the overseer queue for duration of split

2016-01-25 Thread Scott Blum
Hi dev, I searched around on this but couldn't find any related JIRA tickets or work, although perhaps I missed it. We've run into a major scaling problem in the shard splitting operation. The entire shard split is a single operation in overseer, and blocks any other queue items from executing wh

Re: Merge vs Rebase

2016-01-25 Thread Yonik Seeley
On Mon, Jan 25, 2016 at 2:47 PM, Shai Erera wrote: > The 'merged' commit, in this case, seems redundant to me as it doesn't add > any useful information about them. I believe this case isn't an example one > for a merge. Just my thoughts... +1 For back-porting the majority of issues from trunk t

[jira] [Comment Edited] (LUCENE-6930) Decouple GeoPointField from NumericType

2016-01-25 Thread Nicholas Knize (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116002#comment-15116002 ] Nicholas Knize edited comment on LUCENE-6930 at 1/25/16 8:50 PM: --

[jira] [Updated] (LUCENE-6930) Decouple GeoPointField from NumericType

2016-01-25 Thread Nicholas Knize (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Knize updated LUCENE-6930: --- Attachment: LUCENE-6930.patch Updated patch to include the following: * incorporate review f

[jira] [Commented] (LUCENE-6956) TestBKDTree.testRandomMedium() failure: some hits were wrong

2016-01-25 Thread Nicholas Knize (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115991#comment-15115991 ] Nicholas Knize commented on LUCENE-6956: Oh, sorry for not addressing the {{1e-7}

[jira] [Updated] (SOLR-8595) Use BinaryRequestWriter by default in HttpSolrClient and ConcurrentUpdateSolrClient

2016-01-25 Thread Shalin Shekhar Mangar (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shalin Shekhar Mangar updated SOLR-8595: Attachment: SOLR-8595.patch Trivial patch. ConcurrentUpdateSolrClient uses HttpSolrCl

[jira] [Created] (SOLR-8595) Use BinaryRequestWriter by default in HttpSolrClient and ConcurrentUpdateSolrClient

2016-01-25 Thread Shalin Shekhar Mangar (JIRA)
Shalin Shekhar Mangar created SOLR-8595: --- Summary: Use BinaryRequestWriter by default in HttpSolrClient and ConcurrentUpdateSolrClient Key: SOLR-8595 URL: https://issues.apache.org/jira/browse/SOLR-8595

Re: Merge vs Rebase

2016-01-25 Thread Mark Miller
On Mon, Jan 25, 2016 at 3:11 PM Dawid Weiss wrote: > > commit 51396b8cf63fd7c77d005d10803ae953acfe659f > > Merge: 5319ca6 6df206a > > > > The 'merged' commit, in this case, seems redundant to me as it doesn't > add > > any useful information about them. > > It tells you exactly which two parent c

Re: Merge vs Rebase

2016-01-25 Thread Shai Erera
As a person looking at the history, I don't care what this particular commit merged. I only care about the two commits before it. They're the ones with content, they're the ones I'll want to 'git show' ... most likely. Anyway, we don't have to agree on this, but I do suggest that we come up w/ a s

[jira] [Commented] (LUCENE-6956) TestBKDTree.testRandomMedium() failure: some hits were wrong

2016-01-25 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115897#comment-15115897 ] Michael McCandless commented on LUCENE-6956: Thanks [~nknize], I like seeing

Re: Merge vs Rebase

2016-01-25 Thread Dawid Weiss
> commit 51396b8cf63fd7c77d005d10803ae953acfe659f > Merge: 5319ca6 6df206a > > The 'merged' commit, in this case, seems redundant to me as it doesn't add > any useful information about them. It tells you exactly which two parent commits this merge actually joins. In terms of patches -- this tells

Re: Merge vs Rebase

2016-01-25 Thread Shai Erera
I'll admit Dawid that I obviously still have a lot to learn about working with Git, but what I wrote above reflects my workflow on another project, where we also use Gerrit for doing the code reviews. > How do you get reviews? Did you push feature-branch to origin or did you just create a patch fr

Re: Merge vs Rebase

2016-01-25 Thread Mark Miller
Yup, it's committers like you and Joel that I'm most worried about simple guidelines for. Those that are deep into Git on this project are likely to do whatever they want anyway. I'm not looking to waste my time fighting them. But for those that don't want to walk those waters, that don't have a re

[jira] [Updated] (SOLR-8594) Impossible Cast: equals() method in ConstDoubleSource always returns false

2016-01-25 Thread Marc Breslow (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marc Breslow updated SOLR-8594: --- Attachment: SOLR-8594-fix-impossible-cast.patch > Impossible Cast: equals() method in ConstDoubleSource

[jira] [Created] (SOLR-8594) Impossible Cast: equals() method in ConstDoubleSource always returns false

2016-01-25 Thread Marc Breslow (JIRA)
Marc Breslow created SOLR-8594: -- Summary: Impossible Cast: equals() method in ConstDoubleSource always returns false Key: SOLR-8594 URL: https://issues.apache.org/jira/browse/SOLR-8594 Project: Solr

Re: Merge vs Rebase

2016-01-25 Thread Shai Erera
I don't think anyone here says "no merges at all", but rather I feel the direction is "rebase whenever possible, merge when you must or it makes sense". I realize that the last part is fuzzy and open, and maybe that's why Dawid (I think?) suggested that we don't change much yet, but rather let this

Re: Merge vs Rebase

2016-01-25 Thread Erick Erickson
Gotta echo Joel, I just want to get through my first commit here. Yonik's outline is along the lines of what I'm looking for. For newcomers (including newcomers to Git like me), this discussion is a little analogous to someone asking "how do I write to a file in Java" and having the discussion dive

Re: Merge vs Rebase

2016-01-25 Thread Dawid Weiss
> git checkout -b feature-branch > git commit -a -m "message" > (Get reviews) > git commit --amend (addressing review comments) How do you get reviews? Did you push feature-branch to origin or did you just create a patch from it? If you did push then it doesn't make sense to amend. If you didn't p

Re: Merge vs Rebase

2016-01-25 Thread Michael McCandless
On Mon, Jan 25, 2016 at 2:49 AM, Shai Erera wrote: This has been our way with Apache SVN anyway, so why change it? > I don't consider this a valid argument ;) Git is a new tool, it opens up new features. We shouldn't "lock ourselves into the SVN" way just because "that is what we have always d

Re: Merge vs Rebase

2016-01-25 Thread Michael McCandless
I am very much a git newbie, but: > The example of the conflict between my commit and Mike’s is just a “normal > usecase”. It did not happen in this case, but what if there were tricky conflicts to resolve? And I went and did that and then committed the resulting merge? I would want this infor

[jira] [Updated] (SOLR-8512) Implement minimal set of get* methods in ResultSetImpl for column indices

2016-01-25 Thread Kevin Risden (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-8512: --- Attachment: SOLR-8512.patch Fixed merge issues on top of SOLR-8519 and SOLR-8517 > Implement minimal s

[jira] [Updated] (SOLR-8517) Implement minimal set of get* methods in ResultSetImpl for column names

2016-01-25 Thread Kevin Risden (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-8517: --- Attachment: SOLR-8517.patch Fixed merge issues on top of changes from SOLR-8519 > Implement minimal se

[jira] [Resolved] (SOLR-8519) Implement ResultSetMetaDataImpl.getColumnCount()

2016-01-25 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein resolved SOLR-8519. -- Resolution: Implemented > Implement ResultSetMetaDataImpl.getColumnCount() >

Re: [JENKINS] Lucene-Solr-NightlyTests-trunk - Build # 919 - Still Failing

2016-01-25 Thread Michael McCandless
I'll disable Direct and Memory for this test. Mike McCandless http://blog.mikemccandless.com On Mon, Jan 25, 2016 at 6:12 AM, Apache Jenkins Server wrote: > Build: https://builds.apache.org/job/Lucene-Solr-NightlyTests-trunk/919/ > > 1 tests failed. > FAILED: org.apache.lucene.search.TestGeoP

[jira] [Commented] (SOLR-8519) Implement ResultSetMetaDataImpl.getColumnCount()

2016-01-25 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115765#comment-15115765 ] Joel Bernstein commented on SOLR-8519: -- Committed: https://github.com/apache/lucene-s

[jira] [Commented] (SOLR-8519) Implement ResultSetMetaDataImpl.getColumnCount()

2016-01-25 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115717#comment-15115717 ] Joel Bernstein commented on SOLR-8519: -- Actually that patches are working out well. Le

[jira] [Commented] (SOLR-8517) Implement minimal set of get* methods in ResultSetImpl for column names

2016-01-25 Thread Kevin Risden (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115692#comment-15115692 ] Kevin Risden commented on SOLR-8517: Created PR for this: https://github.com/apache/luc

[jira] [Commented] (SOLR-8519) Implement ResultSetMetaDataImpl.getColumnCount()

2016-01-25 Thread Kevin Risden (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115684#comment-15115684 ] Kevin Risden commented on SOLR-8519: {quote} As we start implementing the column type m

[jira] [Commented] (SOLR-8519) Implement ResultSetMetaDataImpl.getColumnCount()

2016-01-25 Thread Kevin Risden (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115681#comment-15115681 ] Kevin Risden commented on SOLR-8519: [~joel.bernstein] - I opened a PR for this which h

[jira] [Commented] (SOLR-8519) Implement ResultSetMetaDataImpl.getColumnCount()

2016-01-25 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115680#comment-15115680 ] Joel Bernstein commented on SOLR-8519: -- The latest patch looks great! I don't plan on

Re: Merge vs Rebase

2016-01-25 Thread Shai Erera
I used cherry-pick, as to me it's the most similar thing to the svn merge workflow we had. But as Mark said, there are other ways too, and IMO we should get to an agreed upon way as a project, and not individuals. For instance, IIRC, branch_5x now has 2 commits: the first is the one from master, a

Re: Merge vs Rebase

2016-01-25 Thread Mark Miller
Although, again, before someone gets angry, some groups choose to merge in this case as well instead. There are lots of legit choices. Projects tend to come to consensus on how they operate with these things. There is no 'correct' choice, just opinions and what the project coalesces around. - Mar

Re: Merge vs Rebase

2016-01-25 Thread Mark Miller
>> The next step is merging to branch_5x >> How do you recommend I do it? Generally, people use 'cherry-pick' for this. - Mark On Mon, Jan 25, 2016 at 12:39 PM Noble Paul wrote: > The most common usecase is > Do development on trunk(master) > > git commit to master > git push > > > The next st

Re: Merge vs Rebase

2016-01-25 Thread Noble Paul
The most common usecase is Do development on trunk(master) git commit to master git push The next step is merging to branch_5x How do you recommend I do it? Another chore we do is on adding new files is svn propset svn:eol-style native do we have an equivalent for that in git? On Mon, Jan 2

[jira] [Comment Edited] (LUCENE-6985) Create some (simple) guides on how to use git to perform common dev tasks

2016-01-25 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114007#comment-15114007 ] Paul Elschot edited comment on LUCENE-6985 at 1/25/16 4:52 PM:

Re: Merge vs Rebase

2016-01-25 Thread Yonik Seeley
> git push origin HEAD:master (this is the equivalent of svn commit) > (b) Is there a less verbose way to do it, I'm no git expert either, but it seems like the simplest example of applying and committing a patch could be much simpler by having good defaults and not using a separate branch. 1)

[JENKINS] Lucene-Solr-5.x-Linux (32bit/jdk1.7.0_80) - Build # 15348 - Failure!

2016-01-25 Thread Policeman Jenkins Server
Build: http://jenkins.thetaphi.de/job/Lucene-Solr-5.x-Linux/15348/ Java: 32bit/jdk1.7.0_80 -server -XX:+UseSerialGC 1 tests failed. FAILED: org.apache.solr.handler.component.TestDistributedStatsComponentCardinality.test Error Message: int_i: goodEst=13923, poorEst=13970, real=13952, p=q=id:[37

[jira] [Closed] (LUCENE-6922) Improve svn to git workaround script

2016-01-25 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Elschot closed LUCENE-6922. Resolution: Fixed After the move from svn to git there is no more need for this. Thanks for moving

[JENKINS-MAVEN] Lucene-Solr-Maven-5.x #1165: POMs out of sync

2016-01-25 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/Lucene-Solr-Maven-5.x/1165/ No tests ran. Build Log: [...truncated 25439 lines...] BUILD FAILED /x1/jenkins/jenkins-slave/workspace/Lucene-Solr-Maven-5.x/build.xml:766: The following error occurred while executing this line: /x1/jenkins/jenkins-slave/workspac

Re: To Detect Wheter Core is Available To Post

2016-01-25 Thread Shawn Heisey
On 1/25/2016 12:13 AM, Edwin Lee wrote: > We want to detect the health of each core —- whether they are > available to post. We have to figure out ways to do that: > > 1. Using luke request . —- Cost is a bit high for core loading > 2. We have designed a cache and adding the hook when the core is

Re: Merge vs Rebase

2016-01-25 Thread Joel Bernstein
I'm a non git expert and I would prefer to have guidelines to follow. Understanding the complexities here is not something I have any interest in. I just want to merge and commit in some agreed apon standard way. Joel Bernstein http://joelsolr.blogspot.com/ On Mon, Jan 25, 2016 at 10:37 AM, Shai

[jira] [Updated] (LUCENE-6993) Update TLDs to latest list

2016-01-25 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated LUCENE-6993: -- Attachment: LUCENE-6993.patch Attaching a patch against trunk that updates the TLD Macro file and the

[jira] [Commented] (LUCENE-6992) Add sugar methods to allow creating a MemoryIndex from a Document or set of IndexableFields

2016-01-25 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115441#comment-15115441 ] David Smiley commented on LUCENE-6992: -- +1 Looks good. Nice work Alan. > Add sugar

[jira] [Comment Edited] (LUCENE-6991) WordDelimiterFilter bug

2016-01-25 Thread Pawel Rog (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115414#comment-15115414 ] Pawel Rog edited comment on LUCENE-6991 at 1/25/16 3:41 PM: T

[jira] [Commented] (LUCENE-6991) WordDelimiterFilter bug

2016-01-25 Thread Pawel Rog (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115414#comment-15115414 ] Pawel Rog commented on LUCENE-6991: --- Thanks for the suggestion. When I changed whitespa

[jira] [Created] (LUCENE-6993) Update TLDs to latest list

2016-01-25 Thread Mike Drob (JIRA)
Mike Drob created LUCENE-6993: - Summary: Update TLDs to latest list Key: LUCENE-6993 URL: https://issues.apache.org/jira/browse/LUCENE-6993 Project: Lucene - Core Issue Type: Improvement

Re: Merge vs Rebase

2016-01-25 Thread Shai Erera
Hi Dawid, Yes, I know what --amend does. I never amend the parent commit, only my initial commit. I think we're talking about the same thing, but just to clarify, this is what I mean: git checkout -b feature-branch git commit -a -m "message" (Get reviews) git commit --amend (addressing review com

Re: Merge vs Rebase

2016-01-25 Thread Mark Miller
On Mon, Jan 25, 2016 at 10:15 AM Dawid Weiss wrote: > For example I > disagree with Mark that multiple merges and then final merge are a bad > thing in general. They are fairly straightforward in the commit graph > and they very clearly signify that somebody was working on their own > stuff and

[jira] [Commented] (LUCENE-6991) WordDelimiterFilter bug

2016-01-25 Thread Jack Krupansky (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115405#comment-15115405 ] Jack Krupansky commented on LUCENE-6991: Does seem odd and wrong. I also notice

[jira] [Updated] (SOLR-8517) Implement minimal set of get* methods in ResultSetImpl for column names

2016-01-25 Thread Kevin Risden (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-8517: --- Attachment: SOLR-8517.patch Fixes a NPE with .toString() on the Tuple#getString method when manually t

[jira] [Commented] (SOLR-8502) Improve Solr JDBC Driver to support SQL Clients like DBVisualizer

2016-01-25 Thread Kevin Risden (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115325#comment-15115325 ] Kevin Risden commented on SOLR-8502: [~joel.bernstein] Here are some more tickets that

[jira] [Updated] (SOLR-8512) Implement minimal set of get* methods in ResultSetImpl for column indices

2016-01-25 Thread Kevin Risden (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-8512: --- Attachment: SOLR-8512.patch Patch that builds upon metadata passing from SOLR-8519. This is much simple

[jira] [Commented] (SOLR-8512) Implement minimal set of get* methods in ResultSetImpl for column indices

2016-01-25 Thread Kevin Risden (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115317#comment-15115317 ] Kevin Risden commented on SOLR-8512: Depends upon metadata from SOLR-8519 and implement

Re: Merge vs Rebase

2016-01-25 Thread david.w.smi...@gmail.com
Well put Mark. It's definitely not an either-or, it's about judicious use of merge commits. And, someone correct me if I'm wrong, but I think we decided to switch from svn to git* but otherwise keep things the same.* Wouldn't that preclude these little merge bubbles? This is because 'svn' does

[jira] [Updated] (SOLR-8517) Implement minimal set of get* methods in ResultSetImpl for column names

2016-01-25 Thread Kevin Risden (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-8517: --- Attachment: SOLR-8517.patch Added some tests for getObject. > Implement minimal set of get* methods in

[jira] [Commented] (SOLR-8519) Implement ResultSetMetaDataImpl.getColumnCount()

2016-01-25 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115289#comment-15115289 ] Joel Bernstein commented on SOLR-8519: -- Ok, I'll take a look at this today. > Impleme

[jira] [Updated] (SOLR-8590) example/files improvements

2016-01-25 Thread Erik Hatcher (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Hatcher updated SOLR-8590: --- Description: There are several example/files improvements/fixes that are warranted: * Fix e-mail and U

[jira] [Commented] (SOLR-8251) MatchAllDocsQuery is much slower in solr5.3.1 compare to solr4.7

2016-01-25 Thread Stephan Lagraulet (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115284#comment-15115284 ] Stephan Lagraulet commented on SOLR-8251: - I have other deadlocks when the cluster

[jira] [Commented] (SOLR-8251) MatchAllDocsQuery is much slower in solr5.3.1 compare to solr4.7

2016-01-25 Thread Stephan Lagraulet (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115281#comment-15115281 ] Stephan Lagraulet commented on SOLR-8251: - When Solr5 is under heavy load yourkit r

[jira] [Updated] (SOLR-8593) Integrate Apache Calcite into the SQLHandler

2016-01-25 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-8593: - Fix Version/s: Trunk > Integrate Apache Calcite into the SQLHandler > -

[jira] [Commented] (SOLR-8593) Integrate Apache Calcite into the SQLHandler

2016-01-25 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115253#comment-15115253 ] Joel Bernstein commented on SOLR-8593: -- Linking to the JDBC driver work. The JDBC driv

[jira] [Commented] (SOLR-8587) Add segments file information to core admin status

2016-01-25 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115246#comment-15115246 ] Shai Erera commented on SOLR-8587: -- Oh :). But the plan is still that if the commit messag

  1   2   >