[jira] [Commented] (LUCENE-8060) Enable top-docs collection optimizations by default

2018-08-07 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571940#comment-16571940 ] Adrien Grand commented on LUCENE-8060: -- Mike just fixed nightly benchmarks so that we can see the

[jira] [Created] (LUCENE-8448) Slowdown of nested boolean queries after LUCENE-8060

2018-08-07 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8448: Summary: Slowdown of nested boolean queries after LUCENE-8060 Key: LUCENE-8448 URL: https://issues.apache.org/jira/browse/LUCENE-8448 Project: Lucene - Core

[jira] [Commented] (LUCENE-8442) testPendingDeleteDVGeneration fails with NoSuchFileException

2018-08-07 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571613#comment-16571613 ] Adrien Grand commented on LUCENE-8442: -- +1 > testPendingDeleteDVGeneration fails with

[jira] [Commented] (LUCENE-8447) Add DISJOINT and WITHIN support to LatLonShape queries

2018-08-07 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571600#comment-16571600 ] Adrien Grand commented on LUCENE-8447: -- Thanks Nick, it looks great. It looks like INTERSECTS now

[jira] [Commented] (LUCENE-8442) testPendingDeleteDVGeneration fails with NoSuchFileException

2018-08-07 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571245#comment-16571245 ] Adrien Grand commented on LUCENE-8442: -- Thanks for digging this failure [~dnhatn]! I'd like

[jira] [Commented] (LUCENE-8060) Enable top-docs collection optimizations by default

2018-08-05 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569576#comment-16569576 ] Adrien Grand commented on LUCENE-8060: -- Thanks Steve. The second one was a test bug due to the fact

[jira] [Commented] (LUCENE-8440) Add support for indexing and searching Line and Point shapes using LatLonShape encoding

2018-08-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567452#comment-16567452 ] Adrien Grand commented on LUCENE-8440: -- +1 to the patch > Add support for indexing and searching

[jira] [Commented] (LUCENE-8433) Add FutureArrays.equals(Object[] a, int aToIndex, Object[] b, int bFromIndex, int bToIndex)

2018-08-01 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565699#comment-16565699 ] Adrien Grand commented on LUCENE-8433: -- Maintaining this fork array has some cost, yet this

[jira] [Commented] (LUCENE-8441) Wrong index sort field type throws unexpected NullPointerException

2018-08-01 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564996#comment-16564996 ] Adrien Grand commented on LUCENE-8441: -- +1 > Wrong index sort field type throws unexpected

[jira] [Resolved] (LUCENE-8437) CheckIndex should not duplicate SegmentInfos serialization

2018-08-01 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8437. -- Resolution: Fixed Fix Version/s: 7.5 master (8.0) > CheckIndex

[jira] [Commented] (LUCENE-8440) Add support for indexing and searching Line and Point shapes using LatLonShape encoding

2018-08-01 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564926#comment-16564926 ] Adrien Grand commented on LUCENE-8440: -- Thanks Nick. I think having more javadocs would help but it

[jira] [Resolved] (LUCENE-8060) Enable top-docs collection optimizations by default

2018-08-01 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8060. -- Resolution: Fixed > Enable top-docs collection optimizations by default >

[jira] [Commented] (LUCENE-8204) ReqOptSumScorer should leverage sub scorers' per-block max scores

2018-07-31 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564306#comment-16564306 ] Adrien Grand commented on LUCENE-8204: -- +1 on the approach, thanks for the explanation about why we

[jira] [Commented] (LUCENE-8439) DisjunctionMaxScorer should leverage sub scorers' per-block max scores

2018-07-31 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564252#comment-16564252 ] Adrien Grand commented on LUCENE-8439: -- Pretty cool. I guess it works well because scores on title

[jira] [Commented] (LUCENE-8060) Enable top-docs collection optimizations by default

2018-07-31 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564195#comment-16564195 ] Adrien Grand commented on LUCENE-8060: -- To give some perspective, here are the results of

[jira] [Updated] (LUCENE-8437) CheckIndex should not duplicate SegmentInfos serialization

2018-07-31 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8437: - Attachment: LUCENE-8437.patch > CheckIndex should not duplicate SegmentInfos serialization >

[jira] [Commented] (LUCENE-8437) CheckIndex should not duplicate SegmentInfos serialization

2018-07-31 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563452#comment-16563452 ] Adrien Grand commented on LUCENE-8437: -- Here is a patch. > CheckIndex should not duplicate

[jira] [Created] (LUCENE-8437) CheckIndex should not duplicate SegmentInfos serialization

2018-07-31 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8437: Summary: CheckIndex should not duplicate SegmentInfos serialization Key: LUCENE-8437 URL: https://issues.apache.org/jira/browse/LUCENE-8437 Project: Lucene - Core

[jira] [Commented] (SOLR-12574) SignificantTermsQParserPlugin should output its keys in a combined bucket

2018-07-30 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561971#comment-16561971 ] Adrien Grand commented on SOLR-12574: - [~arafalov] This seems to cause failures in

[jira] [Resolved] (LUCENE-5232) Remove doMaxScore from indexsearcher, collector specializations, etc

2018-07-30 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-5232. -- Resolution: Fixed Fix Version/s: (was: 6.0) LUCENE-8405 and LUCENE-8412 removed

[jira] [Commented] (LUCENE-8432) Stop calling comparator even if early termination is not possible

2018-07-27 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559949#comment-16559949 ] Adrien Grand commented on LUCENE-8432: -- +1 to do it this way too. I don't have a suggestion at the

[jira] [Commented] (LUCENE-8422) Add Matches iteration to interval queries

2018-07-27 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559870#comment-16559870 ] Adrien Grand commented on LUCENE-8422: -- I'm curious whether you considered adding eg.

[jira] [Commented] (LUCENE-8419) Return token unchanged for pathological Stempel tokens

2018-07-27 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559683#comment-16559683 ] Adrien Grand commented on LUCENE-8419: -- [~ab] Do you have any ideas how to improve this? > Return

[jira] [Resolved] (LUCENE-8429) DaciukMihovAutomatonBuilder needs protection against stack overflows

2018-07-27 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8429. -- Resolution: Fixed Fix Version/s: 7.5 master (8.0) >

[jira] [Resolved] (LUCENE-8410) Soft delete optimization never kicks in

2018-07-27 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8410. -- Resolution: Fixed Fix Version/s: 7.5 master (8.0) Commit

[jira] [Commented] (LUCENE-8420) Upgrade OpenNLP to 1.9.0

2018-07-27 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559588#comment-16559588 ] Adrien Grand commented on LUCENE-8420: -- Woops I used the wrong bug id in my commit message. Sorry

[jira] [Resolved] (LUCENE-8428) Allow configurable sentinels in PriorityQueue

2018-07-27 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8428. -- Resolution: Fixed Fix Version/s: 7.5 master (8.0) > Allow

[jira] [Resolved] (LUCENE-8423) The way IndexWriter carries over previous generations is fragile

2018-07-27 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8423. -- Resolution: Fixed Fix Version/s: 7.5 master (8.0) > The way

[jira] [Resolved] (LUCENE-8405) Remove TopHits.maxScore

2018-07-27 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8405. -- Resolution: Fixed > Remove TopHits.maxScore > --- > >

[jira] [Commented] (LUCENE-7314) Graduate LatLonPoint to core

2018-07-26 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558854#comment-16558854 ] Adrien Grand commented on LUCENE-7314: -- [~nknize] Shall we resolve this issue now? > Graduate

[jira] [Commented] (LUCENE-8060) Enable top-docs collection optimizations by default

2018-07-26 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558683#comment-16558683 ] Adrien Grand commented on LUCENE-8060: -- {quote}why have a setDefaultNumTotalHitsToTrack(int) just

[jira] [Created] (LUCENE-8431) Allow top collectors to compute lower bounds of the total hit count

2018-07-26 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8431: Summary: Allow top collectors to compute lower bounds of the total hit count Key: LUCENE-8431 URL: https://issues.apache.org/jira/browse/LUCENE-8431 Project: Lucene

[jira] [Updated] (LUCENE-8060) Enable top-docs collection optimizations by default

2018-07-26 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8060: - Summary: Enable top-docs collection optimizations by default (was: Require users to tell us

[jira] [Commented] (LUCENE-8204) ReqOptSumScorer should leverage sub scorers' per-block max scores

2018-07-26 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558269#comment-16558269 ] Adrien Grand commented on LUCENE-8204: -- The benchmark numbers look great! Some comments on the

[jira] [Updated] (LUCENE-8430) TopDocs.totalHits is not always the accurate hit count

2018-07-26 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8430: - Issue Type: Sub-task (was: Improvement) Parent: LUCENE-8060 > TopDocs.totalHits is not

[jira] [Commented] (LUCENE-8430) TopDocs.totalHits is not always the accurate hit count

2018-07-26 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558107#comment-16558107 ] Adrien Grand commented on LUCENE-8430: -- Here is a proposal which replaces TopDocs.totalHits with a

[jira] [Updated] (LUCENE-8430) TopDocs.totalHits is not always the accurate hit count

2018-07-26 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8430: - Attachment: LUCENE-8430.patch > TopDocs.totalHits is not always the accurate hit count >

[jira] [Created] (LUCENE-8430) TopDocs.totalHits is not always the accurate hit count

2018-07-26 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8430: Summary: TopDocs.totalHits is not always the accurate hit count Key: LUCENE-8430 URL: https://issues.apache.org/jira/browse/LUCENE-8430 Project: Lucene - Core

[jira] [Created] (LUCENE-8429) DaciukMihovAutomatonBuilder needs protection against stack overflows

2018-07-26 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8429: Summary: DaciukMihovAutomatonBuilder needs protection against stack overflows Key: LUCENE-8429 URL: https://issues.apache.org/jira/browse/LUCENE-8429 Project: Lucene

[jira] [Commented] (SOLR-12587) Reuse Lucene's PriorityQueue for the ExportHandler

2018-07-26 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556968#comment-16556968 ] Adrien Grand commented on SOLR-12587: - I opened LUCENE-8428 for discussion. > Reuse Lucene's

[jira] [Created] (LUCENE-8428) Allow configurable sentinels in PriorityQueue

2018-07-26 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8428: Summary: Allow configurable sentinels in PriorityQueue Key: LUCENE-8428 URL: https://issues.apache.org/jira/browse/LUCENE-8428 Project: Lucene - Core Issue

[jira] [Commented] (LUCENE-8060) Require users to tell us whether they need total hit counts

2018-07-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556323#comment-16556323 ] Adrien Grand commented on LUCENE-8060: -- I'd like to avoid IndexSearcher doing "nothing" or

[jira] [Commented] (SOLR-12587) Reuse Lucene's PriorityQueue for the ExportHandler

2018-07-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556261#comment-16556261 ] Adrien Grand commented on SOLR-12587: - Oh I see, a chicken-and-egg issue! I think this

[jira] [Commented] (LUCENE-8060) Require users to tell us whether they need total hit counts

2018-07-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556214#comment-16556214 ] Adrien Grand commented on LUCENE-8060: -- {quote}I don't know a lot about how the current estimation

[jira] [Commented] (LUCENE-8060) Require users to tell us whether they need total hit counts

2018-07-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555890#comment-16555890 ] Adrien Grand commented on LUCENE-8060: -- Our current hit count estimations are terrible. I don't

[jira] [Commented] (SOLR-12587) Reuse Lucene's PriorityQueue for the ExportHandler

2018-07-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555903#comment-16555903 ] Adrien Grand commented on SOLR-12587: - I think you could fix your first nocommit by passing

[jira] [Resolved] (LUCENE-8427) TestBlockMaxConjunction.testRandom() reproducing failure

2018-07-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8427. -- Resolution: Fixed Fix Version/s: master (8.0) Thanks [~steve_rowe] this was an actual

***UNCHECKED*** [jira] [Commented] (LUCENE-8425) Expose hard live docs on SegmentReader level

2018-07-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555299#comment-16555299 ] Adrien Grand commented on LUCENE-8425: -- +1 thanks! > Expose hard live docs on SegmentReader level

[jira] [Commented] (LUCENE-8421) TopScoreDocCollector.create(int) should disable exact hit counts

2018-07-24 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554471#comment-16554471 ] Adrien Grand commented on LUCENE-8421: -- Sorry I should have provided more context. I agree this

[jira] [Commented] (LUCENE-8425) Expose hard live docs on SegmentReader level

2018-07-24 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554320#comment-16554320 ] Adrien Grand commented on LUCENE-8425: -- I wish we didn't have to make SegmentReader constructors

[jira] [Commented] (LUCENE-8412) Remove trackDocScores from TopFieldCollector factory methods

2018-07-24 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553979#comment-16553979 ] Adrien Grand commented on LUCENE-8412: -- Thanks Steve, I'll look! > Remove trackDocScores from

[jira] [Created] (LUCENE-8423) The way IndexWriter carries over previous generations is fragile

2018-07-23 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8423: Summary: The way IndexWriter carries over previous generations is fragile Key: LUCENE-8423 URL: https://issues.apache.org/jira/browse/LUCENE-8423 Project: Lucene -

[jira] [Created] (LUCENE-8421) TopScoreDocCollector.create(int) should disable exact hit counts

2018-07-23 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8421: Summary: TopScoreDocCollector.create(int) should disable exact hit counts Key: LUCENE-8421 URL: https://issues.apache.org/jira/browse/LUCENE-8421 Project: Lucene -

[jira] [Resolved] (LUCENE-8412) Remove trackDocScores from TopFieldCollector factory methods

2018-07-23 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8412. -- Resolution: Fixed Fix Version/s: master (8.0) Thanks [~mikemccand] and [~romseygeek]

[jira] [Commented] (LUCENE-8312) Leverage impacts for SynonymQuery

2018-07-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548157#comment-16548157 ] Adrien Grand commented on LUCENE-8312: -- It looks like this caused the slowdown at

[jira] [Commented] (LUCENE-8412) Remove trackDocScores from TopFieldCollector factory methods

2018-07-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548112#comment-16548112 ] Adrien Grand commented on LUCENE-8412: -- Here is a patch. It removes trackDocScores from

[jira] [Updated] (LUCENE-8412) Remove trackDocScores from TopFieldCollector factory methods

2018-07-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8412: - Attachment: LUCENE-8412.patch > Remove trackDocScores from TopFieldCollector factory methods >

[jira] [Created] (LUCENE-8412) Remove trackDocScores from TopFieldCollector factory methods

2018-07-18 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8412: Summary: Remove trackDocScores from TopFieldCollector factory methods Key: LUCENE-8412 URL: https://issues.apache.org/jira/browse/LUCENE-8412 Project: Lucene - Core

[jira] [Resolved] (LUCENE-8411) Remove fillFields from TopFieldCollector factory methods

2018-07-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8411. -- Resolution: Fixed Fix Version/s: master (8.0) > Remove fillFields from

[jira] [Created] (LUCENE-8411) Remove fillFields from TopFieldCollector factory methods

2018-07-18 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8411: Summary: Remove fillFields from TopFieldCollector factory methods Key: LUCENE-8411 URL: https://issues.apache.org/jira/browse/LUCENE-8411 Project: Lucene - Core

[jira] [Created] (LUCENE-8410) Soft delete optimization never kicks in

2018-07-18 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8410: Summary: Soft delete optimization never kicks in Key: LUCENE-8410 URL: https://issues.apache.org/jira/browse/LUCENE-8410 Project: Lucene - Core Issue Type:

[jira] [Commented] (LUCENE-8405) Remove TopHits.maxScore

2018-07-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547112#comment-16547112 ] Adrien Grand commented on LUCENE-8405: -- Thanks Mike and David for looking! bq. Why does

[jira] [Commented] (LUCENE-8403) Support 'filtered' term vectors - don't require all terms to be present

2018-07-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547104#comment-16547104 ] Adrien Grand commented on LUCENE-8403: -- bq. I can't seem to find those call-sites right now though.

[jira] [Commented] (LUCENE-8407) Add SpanTermQuery.getTermStates()

2018-07-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547102#comment-16547102 ] Adrien Grand commented on LUCENE-8407: -- +1 > Add SpanTermQuery.getTermStates() >

[jira] [Resolved] (LUCENE-8263) Add indexPctDeletedTarget as a parameter to TieredMergePolicy to control more aggressive merging

2018-07-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8263. -- Resolution: Fixed Fix Version/s: 7.5 master (8.0) > Add

[jira] [Commented] (LUCENE-8405) Remove TopHits.maxScore

2018-07-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546235#comment-16546235 ] Adrien Grand commented on LUCENE-8405: -- Here is a patch. I tried to avoid adding a breaking change

[jira] [Updated] (LUCENE-8405) Remove TopHits.maxScore

2018-07-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8405: - Attachment: LUCENE-8405.patch > Remove TopHits.maxScore > --- > >

[jira] [Created] (LUCENE-8405) Remove TopHits.maxScore

2018-07-17 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8405: Summary: Remove TopHits.maxScore Key: LUCENE-8405 URL: https://issues.apache.org/jira/browse/LUCENE-8405 Project: Lucene - Core Issue Type: Task

[jira] [Commented] (LUCENE-8400) Make BytesRefHash.compact public and @lucene.internal

2018-07-16 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545030#comment-16545030 ] Adrien Grand commented on LUCENE-8400: -- I don't mind making it public. The whole class is already

[jira] [Created] (LUCENE-8399) TestLatLonShapeQuerie failures

2018-07-16 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8399: Summary: TestLatLonShapeQuerie failures Key: LUCENE-8399 URL: https://issues.apache.org/jira/browse/LUCENE-8399 Project: Lucene - Core Issue Type: Test

[jira] [Commented] (LUCENE-8398) TieredMergePolicy.getMaxMergedSegmentMB has rounding error

2018-07-16 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544974#comment-16544974 ] Adrien Grand commented on LUCENE-8398: -- +1 > TieredMergePolicy.getMaxMergedSegmentMB has rounding

[jira] [Commented] (LUCENE-8263) Add indexPctDeletedTarget as a parameter to TieredMergePolicy to control more aggressive merging

2018-07-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544687#comment-16544687 ] Adrien Grand commented on LUCENE-8263: -- [~erickerickson] I would create a separate JIRA for this

[jira] [Commented] (LUCENE-8263) Add indexPctDeletedTarget as a parameter to TieredMergePolicy to control more aggressive merging

2018-07-13 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543800#comment-16543800 ] Adrien Grand commented on LUCENE-8263: -- bq. I such situations, deletesPctAllowed around 10-15%

[jira] [Commented] (LUCENE-8263) Add indexPctDeletedTarget as a parameter to TieredMergePolicy to control more aggressive merging

2018-07-13 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543375#comment-16543375 ] Adrien Grand commented on LUCENE-8263: -- bq. It's surprising how many tests relied on the behavior

[jira] [Commented] (LUCENE-8397) Add DirectoryTaxonomyWriter.getCache

2018-07-13 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542856#comment-16542856 ] Adrien Grand commented on LUCENE-8397: -- +1 > Add DirectoryTaxonomyWriter.getCache >

[jira] [Commented] (LUCENE-8396) Add Points Based Shape Indexing

2018-07-13 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542779#comment-16542779 ] Adrien Grand commented on LUCENE-8396: -- bq. do quantization first [...] and then make tessellation

[jira] [Commented] (LUCENE-8396) Add Points Based Shape Indexing

2018-07-13 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542761#comment-16542761 ] Adrien Grand commented on LUCENE-8396: -- This looks awesome. Indexing two additional dimensions

[jira] [Commented] (LUCENE-8395) WordDelimiterGraphFilter can incorrectly add holes to a TokenStream

2018-07-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541528#comment-16541528 ] Adrien Grand commented on LUCENE-8395: -- Sneaky. +1 > WordDelimiterGraphFilter can incorrectly add

[jira] [Resolved] (LUCENE-8382) Don't propagate calls to setMinCompetitiveScore in MultiCollector

2018-07-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8382. -- Resolution: Fixed Fix Version/s: master (8.0) Thanks Jim! > Don't propagate calls to

[jira] [Resolved] (LUCENE-8393) TieredMergePolicy needs to take into account the maximum segment size when computing the allowed number of segments

2018-07-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8393. -- Resolution: Fixed Fix Version/s: 7.5 master (8.0) >

[jira] [Resolved] (LUCENE-8392) TieredMergePolicy has broken assumptions when maxMergeAtOnce is greater than segmentsPerTier

2018-07-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8392. -- Resolution: Fixed Fix Version/s: 7.5 master (8.0) >

[jira] [Resolved] (LUCENE-8394) TieredMergePolicy's handling of the case that all segments are less than the floor segment size is fragile

2018-07-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8394. -- Resolution: Fixed Fix Version/s: 7.5 master (8.0) >

[jira] [Resolved] (LUCENE-8391) Better tests for merge policies

2018-07-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8391. -- Resolution: Fixed Fix Version/s: 7.5 master (8.0) > Better tests

[jira] [Commented] (LUCENE-8394) TieredMergePolicy's handling of the case that all segments are less than the floor segment size is fragile

2018-07-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537241#comment-16537241 ] Adrien Grand commented on LUCENE-8394: -- Here is a patch that ensures that the allowed segment count

[jira] [Updated] (LUCENE-8394) TieredMergePolicy's handling of the case that all segments are less than the floor segment size is fragile

2018-07-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8394: - Attachment: LUCENE-8394.patch > TieredMergePolicy's handling of the case that all segments are

[jira] [Created] (LUCENE-8394) TieredMergePolicy's handling of the case that all segments are less than the floor segment size is fragile

2018-07-09 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8394: Summary: TieredMergePolicy's handling of the case that all segments are less than the floor segment size is fragile Key: LUCENE-8394 URL:

[jira] [Commented] (LUCENE-8383) Fix computation of mergingBytes in TieredMergePolicy

2018-07-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537117#comment-16537117 ] Adrien Grand commented on LUCENE-8383: -- I went ahead and merged these issues so that it's easier to

[jira] [Resolved] (LUCENE-8385) Fix computation of the allowed segment count in TieredMergePolicy

2018-07-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8385. -- Resolution: Fixed Fix Version/s: 7.5 master (8.0) > Fix computation

[jira] [Resolved] (LUCENE-8383) Fix computation of mergingBytes in TieredMergePolicy

2018-07-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8383. -- Resolution: Fixed Fix Version/s: 7.5 master (8.0) > Fix computation

[jira] [Commented] (LUCENE-8393) TieredMergePolicy needs to take into account the maximum segment size when computing the allowed number of segments

2018-07-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536899#comment-16536899 ] Adrien Grand commented on LUCENE-8393: -- Here is a patch. > TieredMergePolicy needs to take into

[jira] [Updated] (LUCENE-8393) TieredMergePolicy needs to take into account the maximum segment size when computing the allowed number of segments

2018-07-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8393: - Attachment: LUCENE-8393.patch > TieredMergePolicy needs to take into account the maximum

[jira] [Created] (LUCENE-8393) TieredMergePolicy needs to take into account the maximum segment size when computing the allowed number of segments

2018-07-09 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8393: Summary: TieredMergePolicy needs to take into account the maximum segment size when computing the allowed number of segments Key: LUCENE-8393 URL:

[jira] [Updated] (LUCENE-8391) Better tests for merge policies

2018-07-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8391: - Attachment: LUCENE-8391.patch > Better tests for merge policies >

[jira] [Commented] (LUCENE-8392) TieredMergePolicy has broken assumptions when maxMergeAtOnce is greater than segmentsPerTier

2018-07-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536789#comment-16536789 ] Adrien Grand commented on LUCENE-8392: -- Here is a patch. It computes {{mergeFactor=min(segsPerTier,

[jira] [Created] (LUCENE-8392) TieredMergePolicy has broken assumptions when maxMergeAtOnce is greater than segmentsPerTier

2018-07-09 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8392: Summary: TieredMergePolicy has broken assumptions when maxMergeAtOnce is greater than segmentsPerTier Key: LUCENE-8392 URL: https://issues.apache.org/jira/browse/LUCENE-8392

[jira] [Updated] (LUCENE-8392) TieredMergePolicy has broken assumptions when maxMergeAtOnce is greater than segmentsPerTier

2018-07-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8392: - Attachment: LUCENE-8392.patch > TieredMergePolicy has broken assumptions when maxMergeAtOnce is

[jira] [Created] (LUCENE-8391) Better tests for merge policies

2018-07-09 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8391: Summary: Better tests for merge policies Key: LUCENE-8391 URL: https://issues.apache.org/jira/browse/LUCENE-8391 Project: Lucene - Core Issue Type: Test

[jira] [Commented] (LUCENE-8390) Replace MatchesIteratorSupplier with IOSupplier

2018-07-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536715#comment-16536715 ] Adrien Grand commented on LUCENE-8390: -- +1 I'd remove it directly without a deprecation phase

[jira] [Commented] (LUCENE-8386) Maybe a DocIdSetIterator may implement Bits?

2018-07-08 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536402#comment-16536402 ] Adrien Grand commented on LUCENE-8386: -- Sorry for introducing some confusion, when I mentioned

[jira] [Commented] (LUCENE-8383) Fix computation of mergingBytes in TieredMergePolicy

2018-07-07 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535818#comment-16535818 ] Adrien Grand commented on LUCENE-8383: -- As you prefer. > Fix computation of mergingBytes in

<    2   3   4   5   6   7   8   9   10   11   >