Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/34#discussion_r66244801
--- Diff: lucene/core/src/java/org/apache/lucene/store/Directory.java ---
@@ -165,4 +165,13 @@ public void copyFrom(Directory from, String src,
String
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/34#discussion_r66629876
--- Diff:
solr/contrib/hdfs/src/test/org/apache/solr/cloud/hdfs/HdfsTestUtil.java ---
@@ -91,6 +91,9 @@ public static MiniDFSCluster setupClass(String
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/32#discussion_r61541928
--- Diff:
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java ---
@@ -348,7 +358,13 @@ public JettySolrRunner
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/32#discussion_r61541687
--- Diff:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java ---
@@ -572,6 +574,40 @@ public void downloadConfig(String
Github user romseygeek commented on the pull request:
https://github.com/apache/lucene-solr/pull/32#issuecomment-215646194
Thanks for the comments! I'll try and incorporate your suggestions and see
how far we get.
---
If your project is set up for it, you can reply to this email
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/32#discussion_r61569303
--- Diff:
solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java ---
@@ -1066,32 +1079,201 @@ public static String getCollectionPath
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/32#discussion_r61568081
--- Diff:
solr/solrj/src/java/org/apache/solr/common/cloud/CollectionStateWatcher.java ---
@@ -0,0 +1,42 @@
+package org.apache.solr.common.cloud
Github user romseygeek commented on the pull request:
https://github.com/apache/lucene-solr/pull/32#issuecomment-218251017
That's... a good point, actually.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user romseygeek closed the pull request at:
https://github.com/apache/lucene-solr/pull/32
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/37#discussion_r63663320
--- Diff:
solr/core/src/test/org/apache/solr/cloud/CollectionsAPIDistributedZkTest.java
---
@@ -70,357 +77,193 @@
import
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/37#discussion_r63663466
--- Diff:
solr/core/src/test/org/apache/solr/cloud/CollectionsAPIDistributedZkTest.java
---
@@ -70,357 +77,193 @@
import
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/37#discussion_r63663986
--- Diff:
solr/core/src/test/org/apache/solr/cloud/CollectionsAPIDistributedZkTest.java
---
@@ -599,17 +409,17 @@ private void testNoConfigSetExist
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/37#discussion_r63664257
--- Diff:
solr/core/src/test/org/apache/solr/cloud/CollectionsAPIDistributedZkTest.java
---
@@ -70,357 +77,193 @@
import
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/37#discussion_r63663755
--- Diff:
solr/core/src/test/org/apache/solr/cloud/CollectionsAPIDistributedZkTest.java
---
@@ -435,73 +278,55 @@ private void testErrorHandling
Github user romseygeek commented on the pull request:
https://github.com/apache/lucene-solr/pull/32#issuecomment-218911016
I think this is ready - will put up a patch on the JIRA issue and commit
tomorrow UK time. Which is now apparently today UK time.
/me goes to bed
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/32#discussion_r62810535
--- Diff:
solr/solrj/src/test/org/apache/solr/common/cloud/TestCollectionStateWatchers.java
---
@@ -0,0 +1,235 @@
+package
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/32#discussion_r62810671
--- Diff:
solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java ---
@@ -635,6 +669,8 @@ public Object getUpdateLock
Github user romseygeek commented on the pull request:
https://github.com/apache/lucene-solr/pull/34#issuecomment-217531618
@markrmiller I don't think we need to make people jump through any more
hoops, and HDFS integration would stay as part of the core distribution, but
moving
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/32#discussion_r61777874
--- Diff:
solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java ---
@@ -1066,32 +1079,201 @@ public static String getCollectionPath
Github user romseygeek commented on the pull request:
https://github.com/apache/lucene-solr/pull/32#issuecomment-216315281
OK, latest push moves all notifications out of synchronized blocks.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user romseygeek commented on the pull request:
https://github.com/apache/lucene-solr/pull/32#issuecomment-216347644
Feedback is good :-)
I'll pull CSW back out and make it public again. I think keeping it
separate from the Predicate is still a useful distinction
Github user romseygeek commented on the pull request:
https://github.com/apache/lucene-solr/pull/32#issuecomment-216922168
> One thing I noticed in writing this is that it's uncertain whether you'll
miss any states or not
Unless I'm misunderstanding you, this is just how
Github user romseygeek commented on the pull request:
https://github.com/apache/lucene-solr/pull/32#issuecomment-216941787
Last push exposes CollectionStateWatcher directly again, and moves
notification calls into an Executor.
---
If your project is set up for it, you can reply
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/34#discussion_r62206298
--- Diff: solr/core/src/java/org/apache/solr/update/UpdateHandler.java ---
@@ -200,4 +187,16 @@ public void registerOptimizeCallback
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/34#discussion_r62204058
--- Diff: solr/core/ivy.xml ---
@@ -61,15 +61,6 @@
-
-
-
-
-
--- End diff
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/34#discussion_r62205397
--- Diff: solr/core/src/test/org/apache/solr/cloud/ShardSplitTest.java ---
@@ -57,7 +57,6 @@
import static
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/34#discussion_r62203539
--- Diff: lucene/core/src/java/org/apache/lucene/store/Directory.java ---
@@ -165,4 +165,13 @@ public void copyFrom(Directory from, String src,
String
Github user romseygeek commented on the pull request:
https://github.com/apache/lucene-solr/pull/32#issuecomment-218122269
New plan! We now have a separate notification thread, and change
notifications are placed into a LinkedBlockingQueue that the thread waits on.
A caveat
GitHub user romseygeek opened a pull request:
https://github.com/apache/lucene-solr/pull/32
SOLR-8323
Adds a CollectionStateWatcher API to listen for changes to collection state
(SOLR-8323)
You can merge this pull request into a Git repository by running:
$ git pull https
Github user romseygeek commented on the pull request:
https://github.com/apache/lucene-solr/pull/32#issuecomment-217978029
On further reflection, I've pulled the separate executor back out again. I
think the SolrZkClient's separate executor will work well enough, and for the
most
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/150#discussion_r98625031
--- Diff: solr/core/src/test-files/log4j.properties ---
@@ -7,6 +7,7 @@
log4j.appender.CONSOLE.layout=org.apache.log4j.EnhancedPatternLayout
Github user romseygeek commented on the issue:
https://github.com/apache/lucene-solr/pull/69
Hi,
BasicAuthIntegrationTest has been refactored since you opened this request,
do you think you could try adding a test case in there now?
---
If your project is set up for it, you
GitHub user romseygeek opened a pull request:
https://github.com/apache/lucene-solr/pull/118
SOLR-9659: Add DataWatch API
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/romseygeek/lucene-solr topic/datawatch
Alternatively you
Github user romseygeek commented on the issue:
https://github.com/apache/lucene-solr/pull/37
Finally merged this in (with a few changes), thanks @tomjon !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/162#discussion_r117773779
--- Diff:
lucene/grouping/src/java/org/apache/lucene/search/grouping/TopGroupsCollector.java
---
@@ -39,6 +39,14 @@
private final Sort
GitHub user romseygeek opened a pull request:
https://github.com/apache/lucene-solr/pull/397
Matches highlighter
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/romseygeek/lucene-solr matches-highlighter
Alternatively you can
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/397#discussion_r193429612
--- Diff:
lucene/core/src/java/org/apache/lucene/index/LeafReaderContext.java ---
@@ -35,7 +35,7 @@
/**
* Creates a new {@link
GitHub user romseygeek opened a pull request:
https://github.com/apache/lucene-solr/pull/317
LUCENE-8145: OffsetsEnum is now unitary
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/romseygeek/lucene-solr offsetsenum
Github user romseygeek commented on the issue:
https://github.com/apache/lucene-solr/pull/317
> we could create a single enum per position query
I definitely want to do this! For Spans and phrases, and if intervals ever
hap
Github user romseygeek commented on the issue:
https://github.com/apache/lucene-solr/pull/317
I've moved all scoring into PassageScorer itself, and restored the
Passage.setScore() method.
One thing I notice now is that the various methods on PassageScorer other
than score
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/317#discussion_r165431325
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/OffsetsEnum.java
---
@@ -124,34 +123,122 @@ public PostingsEnum
GitHub user romseygeek opened a pull request:
https://github.com/apache/lucene-solr/pull/334
LUCENE-8196
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/romseygeek/lucene-solr positions
Alternatively you can review and apply
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/345#discussion_r179913306
--- Diff:
lucene/core/src/test/org/apache/lucene/search/TestMatchesIterator.java ---
@@ -0,0 +1,317 @@
+/*
+ * Licensed to the Apache
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/345#discussion_r179913304
--- Diff: lucene/core/src/java/org/apache/lucene/search/Weight.java ---
@@ -69,6 +69,21 @@ protected Weight(Query query) {
*/
public
Github user romseygeek commented on the issue:
https://github.com/apache/lucene-solr/pull/345
I added an assertion to QueryUtils that calls Weight.matches() for each
collected document and ensures that the response isn't null (this actually
caught a bug in MTQ's handling). I've also
Github user romseygeek commented on the issue:
https://github.com/apache/lucene-solr/pull/345
> For instance I don't think it should try to report matches whenever there
are no terms involved
The reason I did this was to make Boolean matching accurate. Say for
example
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/345#discussion_r180669841
--- Diff:
lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java
---
@@ -0,0 +1,168 @@
+/*
+ * Licensed
Github user romseygeek commented on the issue:
https://github.com/apache/lucene-solr/pull/345
bq. I agree that making the call fully lazy would be ideal
This can't be done, unfortunately, as we need to know up-front if there's a
match or not. Hence the slightly odd
Github user romseygeek commented on the issue:
https://github.com/apache/lucene-solr/pull/345
I extended MatchesAsserter to keep track of the last matching document, and
check that if the document one below the current collection is not a hit, then
its Matches is null
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/345#discussion_r179679658
--- Diff:
lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/345#discussion_r179679922
--- Diff:
lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/345#discussion_r179680356
--- Diff:
lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed
Github user romseygeek commented on the issue:
https://github.com/apache/lucene-solr/pull/345
> In term of testing, I think we should enforce some consistency with
extractTerms
The two aren't always consistent - for example, TermInSetQu
GitHub user romseygeek opened a pull request:
https://github.com/apache/lucene-solr/pull/345
LUCENE-8229: Add Weight.matches() method
This PR adds a method to Weight that allows iterating over the matching
positions (and offsets if available) for a particular document and field
Github user romseygeek commented on the issue:
https://github.com/apache/lucene-solr/pull/328
Hi @tballison , are you still interested in pushing this one? I can help
out, as I'd like to get this committed so that we can move forward with
LUCENE-8497 and remove
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/460#discussion_r221522640
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/TrimFilterFactory.java
---
@@ -53,7 +51,7 @@ public TrimFilter
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/460#discussion_r221522467
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ASCIIFoldingFilterFactory.java
---
@@ -56,18 +53,13 @@ public
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/460#discussion_r221522605
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ScandinavianFoldingFilterFactory.java
---
@@ -51,7 +49,7
Github user romseygeek commented on the issue:
https://github.com/apache/lucene-solr/pull/460
Thanks Mayya, this looks good. I think it would help to get
https://github.com/apache/lucene-solr/pull/328 in first, as that would clean up
the Solr issues and allow us to remove
Github user romseygeek commented on the issue:
https://github.com/apache/lucene-solr/pull/328
The lucene-level changes are there so that you can take an existing
CustomAnalyzer and tweak it, if I'm reading correctly. Can you instead add a
constructor to CustomAnalyzer.Builder
Github user romseygeek commented on the issue:
https://github.com/apache/lucene-solr/pull/328
I think we can proceed with LUCENE-8497 anyway by adding a new method to
TokenizerChain that only uses multi-term aware filters. Feel free to close
this one @tballison
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/500#discussion_r234535812
--- Diff:
lucene/test-framework/src/java/org/apache/lucene/analysis/ValidatingTokenFilter.java
---
@@ -50,6 +53,9 @@
private final
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/500#discussion_r234535761
--- Diff:
lucene/test-framework/src/java/org/apache/lucene/analysis/TokenStreamUtil.java
---
@@ -0,0 +1,41 @@
+/*
+ * Licensed
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/500#discussion_r234535890
--- Diff:
lucene/test-framework/src/java/org/apache/lucene/analysis/ValidatingTokenFilter.java
---
@@ -50,6 +53,9 @@
private final
64 matches
Mail list logo
