Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/531
Code changes seem good; I'll look closer and run tests.
PathHierarchyTokenizerFactory _might_ eventually be used at query time if
we had a syntax to say "get me all my ance
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/531
Nonetheless we could stop trying to solve this ambiguous case further _for
now_ (thus commit what you have here) since (a) this syntax is very
experimental (b) it's documented nowhere (c
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/531
> Perhaps we could test whether "foo" is a defined field in the current
collection?
Eh; that sounds too much like a "guess what the user might mean" kind of
Github user dsmiley commented on the pull request:
https://github.com/apache/lucene-solr/commit/c04a3ac306b017054173d986e32ea217e2fc6595#commitcomment-31829970
In
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java:
In
solr/core/src/java/org
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/531
The way this field is indexed has been experimental and will remain so for
a bit. 8.0 will be it's more public debut, after which changing it will be
more effort than today. Nonetheless I
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/531
Looks good. I thought you were going to test with something to show we
don't screw it up? You could search for 'redients' which would have returned
something before but now should
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/531
Thanks for helping out!
It's insufficient to simply prepend a `*` since it would match other labels
that share the same suffix. For example:
`childFilter='ingredients/name\_s:cocoa'` would
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/528
Man this is a tangled mess we are trying to unravel! I wish someone
undertook this years ago.
Lets not rename DUP#processDelete as it is an URP defined method we
override, and I doubt
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/528
I like that the zk version of processCommit completely overrides the
superclass since the logic is much more complicated. But it's a little
unfortunate to call super.processCommit which
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/528
* DUP.next can be removed as it's redundant with the same in the superclass
* DUP.MAX_RETRIES_TO_FOLLOWERS_DEFAULT you accidentally added an 'R' to the
** of the javadoc.
* DUP.isLeader
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/528
* DUP.postProcessAdd's javadoc is confusing; maybe drop it. It says "This
method can be overridden to tamper with the cmd" but I'm looking at where we
override it and I don't see any
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/528#discussion_r243999855
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedStandaloneUpdateProcessor.java
---
@@ -0,0 +1,121 @@
+/*
+ * Licensed
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/528#discussion_r243847609
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java
---
@@ -1250,23 +1250,10 @@ private UpdateCommand
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/528#discussion_r243847326
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedStandaloneUpdateProcessor.java
---
@@ -0,0 +1,121 @@
+/*
+ * Licensed
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/528#discussion_r243847270
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedStandaloneUpdateProcessor.java
---
@@ -0,0 +1,121 @@
+/*
+ * Licensed
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/528#discussion_r243844185
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java
---
@@ -1250,23 +1250,10 @@ private UpdateCommand
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/528#discussion_r243843542
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedStandaloneUpdateProcessor.java
---
@@ -42,15 +53,36 @@ public
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/528
Looks good. More to do?
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/528#discussion_r241967674
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java
---
@@ -1417,45 +1407,7 @@ private void doDeleteById
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/528#discussion_r241967637
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedStandaloneUpdateProcessor.java
---
@@ -56,8 +59,15 @@ public void
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/528#discussion_r241945926
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java
---
@@ -1417,45 +1407,7 @@ private void doDeleteById
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/528#discussion_r241945549
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java
---
@@ -223,6 +289,7 @@ private String getLeaderUrlZk
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/528#discussion_r241945502
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedStandaloneUpdateProcessor.java
---
@@ -56,8 +59,15 @@ public void
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/528#discussion_r241945460
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java
---
@@ -58,6 +75,127 @@ String getCollectionName
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/519
I'm not sure if the "base" functionality needed to be in a new class... I
could imagine simply adding subclasses and leave DUP named as it is with it's
base functionality. WDYT? I
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/519
good start
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/489
There is no "development" branch, so I don't know what you mean by that.
You don't _have_ to run the full test suite after each commit, but _ideally_ it
ought to pass on each commit
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/489#discussion_r238527873
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedStandAloneUpdateProcessor.java
---
@@ -0,0 +1,100 @@
+/*
+ * Licensed
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/489#discussion_r238528464
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/CdcrUpdateProcessor.java ---
@@ -16,115 +16,12 @@
*/
package
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/489#discussion_r238527608
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessorFactory.java
---
@@ -50,8 +51,16 @@ public static void
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/455
What does "so _root_ is not hard-coded into childless documents" mean? If
you think SOLR-5211 is missing something, can you please post a patch file to
the issue and explain what you
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r235022057
--- Diff: solr/core/src/test/org/apache/solr/BlockUpdateTest.java ---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r235001356
--- Diff: solr/core/src/test/org/apache/solr/BlockUpdateTest.java ---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/501
Nice.
Do we even need the test config / schema at all? If they don't add
anything, we shouldn't have them. Also I see there is still some "Block"
terminology added here we
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r234869970
--- Diff: solr/core/src/java/org/apache/solr/update/AddUpdateCommand.java
---
@@ -194,20 +197,33 @@ public String getHashableId() {
return
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/501
Also please rename "block" terminology to "nested" where possible.
---
-
To unsubscribe,
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r234646277
--- Diff:
solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java ---
@@ -975,6 +976,14 @@ private void updateDocOrDocValues
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r234498494
--- Diff: solr/core/src/java/org/apache/solr/update/AddUpdateCommand.java
---
@@ -194,20 +203,22 @@ public String getHashableId() {
return
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r234496047
--- Diff: solr/core/src/java/org/apache/solr/update/AddUpdateCommand.java
---
@@ -96,12 +96,21 @@ public SolrInputDocument getSolrInputDocument
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r234496573
--- Diff:
solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java ---
@@ -975,6 +976,14 @@ private void updateDocOrDocValues
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r234495484
--- Diff: solr/core/src/java/org/apache/solr/update/AddUpdateCommand.java
---
@@ -96,12 +96,21 @@ public SolrInputDocument getSolrInputDocument
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r234496324
--- Diff: solr/core/src/java/org/apache/solr/update/AddUpdateCommand.java
---
@@ -194,20 +203,22 @@ public String getHashableId() {
return
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r234496354
--- Diff: solr/core/src/java/org/apache/solr/update/AddUpdateCommand.java
---
@@ -194,20 +203,22 @@ public String getHashableId() {
return
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r231566214
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java
---
@@ -259,9 +264,8 @@ public boolean
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r231567341
--- Diff:
solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java
---
@@ -1164,6 +1225,31 @@ public void processGetUpdates
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r231127727
--- Diff:
solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java
---
@@ -639,12 +651,32 @@ public static SolrInputDocument
Github user dsmiley commented on the pull request:
https://github.com/apache/lucene-solr/commit/43d7f5d104802bc3281d5995c6c2d71bebf1f369#commitcomment-31121980
I understand it's a design decision. I'm not certain about the correctness
of the logic; I've been leaving that to you here
Github user dsmiley commented on the pull request:
https://github.com/apache/lucene-solr/commit/43d7f5d104802bc3281d5995c6c2d71bebf1f369#commitcomment-31096103
isNestedAtomicUpdate seems to return true even it it isn't an atomic
update. So it's name isn't right or the method
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r228197896
--- Diff:
solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java
---
@@ -609,9 +618,10 @@ public static SolrInputDocument
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r228174440
--- Diff: solr/core/src/java/org/apache/solr/update/AddUpdateCommand.java
---
@@ -262,6 +263,11 @@ private void flattenAnonymous(List
unwrappedDocs
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r228026284
--- Diff: solr/core/src/java/org/apache/solr/update/AddUpdateCommand.java
---
@@ -262,6 +263,11 @@ private void flattenAnonymous(List
unwrappedDocs
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/455
As a general point, I feel we should prefer "nested" terminology instead of
"block". If we were purely working within Lucene then I think "block" might be
okay bu
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r226709714
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateBlockTest.java
---
@@ -59,39 +52,147 @@ public void before
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r226709264
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateBlockTest.java
---
@@ -59,39 +52,147 @@ public void before
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r224133917
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateBlockTest.java
---
@@ -0,0 +1,370 @@
+/*
+ * Licensed to the Apache
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r224127559
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateBlockTest.java
---
@@ -0,0 +1,370 @@
+/*
+ * Licensed to the Apache
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r223747918
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java
---
@@ -442,5 +442,58 @@ protected void doRemoveRegex
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r224306158
--- Diff:
solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java
---
@@ -639,12 +650,30 @@ public static SolrInputDocument
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r224306892
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java
---
@@ -1360,24 +1385,47 @@ boolean getUpdatedDocument
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r223747455
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java
---
@@ -442,5 +442,58 @@ protected void doRemoveRegex
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r224307768
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java
---
@@ -1360,24 +1385,47 @@ boolean getUpdatedDocument
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r224306195
--- Diff:
solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java
---
@@ -661,6 +690,21 @@ public static SolrInputDocument
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r224209409
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateBlockTest.java
---
@@ -0,0 +1,370 @@
+/*
+ * Licensed to the Apache
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r224283996
--- Diff:
solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java
---
@@ -609,9 +618,10 @@ public static SolrInputDocument
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r224300831
--- Diff:
solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java
---
@@ -639,12 +650,30 @@ public static SolrInputDocument
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r224130315
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateBlockTest.java
---
@@ -0,0 +1,370 @@
+/*
+ * Licensed to the Apache
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r223749656
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java
---
@@ -111,6 +114,8 @@
public static final
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r224131263
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateBlockTest.java
---
@@ -0,0 +1,370 @@
+/*
+ * Licensed to the Apache
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r224131571
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateBlockTest.java
---
@@ -0,0 +1,370 @@
+/*
+ * Licensed to the Apache
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r223561565
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java
---
@@ -461,5 +466,33 @@ private static boolean
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r223244019
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java
---
@@ -461,5 +466,33 @@ private static boolean
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r223243871
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java
---
@@ -461,5 +466,33 @@ private static boolean
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r223244909
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateBlockTest.java
---
@@ -181,6 +182,180 @@ public void testBlockRealTimeGet
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r223244186
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java
---
@@ -461,5 +466,33 @@ private static boolean
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r218293921
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java
---
@@ -1184,7 +1196,16 @@ protected boolean versionAdd
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/455
ConvertedLegacyTest fails in part because line 306 adds with
overwrite=false -- a bit of a dubious Solr feature that is probably not
properly compatible with the UpdateLog which makes various
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214773746
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -132,6 +134,12 @@ public void transform(SolrDocument
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214773781
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java
---
@@ -106,9 +123,20 @@ public DocTransformer create
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214541964
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java
---
@@ -57,12 +58,34 @@
static final char
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214542527
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java
---
@@ -243,11 +250,39 @@ private void
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214542110
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java
---
@@ -57,12 +58,34 @@
static final char
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214541721
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -54,24 +54,26 @@
private final DocSet
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214542721
--- Diff:
solr/solrj/src/test/org/apache/solr/client/solrj/SolrExampleTests.java ---
@@ -1831,7 +1831,7 @@ public void testChildDoctransformer() throws
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214542262
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DocTransformer.java ---
@@ -114,4 +114,27 @@ public void transform(SolrDocument doc
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214542325
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java
---
@@ -91,10 +98,10 @@ private void
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214541692
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -131,6 +131,12 @@ public void transform(SolrDocument
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/433#discussion_r214121353
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java
---
@@ -198,32 +209,32 @@ private String
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/433#discussion_r214122537
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java
---
@@ -165,31 +165,42 @@ private String
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/433#discussion_r214120233
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java
---
@@ -437,45 +461,46 @@ protected void doClose
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/433#discussion_r214118388
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java
---
@@ -437,45 +461,46 @@ protected void doClose
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/443
Oh right; we'd get an infinite loop as the ChildDocTransformerFactory is
already being called by SolrReturnFields! Ouch!
Sorry but I don't like your solution of trying to parse/strip
Github user dsmiley commented on the pull request:
https://github.com/apache/lucene-solr/commit/da0856f1dc41b7ea85ce71801900d63c06422db2#commitcomment-30344425
In
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java:
In
solr/core/src/java/org
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214044533
--- Diff: solr/solr-ref-guide/src/transforming-result-documents.adoc ---
@@ -137,6 +137,7 @@ When using this transformer, the `parentFilter`
parameter
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214044911
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java
---
@@ -106,9 +107,12 @@ public DocTransformer create
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214018618
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -297,6 +297,35 @@ public void
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r213541579
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -124,10 +124,11 @@ public void
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r213540255
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -123,6 +124,16 @@ public void transform(SolrDocument
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r213295374
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -99,6 +96,9 @@ public void transform(SolrDocument
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r213291939
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r213292329
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -109,9 +109,14 @@ public void transform(SolrDocument
1 - 100 of 588 matches
Mail list logo
