[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798634#comment-16798634
]
ASF subversion and git services commented on SOLR-11126:
Commit
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798633#comment-16798633
]
ASF subversion and git services commented on SOLR-11126:
Commit
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798632#comment-16798632
]
ASF subversion and git services commented on SOLR-11126:
Commit
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798630#comment-16798630
]
Shalin Shekhar Mangar commented on SOLR-11126:
--
This issue was only committed for 8.0 but I
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789521#comment-16789521
]
Jan Høydahl commented on SOLR-11126:
[~shalinmangar], [~anshumg], please resolve this if you're done
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789280#comment-16789280
]
Amrit Sarkar commented on SOLR-11126:
-
[~janhoy] yes I believe, the patch is committed.
> Node-level
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745041#comment-16745041
]
Jan Høydahl commented on SOLR-11126:
This issue can be resolved?
> Node-level health check handler
>
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16735107#comment-16735107
]
ASF subversion and git services commented on SOLR-11126:
Commit
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734425#comment-16734425
]
Lucene/Solr QA commented on SOLR-11126:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734037#comment-16734037
]
Amrit Sarkar commented on SOLR-11126:
-
Ah :( Right. Didn't fail to start for me but yes fails to
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733991#comment-16733991
]
Shalin Shekhar Mangar commented on SOLR-11126:
--
[~sarkaramr...@gmail.com] -- Solr fails to
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733966#comment-16733966
]
Shalin Shekhar Mangar commented on SOLR-11126:
--
This is interesting. The system, thread,
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733958#comment-16733958
]
Amrit Sarkar commented on SOLR-11126:
-
Thanks, Shalin, apologies you had to review multiple times. I
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733898#comment-16733898
]
Shalin Shekhar Mangar commented on SOLR-11126:
--
I found a reproducible failure for the test:
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733887#comment-16733887
]
Shalin Shekhar Mangar commented on SOLR-11126:
--
Thanks Amrit. The changes look good to me.
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733618#comment-16733618
]
Lucene/Solr QA commented on SOLR-11126:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733211#comment-16733211
]
Amrit Sarkar commented on SOLR-11126:
-
Fresh patch uploaded, incorporating all suggestions made
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732987#comment-16732987
]
Amrit Sarkar commented on SOLR-11126:
-
Thanks Shalin for the feedback. I see there are some details
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732971#comment-16732971
]
Shalin Shekhar Mangar commented on SOLR-11126:
--
Thanks Amrit. A few comments:
# The
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721718#comment-16721718
]
Anshum Gupta commented on SOLR-11126:
-
[~janhoy]- you couldn't get it to work in 7.5 or 7.6 because
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721546#comment-16721546
]
Amrit Sarkar commented on SOLR-11126:
-
Integrated SOLR-11126-v2.patch into fresh one:
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721068#comment-16721068
]
Jan Høydahl commented on SOLR-11126:
Ok, I guess the /api/node/health was never committed, but I
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721058#comment-16721058
]
Jan Høydahl commented on SOLR-11126:
I tested it in my 7.5.0 with
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721029#comment-16721029
]
Amrit Sarkar commented on SOLR-11126:
-
Hi [~anshumg], thank you for adding this handler, this can be
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282829#comment-16282829
]
Anshum Gupta commented on SOLR-11126:
-
FYI, the test doesn't work because of the changed path. I'll
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280784#comment-16280784
]
ASF subversion and git services commented on SOLR-11126:
Commit
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280772#comment-16280772
]
ASF subversion and git services commented on SOLR-11126:
Commit
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280760#comment-16280760
]
ASF subversion and git services commented on SOLR-11126:
Commit
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280672#comment-16280672
]
Anshum Gupta commented on SOLR-11126:
-
[~ctargett] sorry about missing the comments here. Yes, it
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211266#comment-16211266
]
Cassandra Targett commented on SOLR-11126:
--
[~anshumg]: This issue is in CHANGES for 7.1 but it's
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201094#comment-16201094
]
Hoss Man commented on SOLR-11126:
-
NOTE: If this gets backported, please make sure to backport the test
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117943#comment-16117943
]
Anshum Gupta commented on SOLR-11126:
-
Also, about the v2 support, it might make more sense for this
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117519#comment-16117519
]
ASF subversion and git services commented on SOLR-11126:
Commit
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117473#comment-16117473
]
ASF subversion and git services commented on SOLR-11126:
Commit
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117472#comment-16117472
]
Anshum Gupta commented on SOLR-11126:
-
Thanks for taking a look at this [~shalinmangar].
I've changed
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115231#comment-16115231
]
Shalin Shekhar Mangar commented on SOLR-11126:
--
# It is a bad idea to do {{updateLiveNodes}}
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111535#comment-16111535
]
ASF subversion and git services commented on SOLR-11126:
Commit
[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103996#comment-16103996
]
Anshum Gupta commented on SOLR-11126:
-
Also, this allows for the handler to be extended just the way
38 matches
Mail list logo