Re: restlet dependencies

Ok, good enough for me, thanks for feedback David and Noble, proceeding with the cherry-picks to 8x Tim On Tue, Oct 6, 2020 at 8:25 PM David Smiley wrote: > No strong opinion from me. I think the back-compat concern is minor. > > ~ David Smiley > Apache Lucene/Solr Search Developer >

Re: restlet dependencies

No strong opinion from me. I think the back-compat concern is minor. ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Tue, Oct 6, 2020 at 5:42 PM Noble Paul wrote: > I think we should call that out in the changes.txt and make the changes > right

Re: restlet dependencies

I think we should call that out in the changes.txt and make the changes right away. On Wed, Oct 7, 2020, 8:20 AM Timothy Potter wrote: > Just want to close the loop on this restlet issue. I've removed the > restlet dependency in master (e879a52291ef7dcd0514e7419d811b6ff800bcce) but > have not

Re: restlet dependencies

Just want to close the loop on this restlet issue. I've removed the restlet dependency in master (e879a52291ef7dcd0514e7419d811b6ff800bcce) but have not backported that to 8.x yet. I'm hesitant to backport because I had to change public function signatures on ManagedResource, e.g.

Re: restlet dependencies

Awesome guys, thanks for the pointers ... am cooking up a PR (for master) for this today On Thu, Oct 1, 2020 at 2:22 AM Noble Paul wrote: > The annotation ( > https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/api/EndPoint.java > ) > supports wild cards and

Re: restlet dependencies

The annotation (https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/api/EndPoint.java) supports wild cards and templated paths On Thu, Oct 1, 2020 at 5:28 PM Ishan Chattopadhyaya wrote: > > > But when I suggested porting the code that uses restlet to JAX-RS /

Re: restlet dependencies

> But when I suggested porting the code that uses restlet to JAX-RS / Jersey, Ishan said > that wasn't necessary and is already supported with some Annotations ... I have no idea > what that means and need more info about what is already in place. I was mainly referring to the @Endpoint

Re: restlet dependencies

@Tim Please check ClusterAPI or ZookeeperReadAPI etc. Recently used it in Yasa: https://github.com/yasa-org/yasa/blob/master/yasa-solr-plugin/src/main/java/io/github/kezhenxu94/YasaHandler.java On Thu, Oct 1, 2020 at 10:46 AM Noble Paul wrote: > @Tim Potter > > I tried several times to get rid

Re: restlet dependencies

@Tim Potter I tried several times to get rid of the restlet dependency & keep the functionality as is. I failed miserably. I'm not saying this to discourage anyone who wants to give a try. Just letting you know that it is not as easy as it may sound On Thu, Oct 1, 2020 at 2:42 AM Houston Putman

Re: restlet dependencies

+1 to Tomas' proposal. Created SOLR-14907 to track the effort. - Houston On Wed, Sep 30, 2020 at 12:26 PM Tomás Fernández Löbbe < tomasflo...@gmail.com> wrote: > > Let's support the single file upload feature > +1, but let this behave exactly

Re: restlet dependencies

> Let's support the single file upload feature +1, but let this behave exactly as a zip file with a single file in it (regarding trusted/untrusted). We just need to change the configset handler to be able to handle non-zip files, and have a way to "locate" that file inside the configset (in case

Re: restlet dependencies

I think that me in “violent agreement” with you. Let’s understand the Annotations approach that we have, or pick something that is commonly used like JAX-RS / Jersey. > On Sep 30, 2020, at 11:41 AM, Timothy Potter wrote: > > I'm sorry, I don't understand what you mean by "make it a single

Re: restlet dependencies

I'm sorry, I don't understand what you mean by "make it a single pattern (the annotations?)" Eric? To me, the pattern is well established in the Java world: JAX-RS (with Jersey as the underlying impl. which has nice integration with Jetty). But when I suggested porting the code that uses restlet

Re: restlet dependencies

The use case of “I want to update something via a API” is I think pretty common, and it would be nice to make it a single pattern (the annotations?) with lots of examples/developer docs for the next person. > On Sep 30, 2020, at 11:04 AM, Timothy Potter wrote: > > I started looking into

Re: restlet dependencies

I started looking into removing Managed Resources in master and wanted to mention that the LTR contrib also relies on this framework (ManagedModelStore and ManagedFeatureStore, see: https://lucene.apache.org/solr/guide/8_6/learning-to-rank.html#uploading-a-model). I only mention this b/c it's been

Re: restlet dependencies

These resources are fundamentally a part of the configSet and can (in general) affect query results and thus flushing caches (via a reload) is appropriate. ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Wed, Sep 30, 2020 at 9:06 AM Noble Paul

Re: restlet dependencies

Well, I believe we should have a mechanism to upload a single file to a configset. > A single file configset upload would require the user to reload the > collection, so it isn't better than managed resources. This is not true Only config/schema file changes result in core reload. On Wed,

Re: restlet dependencies

>It is supported and documented: >https://lucene.apache.org/solr/guide/8_6/managed-resources.html I was referring to how the code works. Not how the feature works On Wed, Sep 30, 2020 at 7:46 PM Ishan Chattopadhyaya wrote: > > > * Nobody knows how it works. It's unsupported > It is supported

Re: restlet dependencies

Core reloads cause caches to be invalidated, hence the query response times shoot up momentarily. This doesn't happen when using managed synonyms etc, does it? On Wed, 30 Sep, 2020, 5:53 pm David Smiley, wrote: > Definitely don't remove in 8.x! > > > A single file configset upload would

Re: restlet dependencies

Definitely don't remove in 8.x! > A single file configset upload would require the user to reload the collection, so it isn't better than managed resources. Do you view that as a substantial point in favor of managed-resources? I view that as a trivial matter, and one I prefer to automagic and

Re: restlet dependencies

> * Nobody knows how it works. It's unsupported It is supported and documented: https://lucene.apache.org/solr/guide/8_6/managed-resources.html > * RESTlet dependency > * Cannot be secured using standard permissions > * It's extremely complex for the functionality it offers. I agree. Whatever

Re: restlet dependencies

The managed resources is the only reasonable way to upload synonyms on the fly for users today. A single file configset upload would require the user to reload the collection, so it isn't better than managed resources. I would not recommend we remove the functionality without first building a

Re: restlet dependencies

Please don't do this. In short: remove restlet stuff from master. Pull requests on master are executed with Gradle on GitHub hardware. Ivy stuff in 8.x is built in more or less persistent servers and there is no issue. What's the problem? Uwe Am September 30, 2020 8:59:06 AM UTC schrieb

Re: restlet dependencies

Can we discuss this with ASF and get an exception for this? On Wed, 30 Sep, 2020, 11:57 am Dawid Weiss, wrote: > We can't have or redistribute binaries in ASL sources - that's my > understanding. > > Dawid > > On Tue, Sep 29, 2020 at 10:02 PM Ishan Chattopadhyaya > wrote: > > > > Can we pull

Re: restlet dependencies

We can't have or redistribute binaries in ASL sources - that's my understanding. Dawid On Tue, Sep 29, 2020 at 10:02 PM Ishan Chattopadhyaya wrote: > > Can we pull in the jar inside our codebase? > > On Wed, 30 Sep, 2020, 1:19 am Dawid Weiss, wrote: >> >> >> We can upgrade if it doesn't break

Re: restlet dependencies

I don't support removing managed resources in a minor release. Some of my clients depend on it. Also, single file upload has important security considerations and we don't have time to have that feature in before 8.7. On Wed, 30 Sep, 2020, 10:50 am Noble Paul, wrote: > @Tomas Fernandez Lobbe >

Re: restlet dependencies

@Tomas Fernandez Lobbe @Ishan Chattopadhyaya Let's support the single file upload feature. Let's automatically make that configset "untrusted" if any file is uploaded over REST. Those "untrusted" features are not really important for normal users On Wed, Sep 30, 2020 at 3:19 PM Noble Paul wrote:

Re: restlet dependencies

I think we should just get rid of that feature in the next release. if somebody is dependent on that let them stick to 8.6x or 8.7. We should not bend over backwards to support some esoteric feature nobody uses Managed Resources has the following problems * Nobody knows how it works. It's

Re: restlet dependencies

Can we pull in the jar inside our codebase? On Wed, 30 Sep, 2020, 1:19 am Dawid Weiss, wrote: > > We can upgrade if it doesn't break anything... which I can't guarantee. ;) > > Dawid > >>

Re: restlet dependencies

We can upgrade if it doesn't break anything... which I can't guarantee. ;) Dawid >

Re: restlet dependencies

9 is too soon from a deprecation stand point >>>>>>>>> >>>>>>>>> IMO it's never too soon as long as there is a deprecated release. >>>>>>>>> Users take their time upgrading to major versions. >>>>>>>

Re: restlet dependencies

>>>>>>> > How much harder are the use-cases currently covered by managed >>>>>>>> resources, if that module was removed? >>>>>>>> >>>>>>>> I believe in practice, users synchronize one-way from their DB

Re: restlet dependencies

>> newly updated files but does not delete the existing files? >>> >>> ~ David Smiley >>> Apache Lucene/Solr Search Developer >>> http://www.linkedin.com/in/davidwsmiley >>> <http://www.linkedin.com/in/davidwsmiley> >>> &g

Re: restlet dependencies

re I >>>>>>> work. >>>>>>> Otherwise, they would probably be using Solr as the source of truth, >>>>>>> which >>>>>>> doesn't seem architecturally-sound for most apps IMO. Those users >>>>>>> (hope

Re: restlet dependencies

;>>> I was thinking the same. Because GitHub does not cache the downloaded >> >>>> artifacts like our jenkins servers. >> >>>> >> >>>> It seems to run it in a new VM or container every time, so it downloads >> >>>> all artifacts.

Re: restlet dependencies

ansition here is pretty easy: serialize the >>>>>> client-managed data to the right Solr format (stopwords vs synonyms vs >>>>>> ...) >>>>>> and then a file upload to Solr/ZK and then telling Solr which collections >>>>>> to &quo

Re: restlet dependencies

n a file upload to Solr/ZK and then telling Solr which collections >>>>> to "reload". >>>>> >>>>> Hmmm; seems the configSet API doesn't have an API to update a single >>>>> file! I wonder if uploading a configSet to the same name

Re: restlet dependencies

files but does not delete the existing files? >>>> >>>> ~ David Smiley >>>> Apache Lucene/Solr Search Developer >>>> http://www.linkedin.com/in/davidwsmiley >>>> >>>> >>>> On Wed, Sep 23, 2020 at 10:28 AM Timothy Potter

Re: restlet dependencies

per >>> http://www.linkedin.com/in/davidwsmiley >>> >>> >>> On Wed, Sep 23, 2020 at 10:28 AM Timothy Potter >>> wrote: >>> >>>> I agree we should deprecate the managed resources feature, it was the >>>> first thing I was

Re: restlet dependencies

thing I was asked to build by LW nearly 7 years ago, before I was a >>> committer. Restlet was already in place and I built on top of that, not >>> sure who introduced it originally (nor do I care). Clearly from the vantage >>> point of looking back, JAX-RS and Jersey won the da

Re: restlet dependencies

then. What's important is how we move forward vs. > bestowing judgement backed by wisdom of hindsight on decisions made many > years ago. > > In the short term, does Apache have an Artifactory (or similar) where we can > host the Restlet dependencies for Github to pull them from

Re: restlet dependencies

Thank you for considering doing something with this, guys. Not pointing fingers at anyone but those restlet dependencies are causing notorious problems, in many places (and the invalid empty manifest entry is the most annoying of all...). Dawid

Re: restlet dependencies

th REST in Java but >> that simply wasn't the case back then. What's important is how we move >> forward vs. bestowing judgement backed by wisdom of hindsight on decisions >> made many years ago. >> >> In the short term, does Apache have an Artifactory (or similar) wher

Re: restlet dependencies

wasn't the case back then. What's important is how we move > forward vs. bestowing judgement backed by wisdom of hindsight on decisions > made many years ago. > > In the short term, does Apache have an Artifactory (or similar) where we > can host the Restlet dependencies for Github to pu

Re: restlet dependencies

y from the vantage >> point of looking back, JAX-RS and Jersey won the day with REST in Java but >> that simply wasn't the case back then. What's important is how we move >> forward vs. bestowing judgement backed by wisdom of hindsight on decisions >> made many years ago. &g

Re: restlet dependencies

looking back, JAX-RS and Jersey won the day with REST in Java but > that simply wasn't the case back then. What's important is how we move > forward vs. bestowing judgement backed by wisdom of hindsight on decisions > made many years ago. > > > > In the short term, does Apach

Re: restlet dependencies

gt; >> >>>> Uwe >> >>>> >> >>>> Am September 18, 2020 7:32:47 PM UTC schrieb Dawid Weiss >> >>>> : >> >>>>> >> >>>>> I don't think it's http/https - I believe restlet repository simply >> >>

Re: restlet dependencies

) where we can host the Restlet dependencies for Github to pull them from? If not, then we can port the code that's using Restlet over to using JAX-RS / Jersey. Personally I'd prefer we remove Managed Resources support from 9 instead of porting the Restlet code but I don't know if 9 is too soon from

Re: restlet dependencies

t's http/https - I believe restlet repository simply >>>>> bans github servers because of excessive traffic? These URLs work for >>>>> me locally... >>>>> >>>>> Dawid >>>>> >>>>> On Fri, Sep 18, 2020 at 6:35

Re: restlet dependencies

On Fri, Sep 18, 2020 at 6:35 PM Christine Poerschke (BLOOMBERG/ >>>> LONDON) wrote: >>>> >>>>> >>>>> This sounds vaguely familiar. "http works, https does not work" and >>>>> https://issues.apache.org/jira/browse/SOLR-13756

Re: restlet dependencies

es.apache.org/jira/browse/SOLR-13756> possibly related? > > From: dev@lucene.apache.org <mailto:dev@lucene.apache.org> At: 09/18/20 > 10:01:29 > To: dev@lucene.apache.org <mailto:dev@lucene.apache.org> > Subject: Re: restlet dependencies > > I don't think

Re: restlet dependencies

>>> >>>> >>>> This sounds vaguely familiar. "http works, https does not work" and >>>> https://issues.apache.org/jira/browse/SOLR-13756 possibly related? >>>> >>>> From: dev@lucene.apache.org At: 09/18/20 10:01:29 >>

Re: restlet dependencies

>> LONDON) wrote: >> >>> >>> This sounds vaguely familiar. "http works, https does not work" and >>> https://issues.apache.org/jira/browse/SOLR-13756 possibly related? >>> >>> From: dev@lucene.apache.org At: 09/18/20 10:01:29 >

Re: restlet dependencies

sounds vaguely familiar. "http works, https does not work" and >https://issues.apache.org/jira/browse/SOLR-13756 possibly related? >> >> From: dev@lucene.apache.org At: 09/18/20 10:01:29 >> To: dev@lucene.apache.org >> Subject: Re: restlet dependencies >&g

Re: restlet dependencies

https does not work" and > https://issues.apache.org/jira/browse/SOLR-13756 possibly related? > > From: dev@lucene.apache.org At: 09/18/20 10:01:29 > To: dev@lucene.apache.org > Subject: Re: restlet dependencies > > I don't think it is, sadly. > https://repo1.maven

Re: restlet dependencies

This sounds vaguely familiar. "http works, https does not work" and https://issues.apache.org/jira/browse/SOLR-13756 possibly related? From: dev@lucene.apache.org At: 09/18/20 10:01:29To: dev@lucene.apache.org Subject: Re: restlet dependencies I don't think it is, sadly. htt

Re: restlet dependencies

I don't think it is, sadly. https://repo1.maven.org/maven2/org/restlet The link you provided (mvnrepository) aggregates from several maven repositories. D. On Fri, Sep 18, 2020 at 10:46 AM Ishan Chattopadhyaya wrote: > > Sorry, afk, but I heard (*hearsay*) that restlet is also on maven

Re: restlet dependencies

https://mvnrepository.com/artifact/org.restlet.jee/org.restlet.ext.servlet On Fri, 18 Sep, 2020, 2:15 pm Ishan Chattopadhyaya, < ichattopadhy...@gmail.com> wrote: > Sorry, afk, but I heard (*hearsay*) that restlet is also on maven central > these days. Can we confirm and switch to that? Sorry,

Re: restlet dependencies

Sorry, afk, but I heard (*hearsay*) that restlet is also on maven central these days. Can we confirm and switch to that? Sorry, if that's not the case. On Fri, 18 Sep, 2020, 1:15 pm Dawid Weiss, wrote: > Just FYI: can't get PR builds on github to work recently because of this: > > > Could not

restlet dependencies

Just FYI: can't get PR builds on github to work recently because of this: > Could not resolve all files for configuration ':solr:core:compileClasspath'. 350 > Could not download org.restlet.ext.servlet-2.4.3.jar (org.restlet.jee:org.restlet.ext.servlet:2.4.3) 351 > Could not get resource