Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/26#issuecomment-65926546
Quick note: `KNearestNeighborClassifier` is misspelled
`KNearesteighborClassifier`
---
If your project is set up for it, you can reply to this email and have your
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/20#issuecomment-67831967
Any chance you can rebase this to be against master? I basically just
copied spatial there
(https://github.com/apache/lucenenet/tree/master/src/contrib/Spatial
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/30#issuecomment-68186997
Good catch, keep them coming! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/41#issuecomment-68598731
Why won't we override Equals as well? why use a dedicated method for this?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/70#issuecomment-72607213
This is very weird that the file isn't being created despite the call to
`file.Create();`
I'd like to have @uschindler's eyes on this before pulling
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/78#issuecomment-73201369
Thanks I'll review and squash shortly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/77#issuecomment-73201186
Thanks!
In the next pull follow these steps and it will go smooth:
```
git fetch apache (or however you called the apache repo)
git checkout
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/85#issuecomment-73404422
This needs to happen on the base class level to leverage randomized testing
properly:
https://github.com/apache/lucene-solr/blob/trunk/lucene/core/src/test
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/70#issuecomment-72628999
I don't mind Lucene.NET 4.8 being non-compatible with Java Lucene 4.8 in
that regard since it doesn't affect anything but our create new index story
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/51#issuecomment-70582104
The tests package should be renamed (`git mv`ed) to be
Lucene.Net.Tests.Codecs
---
If your project is set up for it, you can reply to this email and have your
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/52#issuecomment-70619587
Thanks Sean
We may want to include some explanation on the folder structure, as well as
probably removing the current status of things (which is bound
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/52#issuecomment-70663487
I'm all in for the `up-for-grabs` thing, and would have done it already if
we had github issues enabled..
---
If your project is set up for it, you can reply
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/52#issuecomment-70694873
Email Infra, I think no Apache project has it enabled. There's JIRA for
that :(
---
If your project is set up for it, you can reply to this email and have your
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/51#issuecomment-70482662
Looks good. I merged now because you were working off master - please
create a branch for future PRs :)
---
If your project is set up for it, you can reply
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/47#discussion_r23003074
--- Diff: src/Lucene.Net.Core/Codecs/Lucene45/Lucene45DocValuesConsumer.cs
---
@@ -123,11 +123,13 @@ internal virtual void AddNumericField(FieldInfo
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/47#issuecomment-70076543
No need to port `Numeric` IMO, all usages I've seen of it mattered only for
inheritance which I could get by one way or another.
---
If your project is set up
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/53#issuecomment-70849686
Thanks for this PR
Can you please resend this PR, this time with only the Expressions bits
(code + tests), and also rebase this against the current master
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/52#issuecomment-71090114
@SeanKilleen no, basically you should see only one commit here
https://github.com/SeanKilleen/lucenenet/compare/AddContributorsGuide
---
If your project is set up
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/95#issuecomment-73962107
@Chand2048 any reason why you closed this PR then ? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/92#issuecomment-74815615
@guidotag I think this can be closed now that #97 is merged? can the PQ
from `Support` be removed now?
---
If your project is set up for it, you can reply
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/103#issuecomment-75110511
I must be missing something - this is not using the Java's PQ, it's using
this:
https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/core/src/java
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/104#issuecomment-75111513
Yes, PLEASE :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/98#issuecomment-74593471
Thanks, I'll review shortly. Will probably cherry pick and not merge
because there's too many discrete unrelated changes here. Would be great if
future PRs
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/103#issuecomment-75200475
What do you think we should do - keep with one PQ implementation and make
it to support resizing (i.e. when `maxSize` is null), or keep using that other
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/62#issuecomment-71629826
@laimis can you please review, based on your changes there?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/61#issuecomment-71629708
I'll cherry pick and close - thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/64#discussion_r23669127
--- Diff: src/Lucene.Net.Core/packages.config ---
@@ -1,5 +1,6 @@
?xml version=1.0 encoding=utf-8?
packages
+ package id=Antlr4.Runtime
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/64#discussion_r23669113
--- Diff: msbuild.log ---
@@ -0,0 +1,15 @@
+Build started 1/2/2015 4:43:13 PM.
+ 1Project C:\Projects\GitHub\lucene.net\Lucene.Net.sln
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/64#issuecomment-71790653
Thanks, left some comments
Lets try to avoid touching unrelated files...
---
If your project is set up for it, you can reply to this email and have your
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/64#discussion_r23669229
--- Diff: src/Lucene.Net.Tests.Classification/packages.config ---
@@ -1,4 +0,0 @@
-?xml version=1.0 encoding=utf-8?
-packages
- package
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/64#discussion_r23669193
--- Diff: src/Lucene.Net.Tests.Facet/Lucene.Net.Tests.Facet.csproj ---
@@ -34,7 +34,7 @@
HintPath..\..\packages\Apache.NMS.1.6.0.3083\lib
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/64#issuecomment-72333797
I moved ahead and just copied the files over, way easier
Any further work on Expressions (e.g. fixing tests) needs to happen on a
branch and merged via
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/20#issuecomment-72334252
@cyberram any update on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/58#issuecomment-71346902
Good catch!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/67#issuecomment-72362825
Yes, works now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/69#discussion_r23902204
--- Diff: src/Lucene.Net.Codecs/Memory/DirectPostingsFormat.cs ---
@@ -353,40 +344,30 @@ public DirectField(SegmentReadState state, string
field, Terms
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/69#issuecomment-72388745
Looks good! one lesson we learned post-sbyte removal is some calculations
are relying on the value to be -128 - 128 in range, so sbyte conversion is
required before
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/43#issuecomment-68866114
@uschindler yes that was our understanding (see mail thread), and thanks
for confirming that. Why the effort for fsync'ing a dir in the first place
though
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/43#issuecomment-68867580
Ok @laimis, so to enable better support of Mono on non-Windows OSs lets
bring back this for dirs as well, however lets make 2 changes: (1) handle
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/43#issuecomment-68867722
Thanks @uschindler, this makes sense, although all of that doesn't apply to
Windows really :)
We'll be bringing this back for the sake of better non-Windows
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/88#issuecomment-73529139
To be frank my main concern is with the actual implementation - the Java
version is relying on a JVM implementation, and if we are to write our own we
should
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/95#issuecomment-73859173
Can you point at some of those tests? I'm not sure we actually want to
not-ignore \0
---
If your project is set up for it, you can reply to this email and have
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/70#issuecomment-73765620
I'm assigning this to myself. I'll work on this next week and get some
well-defined behavior suitable for the CLR in place.
---
If your project is set up
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/92#issuecomment-73764768
@guidotag this is mainly why I haven't pulled this in yet. I wasn't the one
to bring this PQ implementation in so I wanted to review this carefully and
haven't got
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/92#issuecomment-73803989
Because as you indicate, items are not compared based on one strategy
always. See the link I posted for another example of this.
`IComparer` is more
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/88#issuecomment-73445246
What is this fix about?
Also, have you implemented an LRU cache from scratch? any reason why you
didn't use other implementations such as
http
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/92#issuecomment-73806542
Go ahead!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/118#issuecomment-77048230
Yes, but if you can do some work on the Codec tests that will be great
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/112#issuecomment-76635291
Ok just reviewed it - this class has only 2 usages and the fix looks legit
enough...
I moved class using it to the TestFramework project; the other only
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/117#issuecomment-76625513
I'll handle this in a few days, won't merge for now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/118#discussion_r25691530
--- Diff: src/Lucene.Net.Tests/core/Index/TestAddIndexes.cs ---
@@ -1207,8 +1207,8 @@ public UnRegisteredCodec()
/*
* simple
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/108#issuecomment-75497759
@laimis what do you make of @Chand2048 's comment about this test not
existing in the original Java code?
---
If your project is set up for it, you can reply
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/113#issuecomment-76078565
Merged. We should probably add a LUCENE TODO to tackle this later since we
are swallowing the original exception
---
If your project is set up for it, you can
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/114#issuecomment-76154853
@Chand2048 this is exactly how this is being done in Apache Lucene - see
https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/core/src/test/org
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/127#issuecomment-91896983
Thanks @laimis -- can you do said review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/132#issuecomment-96372011
Good catch, will merge now
Can you evaluate if we still need that non-generic class?
---
If your project is set up for it, you can reply to this email
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/130#issuecomment-95234992
Is there a reason to have that marker interface public and not kept private?
While I'd assume there are more places like this, I wonder if we can assume
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/131#issuecomment-95356979
Thanks. We are not actively maintaining the 3.x branch as we put all our
efforts in having a 4.x release soon. I'll be keeping this around for a
reference
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/135#issuecomment-98381886
Awesome work, thanks. Pushing this now and let's see if TC confirms.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/138#issuecomment-98593927
Good catch
2 things come to mind:
1. `OffsetGap_Renamed` and such other `_Renamed` instances need to be,
well, renamed and have that suffix
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/142#issuecomment-100528838
All looks good, I don't see anything to discuss here really. Will merge now.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/145#issuecomment-102659785
Can you rebase please? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/145#discussion_r30463210
--- Diff: src/Lucene.Net.Core/Util/OfflineSorter.cs ---
@@ -34,486 +34,6 @@ namespace Lucene.Net.Util
/// /summary
public sealed class
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/145#issuecomment-102662514
Good catch, I'll merge now.
For the record, `DateTime.UtcNow.Ticks` is a closer equivalent to
`System.currentTimeMillis` but for the purpose
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/157#discussion_r47976547
--- Diff: src/Lucene.Net.Analysis.Common/Analysis/Util/CharArrayIterator.cs
---
@@ -1,276 +1,268 @@
using System;
+using ICU4NET
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/155#issuecomment-163713206
Looks good - let's do this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/158#issuecomment-167158881
Hi, thanks for submitting this.
The code in question isn't being maintained any more - it is part of a
previous release and will be replaced soon
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/159#discussion_r49704493
--- Diff: src/Lucene.Net.Analysis.Common/Analysis/Core/LetterTokenizer.cs
---
@@ -75,10 +75,10 @@ public LetterTokenizer(LuceneVersion matchVersion
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/160#issuecomment-176117158
Looks good, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/161#issuecomment-207031535
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/162#issuecomment-207031319
Looks good, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/163#issuecomment-201195415
Looks good, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/167#issuecomment-213343394
Thanks! I've made a comment on the Exception type used
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/167#discussion_r60710792
--- Diff: src/Lucene.Net.Facet/Taxonomy/WriterCache/CollisionMap.cs ---
@@ -261,7 +261,7 @@ public Entry Next()
Entry e
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/168#discussion_r60711453
--- Diff: src/Lucene.Net.Tests/core/Index/TestIndexWriterWithThreads.cs ---
@@ -726,15 +724,15 @@ public override void Run
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/168#discussion_r60711321
--- Diff: src/Lucene.Net.Tests/core/Index/TestIndexWriterWithThreads.cs ---
@@ -657,7 +655,7 @@ public virtual void TestRollbackAndCommitWithThreads
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/169#issuecomment-214746674
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/168#issuecomment-213845719
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/167#issuecomment-213849508
Thanks, merged. On your next PR, please work on a branch, it is an ill
practice in git to merge from someone else's master.
---
If your project is set up
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/170#issuecomment-215986990
Merged, thanks!
(please submit future PRs from branches to avoid history conflicts..)
---
If your project is set up for it, you can reply to this email
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/171#issuecomment-220534914
Looks great, thanks for amazing work here.
I left a few more minor comments, other than that LGTM and I'll merge soon
---
If your project is set up
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62450979
--- Diff: src/Lucene.Net.Core/Index/LiveIndexWriterConfig.cs ---
@@ -149,7 +149,11 @@ internal LiveIndexWriterConfig(Analyzer analyzer,
LuceneVersion
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62451281
--- Diff: src/Lucene.Net.Core/Index/IConcurrentMergeScheduler.cs ---
@@ -0,0 +1,15 @@
+namespace Lucene.Net.Index
+{
+public
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62451346
--- Diff: src/Lucene.Net.Core/Index/TaskMergeScheduler.cs ---
@@ -0,0 +1,665 @@
+using System;
+using System.Collections.Generic;
+using
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62451390
--- Diff: src/Lucene.Net.Tests/core/Index/TestTransactions.cs ---
@@ -128,13 +134,21 @@ public IndexerThread(TestTransactions outerInstance,
object
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62451412
--- Diff: src/Lucene.Net.Tests/core/TestMergeSchedulerExternal.cs ---
@@ -76,7 +76,9 @@ protected override MergeThread GetMergeThread(IndexWriter
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r63530104
--- Diff: src/Lucene.Net.Core/Index/TaskMergeScheduler.cs ---
@@ -0,0 +1,667 @@
+using System;
+using System.Collections.Generic;
+using
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r63530524
--- Diff: src/Lucene.Net.Core/Index/LiveIndexWriterConfig.cs ---
@@ -149,7 +149,11 @@ internal LiveIndexWriterConfig(Analyzer analyzer,
LuceneVersion
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r63530865
--- Diff: src/Lucene.Net.Tests/core/Index/TestIndexWriterConfig.cs ---
@@ -307,7 +315,11 @@ public virtual void TestInvalidValues
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/171#issuecomment-216681382
Thanks! give me a day or two to review this properly :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62423483
--- Diff: src/Lucene.Net.Core/Index/TaskMergeScheduler.cs ---
@@ -0,0 +1,665 @@
+using System;
+using System.Collections.Generic;
+using
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62423417
--- Diff: src/Lucene.Net.Core/Index/LiveIndexWriterConfig.cs ---
@@ -149,7 +149,11 @@ internal LiveIndexWriterConfig(Analyzer analyzer,
LuceneVersion
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62423632
--- Diff: src/Lucene.Net.Core/Index/IConcurrentMergeScheduler.cs ---
@@ -0,0 +1,15 @@
+namespace Lucene.Net.Index
+{
+public
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62423674
--- Diff: src/Lucene.Net.Core/Index/TaskMergeScheduler.cs ---
@@ -0,0 +1,665 @@
+using System;
+using System.Collections.Generic;
+using
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62423611
--- Diff: src/Lucene.Net.Tests/core/TestMergeSchedulerExternal.cs ---
@@ -76,7 +76,9 @@ protected override MergeThread GetMergeThread(IndexWriter
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/174
Looks good! will review shortly, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/173
Yes, this is my WIP branch. CharArrayMap and CharArraySet are a bit buggy
still (tests are failing) and need to wipe those bugs out. I think this branch
has all my changes (no local
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/177
Awesome work, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/178
Merged, if that dependency will cause issues we will handle it then
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/172
Thanks @conniey , looks good! I left a few comments - the main idea is to
minimize the amount of non-Java compatible changes we make and to document well
the ones we have to make
1 - 100 of 156 matches
Mail list logo
