[GitHub] madlib issue #244: Changes for Personalized Page Rank : Jira:1084

Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/244 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/387/ ---

[GitHub] madlib pull request #241: MiniBatch Pre-Processor: Add new module minibatch_...

Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/241#discussion_r175957289 --- Diff: src/ports/postgres/modules/utilities/minibatch_preprocessing.py_in --- @@ -0,0 +1,559 @@ +# coding=utf-8 +# +# Licensed to the

[GitHub] madlib pull request #244: Changes for Personalized Page Rank : Jira:1084

Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/244#discussion_r175952795 --- Diff: src/ports/postgres/modules/graph/pagerank.py_in --- @@ -527,14 +562,63 @@ def pagerank(schema_madlib, vertex_table, vertex_id, edge_table,

[GitHub] madlib pull request #244: Changes for Personalized Page Rank : Jira:1084

Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/244#discussion_r175952633 --- Diff: src/ports/postgres/modules/graph/pagerank.py_in --- @@ -527,14 +562,63 @@ def pagerank(schema_madlib, vertex_table, vertex_id, edge_table,

[GitHub] madlib pull request #244: Changes for Personalized Page Rank : Jira:1084

Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/244#discussion_r175952712 --- Diff: src/ports/postgres/modules/graph/pagerank.py_in --- @@ -44,29 +44,40 @@ from utilities.utilities import add_postfix from

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175949965 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -222,67 +243,83 @@ def mlp(schema_madlib, source_table, output_table,

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175950079 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -292,26 +329,33 @@ def mlp(schema_madlib, source_table, output_table,

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175947887 --- Diff: src/modules/convex/algo/igd.hpp --- @@ -90,20 +90,27 @@ IGD::transition(state_type , for (int

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175947857 --- Diff: src/modules/convex/algo/igd.hpp --- @@ -90,20 +90,27 @@ IGD::transition(state_type , for (int

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175950139 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -491,10 +571,28 @@ def _update_temp_model_table(args, iteration, temp_output_table,

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175948252 --- Diff: src/modules/convex/mlp_igd.cpp --- @@ -130,6 +145,90 @@ mlp_igd_transition::run(AnyType ) { return state; } +/** + *

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175949682 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -222,67 +243,83 @@ def mlp(schema_madlib, source_table, output_table,

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175948750 --- Diff: src/modules/convex/task/mlp.hpp --- @@ -111,6 +117,57 @@ class MLP { template double MLP::lambda = 0;

[GitHub] madlib issue #240: MLP: Fix step size initialization based on learning rate ...

Github user jingyimei commented on the issue: https://github.com/apache/madlib/pull/240 We manually tested the bug fix by printing the step_size and step_size_init for each iteration and then called mlp with all the possible policies. step_size was updated as expected. +1 for the

[GitHub] madlib pull request #245: Reduce Install Check run time

Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/245 ---

[GitHub] madlib issue #245: Reduce Install Check run time

Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/245 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/386/ ---

[GitHub] madlib pull request #246: DT user doc updates

Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/246#discussion_r175927937 --- Diff: src/ports/postgres/modules/recursive_partitioning/decision_tree.sql_in --- @@ -418,7 +468,10 @@ tree_predict(tree_model, new_data_table

[GitHub] madlib pull request #246: DT user doc updates

Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/246#discussion_r175924018 --- Diff: src/ports/postgres/modules/recursive_partitioning/decision_tree.sql_in --- @@ -127,7 +132,11 @@ tree_train( weights (optional)

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175888098 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -590,51 +664,103 @@ def _validate_warm_start(output_table, summary_table,

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175893520 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -1457,3 +1660,85 @@ def mlp_predict_help(schema_madlib, message): return """

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175891761 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -72,107 +73,127 @@ def mlp(schema_madlib, source_table, output_table,

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175627412 --- Diff: src/modules/convex/mlp_igd.cpp --- @@ -130,6 +145,90 @@ mlp_igd_transition::run(AnyType ) { return state; } +/** + *

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175872591 --- Diff: src/modules/convex/task/mlp.hpp --- @@ -111,6 +117,57 @@ class MLP { template double MLP::lambda = 0;

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175923655 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -33,11 +34,12 @@ from convex.utils_regularization import __utils_normalize_data_grouping

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175894372 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -1457,3 +1660,85 @@ def mlp_predict_help(schema_madlib, message): return """

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175923217 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -292,26 +329,33 @@ def mlp(schema_madlib, source_table, output_table,

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175889157 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -590,51 +664,103 @@ def _validate_warm_start(output_table, summary_table,

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175921215 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -222,67 +243,83 @@ def mlp(schema_madlib, source_table, output_table,

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175628144 --- Diff: src/modules/convex/mlp_igd.cpp --- @@ -130,6 +145,90 @@ mlp_igd_transition::run(AnyType ) { return state; } +/** + *

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175877947 --- Diff: src/modules/convex/task/mlp.hpp --- @@ -111,6 +117,57 @@ class MLP { template double MLP::lambda = 0;

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175929883 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -292,26 +329,33 @@ def mlp(schema_madlib, source_table, output_table,

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175620624 --- Diff: src/modules/convex/algo/igd.hpp --- @@ -90,20 +90,27 @@ IGD::transition(state_type , for (int

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175871655 --- Diff: src/modules/convex/mlp_igd.cpp --- @@ -170,6 +289,24 @@ mlp_igd_final::run(AnyType ) { return state; } + +/** + *

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175917822 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -222,67 +243,83 @@ def mlp(schema_madlib, source_table, output_table,

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175895832 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -72,107 +73,127 @@ def mlp(schema_madlib, source_table, output_table,

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175873168 --- Diff: src/modules/convex/task/mlp.hpp --- @@ -111,6 +117,57 @@ class MLP { template double MLP::lambda = 0;

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175626817 --- Diff: src/modules/convex/mlp_igd.cpp --- @@ -130,6 +145,90 @@ mlp_igd_transition::run(AnyType ) { return state; } +/** + *

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175625333 --- Diff: src/modules/convex/algo/igd.hpp --- @@ -90,20 +90,27 @@ IGD::transition(state_type , for (int

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175621915 --- Diff: src/modules/convex/algo/igd.hpp --- @@ -90,20 +90,27 @@ IGD::transition(state_type , for (int

[GitHub] madlib pull request #246: DT user doc updates

GitHub user fmcquillan99 opened a pull request: https://github.com/apache/madlib/pull/246 DT user doc updates @rahiyer please review DT user doc updates Will start working on RF in parallel. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] madlib pull request #244: Changes for Personalized Page Rank : Jira:1084

Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/244#discussion_r175663431 --- Diff: src/ports/postgres/modules/graph/pagerank.py_in --- @@ -149,25 +164,39 @@ def pagerank(schema_madlib, vertex_table, vertex_id, edge_table,

[GitHub] madlib pull request #244: Changes for Personalized Page Rank : Jira:1084

Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/244#discussion_r175664342 --- Diff: src/ports/postgres/modules/graph/test/pagerank.sql_in --- @@ -84,7 +89,8 @@ SELECT pagerank( NULL, NULL,

[GitHub] madlib pull request #244: Changes for Personalized Page Rank : Jira:1084

Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/244#discussion_r175627510 --- Diff: src/ports/postgres/modules/graph/pagerank.py_in --- @@ -527,14 +562,63 @@ def pagerank(schema_madlib, vertex_table, vertex_id, edge_table,

[GitHub] madlib pull request #244: Changes for Personalized Page Rank : Jira:1084

Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/244#discussion_r175665727 --- Diff: src/ports/postgres/modules/graph/pagerank.sql_in --- @@ -120,6 +121,10 @@ distribution per group. When this value is NULL, no grouping is used

[GitHub] madlib pull request #244: Changes for Personalized Page Rank : Jira:1084

Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/244#discussion_r175631615 --- Diff: src/ports/postgres/modules/graph/pagerank.sql_in --- @@ -273,6 +278,48 @@ SELECT * FROM pagerank_out_summary ORDER BY user_id; (2 rows)