Writing a surefire provider

2021-09-30 Thread Andy Piper
Hi Apologies for what I am sure is a dumb question - I am wanting to write a surefire provider that works in much the same way as the junit platform provider but augments the run with JVM instrumentation configured via args on the command line. The obviously requires that the tests are run

[GitHub] [maven-site] asfgit closed pull request #227: Add vogella as a provider of training

2021-02-21 Thread GitBox
asfgit closed pull request #227: URL: https://github.com/apache/maven-site/pull/227 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-site] jnerlich commented on pull request #227: Add vogella as a provider of training

2021-02-05 Thread GitBox
jnerlich commented on pull request #227: URL: https://github.com/apache/maven-site/pull/227#issuecomment-773154203 thanks @McFoggy for the feedback, this was a typo and has been corrected. This is an automated message from

[GitHub] [maven-site] jnerlich commented on a change in pull request #227: Add vogella as a provider of training

2021-02-05 Thread GitBox
jnerlich commented on a change in pull request #227: URL: https://github.com/apache/maven-site/pull/227#discussion_r570120132 ## File path: content/markdown/support-and-training.md ## @@ -57,6 +57,14 @@ When you walk away from this class, you will know how to: Public

[GitHub] [maven-site] jnerlich commented on a change in pull request #227: Add vogella as a provider of training

2021-02-04 Thread GitBox
jnerlich commented on a change in pull request #227: URL: https://github.com/apache/maven-site/pull/227#discussion_r570120132 ## File path: content/markdown/support-and-training.md ## @@ -57,6 +57,14 @@ When you walk away from this class, you will know how to: Public

[GitHub] [maven-site] jnerlich commented on pull request #227: Add vogella as a provider of training

2021-02-04 Thread GitBox
jnerlich commented on pull request #227: URL: https://github.com/apache/maven-site/pull/227#issuecomment-773154203 thanks @McFoggy for the feedback, this was a typo and has been corrected. This is an automated message from

[GitHub] [maven-site] McFoggy commented on pull request #227: Add vogella as a provider of training

2021-02-03 Thread GitBox
McFoggy commented on pull request #227: URL: https://github.com/apache/maven-site/pull/227#issuecomment-772796748 Following the link it is not clear where the one day training is: - the page in German (translated using google translate) might refer to that - but the translated page in

[GitHub] [maven-site] elharo commented on a change in pull request #227: Add vogella as a provider of training

2021-02-03 Thread GitBox
elharo commented on a change in pull request #227: URL: https://github.com/apache/maven-site/pull/227#discussion_r569445545 ## File path: content/markdown/support-and-training.md ## @@ -57,6 +57,14 @@ When you walk away from this class, you will know how to: Public virtual

[GitHub] [maven-site] jnerlich opened a new pull request #227: Add vogella as a provider of training

2021-02-03 Thread GitBox
jnerlich opened a new pull request #227: URL: https://github.com/apache/maven-site/pull/227 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[maven resolver provider] Trying to programatically build an effective model - can't find a public ModelResolver

2019-04-07 Thread Sahil Muthoo
Hello - I’m looking to programatically obtain an effective model from a POM file from outside a Maven container. Search on the interwebs have taken me to [Maven Resolver Provider](https://maven.apache.org/ref/3.6.0/maven-resolver-provider/). This appears to have [replaced Eclipse Aether](http

[GitHub] maven-surefire issue #161: SUREFIRE-1396: Provider class path is incorrect f...

2017-08-28 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/161 @jon-bell Thx for contributing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] maven-surefire pull request #161: SUREFIRE-1396: Provider class path is inco...

2017-08-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven-surefire/pull/161 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] maven-surefire issue #161: SUREFIRE-1396: Provider class path is incorrect f...

2017-08-28 Thread jon-bell
Github user jon-bell commented on the issue: https://github.com/apache/maven-surefire/pull/161 @Tibor17 I have rebased master on top of my branch, it is again up to date. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

Re: [GitHub] maven-surefire issue #161: SUREFIRE-1396: Provider class path is incorrect f...

2017-08-28 Thread Tibor Digana
Check your branch if it is up to date with master. On Mon, Aug 28, 2017 at 11:51 PM, Tibor17 wrote: > Github user Tibor17 commented on the issue: > > https://github.com/apache/maven-surefire/pull/161 > > @jon-bell > Ok, now your IT passed. I will run whole test

[GitHub] maven-surefire issue #161: SUREFIRE-1396: Provider class path is incorrect f...

2017-08-28 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/161 @jon-bell Ok, now your IT passed. I will run whole test set now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven-surefire issue #161: SUREFIRE-1396: Provider class path is incorrect f...

2017-08-23 Thread jon-bell
Github user jon-bell commented on the issue: https://github.com/apache/maven-surefire/pull/161 @Tibor17 Is there anything else I can do to help get this merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven-surefire issue #161: SUREFIRE-1396: Provider class path is incorrect f...

2017-08-09 Thread jon-bell
Github user jon-bell commented on the issue: https://github.com/apache/maven-surefire/pull/161 @Tibor17 Let me know if there is anything else I can do on this. Thanks Jonathan --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] maven-surefire issue #155: Revert junit-plattform provider code from 3.0-rc1...

2017-08-06 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/155 @Tibor17 I'll have a look at the state of the junit5 branch next week. Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] maven-surefire issue #161: SUREFIRE-1396: Provider class path is incorrect f...

2017-08-04 Thread jon-bell
into the `it-repo` as well. This seems to not be a problem for any test packages, but is for a provider (which gets the forked Maven classloader instead of the test classloader). Given that the only other provider in the repo for integration tests *does not* reference the parent pom, I assume

[GitHub] maven-surefire issue #161: SUREFIRE-1396: Provider class path is incorrect f...

2017-08-03 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/161 @jon-bell I will investigate this issue: `Could not find artifact org.apache.maven.surefire:it-parent:pom:1.0 in central (https://repo.maven.apache.org/maven2)` --- If your project

[GitHub] maven-surefire issue #155: Revert junit-plattform provider code from 3.0-rc1...

2017-08-03 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/155 @britter #155 and #154 are done. Pls let me know if I should continue with #153. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] maven-surefire pull request #154: Move junit5 provider code

2017-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven-surefire/pull/154 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] maven-surefire pull request #155: Revert junit-plattform provider code from ...

2017-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven-surefire/pull/155 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] maven-surefire issue #155: Revert junit-plattform provider code from 3.0-rc1...

2017-08-01 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/155 @Tibor17 I'd say this order: - #155: revert stuff from rc1 branch - #154: Add the stuff to junit5 branch #153 I have to rework, since we have to target it at junit5

[GitHub] maven-surefire issue #155: Revert junit-plattform provider code from 3.0-rc1...

2017-08-01 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/155 @britter In what order should this PR and https://github.com/apache/maven-surefire/pull/153 be pushed? Is https://github.com/apache/maven-surefire/pull/154 independent? --- If your

[GitHub] maven-surefire issue #161: SUREFIRE-1396: Provider class path is incorrect f...

2017-08-01 Thread jon-bell
Github user jon-bell commented on the issue: https://github.com/apache/maven-surefire/pull/161 Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] maven-surefire issue #161: SUREFIRE-1396: Provider class path is incorrect f...

2017-08-01 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/161 @jon-bell Please squash your commits into one single commit and override your branch. Name the final commit `[SUREFIRE-1396] Provider class path is incorrect for custom provider

[GitHub] maven-surefire pull request #161: SUREFIRE-1396: Provider class path is inco...

2017-07-31 Thread jon-bell
Github user jon-bell commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/161#discussion_r130497860 --- Diff: surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath-provider/pom.xml --- @@ -0,0 +1,61

[GitHub] maven-surefire pull request #161: SUREFIRE-1396: Provider class path is inco...

2017-07-31 Thread Tibor17
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/161#discussion_r130488490 --- Diff: surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath-provider/pom.xml --- @@ -0,0 +1,61

[GitHub] maven-surefire issue #161: SUREFIRE-1396: Provider class path is incorrect f...

2017-07-31 Thread jon-bell
Github user jon-bell commented on the issue: https://github.com/apache/maven-surefire/pull/161 Thanks - I made the fixes you suggested above, and confirmed that the build passed on `mvn clean install -P run-its` --- If your project is set up for it, you can reply to this email and

[GitHub] maven-surefire pull request #161: SUREFIRE-1396: Provider class path is inco...

2017-07-31 Thread Tibor17
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/161#discussion_r130447743 --- Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java --- @@ -2755,7 +2755,16 @@ public

[GitHub] maven-surefire pull request #161: SUREFIRE-1396: Provider class path is inco...

2017-07-31 Thread jon-bell
Github user jon-bell commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/161#discussion_r130447222 --- Diff: surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath-provider/pom.xml --- @@ -0,0 +1,61

[GitHub] maven-surefire pull request #161: SUREFIRE-1396: Provider class path is inco...

2017-07-31 Thread jon-bell
Github user jon-bell commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/161#discussion_r130446456 --- Diff: surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath-provider/pom.xml --- @@ -0,0 +1,61

[GitHub] maven-surefire pull request #161: SUREFIRE-1396: Provider class path is inco...

2017-07-31 Thread Tibor17
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/161#discussion_r130445462 --- Diff: surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath-provider/pom.xml --- @@ -0,0 +1,61

[GitHub] maven-surefire pull request #161: SUREFIRE-1396: Provider class path is inco...

2017-07-31 Thread Tibor17
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/161#discussion_r130445317 --- Diff: surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath-provider/pom.xml --- @@ -0,0 +1,61

[GitHub] maven-surefire pull request #161: SUREFIRE-1396: Provider class path is inco...

2017-07-31 Thread Tibor17
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/161#discussion_r130444914 --- Diff: surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath-provider/pom.xml --- @@ -0,0 +1,61

[GitHub] maven-surefire pull request #161: SUREFIRE-1396: Provider class path is inco...

2017-07-29 Thread jon-bell
GitHub user jon-bell opened a pull request: https://github.com/apache/maven-surefire/pull/161 SUREFIRE-1396: Provider class path is incorrect for custom provider in Failsafe Hi, When using a custom Surefire provider with Surefire (not Failsafe), the "provider clas

[GitHub] maven-surefire issue #155: Revert junit-plattform provider code from 3.0-rc1...

2017-07-29 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/155 @britter We have finished feature SUREFIRE 1302 and I am going get back to JUnit5. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

Maven Resolver Provider, Repo Provisioner and 3.5.1

2017-07-19 Thread Manfred Moser
Hi all, I moved my Maven Repository Provisioner to using Maven Resolver and 3.5.0 from Aether and 3.3.9 and have to say.. nice work on the migration. It essentially compiled after just changing a few dependencies! I did run into an issue in the Maven Resolver Provider where a missing setter

[GitHub] maven-surefire issue #154: Move junit5 provider code

2017-07-06 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/154 @Tibor17 awesome. Thank you for the feedback. Waiting for the merge to continue work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

Re: [GitHub] maven-surefire issue #154: Move junit5 provider code

2017-07-06 Thread Tibor Digana
Hi Benedikt, I did not forget your commits. I will merge them soon. We are struggling with native cmd and release. Every day I thought it's been the time to go out with release version. On Wed, Jul 5, 2017 at 2:08 PM, britter wrote: > Github user britter commented on the

[GitHub] maven-surefire issue #154: Move junit5 provider code

2017-07-05 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/154 @Tibor17 comments would be appreciated. We need this and #155 to continue work in this direction. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] maven-surefire issue #154: Move junit5 provider code

2017-06-15 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/154 @tibor17 got some time to review and merge this an #155? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] maven-surefire pull request #155: Revert junit-plattform provider code from ...

2017-06-12 Thread britter
GitHub user britter opened a pull request: https://github.com/apache/maven-surefire/pull/155 Revert junit-plattform provider code from 3.0-rc1 branch. This code will be moved to the junit5 branch. This commit reverts: - Commit 70c8843e935882b0a78916894cb9f042964f2717

[GitHub] maven-surefire pull request #154: Move junit5 provider code

2017-06-12 Thread britter
GitHub user britter opened a pull request: https://github.com/apache/maven-surefire/pull/154 Move junit5 provider code Move the junit5/junit-plattform provider code to the junit5 branch. I used `git cherry-pick 73e09a8b^..70c8843e` to do this. You can merge this pull request

Re: convert maven-resolver-provider to jsr330

2017-05-25 Thread Tamás Cservenák
nd plexus > > annotations used in maven-resolver-provider, leaving only jsr330. The > > change is small and I believe safe, does not change any user-observable > > behaviour during normal maven build and all ITs pass. > > > > [MNG-6233] https://issues.apache.org/jira

Re: convert maven-resolver-provider to jsr330

2017-05-24 Thread Jason Dillon
Yes please, thank you :-] —jason On May 24, 2017 at 2:38:24 PM, Igor Fedorenko (i...@ifedorenko.com) wrote: I'd like to ask for somebody to second my change described in [MNG-6233]. The change cleans up mixture of jsr330 and plexus annotations used in maven-resolver-provider, leaving only

Re: convert maven-resolver-provider to jsr330

2017-05-24 Thread Olivier Lamy
> > annotations used in maven-resolver-provider, leaving only jsr330. The > > change is small and I believe safe, does not change any user-observable > > behaviour during normal maven build and all ITs pass. > > > > [MNG-6233] https://issues.apache.org/jira

Re: convert maven-resolver-provider to jsr330

2017-05-24 Thread Manfred Moser
Lgtm +1 Igor Fedorenko wrote on 2017-05-24 14:38: > I'd like to ask for somebody to second my change described in > [MNG-6233]. The change cleans up mixture of jsr330 and plexus > annotations used in maven-resolver-provider, leaving only jsr330. The > change is small and I believ

convert maven-resolver-provider to jsr330

2017-05-24 Thread Igor Fedorenko
I'd like to ask for somebody to second my change described in [MNG-6233]. The change cleans up mixture of jsr330 and plexus annotations used in maven-resolver-provider, leaving only jsr330. The change is small and I believe safe, does not change any user-observable behaviour during normal maven

[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...

2017-04-11 Thread mgreau
Github user mgreau commented on the issue: https://github.com/apache/maven-surefire/pull/142 @britter Hi FYI I have create a PR (#146) to finalize the updates proposed by @marcphilipp At @exoplatform we are working on UI automation tests with Maven JUnit5 and Selenide, so

[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...

2017-02-17 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/142 @sbrannen It looks like we will rename 2.19.2 to 2.20.0, but this is not official yet. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...

2017-02-17 Thread sbrannen
Github user sbrannen commented on the issue: https://github.com/apache/maven-surefire/pull/142 Very happy to hear that the Surefire team has taken over the provider for the JUnit Platform!!! Thanks! 😄 --- If your project is set up for it, you can reply to this email

[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...

2017-02-17 Thread sbrannen
Github user sbrannen commented on the issue: https://github.com/apache/maven-surefire/pull/142 @marcphilipp, 2.19.2 will support "*Tests" by default as well: https://twitter.com/sam_brannen/status/766979129954570240 --- If your project is set up for it, you can reply to

[GitHub] maven-surefire pull request #142: SUREFIRE-1330: Import provider code donate...

2017-02-17 Thread sbrannen
Github user sbrannen commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/142#discussion_r101716366 --- Diff: surefire-providers/pom.xml --- @@ -41,6 +41,7 @@ surefire-junit3 surefire-junit4 surefire-junit47 +

[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...

2017-02-14 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/142 awesome! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...

2017-02-13 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/142 @britter @marcphilipp Done. We are preparing a new release version of Maven and Surefire was examined last days. We still investigate some issues. --- If your project is set up

[GitHub] maven-surefire pull request #142: SUREFIRE-1330: Import provider code donate...

2017-02-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven-surefire/pull/142 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...

2017-02-12 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/142 Thank you! I will continue then with the detection code in ABstractSurefireMojo. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...

2017-02-11 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/142 @britter Sure I will do it, no problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...

2017-02-11 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/142 @Tibor17 this PR is for 3.0-rc1 branch not for master. Can't we integrate it into 3.0-rc1 branch right away? --- If your project is set up for it, you can reply to this email and have your

[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...

2017-02-11 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/142 @britter LGTM We have to wait for release 2.19.2. After that I will squash previous changes into one and commit to master which will be 3.0 RC1. Meanwhile we can continue on

[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...

2017-02-10 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/142 Resolved comments by @marcphilipp WDYT @Tibor17? Looks good for merge? behavior of surefire is currently not changed since we don't have automatic look up code. Would like to

[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...

2017-02-06 Thread marcphilipp
Github user marcphilipp commented on the issue: https://github.com/apache/maven-surefire/pull/142 > It may be possible to the the tests running by explicitly declaring the already released provider by the JUnit team as described in their documentation. I gave that a

[GitHub] maven-surefire pull request #142: SUREFIRE-1330: Import provider code donate...

2017-02-06 Thread marcphilipp
Github user marcphilipp commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/142#discussion_r99669653 --- Diff: surefire-providers/pom.xml --- @@ -41,6 +41,7 @@ surefire-junit3 surefire-junit4 surefire-junit47 +

[GitHub] maven-surefire pull request #142: SUREFIRE-1330: Import provider code donate...

2017-02-06 Thread marcphilipp
Github user marcphilipp commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/142#discussion_r99669961 --- Diff: surefire-providers/surefire-junit5/src/main/resources/META-INF/services/org.apache.maven.surefire.providerapi.SurefireProvider --- @@

[GitHub] maven-surefire pull request #142: SUREFIRE-1330: Import provider code donate...

2017-02-06 Thread britter
GitHub user britter opened a pull request: https://github.com/apache/maven-surefire/pull/142 SUREFIRE-1330: Import provider code donated by JUnit team This PR adds the code donated in [SUREFIRE-1330](https://issues.apache.org/jira/browse/SUREFIRE-1330) by @marcphilipp. Here

[SUREFIRE] JUnit 5 surefire provider code donation

2017-02-05 Thread Benedikt Ritter
in IRC. We’ve agreed to target the 3.0 release with JUnit 5 support. So we won’t work on JUnit 5 support for the 2.x line. Furthermore we agreed that I ask the JUnit team to officially donate their provider code to the maven project so that we can start working on the integration. Next I talked

Re: [8/8] maven git commit: [MNG-6093] use monkey patched slf4j-simple provider with Maven color

2017-01-22 Thread Hervé BOUTEMY
thanks for the review: such reviews in branches are great to fix such little things without adding stupid dedicated commits I let some more time to others to review this MNG-3507 branch before merging to master (then we'll have color back: great!) Regards, Hervé Le samedi 21 janvier 2017,

Re: [8/8] maven git commit: [MNG-6093] use monkey patched slf4j-simple provider with Maven color

2017-01-21 Thread Christian Schulte
Just noticed there is + * @since 3.4.0 in org.slf4j.impl.MavenSimpleLogger. There will be no 3.4.0 ;-). Will grep for that in my changes now myself. Regards, -- Christian - To unsubscribe, e-mail:

Re: [Wagon] http-provider suite is longer by 3 minutes

2017-01-04 Thread Michael Osipov
Am 2017-01-05 um 01:01 schrieb Dan Tran: Hi, before the canceled wagon-1.11 the suite was about 6minutes, now it is 9 min on my virtualbox centos 7, jdk 7 Is it a concern? Can you actually tell which test exactly runs longer? I have added to two tests a sleep for 2000 ms to avoid race

[Wagon] http-provider suite is longer by 3 minutes

2017-01-04 Thread Dan Tran
Hi, before the canceled wagon-1.11 the suite was about 6minutes, now it is 9 min on my virtualbox centos 7, jdk 7 Is it a concern? Thanks -Dan PS the good thing the huge http test no longer timeout on my box

Re: maven-aether-provider renamed to maven-resolver-provider.

2016-12-12 Thread Michael Osipov
Am 2016-12-11 um 23:43 schrieb Christian Schulte: Do we want to deploy a 'maven-aether-provider' relocating to 'maven-resolver-provider'? Since we change the groupId already, why not? Michael - To unsubscribe, e-mail: dev

maven-aether-provider renamed to maven-resolver-provider.

2016-12-11 Thread Christian Schulte
Do we want to deploy a 'maven-aether-provider' relocating to 'maven-resolver-provider'? Regards, -- Christian - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

[SUREFIRE] Incorporating JUnit 5 surefire provider

2016-10-20 Thread Benedikt Ritter
Hello, as you might know, JUnit is EPL licensed. However there is currently an effort going on to relicense the surefire provider under ALv2 [1]. It looks like all contributors have accepted the relicensing, so we can incorporate the provider code soon. Would this be okay for the maven community

Re: [SUREFIRE] Surefire provider for JUnit 5?

2016-09-04 Thread Tibor Digana
> > > > > Tibor Digana <[hidden email] > > > > <http:///user/SendEmail.jtp?type=node=5879457=0>> schrieb am > > Mo., > > > > 29. Aug. 2016 um > > > > 12:56 Uhr: > > > > > > > > > Hi Benedikt, > > >

Re: [SUREFIRE] Surefire provider for JUnit 5?

2016-09-03 Thread Benedikt Ritter
; > > Hi Benedikt, > > > > > > > > I found out that JUNit 5 was release with ALPHA version in Maven > > > Central. > > > > I guess there is no need to rush in Surefire yet. > > > > The JUnit team should contribute in JUnit co

Re: [SUREFIRE] Surefire provider for JUnit 5?

2016-08-30 Thread Tibor Digana
Central. > > > I guess there is no need to rush in Surefire yet. > > > The JUnit team should contribute in JUnit code line in the artifact > > > project org.junit.surefire-junit5 and test that provider. AFter the it > > > is stable with non-alpha and non-beta version

Re: [SUREFIRE] Surefire provider for JUnit 5?

2016-08-30 Thread Tibor Digana
out that JUNit 5 was release with ALPHA version in Maven > Central. > > I guess there is no need to rush in Surefire yet. > > The JUnit team should contribute in JUnit code line in the artifact > > project org.junit.surefire-junit5 and test that provider. AFter the it > > is st

Re: [SUREFIRE] Surefire provider for JUnit 5?

2016-08-30 Thread Benedikt Ritter
te in JUnit code line in the artifact > project org.junit.surefire-junit5 and test that provider. AFter the it > is stable with non-alpha and non-beta version we can take over, but > the next question would be license of JUnit 5. > I think the team has enough to do with getting JU

Re: [SUREFIRE] Surefire provider for JUnit 5?

2016-08-29 Thread Tibor Digana
Hi Benedikt, I found out that JUNit 5 was release with ALPHA version in Maven Central. I guess there is no need to rush in Surefire yet. The JUnit team should contribute in JUnit code line in the artifact project org.junit.surefire-junit5 and test that provider. AFter the it is stable with non

Re: [SUREFIRE] Surefire provider for JUnit 5?

2016-08-29 Thread Benedikt Ritter
Hello Tibor, Tibor Digana <tibor.dig...@googlemail.com> schrieb am Sa., 27. Aug. 2016 um 22:48 Uhr: > The JUnit5 team create junit5-provider which might be nice to have a > look inside. I don't know if this provider has all features Surefire > provided through surefire-junit47-p

Re: [SUREFIRE] Surefire provider for JUnit 5?

2016-08-27 Thread Tibor Digana
The JUnit5 team create junit5-provider which might be nice to have a look inside. I don't know if this provider has all features Surefire provided through surefire-junit47-provider, I know for certain that junit5-provider converts JUnit 5 Executor to JUnit 4 Runners and that's the way to support

Re: [SUREFIRE] Surefire provider for JUnit 5?

2016-08-27 Thread Tibor Digana
hm, you know, I don't like new provider because it's a lot of work to support all the features we had in surefire-junit47. This may always go with bugs and finally more work for you, integration tests, ... On 8/27/16, Benedikt Ritter <brit...@apache.org> wrote: > Tibor Digana &

Re: [SUREFIRE] Surefire provider for JUnit 5?

2016-08-27 Thread Benedikt Ritter
Tibor Digana <tibor.dig...@googlemail.com> schrieb am Sa., 27. Aug. 2016 um 15:01 Uhr: > I won't ha ve much time for JUnit 5 provider because I am preparing > Version 2.19.2 to release and next release with blocker and critical > fix, then 3.0-RC1. > > Feel free to open p

Re: [SUREFIRE] Surefire provider for JUnit 5?

2016-08-27 Thread Tibor Digana
I won't ha ve much time for JUnit 5 provider because I am preparing Version 2.19.2 to release and next release with blocker and critical fix, then 3.0-RC1. Feel free to open pull request in GitHub for JUnit 5 provider. On 8/27/16, Kristian Rosenvold <kristian.rosenv...@gmail.com> wrote

Re: [SUREFIRE] Surefire provider for JUnit 5?

2016-08-27 Thread Kristian Rosenvold
Hi, Benedikt :) JUnit 5 provider is cool, yes please :) Providers have different language levels (the different modules have different language levels), and I am sure we can build with jdk8. jdk8 still supports the target 1.6, right ? Kristian 2016-08-27 11:23 GMT+02:00 Benedikt Ritter

[SUREFIRE] Surefire provider for JUnit 5?

2016-08-27 Thread Benedikt Ritter
and Marc gave me a kick start about the new architecture. The JUnit team already implemented a rudimentary surefire provider for JUnit 5 [4] and they eventually like to donate it to the maven project. This is where I come into play, since I know Marc know and I'm a member of the ASF and I though

[GitHub] maven-scm pull request #50: [SCM-832] maven-scm-provider-jgit should support...

2016-06-23 Thread mkutter
GitHub user mkutter opened a pull request: https://github.com/apache/maven-scm/pull/50 [SCM-832] maven-scm-provider-jgit should support SSH public key auth Support for public key auth for ssh transfer is added by implementing a TransportConfigCallback and adding it to the session

Re: maven git commit: [MNG-6038] use Gossip slf4j provider (with level color support)

2016-06-13 Thread Hervé BOUTEMY
tell and we can easily revert > >> > >> I am afraid that I have to downvote this for two reasons: > > the issues you're facing do not seem to be tied to Gossip slf4j provider > > bug MNG-3705 general ANSI color support: issues found, now we have to > > work to fix th

Re: maven git commit: [MNG-6038] use Gossip slf4j provider (with level color support)

2016-06-12 Thread Michael Osipov
facing do not seem to be tied to Gossip slf4j provider bug MNG-3705 general ANSI color support: issues found, now we have to work to fix them (eventually helping JAnsi, since I thought JAnsi was mature...) 1. JAnsi requires Microsoft Visual C++ 2008 SP1 Redistributable Package [1]. According

Re: maven git commit: [MNG-6038] use Gossip slf4j provider (with level color support)

2016-06-12 Thread Michael Osipov
facing do not seem to be tied to Gossip slf4j provider bug MNG-3705 general ANSI color support: issues found, now we have to work to fix them (eventually helping JAnsi, since I thought JAnsi was mature...) That is correct. Not Gossip, but JAnsi. 1. JAnsi requires Microsoft Visual C++ 2008 SP1

Re: maven git commit: [MNG-6038] use Gossip slf4j provider (with level color support)

2016-06-12 Thread Michael Osipov
: file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/guava-19.0.jar constituent[23]: file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/jansi-1.12.jar constituent[24]: file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/maven-aether-provider-3.4.0-SNAPSHOT.jar constituent[25]: file:/home/mosipov/

Re: maven git commit: [MNG-6038] use Gossip slf4j provider (with level color support)

2016-06-12 Thread Hervé BOUTEMY
tied to Gossip slf4j provider bug MNG-3705 general ANSI color support: issues found, now we have to work to fix them (eventually helping JAnsi, since I thought JAnsi was mature...) > > 1. JAnsi requires Microsoft Visual C++ 2008 SP1 Redistributable Package > [1]. According to Microsoft,

Re: maven git commit: [MNG-6038] use Gossip slf4j provider (with level color support)

2016-06-12 Thread Robert Scholte
/jansi-1.12.jar constituent[24]: file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/maven-aether-provider-3.4.0-SNAPSHOT.jar constituent[25]: file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/aether-api-1.0.2.v20150114.jar constituent[26]: file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/

Re: maven git commit: [MNG-6038] use Gossip slf4j provider (with level color support)

2016-06-12 Thread Michael Osipov
-provider-3.4.0-SNAPSHOT.jar constituent[25]: file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/aether-api-1.0.2.v20150114.jar constituent[26]: file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/aether-spi-1.0.2.v20150114.jar constituent[27]: file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/aether

Re: maven git commit: [MNG-6038] use Gossip slf4j provider (with level color support)

2016-06-12 Thread Michael Osipov
2016 11:26:10 hbout...@apache.org a écrit : Repository: maven Updated Branches: refs/heads/master 427f18c3a -> 644ac9c40 [MNG-6038] use Gossip slf4j provider (with level color support) Project: http://git-wip-us.apache.org/repos/asf/maven/repo Commit: http://git-wip-us.apache.org/repos/asf/maven

Re: maven git commit: [MNG-6038] use Gossip slf4j provider (with level color support)

2016-06-12 Thread Michael Osipov
Am 2016-06-12 um 10:38 schrieb Christian Schulte: Am 06/12/16 um 00:03 schrieb Michael Osipov: Am 2016-06-11 um 13:27 schrieb Hervé BOUTEMY: if someone has an objection, just tell and we can easily revert Hervé, thank you for the hard work. I not sure wether this is related to recent

Re: maven git commit: [MNG-6038] use Gossip slf4j provider (with level color support)

2016-06-12 Thread Hervé BOUTEMY
MNG-3507, implemented without anything done at logging provider level. This brings us to one new strategic dependency addition to Maven core: JAnsi, that we expect plugins to use when adding color details to their messages (for example MSITE-779, MINVOKER-205 or SUREFIRE-1254 to start, but I

Re: maven git commit: [MNG-6038] use Gossip slf4j provider (with level color support)

2016-06-12 Thread Christian Schulte
Am 06/12/16 um 00:03 schrieb Michael Osipov: > Am 2016-06-11 um 13:27 schrieb Hervé BOUTEMY: >> if someone has an objection, just tell and we can easily revert > > Hervé, > > thank you for the hard work. > > I not sure wether this is related to recent changes to master or Maven > Core ITs

  1   2   3   4   5   6   >