[GitHub] [maven-site] asfgit closed pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-02-05 Thread GitBox
asfgit closed pull request #225: URL: https://github.com/apache/maven-site/pull/225 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-site] asfgit closed pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-02-04 Thread GitBox
asfgit closed pull request #225: URL: https://github.com/apache/maven-site/pull/225 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-site] rfscholte commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-10 Thread GitBox
rfscholte commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r554558015 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test

[GitHub] [maven-site] pzygielo commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-09 Thread GitBox
pzygielo commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r554014876 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test

[GitHub] [maven-site] MartinKanters commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-09 Thread GitBox
MartinKanters commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r554007128 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test

[GitHub] [maven-site] michael-o commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-09 Thread GitBox
michael-o commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r553996067 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test

[GitHub] [maven-site] slawekjaranowski commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-09 Thread GitBox
slawekjaranowski commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r553961399 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -100,9 +100,11 @@ Introduction to Build Profiles profile

[GitHub] [maven-site] mthmulders commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-09 Thread GitBox
mthmulders commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r553965389 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -100,9 +100,11 @@ Introduction to Build Profiles profile IDs to

[GitHub] [maven-site] michael-o commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
michael-o commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r554064780 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test

[GitHub] [maven-site] MartinKanters commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
MartinKanters commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r554058099 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test

[GitHub] [maven-site] michael-o commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
michael-o commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r554041608 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test

[GitHub] [maven-site] mthmulders commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
mthmulders commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r554024978 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test

[GitHub] [maven-site] pzygielo commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
pzygielo commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r554014876 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test

[GitHub] [maven-site] MartinKanters commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
MartinKanters commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r554007128 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test

[GitHub] [maven-site] michael-o commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
michael-o commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r553996067 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test

[GitHub] [maven-site] mthmulders commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
mthmulders commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r553966399 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test

[GitHub] [maven-site] mthmulders commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
mthmulders commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r553965389 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -100,9 +100,11 @@ Introduction to Build Profiles profile IDs to

[GitHub] [maven-site] slawekjaranowski commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
slawekjaranowski commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r553964597 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal

[GitHub] [maven-site] slawekjaranowski commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
slawekjaranowski commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r553964597 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal

[GitHub] [maven-site] slawekjaranowski commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
slawekjaranowski commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r553961399 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -100,9 +100,11 @@ Introduction to Build Profiles profile

[GitHub] [maven-site] mthmulders opened a new pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

2021-01-08 Thread GitBox
mthmulders opened a new pull request #225: URL: https://github.com/apache/maven-site/pull/225 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: Profile Activation

2016-08-15 Thread Chas Honton
The behavior is AND. You can have multiple profiles for OR. Chas > On Aug 15, 2016, at 11:45 AM, Christopher <ctubb...@apache.org> wrote: > > If there could be "AND" and "OR" primitives for profile activation > c

Re: Profile Activation

2016-08-15 Thread Christopher
If there could be "AND" and "OR" primitives for profile activation conditions, you could do something like: !profilea profilea !true Sadly, this feature does not exist. On Fri, Aug

Re: Profile Activation

2016-08-12 Thread Robert Scholte
;true"." In this case, when invoking Maven with "mvn initialize", profilea isn't defined so I would expect the profile not to be activated. This is also what would happen if the value in the profile activation was commented out. To recap, this is the current result with Maven

Re: Profile Activation

2016-08-12 Thread Karl Heinz Marbaise
t activated 3. mvn initialize -Dprofilea=false: profile activated 4. mvn initialize -Dprofilea=true: profile not activated Guillaume Message du 12/08/16 18:34 De : "Robert Scholte" A : "Maven Developers List" Copie à : Objet : Re: Profile Activation Hi Karl Heinz, you shou

Re: Profile Activation

2016-08-12 Thread Karl Heinz Marbaise
On 12/08/16 18:34, Robert Scholte wrote: Maybe the documentation isn't clear enough. I have added the documentation about the property activation with "!" things a few days ago... Either my assumption was wrong or the the intention is wrong... Kind regards Karl Heinz

Re: Profile Activation

2016-08-12 Thread Robert Scholte
ed with a value which is not "true"." In this case, when invoking Maven with "mvn initialize", profilea isn't defined so I would expect the profile not to be activated. This is also what would happen if the value in the profile activation was commented out. To reca

Re: Profile Activation

2016-08-12 Thread Guillaume Boué
ot; is defined with a value which is not "true"."   In this case, when invoking Maven with "mvn initialize", profilea isn't defined so I would expect the profile not to be activated. This is also what would happen if the value in the profile activation was commente

Re: Profile Activation

2016-08-12 Thread Robert Scholte
Hi Karl Heinz, you should read the activation like this: always activate, *unless* profilea is true. So it says nothing about the availability of the property. Maybe the documentation isn't clear enough. Robert On Fri, 12 Aug 2016 17:45:21 +0200, Karl Heinz Marbaise

RE: Profile Activation

2016-08-12 Thread Martin Gainty
MG>quick comment > To: dev@maven.apache.org > From: khmarba...@gmx.de > Subject: Profile Activation > Date: Fri, 12 Aug 2016 17:45:21 +0200 > > Hi to all, > > I have the following profile: > > > >profile-not-value-true > >

Profile Activation

2016-08-12 Thread Karl Heinz Marbaise
Hi to all, I have the following profile: profile-not-value-true profilea !true com.soebes.maven.plugins echo-maven-plugin initialize

Fwd: About profile activation with JSR223

2015-09-07 Thread Ramón Rial
<rri...@gmail.com> Date: 2015-08-25 19:57 GMT+02:00 Subject: About profile activation with JSR223 To: dev@maven.apache.org Hello. *About JSR223 support for activating Profiles* I have a modified version of *PropertyProfileActivation.java* that allows activate a profile evalua

About profile activation with JSR223

2015-08-25 Thread Ramón Rial
activation. - Allow the evaluation of scripts in some of the JSR223 languages allowed. - Add to the context of the evaluation the *ProjectProperties*, the *UserProperties* and *SystemProperties*. *An example of this:* profile activation property name

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-20 Thread mikebrock
Github user mikebrock commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-46737130 I think that could be pretty cool. I see no reason why not. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-19 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-46546268 Another option would be to provide support for activations based on some language like: activation expressionOS IS 'Linux' AND ( PROPERTY 'Some Name' IS

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-19 Thread ChristianSchulte
Github user ChristianSchulte commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-46547866 Could be as simple as: ``` activation script engine-name= || extension= || mime-type=simple script evaluating to a boolean/script /activation

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-19 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-46555048 I think Christian's idea is better as the logic is contained to the specific activator. I'm not keen at all to add conditional logic to the POM model anywhere, or any type

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-19 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-46562788 @mikebrock Do you think MVEL would be suitable for a one expression evaluator for a Maven profile activator? Imagine putting a MavenProject/pom.xml in the MVEL context and

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-18 Thread FredipusRex
Github user FredipusRex commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-46523185 You do realize that the current OR condition is actually out in use right now in many POM files, right? This was previously the subject of a patch (MNG-3106) -

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-18 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-46524647 First of all - thanks for your email. I understand, that this will ruin current ORing technique, but at least it could be fixed with copying for a while.

Re: MNG-3106 implemented profile activation incorrectly

2014-06-12 Thread Hervé BOUTEMY
to have AND behaviour with multiple activators being AND'd. In it's current form profile activation makes it impossible to do often required. Unless anyone objects I'm going to process http://jira.codehaus.org/browse/MNG-4565 and make multiple activators be AND'd. It's just been implemented

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-12 Thread MysterionRise
Github user MysterionRise closed the pull request at: https://github.com/apache/maven/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-11 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-45731097 What's the link you used for reference? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-11 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-45731386 http://jira.codehaus.org/browse/MNG-4565 - take a look here. It have link for reference

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-11 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-45731568 Yes, that is the Sonatype book which is the de facto reference for Maven but not the official specification but probably as close to one as we have. The actual

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-11 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-45731774 Hm, probably you are correct. I've just have strong feeling, when somebody said 'Sonatype' - think about 'Maven' and vice-versa. Regarding PR, let me know,

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-11 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-45732464 Yes, that's not uncommon. The PR is fine, just waiting for any feedback on the Maven dev list. There is one IT I would disable going forward (which tests that the

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-11 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-45744828 Ok, I've written an integration test and I'll see what falls out on the Maven dev list today. --- If your project is set up for it, you can reply to this email and have

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-11 Thread mosabua
Github user mosabua commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-45811127 if we need to change something in the book - I can take care of that. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-11 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-45811451 This change will actually make it match the book. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-11 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-45820916 @Konstantin, I've applied your patch and pushed the integration test. Try it out and if it's good then close the pull request. --- If your project is set up for it, you

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-11 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-45825613 Let me check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-11 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-45826259 @jvanzyl Looks correct, please close this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-10 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-45643803 I'm sorry, I don't understand, why you close this PR? Does it bad? I miss something? --- If your project is set up for it, you can reply to this email and have your

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-10 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-45644286 Sorry, cut and paste error on my part when closing the other issues. Can you reopen the PR again and I'll process it this afternoon. --- If your project is set up for it,

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-10 Thread MysterionRise
GitHub user MysterionRise opened a pull request: https://github.com/apache/maven/pull/20 [MNG-4565] Multiple profile activation conditions does not work Add possibilty to use multiple activators and have AND between them You can merge this pull request into a Git repository

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-10 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-45673757 I'm looking for a way to make this work, but this breaks MNG-3106 where the current behaviour is to OR the activators. I agree there are cases where AND is preferable but

MNG-3106 implemented profile activation incorrectly

2014-06-10 Thread Jason van Zyl
to get OR behavior, at least it's possible to have AND behaviour with multiple activators being AND'd. In it's current form profile activation makes it impossible to do often required. Unless anyone objects I'm going to process http://jira.codehaus.org/browse/MNG-4565 and make multiple

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-10 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-45681556 I have argued on the Maven dev list to process your patch. The current implementation I believe to be incorrect. --- If your project is set up for it, you can reply to

Re: MNG-3106 implemented profile activation incorrectly

2014-06-10 Thread Paul Benedict
, at least it's possible to have AND behaviour with multiple activators being AND'd. In it's current form profile activation makes it impossible to do often required. Unless anyone objects I'm going to process http://jira.codehaus.org/browse/MNG-4565 and make multiple activators be AND'd. It's just

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-10 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-45704618 I've implement this patch, only cause it's 100% relates with official documentation. --- If your project is set up for it, you can reply to this email and have your

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-08 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-45431277 Just wonder, is there anything I could do? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-08 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-45442939 Tonight I'll try to process all the outstanding PRs. I'll let you know if I need anything. --- If your project is set up for it, you can reply to this email and have your

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-04 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-45134460 I've update pull request. I change my approach, so it will not now a platform dependable. But ITs are still failing at weird place. I'm 100% sure, that it's not my

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-04 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-45138360 Cool, I'll take a look at look at the specific IT failure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-02 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44831587 Good stuff. I will try it today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-01 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44797771 I created a simple shell script to help validate a pull request against the Maven integration tests. This script is not great, and running the Maven integration tests is

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-05-31 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44749028 Any updates on my pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: [GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-05-31 Thread Jason van Zyl
I applied your changes and your test fails. If you want to take look and validate I will take a look later in the weekend. --- T E S T S --- Running

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-05-31 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44751378 Could you tell me, what did you use? I've run tests on Linux: mvn -version Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da;

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-05-31 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44755377 I used Maven, master branch at revision 73d35ba9597cd867717310ae8813376888debb9b. I applied your patch to master, and ran the tests with Maven 3.2.1 on OSX. --- If your

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-05-31 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44755927 Awesome,this is the only platform, I couldn't test against.Could you specify your _mvn -version_ output? I will try to fix test. --- If your project is set up for

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-05-31 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44756291 Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 2014-02-14T12:37:52-05:00) Maven home: /Users/jvanzyl/m2 Java version: 1.7.0_21, vendor: Oracle

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-05-31 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44756590 Not understand your point about failing against master. I agree that platform activators is not good idea. So same with JDK activator, right? I'm only left

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-05-31 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44756676 I will take a look as soon as I can. Maybe making an activator specifically for helping us test this will be better. Thanks for being patient, we'll get this sorted and

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-05-31 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44756700 Maybe creating an activator specifically for testing this might be better. I will take a look as soon as I can. Likely tomorrow. Thanks for your patience, we'll get this

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-05-31 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44757042 I'm 100% don't wanna rush. I will think about special activator for testing purpose (It could be _AlwaysTrueActivator_). I will try to give it a try tomorrow.

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-05-27 Thread MysterionRise
GitHub user MysterionRise opened a pull request: https://github.com/apache/maven/pull/16 [MNG-4565] Multiple profile activation conditions does not work You can merge this pull request into a Git repository by running: $ git pull https://github.com/MysterionRise/maven MNG

Re: git commit: [MNG-5608] added a warning on ${project.basedir} use for profile activation

2014-03-24 Thread Robert Scholte
=HEAD1 Op Mon, 24 Mar 2014 00:20:06 +0100 schreef Hervé BOUTEMY herve.bout...@free.fr: I don't think so: DefaultModelValidator is the *effective model* validator It contains validations that happen when everything is done: it's too late for profile activation controls Regards, Hervé Le

Re: git commit: [MNG-5608] added a warning on ${project.basedir} use for profile activation

2014-03-24 Thread Hervé BOUTEMY
It contains validations that happen when everything is done: it's too late for profile activation controls Regards, Hervé Le dimanche 23 mars 2014 20:29:42 Robert Scholte a écrit : Hi Hervé, I think this should have been fixed

Re: git commit: [MNG-5608] added a warning on ${project.basedir} use for profile activation

2014-03-23 Thread Robert Scholte
context. regards, Robert Op Sun, 23 Mar 2014 19:58:28 +0100 schreef hbout...@apache.org: Repository: maven Updated Branches: refs/heads/master 3c7744a9a - 64c419506 [MNG-5608] added a warning on ${project.basedir} use for profile activation Project: http://git-wip-us.apache.org/repos/asf

Re: git commit: [MNG-5608] added a warning on ${project.basedir} use for profile activation

2014-03-23 Thread Hervé BOUTEMY
I don't think so: DefaultModelValidator is the *effective model* validator It contains validations that happen when everything is done: it's too late for profile activation controls Regards, Hervé Le dimanche 23 mars 2014 20:29:42 Robert Scholte a écrit : Hi Hervé, I think this should have

MNG-5127 - Maven profile activation does not work when profile is defined in inherited 'parent' pom

2012-07-27 Thread Tony Lâmpada
Hi folks, how is it going with this one? Is there anything planned? I have attached a test project to the issue - http://jira.codehaus.org/browse/MNG-5127 Hope it helps. Thanks Tony

Re: New Profile Activation Type Request - Maven Version

2011-02-11 Thread John Patrick
9, 2011 at 9:12 AM, John Patrick nhoj.patr...@gmail.com wrote: Hi, I believe this is the right mailing list, but please send me else where if not. I would like to request that a new profile activation type be added, which is based upon the maven version that is executing. What are people

New Profile Activation Type Request - Maven Version

2011-02-09 Thread John Patrick
Hi, I believe this is the right mailing list, but please send me else where if not. I would like to request that a new profile activation type be added, which is based upon the maven version that is executing. What are people version upon this change? Base Ground I've just done an upgrade

Re: New Profile Activation Type Request - Maven Version

2011-02-09 Thread Anders Hammar
Vote for this jira ticket: http://jira.codehaus.org/browse/MNG-4760 /Anders On Wed, Feb 9, 2011 at 15:12, John Patrick nhoj.patr...@gmail.com wrote: Hi, I believe this is the right mailing list, but please send me else where if not. I would like to request that a new profile activation

Re: New Profile Activation Type Request - Maven Version

2011-02-09 Thread Brian Fox
: Hi, I believe this is the right mailing list, but please send me else where if not. I would like to request that a new profile activation type be added, which is based upon the maven version that is executing. What are people version upon this change? Base Ground I've just done

Bug: profile activation not detected in a parent pom.xml

2010-09-17 Thread Xavier D.
I have discovered a bug in mvn 2.2.1 in relation to inheritance of profiles. It affects profile inheritance within MavenProject and the maven-help-plugin. 1. The help mojo issue: This appears to be a bug that has been re-introduced into mvn 2.2.1: http://jira.codehaus.org/browse/MPH-16 There

profile activation customization

2010-08-20 Thread Mateusz P
Hi I'd like to have more more control on how profiles are activated. I've registered my implementation of ProfileActivator as a plexus component with org.apache.maven.profiles.activation.ProfileActivator role. I've used extension to inject the component to the maven context. The issue is that the

basedir property expansion in file-profile-activation

2010-02-04 Thread Karel Vervaeke
Hi, I attached a patch to MNG-1775 today, and I would like to hear to what extent I can you folks to apply it, and/or what needs to be changed. My arguments pro my own patch: - I think it works, the test2.zip serves as a test case (build fails with maven-2.2.x, but succeeds after patch) -

Re: basedir property expansion in file-profile-activation

2010-02-04 Thread Benjamin Bentmann
Karel Vervaeke wrote: clicky: http://jira.codehaus.org/browse/MNG-1775 Looks like a duplicate of MNG-2363, i.e. the ${basedir} expression is already supposed to work in Maven 3. Benjamin - To unsubscribe, e-mail:

Re: Profile activation by missing file doesn't works

2008-10-01 Thread Dennis Lundberg
Felix Knecht wrote: Hi all The foofoo profile is always activated, no matter if a file 'timestamp' exists in the same directory like the pom.xml or not. It looks to me as the ${basedir} is not correctly resolved. Is this a known problem? http://jira.codehaus.org/browse/MNG-3524

Profile activation by missing file doesn't works

2008-09-26 Thread Felix Knecht
Hi all The foofoo profile is always activated, no matter if a file 'timestamp' exists in the same directory like the pom.xml or not. It looks to me as the ${basedir} is not correctly resolved. Is this a known problem? Thanks Felix [EMAIL PROTECTED] ~/tmp $ cat pom.xml project

Re: Profile activation by missing file doesn't works

2008-09-26 Thread nicolas de loof
Profile activation doesn't support property interopolation, even the ${basedir} one This makes this feature unusable in nested modules configuration, as the file are tested from current dir, not active project root... I already reported this issue in JIRA. Nicolas 2008/9/26 Felix Knecht [EMAIL

Re: Profile activation by missing file doesn't works

2008-09-26 Thread Felix Knecht
nicolas de loof schrieb: Profile activation doesn't support property interopolation, even the ${basedir} one This makes this feature unusable in nested modules configuration, as the file are tested from current dir, not active project root... I already reported this issue in JIRA. Thanks

Re: Profile activation by missing file doesn't works

2008-09-26 Thread John Casey
Is there a JIRA in for this? nicolas de loof wrote: Profile activation doesn't support property interopolation, even the ${basedir} one This makes this feature unusable in nested modules configuration, as the file are tested from current dir, not active project root... I already reported

Re: Profile activation/deactivation

2008-05-16 Thread Paul Gier
; [EMAIL PROTECTED] Subject: Re: Profile activation/deactivation No one can dispute the nice things that profiles let us accomplish in terms of toggling on functionalities... But I wonder much this will impact build reproducibilityespecially given the existence of profiles in the settings.xml file

Re: Profile activation/deactivation

2008-05-16 Thread Paul Gier
I added a proposal for some profile activation/deactivation improvements here: http://docs.codehaus.org/display/MAVENUSER/Improvements+to+Profile+Activation+Deactivation Please take a look and add comments if you are interested. Thanks! Paul Gier wrote: I would like to bring up a couple

RE: Profile activation/deactivation

2008-05-15 Thread Bernhard David
: Profile activation/deactivation I think the ! is probably better then D: E: E: jesse On Wed, May 14, 2008 at 4:51 PM, Paul Gier [EMAIL PROTECTED] wrote: Brian E. Fox wrote: snip Need to think about 1 2 some more but: 3. There was a suggestion to allow the use

  1   2   >