n: "Jason van Zyl"
> Aan: "Maven Developers List"
> Verzonden: 12-12-2021 13:54:16
> Onderwerp: Re: reviewing Maven Wrapper before releasing
>
> >Clearly no one here disagrees with the goal of having robust testing for
> >software that is made availab
hub.com/apache/maven-integration-testing/tree/master/core-it-suite/src/test/resources/mng-5937%20wrapper
>
> -- Origineel bericht --
> Van: "Jason van Zyl"
> Aan: "Maven Developers List"
> Verzonden: 12-12-2021 13:54:16
> Onderwerp: Re: reviewing Maven Wrap
>
> Yes, that is said, we have seen this with Maven 3.8.x recently, but we
> can't change people. Let's get over with and just push a release. Let it
> soak in and continue with bugfixes.
>
>
+1
Am 2021-12-12 um 19:05 schrieb Robert Scholte:
Jason,
my point is that i DID write integration tests as part of the donation
to better understand the code, improve the codebase and its reliability.
While writing them I did find several issues, some caused because the
scripts didn't get in
-- Origineel bericht --
Van: "Hervé BOUTEMY"
Aan: "Maven Developers List"
Verzonden: 10-12-2021 08:08:57
Onderwerp: Re: reviewing Maven Wrapper before releasing
>thank you to everybody who reviewed, discussed, contributed
>
>we now have 16
obert
>> -- Origineel bericht ------
>> Van: "Manfred Moser"
>> Aan: dev@maven.apache.org
>> Verzonden: 10-12-2021 20:58:33
>> Onderwerp: Re: reviewing Maven Wrapper before releasing
>>> I totally agree with finally just shipping this. We got thi
rt done to improve that codebase done afterwards.
> > Hence my response that reliability is gone that was added after donation.
> >
> > Robert
> >
> > -- Origineel bericht --
> > Van: "Manfred Moser"
> > Aan: dev@maven.apache.org
> > Ver
donation.
Robert
-- Origineel bericht --
Van: "Manfred Moser"
Aan: dev@maven.apache.org
Verzonden: 10-12-2021 20:58:33
Onderwerp: Re: reviewing Maven Wrapper before releasing
I totally agree with finally just shipping this. We got this all
donated about two years ago now and ther
>>> Le vendredi 10 décembre 2021, 10:40:41 CET Robert Scholte a écrit :
>>>> I need more time.
>>>>
>>>> e.g. it looks like type=source doesn't use the Java sourcefile to
>>>> download the wrapper.
>>>> now that the plugin and
that was added after
donation.
Robert
-- Origineel bericht --
Van: "Manfred Moser"
Aan: dev@maven.apache.org
Verzonden: 10-12-2021 20:58:33
Onderwerp: Re: reviewing Maven Wrapper before releasing
I totally agree with finally just shipping this. We got this all donated about
two yea
roject, the ITs
> are
> > > incomplete.
> > > They should call both the wrapper-goal and something like 'mvnw
> > > --version' to ensure it is working (this used to be done in
> > > maven-integration-testing)
> > >
> > > thanks,
> > > Robert
&g
te.
> > They should call both the wrapper-goal and something like 'mvnw
> > --version' to ensure it is working (this used to be done in
> > maven-integration-testing)
> >
> > thanks,
> > Robert
> >
> > -- Origineel bericht --
> > Van: &qu
ile to
> >> download the wrapper.
> >> now that the plugin and wrapper are combined in one project, the ITs are
> >> incomplete.
> >> They should call both the wrapper-goal and something like 'mvnw
> >> --version' to ensure it is working (this used to be do
this used to be done in
>> maven-integration-testing)
>>
>> thanks,
>> Robert
>>
>> -- Origineel bericht --
>> Van: "Hervé BOUTEMY"
>> Aan: "Maven Developers List"
>> Verzonden: 10-12-2021 08:08:57
>>
--
Van: "Hervé BOUTEMY"
Aan: "Maven Developers List"
Verzonden: 10-12-2021 13:13:41
Onderwerp: Re: reviewing Maven Wrapper before releasing
the current 3.1.0-SNAPSHOT works like 0.5.6 as donated: I confess I did not test, I just
did not change anything using the general approac
> -- Origineel bericht --
> Van: "Hervé BOUTEMY"
> Aan: "Maven Developers List"
> Verzonden: 10-12-2021 08:08:57
> Onderwerp: Re: reviewing Maven Wrapper before releasing
>
> >thank you to everybody who reviewed, discussed, contributed
>
ineel bericht --
> Van: "Hervé BOUTEMY"
> Aan: "Maven Developers List"
> Verzonden: 10-12-2021 08:08:57
> Onderwerp: Re: reviewing Maven Wrapper before releasing
>
> >thank you to everybody who reviewed, discussed, contributed
> >
> >we n
(this used to be done in
maven-integration-testing)
thanks,
Robert
-- Origineel bericht --
Van: "Hervé BOUTEMY"
Aan: "Maven Developers List"
Verzonden: 10-12-2021 08:08:57
Onderwerp: Re: reviewing Maven Wrapper before releasing
thank you to everybody who reviewed, di
thank you to everybody who reviewed, discussed, contributed
we now have 16 issues fixed, everything seems stable
if nobody objects, I'll start a release over the week-end
Regards,
Hervé
Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit :
> Hi,
>
> Maven Wrapper has been donated to
cept，others be
> zombies
> > >
> > > who
> > >
> > > > > do
> > > > >
> > > > > > not need to be maintained IMO. They can use original wrapper
> plugin
> > > > >
> > > > > any
t;
> > > > do
> > > >
> > > > > not need to be maintained IMO. They can use original wrapper plugin
> > > >
> > > > anyway.
> > > >
> > > > > If we do not force them when beginning，it is harder to add the
&g
gt; > >
> > > anyway.
> > >
> > > > If we do not force them when beginning，it is harder to add the
> > > > liminition
> > > > later.
> > > >
> > > > XenoAmess
> > > >
&
> > > If we do not force them when beginning，it is harder to add the
> > > liminition
> > > later.
> > >
> > > XenoAmess
> > > ____________
> > > From: Slawomir Jaranowski
> > > Sent: Thursday, December 9, 2021 3:11:42 AM
> >
> > From: Slawomir Jaranowski
> > Sent: Thursday, December 9, 2021 3:11:42 AM
> > To: Maven Developers List
> > Subject: Re: reviewing Maven Wrapper before releasing
> >
> > I created issues with the proposition of improvement:
> >
> > https://issue
Slawomir Jaranowski
> Sent: Thursday, December 9, 2021 3:11:42 AM
> To: Maven Developers List
> Subject: Re: reviewing Maven Wrapper before releasing
>
> I created issues with the proposition of improvement:
>
> https://issues.apache.org/jira/browse/MWRAPPER-31
> https:
.
XenoAmess
From: Slawomir Jaranowski
Sent: Thursday, December 9, 2021 3:11:42 AM
To: Maven Developers List
Subject: Re: reviewing Maven Wrapper before releasing
I created issues with the proposition of improvement:
https://issues.apache.org/jira/browse/MWRAPPER-31
s never used, no problem to remove it
> > >
> > > > IT's should confirm that.
> > > >
> > > > Robert
> > > >
> > > > -- Origineel bericht --
> > > > Van: "Jason van Zyl"
> > > > Aan: &quo
me who did not imagine the use
> > case
> >
> > if everybody is confident that it's never used, no problem to remove it
> >
> > > IT's should confirm that.
> > >
> > > Robert
> > >
> > > -- Origineel bericht --
> >
move it
>
> > IT's should confirm that.
> >
> > Robert
> >
> > -- Origineel bericht --
> > Van: "Jason van Zyl"
> > Aan: "Maven Developers List"
> > Verzonden: 7-12-2021 14:55:32
> > Onderwerp: Re: reviewing Maven Wrapper
; IT's should confirm that.
>
> Robert
>
> -- Origineel bericht --
> Van: "Jason van Zyl"
> Aan: "Maven Developers List"
> Verzonden: 7-12-2021 14:55:32
> Onderwerp: Re: reviewing Maven Wrapper before releasing
>
> >Everything buil
> > IT's should confirm that.
> >
> > Robert
> >
> > -- Origineel bericht --
> > Van: "Jason van Zyl"
> > Aan: "Maven Developers List"
> > Verzonden: 7-12-2021 14:55:32
> > Onderwerp: Re: reviewing Maven Wrapper before releasin
e: you can't pass System
> properties to Maven, only arguments. And they should be passed as is to
> mvn.
> IT's should confirm that.
>
> Robert
>
> -- Origineel bericht --
> Van: "Jason van Zyl"
> Aan: "Maven Developers List"
> Verzonde
confirm that.
Robert
-- Origineel bericht --
Van: "Jason van Zyl"
Aan: "Maven Developers List"
Verzonden: 7-12-2021 14:55:32
Onderwerp: Re: reviewing Maven Wrapper before releasing
Everything builds and it generates the wrapper for a project in a way will be
famili
Everything builds and it generates the wrapper for a project in a way will be
familiar to existing users. The switch for current users should, hopefully, be
painless and transparent.
Nice work Robert and Hervé. I put a notice on the GitHub page for the Takari
version about the impending
34 matches
Mail list logo
