On Wed, Feb 13, 2008 at 11:52 PM, Dan Fabulich <[EMAIL PROTECTED]> wrote:
> John Casey wrote:
>
> > I'm trying to document some of the design problems with sort of exotic
> plugin
> > use cases, things like aggregation and use of ${reactorProjects}, that
> we're
> > running into under the current
Hi there,
I've recently created and commented out a couple of issues, provided fixes
for some of them and would like anyone (if possible, of course) to check
whether any of these changes is acceptable and also if there is anything
else I could help with. I'll be glad to do so.
Here they are:
-
That's not really the point. The point is that these behaviors
require exceptional logic to the main build process inside Maven.
They're a deviation of the normal once-per-project mojo, which is
geared to operate on the current project.
If you wanted to draw attention to something that does
On 13/02/2008, at 11:32 PM, Mark Hobson wrote:
Hi there,
I've been chatting to Jason about making some headway with the maven
artifact improvements that have been on the cards for sometime now.
I've dug through much of the code on my travels implementing
dependency:tree, conflict resolution an
Hi,
I would like to put together an archetype release incorporating the
fixes I made for backwards compat. Are there any other critical
problems that should go in first?
Cheers,
Brett
--
Brett Porter
[EMAIL PROTECTED]
http://blogs.exist.com/bporter/
--
Without fixing:
http://jira.codehaus.org/browse/ARCHETYPE-133
The create-from-project option does not work, but that's the only
thing I can think of that makes it really suck. Create from project
also doesn't work on Windows.
On 14-Feb-08, at 9:51 AM, Brett Porter wrote:
Hi,
I would lik
I'm fixing archetype:generate now as it's the best feature in the new
version to let people grab things from lists.
On 14-Feb-08, at 11:20 AM, Jason van Zyl wrote:
ARCHETYPE-133 is fixed. I asked some Windows folks in IRC to test
the create from project on Windows.
I also notice now the ar
On 14-Feb-08, at 11:41 AM, Brett Porter wrote:
On 15/02/2008, at 6:31 AM, Jason van Zyl wrote:
I'm fixing archetype:generate now as it's the best feature in the
new version to let people grab things from lists.
Thanks. I see what you mean about it being broken now as I just get
an NPE.
On 15/02/2008, at 6:31 AM, Jason van Zyl wrote:
I'm fixing archetype:generate now as it's the best feature in the
new version to let people grab things from lists.
Thanks. I see what you mean about it being broken now as I just get an
NPE. I wasn't seeing this yesterday.
I hadn't seen Ra
ARCHETYPE-133 is fixed. I asked some Windows folks in IRC to test the
create from project on Windows.
I also notice now the archetype:generate which brings up the list
(which makes it easier for people) is now hosed. So that needs to be
fixed.
On 14-Feb-08, at 10:21 AM, Jason van Zyl wrot
On 15/02/2008, at 6:41 AM, Brett Porter wrote:
On 15/02/2008, at 6:31 AM, Jason van Zyl wrote:
I'm fixing archetype:generate now as it's the best feature in the
new version to let people grab things from lists.
Thanks. I see what you mean about it being broken now as I just get
an NPE.
Carlos,
Can you elaborate on the need for this?
I understand that since MavenProject is non-final and so are the get/
sets they can be overridden and so we should be using the get/set
internally. However, it would seem we don't need that funcationality
for every field - which particular one
Reading carefully the javadoc I see the mistakes i made in clone :( I
can fix that
The problem arised with a delegate pattern implementation, the
MavenProject instance is encapsulated [1], but the problem comes with
other classes using this constructor to make copies, which will ignore
any customi
I'm not sure why the archiver needs to use the delegate? Is it because
you lose track of the updates? IF that's all, then you could follow
the @todo in the class javadoc :)
If it truly needs it, clone is the right method - I'd definitely
recommend reading the section on clone in Effective J
On 14-Feb-08, at 4:57 PM, Carlos Sanchez wrote:
Reading carefully the javadoc I see the mistakes i made in clone :( I
can fix that
The problem arised with a delegate pattern implementation, the
MavenProject instance is encapsulated [1], but the problem comes with
other classes using this const
The archiver is making a copy of the MavenProject using newProject =
new MavenProject(project)
project is a subclass of MavenProject (EclipseMavenProject)
Instead the archiver should do project.clone() if any
Previous to my patch new MavenProject(project) fails with NPE as the
fields are accessed
It seems curious to me that the archiver needs to understand eclipse.
Isn't this a generic component? Perhaps you should be making
maven-eclipse-archiver or something.
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Carlos
Sanchez
Sent: Thursday, February
On 15/02/2008, at 12:41 PM, Carlos Sanchez wrote:
The archiver is making a copy of the MavenProject using newProject =
new MavenProject(project)
project is a subclass of MavenProject (EclipseMavenProject)
Instead the archiver should do project.clone() if any
I think I was asking the same thin
The archiver doesnt have to understand eclipse. But it can't create a
MavenProject object when the one passed is a subclass that may have
customized behavior
On Thu, Feb 14, 2008 at 5:42 PM, Brian E. Fox <[EMAIL PROTECTED]> wrote:
> It seems curious to me that the archiver needs to understand ecli
I dont know why it is there, but it is, line 314
https://svn.apache.org/viewvc/maven/shared/trunk/maven-archiver/src/main/java/org/apache/maven/archiver/MavenArchiver.java?annotate=627672
emmanuel comment is
we have to clone the project instance so we can write out the pom with
the deployment vers
Ok, well in that case you don't need clone, you just needed to flip
all the get/set's like you did and continue using the copy constructor.
On 15/02/2008, at 12:59 PM, Carlos Sanchez wrote:
I dont know why it is there, but it is, line 314
https://svn.apache.org/viewvc/maven/shared/trunk/maven
does this look better?
https://svn.apache.org/viewvc/maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/MavenProject.java?r1=627670&r2=627932&pathrev=627932&diff_format=h
On Thu, Feb 14, 2008 at 6:11 PM, Brett Porter <[EMAIL PROTECTED]> wrote:
> Ok, well in that case you d
Issue Subscription
Filter: Design & Best Practices (29 issues)
Subscriber: mavendevlist
Key Summary
MNG-2184Possible problem with @aggregator and forked lifecycles
http://jira.codehaus.org/browse/MNG-2184
MNG-3313NetBeans projects, more than ant project, more than fre
23 matches
Mail list logo
