Re: svn commit: r1783494 - /maven/shared/branches/maven-shared-utils-0.9.x/src/main/java/org/apache/maven/shared/utils/cli/StreamFeeder.java

2017-02-18 Thread Hervé BOUTEMY
notice: on PrintStream, autoflush does such flush only when newline is appended see https://docs.oracle.com/javase/7/docs/api/java/io/ PrintStream.html#PrintStream(java.io.OutputStream,%20boolean) Regards, Hervé Le samedi 18 février 2017, 13:45:14 CET Robert Scholte a écrit : > I've added a

Re: Fwd: How to name modules, automatic and otherwise

2017-02-18 Thread Hervé BOUTEMY
IMHO, this means that there is the vast majority of "normal" case then there is life, where exceptionnally everything is mixed: - publishing a temporary fork (for example to have some local patches) - really forking or moving then I'm not sure checking rules on what is inside an artifact while

Re: Fwd: How to name modules, automatic and otherwise

2017-02-18 Thread Christian Schulte
Am 02/18/17 um 12:25 schrieb Robert Scholte: > The idea from Hervé and Rémi is about having a publish rule in Central if > you want to publish a modular jar there which will prevent module name > collisions. > Because the groupId is already owned by a specific organisation, you could > use

[GitHub] maven-surefire pull request #144: Resource leaks.

2017-02-18 Thread ChristianSchulte
GitHub user ChristianSchulte opened a pull request: https://github.com/apache/maven-surefire/pull/144 Resource leaks. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ChristianSchulte/maven-surefire master Alternatively you can

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

2017-02-18 Thread Christian Schulte
Am 02/17/17 um 21:48 schrieb Michael Osipov: > Hi folks, > > Christian Schulte asked me a couple of days ago wether I am able to > build Surefire master with Maven master. It was constantly failing for > him on his OpenBSD machines. Since I have several real servers with > FreeBSD 10.3-STABLE

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

2017-02-18 Thread Tibor Digana
>>MNG-6169 + local revert of clean gives: Not sure about your change (MNG-6169 + local revert of clean), but I know that The Clean Plugin 3.0.0 caused folder target/surefire-reports to be suddenly deleted. No report files found. >> Yes but is this failing because of a regression in core or

Re: I think we are ready for 3.5.0-alpha-1

2017-02-18 Thread Christian Schulte
Am 02/18/17 um 11:41 schrieb Stephen Connolly: > We need help testing on Solaris 10/11 if anyone has access to such a system On a SPARC machine, if possible, please. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

Re: [ANN] feature freeze Maven core 3.5.0

2017-02-18 Thread Christian Schulte
Am 02/18/17 um 12:25 schrieb Stephen Connolly: > Bug fixes only. Let's shake down towards the release. +1 Currently trying to make Jenkins build almost all Maven codebases automatically daily with Maven master. Setup isn't finished yet, though.

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

2017-02-18 Thread Stephen Connolly
MNG-6169 + local revert of clean gives: Failed tests: shouldNotBeVerbose(org.apache.maven.surefire.its.CheckTestNgReportTestIT): log pattern does not match nTimes(..) testSkippedSurefireReportGeneration(org.apache.maven.surefire.its.jiras.Surefire772BothReportsIT): Expecting failsafe report

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

2017-02-18 Thread Stephen Connolly
Yes but is this failing because of a regression in core or surefire? On 18 February 2017 at 17:32, Tibor Digana wrote: > Hi Stephen, > > Both branches should be merged together. > SUREFIRE_SYSPROP_DUPLICATES > SUREFIRE_STDOUT_FLUSH > All tests should pass then. > Cheers

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

2017-02-18 Thread Tibor Digana
Hi Stephen, Both branches should be merged together. SUREFIRE_SYSPROP_DUPLICATES SUREFIRE_STDOUT_FLUSH All tests should pass then. Cheers Tibor On Sat, Feb 18, 2017 at 6:21 PM, Tibor Digana-2 [via Maven] < ml-node+s40175n5899136...@n5.nabble.com> wrote: > We had this problem and the branch

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

2017-02-18 Thread Tibor Digana
We had this problem and the branch SUREFIRE_SYSPROP_DUPLICATES should fix it. On Sat, Feb 18, 2017 at 6:12 PM, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > So Maven 3.5.0-SNAPSHOT just has one failure: > > > Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 14.835

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

2017-02-18 Thread Stephen Connolly
Same for 3.5.0-SNAPSHOT + MNG-6169 on OS-X Results : Failed tests: shouldNotBeVerbose(org.apache.maven.surefire.its.CheckTestNgReportTestIT): log pattern does not match nTimes(..) Tests run: 714, Failures: 1, Errors: 0, Skipped: 133 On 18 February 2017 at 17:12, Stephen Connolly <

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

2017-02-18 Thread Stephen Connolly
So Maven 3.5.0-SNAPSHOT just has one failure: Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 14.835 sec <<< FAILURE! shouldNotBeVerbose(org.apache.maven.surefire.its.CheckTestNgReportTestIT) Time elapsed: 0 sec <<< FAILURE! java.lang.AssertionError: log pattern does not match

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

2017-02-18 Thread Tibor Digana
I have downloaded Michaels log for Maven 3.3.9 & Surefire 2.19.2-SNAPSHOT http://home.apache.org/~michaelo/maven/surefire/maven-surefire-extended-patch-maven-3.3.9.tar.gz and 27 tests failed. On Sat, Feb 18, 2017 at 4:52 PM, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > So

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

2017-02-18 Thread Tibor Digana
>>That is certainly looking like a regression in Maven core But the principle of the bug on FreeBSD should fail the build with Maven 3.3.9 as well. This I do not understand why it is ok with 3.3.9. On Sat, Feb 18, 2017 at 4:55 PM, Tibor Digana wrote: > ok, let's try

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

2017-02-18 Thread Tibor Digana
ok, let's try with two surefire branches merged together. On Sat, Feb 18, 2017 at 4:52 PM, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > So results so far: surefire master branch builds with 3.3.9 but fails with > 3.5.0-SNAPSHOT when running on macOS Sierra with Oracle Java

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

2017-02-18 Thread Stephen Connolly
So results so far: surefire master branch builds with 3.3.9 but fails with 3.5.0-SNAPSHOT when running on macOS Sierra with Oracle Java 1.8.0_121 That is certainly looking like a regression in Maven core On 18 February 2017 at 10:55, Michael Osipov wrote: > For those who

Re: svn commit: r1783494 - /maven/shared/branches/maven-shared-utils-0.9.x/src/main/java/org/apache/maven/shared/utils/cli/StreamFeeder.java

2017-02-18 Thread Robert Scholte
I've added a unittest, just to be sure. Not sure about the price of flushing, but seems expensive to do it after every write of a single byte. Robert On Sat, 18 Feb 2017 08:41:54 +0100, wrote: Author: tibordigana Date: Sat Feb 18 07:41:54 2017 New Revision: 1783494

Re: [ANN] feature freeze Maven core 3.5.0

2017-02-18 Thread Karl Heinz Marbaise
Yes. On 18/02/17 12:37, Arnaud Héritier wrote: Yeah !! Le sam. 18 févr. 2017 à 12:25, Stephen Connolly < stephen.alan.conno...@gmail.com> a écrit : Bug fixes only. Let's shake down towards the release. - Stephen -- Sent from my phone

Re: I think we are ready for 3.5.0-alpha-1

2017-02-18 Thread Karl Heinz Marbaise
Hi, On 18/02/17 12:19, Hervé BOUTEMY wrote: the discussion is not about merging some code from a branch to master: it's about doing an alpha release from master Based on the current state of JIRA for 3.5.0 (all issues closed). I say let us start making a alpha-1 candidate... +1 from me for

Re: maven-surefire git commit: SUREFIRE_SYSPROP_DUPLICATES

2017-02-18 Thread Tibor Digana
yes, Jira will be created for these branches, no problem, but let's see what the future logs bring. On Sat, Feb 18, 2017 at 12:51 PM, Tibor Digana-2 [via Maven] < ml-node+s40175n5899063...@n5.nabble.com> wrote: > The build processes use to take from 45min to 2:21h. > > On Sat, Feb 18, 2017 at

Re: Fwd: How to name modules, automatic and otherwise

2017-02-18 Thread Hervé BOUTEMY
yes, that's it (eventually without even checking that rule automatically when publishing into central: just making an explicit convention to avoid stupid choice of module prefix that is different from groupId but another DNS entry one may own) Regards, Hervé Le samedi 18 février 2017,

Re: maven-surefire git commit: SUREFIRE_SYSPROP_DUPLICATES

2017-02-18 Thread Tibor Digana
The build processes use to take from 45min to 2:21h. On Sat, Feb 18, 2017 at 12:47 PM, Tibor Digana wrote: > I am waiting for Michael's "go on". > There are 58 TestNG ITs and this is not nice fix, however it is god but > the rootcause is that

Re: maven-surefire git commit: SUREFIRE_SYSPROP_DUPLICATES

2017-02-18 Thread Tibor Digana
I am waiting for Michael's "go on". There are 58 TestNG ITs and this is not nice fix, however it is god but the rootcause is that surefire-integration-tests POM has testng default version 5.7 and that is the roortcause of system prop duplicates. I need to find someone who will update 58 tests

Re: Fwd: How to name modules, automatic and otherwise

2017-02-18 Thread Robert Scholte
On Thu, 16 Feb 2017 19:11:33 +0100, Brian Fox wrote: I generally agree the concerns were mostly ignored. Specifically the dangers in not carefully approaching and setting best practices in the names, thereby willfully ignoring what happened with NPM. It doesn't take away

Re: [ANN] feature freeze Maven core 3.5.0

2017-02-18 Thread Arnaud Héritier
Yeah !! Le sam. 18 févr. 2017 à 12:25, Stephen Connolly < stephen.alan.conno...@gmail.com> a écrit : > Bug fixes only. Let's shake down towards the release. > > - Stephen > -- > Sent from my phone > -- - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com

Re: Fwd: How to name modules, automatic and otherwise

2017-02-18 Thread Robert Scholte
The idea from Hervé and Rémi is about having a publish rule in Central if you want to publish a modular jar there which will prevent module name collisions. Because the groupId is already owned by a specific organisation, you could use them as well as "namespace"/prefix of the modular name

[ANN] feature freeze Maven core 3.5.0

2017-02-18 Thread Stephen Connolly
Bug fixes only. Let's shake down towards the release. - Stephen -- Sent from my phone

Re: maven-surefire git commit: SUREFIRE_SYSPROP_DUPLICATES

2017-02-18 Thread Hervé BOUTEMY
IIUC, this one is a good enhancement to integrate, since it makes Surefire more reliable (not relying on the way multiple "-Dmyprop=" is handled) Then there should just be a Jira issue created, and this fix integrated to Surefire master without waiting, isn't it? Or do you fear that this

Re: I think we are ready for 3.5.0-alpha-1

2017-02-18 Thread Stephen Connolly
On Sat 18 Feb 2017 at 11:19, Hervé BOUTEMY wrote: > the discussion is not about merging some code from a branch to master: it's > about doing an alpha release from master > The current issue with surefire where forked tests will fail on at least FreeBSD - as long as it is

Re: I think we are ready for 3.5.0-alpha-1

2017-02-18 Thread Hervé BOUTEMY
the discussion is not about merging some code from a branch to master: it's about doing an alpha release from master then do you have concerns about doing an alpha release from master? or did I miss something? (which branch?) Regards, Hervé Le samedi 18 février 2017, 11:45:17 CET Robert

Re: I think we are ready for 3.5.0-alpha-1

2017-02-18 Thread Karl Heinz Marbaise
Hi Robert, On 17/02/17 17:24, Robert Scholte wrote: Hi Karl Heinz, looking at the commit[1] I see that the projectBuildList.contains will prevent the NPE, but it looks weird to me that the projectBuildList does not contain a mavenProject which was marked as finished so can be built. Why is it

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

2017-02-18 Thread Michael Osipov
For those who would like to reproduce the issues: 1. Build Maven distribution from 3.3.9, master, MNG-6169 and MNG-6169 with locally modified maven-core/src/main/resources/META-INF/plexus/components.xml maven-clean-plugin 2.6.1 => 3.0.0. You should have four distros now. 2. Clone Surefire 3.

Re: I think we are ready for 3.5.0-alpha-1

2017-02-18 Thread Robert Scholte
For me it is a -1 to merge. It is not a regression compared to 3.3.9, so that issue is not a blocker for me and can be part of a next release. Robert On Sat, 18 Feb 2017 09:29:51 +0100, Tibor Digana wrote: +1: changed previous Vote, I want to see colors in

Re: I think we are ready for 3.5.0-alpha-1

2017-02-18 Thread Stephen Connolly
After chatting on IRC I see this surefire issue on at least FreeBSD as a blocker for an alpha. We need help testing on Solaris 10/11 if anyone has access to such a system On Sat 18 Feb 2017 at 09:56, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > If I am cutting an alpha and it

Re: I think we are ready for 3.5.0-alpha-1

2017-02-18 Thread Stephen Connolly
If I am cutting an alpha and it contains known issues, we should list them as such on release notes. I'll see what that would look like some time this weekend and categorise as S1: Maven blows up always - no workaround S2: Maven blows up under certain circumstances - no workaround S3: A

Re: I think we are ready for 3.5.0-alpha-1

2017-02-18 Thread Tibor Digana
+1: changed previous Vote, I want to see colors in console, but Karl should explain to Robert's remark that the change was a workaround. If it is Multithreading Memory Model problem, we can find better fix together. But now the contains() method is part of logic and dev will try to see it