Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

Am 12/20/16 um 01:58 schrieb Christian Schulte: > 2. Collect dependency > - > CollectRequest.setRoot(Dependency): > The dependency passed to this method is some *direct* dependency you got > from somewhere. Management is considered to already be applied. This > will become the

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

Am 12/19/16 um 18:26 schrieb Stephen Connolly: > We need to clarify. > > There is stuff that is "wrong" but has become expected behaviour because we > never "fixed" it => we cannot "fix" now because it will break too many users > > There is stuff that is "wrong" because we broke it, some users

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

We need to clarify. There is stuff that is "wrong" but has become expected behaviour because we never "fixed" it => we cannot "fix" now because it will break too many users There is stuff that is "wrong" because we broke it, some users have legitimate bugs and other users have hacks around the

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

Am 12/18/16 um 13:36 schrieb Robert Scholte: > On Fri, 16 Dec 2016 21:23:14 +0100, Christian Schulte > wrote: > >> Am 12/16/16 um 20:30 schrieb Robert Scholte: >>> On Fri, 16 Dec 2016 17:25:16 +0100, Christian Schulte >>> wrote: >>> Am 12/16/16 um 15:21

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

On Fri, 16 Dec 2016 21:23:14 +0100, Christian Schulte wrote: Am 12/16/16 um 20:30 schrieb Robert Scholte: On Fri, 16 Dec 2016 17:25:16 +0100, Christian Schulte wrote: Am 12/16/16 um 15:21 schrieb Robert Scholte: but this cover the issue we are talking

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

Am 12/16/16 um 20:30 schrieb Robert Scholte: > On Fri, 16 Dec 2016 17:25:16 +0100, Christian Schulte > wrote: > >> Am 12/16/16 um 15:21 schrieb Robert Scholte: >>> >>> but this cover the issue we are talking about, because IIUC you are >>> saying >>> that IF both junit and

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

On Fri, 16 Dec 2016 17:25:16 +0100, Christian Schulte wrote: Am 12/16/16 um 15:21 schrieb Robert Scholte: but this cover the issue we are talking about, because IIUC you are saying that IF both junit and hamcrest get the test-scope AND hamcrest would have a dependency

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

Am 12/16/16 um 17:25 schrieb Christian Schulte: > Am 12/16/16 um 15:21 schrieb Robert Scholte: >> >> but this cover the issue we are talking about, because IIUC you are saying >> that IF both junit and hamcrest get the test-scope AND hamcrest would have >> a dependency THEN that dependency is

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

Am 12/16/16 um 15:21 schrieb Robert Scholte: > > but this cover the issue we are talking about, because IIUC you are saying > that IF both junit and hamcrest get the test-scope AND hamcrest would have > a dependency THEN that dependency is not added to the classpath. That is > still

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

On Thu, 15 Dec 2016 23:39:50 +0100, Christian Schulte wrote: Am 12/15/16 um 23:28 schrieb Christian Schulte: different thing. Think about the dependency management as a global override of everything. That's how the resolver works. That's my Maven does it that way since

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

Am 12/15/16 um 23:28 schrieb Christian Schulte: > different thing. Think about the dependency management as a global > override of everything. That's how the resolver works. That's my Maven does it that way since 2.0.something. Take a look at this pom:

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

Am 12/15/16 um 22:31 schrieb Robert Scholte: > On Thu, 15 Dec 2016 09:40:46 +0100, Christian Schulte > wrote: > >> Am 12/15/16 um 09:28 schrieb Robert Scholte: >>> I think I understand where the confusion is coming from. We must be >>> very clear about definitions. >>>

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

On Thu, 15 Dec 2016 09:40:46 +0100, Christian Schulte wrote: Am 12/15/16 um 09:28 schrieb Robert Scholte: I think I understand where the confusion is coming from. We must be very clear about definitions. Transitive means adding all indirect dependencies with the compile

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

Am 2016-12-15 um 00:39 schrieb Christian Schulte: Am 12/15/16 um 00:19 schrieb Christian Schulte: -ldm,--legacy-dependency-management Use Maven 2 dependency management behaviour. Can also be activated by using -Dmaven.legacyDependencyManagement=true. There are a bunch of issues in JIRA

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

Am 12/15/16 um 09:28 schrieb Robert Scholte: > I think I understand where the confusion is coming from. We must be very > clear about definitions. > Transitive means adding all indirect dependencies with the compile and > runtime dependencies. > So the transitive *scope* itself is not

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

+01:00) Aan: Maven Developers List <dev@maven.apache.org> Onderwerp: Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management. Am 12/15/16 um 01:15 schrieb Christian Schulte: > Am 12/14/16 um 23:29 schrieb Michael Osipov

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

Am 12/15/16 um 01:15 schrieb Christian Schulte: > Am 12/14/16 um 23:29 schrieb Michael Osipov: >> I just hit the same issue with the Maven Clean Plugin: >> plexus-container-default is missing on the classpath. >> >> I think that Christian does the right thing, either adjusting code to >>

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

Am 12/14/16 um 23:29 schrieb Michael Osipov: > I just hit the same issue with the Maven Clean Plugin: > plexus-container-default is missing on the classpath. > > I think that Christian does the right thing, either adjusting code to > documentation or the other way around. We just need to agree

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

Just an additional information. Maven core and the resolver are not behaving consistently in that area and also not in the "repository overriding" area. As you may have noticed, I am just heading for consistency. I am having a hard time figuring out why the core has not been updated to reflect

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

Am 12/15/16 um 00:19 schrieb Christian Schulte: > -ldm,--legacy-dependency-management > Use Maven 2 dependency management behaviour. Can also be activated by > using -Dmaven.legacyDependencyManagement=true. > > There are a bunch of issues in JIRA affecting dependency management. > That option

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

Am 12/14/16 um 22:57 schrieb Robert Scholte: > Digging into this case before the change: > > The 4 related modules ignoring the versions: > > org.apache.maven.wagon:wagon:pom > { > dependencyManagement { > dependencies { >

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

Am 2016-12-14 um 22:57 schrieb Robert Scholte: Digging into this case before the change: The 4 related modules ignoring the versions: org.apache.maven.wagon:wagon:pom { dependencyManagement { dependencies { org.apache.maven.wagon:wagon-provider-test:compile

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

Digging into this case before the change: The 4 related modules ignoring the versions: org.apache.maven.wagon:wagon:pom { dependencyManagement { dependencies { org.apache.maven.wagon:wagon-provider-test:compile

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

Am 2016-12-14 um 18:14 schrieb Christian Schulte: Am 12/14/16 um 17:57 schrieb Robert Scholte: Hi, I read the comment but I'm not sure I follow. The original setup is a widely used pattern: give dependencies which should always have the test-scope this scope in the dependencyManagement of the

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

Am 12/14/16 um 17:57 schrieb Robert Scholte: > Hi, > > I read the comment but I'm not sure I follow. The original setup is a > widely used pattern: give dependencies which should always have the > test-scope this scope in the dependencyManagement of the parent. > Considering the case below it

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

Hi, I read the comment but I'm not sure I follow. The original setup is a widely used pattern: give dependencies which should always have the test-scope this scope in the dependencyManagement of the parent. Considering the case below it must be possible to give easymock the test-scope (I