done
https://github.com/mkleint/maven-3/commit/2ca8e13135e34f5df7cde0a86e37b533de3be676
Milos
On Mon, Jul 2, 2012 at 12:19 AM, Olivier Lamy ol...@apache.org wrote:
2012/7/1 Milos Kleint mkle...@gmail.com:
On Sun, Jul 1, 2012 at 9:30 AM, Olivier Lamy ol...@apache.org wrote:
2012/6/29 Milos
sounds good (at least for me :-) ).
2012/7/3 Milos Kleint mkle...@gmail.com:
done
https://github.com/mkleint/maven-3/commit/2ca8e13135e34f5df7cde0a86e37b533de3be676
Milos
On Mon, Jul 2, 2012 at 12:19 AM, Olivier Lamy ol...@apache.org wrote:
2012/7/1 Milos Kleint mkle...@gmail.com:
On Sun,
Can I proceed in usual github way and request a pull? or I just create
a diff file and apply to the svn source base myself?
Milos
On Tue, Jul 3, 2012 at 5:00 PM, Olivier Lamy ol...@apache.org wrote:
sounds good (at least for me :-) ).
2012/7/3 Milos Kleint mkle...@gmail.com:
done
2012/7/3 Milos Kleint mkle...@gmail.com:
Can I proceed in usual github way and request a pull? or I just create
a diff file and apply to the svn source base myself?
As you prefer.
Perso I use: git svn dcommit.
Did you setup your local clone to use git svn ?
Milos
On Tue, Jul 3, 2012 at 5:00
2012/6/29 Milos Kleint mkle...@gmail.com:
I forgot to mention in previous reply that one important constraint is
that Every single addition needs to fill out the Version value. The
default maven processing makes no use of it and proceeds as before.
Only in the IDE's subclass we will use it to
On Sun, Jul 1, 2012 at 9:30 AM, Olivier Lamy ol...@apache.org wrote:
2012/6/29 Milos Kleint mkle...@gmail.com:
I forgot to mention in previous reply that one important constraint is
that Every single addition needs to fill out the Version value. The
default maven processing makes no use of it
2012/7/1 Milos Kleint mkle...@gmail.com:
On Sun, Jul 1, 2012 at 9:30 AM, Olivier Lamy ol...@apache.org wrote:
2012/6/29 Milos Kleint mkle...@gmail.com:
I forgot to mention in previous reply that one important constraint is
that Every single addition needs to fill out the Version value. The
hello,
I've prepared a patch for MavenModelBuilder and related code that
hopefully will improve the performance of NetBeans
integration/embedding. The basic idea is to have all validation
problems collected but only fail to build the Mavenproject instance
when serious base problems are found
Hi,
The main issue I see is non backward comp for tools implementing their
own ModelProblemCollector.
I don't have issue to change signature but for future enhancement if
needed here, I would prefer to see something more easy to change and
don't break again backward comp in the future.
So instead
Is ModelProblemCollector intended for use outside of maven codebase?
MavenModelBuilder is hardcoding reference on DefaultMPC and there's a
few other implementations in tests or compat module only..
Milos
On Fri, Jun 29, 2012 at 11:49 AM, Olivier Lamy ol...@apache.org wrote:
Hi,
The main issue
Agree it's hard to inject that. So that reduce possible backward comp issues.
BTW what about using this bean/data structure rather than adding new
parameters ?
2012/6/29 Milos Kleint mkle...@gmail.com:
Is ModelProblemCollector intended for use outside of maven codebase?
MavenModelBuilder is
I forgot to mention in previous reply that one important constraint is
that Every single addition needs to fill out the Version value. The
default maven processing makes no use of it and proceeds as before.
Only in the IDE's subclass we will use it to throw exception or not.
If a request or
I have fixed http://jira.codehaus.org/browse/MSUREFIRE-113 but don't
have commit privileges. This is a major regression versus 2.1.3 and for
those of us who run Junit tests via suites a blocker.
-
To unsubscribe, e-mail: [EMAIL
It looks fine, but incomplete. I'd forgotten about this better base
class, and also referenced TestCase in the TestNG provider. If you can
update that as well, then it should be fine.
I've given you commit rights on surefire.
Cheers,
Brett
Mike Perham wrote:
I have fixed
: surefire patch needs review
It looks fine, but incomplete. I'd forgotten about this better base
class, and also referenced TestCase in the TestNG provider. If you can
update that as well, then it should be fine.
I've given you commit rights on surefire.
Cheers,
Brett
Mike Perham wrote:
I have fixed
( clazz ) )
{
...
}
-Original Message-
From: Brett Porter [mailto:[EMAIL PROTECTED]
Sent: Wednesday, May 17, 2006 12:32 PM
To: Maven Developers List
Subject: Re: surefire patch needs review
It looks fine, but incomplete. I'd forgotten about this better base
class, and also referenced
Developers List
Subject: Re: surefire patch needs review
It looks fine, but incomplete. I'd forgotten about this better base
class, and also referenced TestCase in the TestNG provider. If you can
update that as well, then it should be fine.
I've given you commit rights on surefire.
Cheers,
Brett
-
From: Jesse Kuhnert [mailto:[EMAIL PROTECTED]
Sent: Wednesday, May 17, 2006 1:21 PM
To: Maven Developers List
Subject: Re: surefire patch needs review
To be fair, there was definitely more than a ~little~ bit of pressure
being put on Brett at the time...This might have been something I had in
one
, 2006 1:21 PM
To: Maven Developers List
Subject: Re: surefire patch needs review
To be fair, there was definitely more than a ~little~ bit of pressure
being put on Brett at the time...This might have been something I had in
one of the original patches submitted as well
I don't think extending
Mike Perham wrote:
Sorry, I wasn't trying to denigrate anyone, esp Brett. I think we've
all written dodgy code in our day. I just got a chuckle out of the
particular word choice.
Certainly no offence taken. I fully admit to its dodginess (it was an
improvement over not working at all,
Jesse Kuhnert wrote:
P.S. Not using TestNGClassFinder.isTestNGClass is the exact reason
(probably?..) why someone's base class with no test methods and only
@Configuration methods might not be found.
Unlikely, as it is going to assume it's a TestNG class as long as it
doesn't extend TestCase,
Hmmm...I'm not remembering so well these days either. (I'm also a bit
disconnected from what the current surefire code looks like)
When I double checked the isTestNGClass logic though it confirmed that the
basic function is for it to look for ~any~ annotations on the class in
question. (whether
Mike Perham wrote:
Brett, I'm still getting a 403 Forbidden when I try to check in. Is
there a cron job I need to wait for?
There shouldn't be a delay. Have you got it checked out as https?
- Brett
-
To unsubscribe,
Well, there's a delay cause now it works. :-) Thanks.
-Original Message-
From: Brett Porter [mailto:[EMAIL PROTECTED]
Sent: Wednesday, May 17, 2006 2:28 PM
To: Maven Developers List
Subject: Re: surefire patch needs review
Mike Perham wrote:
Brett, I'm still getting a 403 Forbidden
24 matches
Mail list logo
