Re: reviewing Maven Wrapper before releasing
ITs updated to run mvnw MWRAPPER-22 proven to require to reapply the fix: done (surprising that nobody found that bug in Wrapper 0.5.6 and previous for more than 2 years...) release ready to be done: I'll launch it tonight Regards, Hervé Le dimanche 12 décembre 2021, 19:05:33 CET Robert Scholte a écrit : > Jason, > > my point is that i DID write integration tests as part of the donation > to better understand the code, improve the codebase and its reliability. > While writing them I did find several issues, some caused because the > scripts didn't get in sync with the Maven core scripts. > So it is possible to automate these tests, they are there, somebody just > has to ported them to the new project. > Also with the change of strategy how the wrapper should work we need > integration-tests to confirm it all works. > We shouldn't gamble, as almost every release people will only test is > _after_ its vote, which is just too late. > > Robert > > [1] > https://github.com/apache/maven-integration-testing/tree/master/core-it-suit > e/src/test/resources/mng-5937%20wrapper > > -- Origineel bericht -- > Van: "Jason van Zyl" > Aan: "Maven Developers List" > Verzonden: 12-12-2021 13:54:16 > Onderwerp: Re: reviewing Maven Wrapper before releasing > > >Clearly no one here disagrees with the goal of having robust testing for > >software that is made available to users. > > > >As to the timing of that testing being complete for the wrapper, to the > >satisfaction of those objecting to a release, I will argue. > > > >Do we wait four years for adequate testing? I’m not being facetious because > >we’re rolling up on three years since the initial donation of the wrapper > >was made. No one can force anyone else to do work here, sometimes things > >take a while, and there still may be a great deal of time that passes > >before testing is present that is considered adequate. > > > >All else being equal, I think the value of a release to remove the state of > >limbo the wrapper has been in for years outweighs the current lack of > >testing. The wrapper has been in use for 8 years, and while more testing > >is preferred we have reasonable assurances it works as expected. I don’t > >think we’ll be back to zero if we find issues, they can be fixed and will > >be accompanied by tests as most things here are. Right now from a user’s > >perspective the wrapper appears dead at Takari and Apache which is a > >shame. > > > >Would everyone be amenable to an alpha release? And transition to a > >non-alpha release when everyone agrees the testing is sufficient? > > > >jvz > > > >> On Dec 12, 2021, at 5:14 AM, Maarten Mulders > >> wrote: > >> > >> Chiming in a little late, but here are my 2 cents nevertheless. I would > >> not feel confident releasing something that we cannot test in an > >> automated way. Not having an integration test suite means we don't know > >> for sure if it works. And if we know it works and we change something, > >> we're back to zero. > >> > >> To me, this has nothing to do with a (misplaced) drive for perfection. > >> It is all about making sure we ship something to users that we know to > >> work, and that we can easily prove to still work after we change it. > >> > >> Thanks, > >> > >> Maarten > >> > >> On 11/12/2021 13:43, Robert Scholte wrote: > >>> It was marked for Maven 4, and part of the improvements was test > >>> automation, which was now possible because it became part of Maven > >>> Core. Even thought the code still exists in Maven Core, is has now > >>> become useless. There hasn't been a real need for new releases of > >>> Maven Wrapper Plugin until a range of Maven 3.8 started. Maven Wrapper > >>> would have been another feature to attract developers to Maven 4. And > >>> finally, I see that the donated code has been used as base, ignoring > >>> all the effort done to improve that codebase done afterwards. Hence my > >>> response that reliability is gone that was added after donation. > >>> Robert > >>> -- Origineel bericht -- > >>> Van: "Manfred Moser" > >>> Aan: dev@maven.apache.org > >>> Verzonden: 10-12-2021 20:58:33 > >>> Onderwerp: Re: reviewing Maven Wrapper before releasing > >>> > >>>> I totally agree with finally just shipping this. We got this all > >>>> donated about two years
Re: reviewing Maven Wrapper before releasing
Robert, I’m actually not sure what you are implying. Are you saying that you’re going to block the release until someone ports your tests over? Or you’re going to block the release of the separate wrapper? I don’t think anyone disagrees that the tests can be fully automated.I don’t think it’s absolutely necessary for the first release from Apache. We do the best we can, when we can. As for users only trying releases, does this surprise anyone? I don’t think so. It’s something to embrace. If we find a bunch of things wrong with the release we’ll fix them, add tests, and release again. The wrapper is now separate so this is not hard. Overall the Maven project does an excellent job with testing but in this case it’s become a theoretical exercise devoid of user feedback which is essential to improving any piece of software. Add your tests back when you can, others might get their first or add different tests. We’ll get there. Let’s just get it into the hands of users. jvz > On Dec 12, 2021, at 1:05 PM, Robert Scholte wrote: > > Jason, > > my point is that i DID write integration tests as part of the donation to > better understand the code, improve the codebase and its reliability. > While writing them I did find several issues, some caused because the scripts > didn't get in sync with the Maven core scripts. > So it is possible to automate these tests, they are there, somebody just has > to ported them to the new project. > Also with the change of strategy how the wrapper should work we need > integration-tests to confirm it all works. > We shouldn't gamble, as almost every release people will only test is _after_ > its vote, which is just too late. > > Robert > > [1] > https://github.com/apache/maven-integration-testing/tree/master/core-it-suite/src/test/resources/mng-5937%20wrapper > > -- Origineel bericht -- > Van: "Jason van Zyl" > Aan: "Maven Developers List" > Verzonden: 12-12-2021 13:54:16 > Onderwerp: Re: reviewing Maven Wrapper before releasing > >> Clearly no one here disagrees with the goal of having robust testing for >> software that is made available to users. >> >> As to the timing of that testing being complete for the wrapper, to the >> satisfaction of those objecting to a release, I will argue. >> >> Do we wait four years for adequate testing? I’m not being facetious because >> we’re rolling up on three years since the initial donation of the wrapper >> was made. No one can force anyone else to do work here, sometimes things >> take a while, and there still may be a great deal of time that passes before >> testing is present that is considered adequate. >> >> All else being equal, I think the value of a release to remove the state of >> limbo the wrapper has been in for years outweighs the current lack of >> testing. The wrapper has been in use for 8 years, and while more testing is >> preferred we have reasonable assurances it works as expected. I don’t think >> we’ll be back to zero if we find issues, they can be fixed and will be >> accompanied by tests as most things here are. Right now from a user’s >> perspective the wrapper appears dead at Takari and Apache which is a shame. >> >> Would everyone be amenable to an alpha release? And transition to a >> non-alpha release when everyone agrees the testing is sufficient? >> >> jvz >> >>> On Dec 12, 2021, at 5:14 AM, Maarten Mulders wrote: >>> >>> Chiming in a little late, but here are my 2 cents nevertheless. I would not >>> feel confident releasing something that we cannot test in an automated way. >>> Not having an integration test suite means we don't know for sure if it >>> works. And if we know it works and we change something, we're back to zero. >>> >>> To me, this has nothing to do with a (misplaced) drive for perfection. It >>> is all about making sure we ship something to users that we know to work, >>> and that we can easily prove to still work after we change it. >>> >>> Thanks, >>> >>> Maarten >>> >>> On 11/12/2021 13:43, Robert Scholte wrote: >>>> It was marked for Maven 4, and part of the improvements was test >>>> automation, which was now possible because it became part of Maven Core. >>>> Even thought the code still exists in Maven Core, is has now become >>>> useless. >>>> There hasn't been a real need for new releases of Maven Wrapper Plugin >>>> until a range of Maven 3.8 started. >>>> Maven Wrapper would have been another feature to attract developers to >>>> Maven 4
Re: reviewing Maven Wrapper before releasing
> > Yes, that is said, we have seen this with Maven 3.8.x recently, but we > can't change people. Let's get over with and just push a release. Let it > soak in and continue with bugfixes. > > +1
Re: reviewing Maven Wrapper before releasing
Am 2021-12-12 um 19:05 schrieb Robert Scholte: Jason, my point is that i DID write integration tests as part of the donation to better understand the code, improve the codebase and its reliability. While writing them I did find several issues, some caused because the scripts didn't get in sync with the Maven core scripts. So it is possible to automate these tests, they are there, somebody just has to ported them to the new project. Also with the change of strategy how the wrapper should work we need integration-tests to confirm it all works. We shouldn't gamble, as almost every release people will only test is _after_ its vote, which is just too late. Yes, that is said, we have seen this with Maven 3.8.x recently, but we can't change people. Let's get over with and just push a release. Let it soak in and continue with bugfixes. M - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
Jason, my point is that i DID write integration tests as part of the donation to better understand the code, improve the codebase and its reliability. While writing them I did find several issues, some caused because the scripts didn't get in sync with the Maven core scripts. So it is possible to automate these tests, they are there, somebody just has to ported them to the new project. Also with the change of strategy how the wrapper should work we need integration-tests to confirm it all works. We shouldn't gamble, as almost every release people will only test is _after_ its vote, which is just too late. Robert [1] https://github.com/apache/maven-integration-testing/tree/master/core-it-suite/src/test/resources/mng-5937%20wrapper -- Origineel bericht -- Van: "Jason van Zyl" Aan: "Maven Developers List" Verzonden: 12-12-2021 13:54:16 Onderwerp: Re: reviewing Maven Wrapper before releasing Clearly no one here disagrees with the goal of having robust testing for software that is made available to users. As to the timing of that testing being complete for the wrapper, to the satisfaction of those objecting to a release, I will argue. Do we wait four years for adequate testing? I’m not being facetious because we’re rolling up on three years since the initial donation of the wrapper was made. No one can force anyone else to do work here, sometimes things take a while, and there still may be a great deal of time that passes before testing is present that is considered adequate. All else being equal, I think the value of a release to remove the state of limbo the wrapper has been in for years outweighs the current lack of testing. The wrapper has been in use for 8 years, and while more testing is preferred we have reasonable assurances it works as expected. I don’t think we’ll be back to zero if we find issues, they can be fixed and will be accompanied by tests as most things here are. Right now from a user’s perspective the wrapper appears dead at Takari and Apache which is a shame. Would everyone be amenable to an alpha release? And transition to a non-alpha release when everyone agrees the testing is sufficient? jvz On Dec 12, 2021, at 5:14 AM, Maarten Mulders wrote: Chiming in a little late, but here are my 2 cents nevertheless. I would not feel confident releasing something that we cannot test in an automated way. Not having an integration test suite means we don't know for sure if it works. And if we know it works and we change something, we're back to zero. To me, this has nothing to do with a (misplaced) drive for perfection. It is all about making sure we ship something to users that we know to work, and that we can easily prove to still work after we change it. Thanks, Maarten On 11/12/2021 13:43, Robert Scholte wrote: It was marked for Maven 4, and part of the improvements was test automation, which was now possible because it became part of Maven Core. Even thought the code still exists in Maven Core, is has now become useless. There hasn't been a real need for new releases of Maven Wrapper Plugin until a range of Maven 3.8 started. Maven Wrapper would have been another feature to attract developers to Maven 4. And finally, I see that the donated code has been used as base, ignoring all the effort done to improve that codebase done afterwards. Hence my response that reliability is gone that was added after donation. Robert -- Origineel bericht -- Van: "Manfred Moser" Aan: dev@maven.apache.org Verzonden: 10-12-2021 20:58:33 Onderwerp: Re: reviewing Maven Wrapper before releasing I totally agree with finally just shipping this. We got this all donated about two years ago now and there is still nothing shipping. I used to just manually do the testing and thousands of projects are happy. I assume the new project is at least manually testing and works as before or better. Let's not wait nay more and let perfection get into our way. It surely is good enough for a release. The beauty is that if you find an issue.. you just ship again ... no reason to wait. manfred Hervé BOUTEMY wrote on 2021-12-10 04:13 (GMT -08:00): the current 3.1.0-SNAPSHOT works like 0.5.6 as donated: I confess I did not test, I just did not change anything using the general approach "people were happy before, just continue step by step improvements" :) reading the mvnw script (*nix), compiling+running the .java is executed only if neither wget nor curl are available on your machine reading the mvnw.cmd, it seems .java is not supported looking at Git history confirms: https://github.com/apache/maven-wrapper/commit/570bc50afe07bff696a097cd7746d01b00e70337 Don't hesitate to create a Jira issue and corresponding fix to add .java support for Windows: future 3.1.0 will have one more fix over previous 0.5.6 Regards, Hervé Le vendredi 10 décembre 2021, 10:40:41 CET Robe
Re: reviewing Maven Wrapper before releasing
Clearly no one here disagrees with the goal of having robust testing for software that is made available to users. As to the timing of that testing being complete for the wrapper, to the satisfaction of those objecting to a release, I will argue. Do we wait four years for adequate testing? I’m not being facetious because we’re rolling up on three years since the initial donation of the wrapper was made. No one can force anyone else to do work here, sometimes things take a while, and there still may be a great deal of time that passes before testing is present that is considered adequate. All else being equal, I think the value of a release to remove the state of limbo the wrapper has been in for years outweighs the current lack of testing. The wrapper has been in use for 8 years, and while more testing is preferred we have reasonable assurances it works as expected. I don’t think we’ll be back to zero if we find issues, they can be fixed and will be accompanied by tests as most things here are. Right now from a user’s perspective the wrapper appears dead at Takari and Apache which is a shame. Would everyone be amenable to an alpha release? And transition to a non-alpha release when everyone agrees the testing is sufficient? jvz > On Dec 12, 2021, at 5:14 AM, Maarten Mulders wrote: > > Chiming in a little late, but here are my 2 cents nevertheless. I would not > feel confident releasing something that we cannot test in an automated way. > Not having an integration test suite means we don't know for sure if it > works. And if we know it works and we change something, we're back to zero. > > To me, this has nothing to do with a (misplaced) drive for perfection. It is > all about making sure we ship something to users that we know to work, and > that we can easily prove to still work after we change it. > > Thanks, > > Maarten > > On 11/12/2021 13:43, Robert Scholte wrote: >> It was marked for Maven 4, and part of the improvements was test automation, >> which was now possible because it became part of Maven Core. >> Even thought the code still exists in Maven Core, is has now become useless. >> There hasn't been a real need for new releases of Maven Wrapper Plugin until >> a range of Maven 3.8 started. >> Maven Wrapper would have been another feature to attract developers to Maven >> 4. >> And finally, I see that the donated code has been used as base, ignoring all >> the effort done to improve that codebase done afterwards. >> Hence my response that reliability is gone that was added after donation. >> Robert >> -- Origineel bericht ------ >> Van: "Manfred Moser" >> Aan: dev@maven.apache.org >> Verzonden: 10-12-2021 20:58:33 >> Onderwerp: Re: reviewing Maven Wrapper before releasing >>> I totally agree with finally just shipping this. We got this all donated >>> about two years ago now and there is still nothing shipping. >>> >>> I used to just manually do the testing and thousands of projects are happy. >>> I assume the new project is at least manually testing and works as before >>> or better. Let's not wait nay more and let perfection get into our way. It >>> surely is good enough for a release. >>> >>> The beauty is that if you find an issue.. you just ship again ... no reason >>> to wait. >>> >>> manfred >>> >>> Hervé BOUTEMY wrote on 2021-12-10 04:13 (GMT -08:00): >>> >>>> the current 3.1.0-SNAPSHOT works like 0.5.6 as donated: I confess I did >>>> not >>>> test, I just did not change anything using the general approach "people >>>> were >>>> happy before, just continue step by step improvements" :) >>>> >>>> reading the mvnw script (*nix), compiling+running the .java is executed >>>> only if >>>> neither wget nor curl are available on your machine >>>> >>>> reading the mvnw.cmd, it seems .java is not supported >>>> >>>> looking at Git history confirms: >>>> https://github.com/apache/maven-wrapper/commit/570bc50afe07bff696a097cd7746d01b00e70337 >>>> >>>> >>>> >>>> Don't hesitate to create a Jira issue and corresponding fix to add .java >>>> support for Windows: future 3.1.0 will have one more fix over previous >>>> 0.5.6 >>>> >>>> Regards, >>>> >>>> Hervé >>>> >>>> Le vendredi 10 décembre 2021, 10:40:41 CET Robert Scholte a écrit : >>>>> I need more time. >>>>> >>>>> e.g. it l
Re: reviewing Maven Wrapper before releasing
sure, having ITs is our best bet for maintenance, particularly with the OS- dependant scripts notice that with wrapper releases being back independent from Maven core releases, the impact of any issue is not definitive: newer releases of wrapper will fix bugs and permit new features for every past and future release of Maven core = what Manfred did for years and made Maven Wrapper successful. We can safely continue this success history. Regards, Hervé Le dimanche 12 décembre 2021, 11:14:37 CET Maarten Mulders a écrit : > Chiming in a little late, but here are my 2 cents nevertheless. I would > not feel confident releasing something that we cannot test in an > automated way. Not having an integration test suite means we don't know > for sure if it works. And if we know it works and we change something, > we're back to zero. > > To me, this has nothing to do with a (misplaced) drive for perfection. > It is all about making sure we ship something to users that we know to > work, and that we can easily prove to still work after we change it. > > Thanks, > > Maarten > > On 11/12/2021 13:43, Robert Scholte wrote: > > It was marked for Maven 4, and part of the improvements was test > > automation, which was now possible because it became part of Maven Core. > > Even thought the code still exists in Maven Core, is has now become > > useless. > > > > There hasn't been a real need for new releases of Maven Wrapper Plugin > > until a range of Maven 3.8 started. > > Maven Wrapper would have been another feature to attract developers to > > Maven 4. > > > > And finally, I see that the donated code has been used as base, ignoring > > all the effort done to improve that codebase done afterwards. > > Hence my response that reliability is gone that was added after donation. > > > > Robert > > > > -- Origineel bericht -- > > Van: "Manfred Moser" > > Aan: dev@maven.apache.org > > Verzonden: 10-12-2021 20:58:33 > > Onderwerp: Re: reviewing Maven Wrapper before releasing > > > >> I totally agree with finally just shipping this. We got this all > >> donated about two years ago now and there is still nothing shipping. > >> > >> I used to just manually do the testing and thousands of projects are > >> happy. I assume the new project is at least manually testing and works > >> as before or better. Let's not wait nay more and let perfection get > >> into our way. It surely is good enough for a release. > >> > >> The beauty is that if you find an issue.. you just ship again ... no > >> reason to wait. > >> > >> manfred > >> > >> Hervé BOUTEMY wrote on 2021-12-10 04:13 (GMT -08:00): > >>> the current 3.1.0-SNAPSHOT works like 0.5.6 as donated: I confess I > >>> did not > >>> test, I just did not change anything using the general approach > >>> "people were > >>> happy before, just continue step by step improvements" :) > >>> > >>> reading the mvnw script (*nix), compiling+running the .java is > >>> executed only if > >>> neither wget nor curl are available on your machine > >>> > >>> reading the mvnw.cmd, it seems .java is not supported > >>> > >>> looking at Git history confirms: > >>> https://github.com/apache/maven-wrapper/commit/570bc50afe07bff696a097cd7 > >>> 746d01b00e70337 > >>> > >>> > >>> > >>> Don't hesitate to create a Jira issue and corresponding fix to add > >>> .java > >>> support for Windows: future 3.1.0 will have one more fix over > >>> previous 0.5.6 > >>> > >>> Regards, > >>> > >>> Hervé > >>> > >>> Le vendredi 10 décembre 2021, 10:40:41 CET Robert Scholte a écrit : > >>>> I need more time. > >>>> > >>>> e.g. it looks like type=source doesn't use the Java sourcefile to > >>>> download the wrapper. > >>>> now that the plugin and wrapper are combined in one project, the > >>>> ITs are > >>>> incomplete. > >>>> They should call both the wrapper-goal and something like 'mvnw > >>>> --version' to ensure it is working (this used to be done in > >>>> maven-integration-testing) > >>>> > >>>> thanks, > >>>> Robert > >>>> > >>>> -- Origineel bericht -- > >>>
Re: reviewing Maven Wrapper before releasing
Chiming in a little late, but here are my 2 cents nevertheless. I would not feel confident releasing something that we cannot test in an automated way. Not having an integration test suite means we don't know for sure if it works. And if we know it works and we change something, we're back to zero. To me, this has nothing to do with a (misplaced) drive for perfection. It is all about making sure we ship something to users that we know to work, and that we can easily prove to still work after we change it. Thanks, Maarten On 11/12/2021 13:43, Robert Scholte wrote: It was marked for Maven 4, and part of the improvements was test automation, which was now possible because it became part of Maven Core. Even thought the code still exists in Maven Core, is has now become useless. There hasn't been a real need for new releases of Maven Wrapper Plugin until a range of Maven 3.8 started. Maven Wrapper would have been another feature to attract developers to Maven 4. And finally, I see that the donated code has been used as base, ignoring all the effort done to improve that codebase done afterwards. Hence my response that reliability is gone that was added after donation. Robert -- Origineel bericht -- Van: "Manfred Moser" Aan: dev@maven.apache.org Verzonden: 10-12-2021 20:58:33 Onderwerp: Re: reviewing Maven Wrapper before releasing I totally agree with finally just shipping this. We got this all donated about two years ago now and there is still nothing shipping. I used to just manually do the testing and thousands of projects are happy. I assume the new project is at least manually testing and works as before or better. Let's not wait nay more and let perfection get into our way. It surely is good enough for a release. The beauty is that if you find an issue.. you just ship again ... no reason to wait. manfred Hervé BOUTEMY wrote on 2021-12-10 04:13 (GMT -08:00): the current 3.1.0-SNAPSHOT works like 0.5.6 as donated: I confess I did not test, I just did not change anything using the general approach "people were happy before, just continue step by step improvements" :) reading the mvnw script (*nix), compiling+running the .java is executed only if neither wget nor curl are available on your machine reading the mvnw.cmd, it seems .java is not supported looking at Git history confirms: https://github.com/apache/maven-wrapper/commit/570bc50afe07bff696a097cd7746d01b00e70337 Don't hesitate to create a Jira issue and corresponding fix to add .java support for Windows: future 3.1.0 will have one more fix over previous 0.5.6 Regards, Hervé Le vendredi 10 décembre 2021, 10:40:41 CET Robert Scholte a écrit : I need more time. e.g. it looks like type=source doesn't use the Java sourcefile to download the wrapper. now that the plugin and wrapper are combined in one project, the ITs are incomplete. They should call both the wrapper-goal and something like 'mvnw --version' to ensure it is working (this used to be done in maven-integration-testing) thanks, Robert -- Origineel bericht -- Van: "Hervé BOUTEMY" Aan: "Maven Developers List" Verzonden: 10-12-2021 08:08:57 Onderwerp: Re: reviewing Maven Wrapper before releasing >thank you to everybody who reviewed, discussed, contributed > >we now have 16 issues fixed, everything seems stable > >if nobody objects, I'll start a release over the week-end > >Regards, > >Hervé > >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : >> Hi, >> >> Maven Wrapper has been donated to Apache Maven, imported to >> >>https://github.com/apache/maven-wrapper >> >> Documentation published to https://maven.apache.org/wrapper/ >> >> Here is the list of fixes from previous 0.5.6 release: >>https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; >>ve>> >> rsion=12350068 >> >> >> Please test and review so we can do a release soon >> >> Regards, >> >> Hervé >> >> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org > >- >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For add
Re: reviewing Maven Wrapper before releasing
The improvements can still be applied. My understanding was that it was planned for the next Maven release. And that was 4 at the time .. however that changed and we have had no released maintained wrapper for two years now. Lets just move on with the release of the wrapper in Apache and then improve however desired. Manfred Robert Scholte wrote on 2021-12-11 04:43 (GMT -08:00): > It was marked for Maven 4, and part of the improvements was test > automation, which was now possible because it became part of Maven Core. > Even thought the code still exists in Maven Core, is has now become > useless. > > There hasn't been a real need for new releases of Maven Wrapper Plugin > until a range of Maven 3.8 started. > Maven Wrapper would have been another feature to attract developers to > Maven 4. > > And finally, I see that the donated code has been used as base, ignoring > all the effort done to improve that codebase done afterwards. > Hence my response that reliability is gone that was added after > donation. > > Robert > > -- Origineel bericht -- > Van: "Manfred Moser" > Aan: dev@maven.apache.org > Verzonden: 10-12-2021 20:58:33 > Onderwerp: Re: reviewing Maven Wrapper before releasing > >>I totally agree with finally just shipping this. We got this all donated about >>two years ago now and there is still nothing shipping. >> >>I used to just manually do the testing and thousands of projects are happy. I >>assume the new project is at least manually testing and works as before or >>better. Let's not wait nay more and let perfection get into our way. It surely >>is good enough for a release. >> >>The beauty is that if you find an issue.. you just ship again ... no reason to >>wait. >> >>manfred >> >>Hervé BOUTEMY wrote on 2021-12-10 04:13 (GMT -08:00): >> >>> the current 3.1.0-SNAPSHOT works like 0.5.6 as donated: I confess I did not >>> test, I just did not change anything using the general approach "people >>> were >>> happy before, just continue step by step improvements" :) >>> >>> reading the mvnw script (*nix), compiling+running the .java is executed >>> only >>> if >>> neither wget nor curl are available on your machine >>> >>> reading the mvnw.cmd, it seems .java is not supported >>> >>> looking at Git history confirms: >>>https://github.com/apache/maven-wrapper/commit/570bc50afe07bff696a097cd7746d01b00e70337 >>> >>> >>> Don't hesitate to create a Jira issue and corresponding fix to add .java >>> support for Windows: future 3.1.0 will have one more fix over previous >>> 0.5.6 >>> >>> Regards, >>> >>> Hervé >>> >>> Le vendredi 10 décembre 2021, 10:40:41 CET Robert Scholte a écrit : >>>> I need more time. >>>> >>>> e.g. it looks like type=source doesn't use the Java sourcefile to >>>> download the wrapper. >>>> now that the plugin and wrapper are combined in one project, the ITs are >>>> incomplete. >>>> They should call both the wrapper-goal and something like 'mvnw >>>> --version' to ensure it is working (this used to be done in >>>> maven-integration-testing) >>>> >>>> thanks, >>>> Robert >>>> >>>> -- Origineel bericht -- >>>> Van: "Hervé BOUTEMY" >>>> Aan: "Maven Developers List" >>>> Verzonden: 10-12-2021 08:08:57 >>>> Onderwerp: Re: reviewing Maven Wrapper before releasing >>>> >>>> >thank you to everybody who reviewed, discussed, contributed >>>> > >>>> >we now have 16 issues fixed, everything seems stable >>>> > >>>> >if nobody objects, I'll start a release over the week-end >>>> > >>>> >Regards, >>>> > >>>> >Hervé >>>> > >>>> >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : >>>> >> Hi, >>>> >> >>>> >> Maven Wrapper has been donated to Apache Maven, imported to >>>> >> >>>> >>https://github.com/apache/maven-wrapper >>>> >> >>>> >> Documentation published to https://maven.apache.org/wrapper/ >>>> >> >>>> >> Here is the list of fixes from previous 0.5.6 release: >>>> >>>> >>https://issues.apache.org
Re: reviewing Maven Wrapper before releasing
It was marked for Maven 4, and part of the improvements was test automation, which was now possible because it became part of Maven Core. Even thought the code still exists in Maven Core, is has now become useless. There hasn't been a real need for new releases of Maven Wrapper Plugin until a range of Maven 3.8 started. Maven Wrapper would have been another feature to attract developers to Maven 4. And finally, I see that the donated code has been used as base, ignoring all the effort done to improve that codebase done afterwards. Hence my response that reliability is gone that was added after donation. Robert -- Origineel bericht -- Van: "Manfred Moser" Aan: dev@maven.apache.org Verzonden: 10-12-2021 20:58:33 Onderwerp: Re: reviewing Maven Wrapper before releasing I totally agree with finally just shipping this. We got this all donated about two years ago now and there is still nothing shipping. I used to just manually do the testing and thousands of projects are happy. I assume the new project is at least manually testing and works as before or better. Let's not wait nay more and let perfection get into our way. It surely is good enough for a release. The beauty is that if you find an issue.. you just ship again ... no reason to wait. manfred Hervé BOUTEMY wrote on 2021-12-10 04:13 (GMT -08:00): the current 3.1.0-SNAPSHOT works like 0.5.6 as donated: I confess I did not test, I just did not change anything using the general approach "people were happy before, just continue step by step improvements" :) reading the mvnw script (*nix), compiling+running the .java is executed only if neither wget nor curl are available on your machine reading the mvnw.cmd, it seems .java is not supported looking at Git history confirms: https://github.com/apache/maven-wrapper/commit/570bc50afe07bff696a097cd7746d01b00e70337 Don't hesitate to create a Jira issue and corresponding fix to add .java support for Windows: future 3.1.0 will have one more fix over previous 0.5.6 Regards, Hervé Le vendredi 10 décembre 2021, 10:40:41 CET Robert Scholte a écrit : I need more time. e.g. it looks like type=source doesn't use the Java sourcefile to download the wrapper. now that the plugin and wrapper are combined in one project, the ITs are incomplete. They should call both the wrapper-goal and something like 'mvnw --version' to ensure it is working (this used to be done in maven-integration-testing) thanks, Robert -- Origineel bericht -- Van: "Hervé BOUTEMY" Aan: "Maven Developers List" Verzonden: 10-12-2021 08:08:57 Onderwerp: Re: reviewing Maven Wrapper before releasing >thank you to everybody who reviewed, discussed, contributed > >we now have 16 issues fixed, everything seems stable > >if nobody objects, I'll start a release over the week-end > >Regards, > >Hervé > >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : >> Hi, >> >> Maven Wrapper has been donated to Apache Maven, imported to >> >>https://github.com/apache/maven-wrapper >> >> Documentation published to https://maven.apache.org/wrapper/ >> >> Here is the list of fixes from previous 0.5.6 release: >>https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; >>ve>> >> rsion=12350068 >> >> >> Please test and review so we can do a release soon >> >> Regards, >> >> Hervé >> >> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org > >- >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
Maybe mrm-maven-plugin can be used for mock Central for downloading wrapper. sob., 11 gru 2021 o 09:03 Hervé BOUTEMY napisał(a): > I'm trying an "exec:exec" approach > https://github.com/apache/maven-wrapper/tree/it_run_mvnw > > the only tricky case is for source distribution type to download the > wrapper > that is not available on central > > perhaps I'll simply skip that one for now: we'll have time to improve later > > Le vendredi 10 décembre 2021, 12:56:23 CET Slawomir Jaranowski a écrit : > > In order to run proper IT test by maven-invoker-plugin we should provide > > invoker.properties like: > > > > invoker.goals.1 = wraper:wrapper > > > > invoker.goals.2 = validate > > invoker.mavenExecutable.2 = ./mvnw > > invoker.os.family.2 = unix, mac > > > > invoker.goals.3 = validate > > invoker.mavenExecutable.3 = ./mvnw.cmd > > invoker.os.family.3 = windows > > > > but > > - mavenExecutable - can be set on global configuration only > > - invoker.os.family - not support indexing ... > > > > So first improvement on maven-invoker-plugin will be needed ... > > or switch to another tools for IT testing > > or try to complicate maven-invoker configuration - I don't sure if will > be > > posible > > > > I can take care about changes in maven-invoker-plugin if you wish > > > > pt., 10 gru 2021 o 11:03 Robert Scholte > napisał(a): > > > I need more time. > > > > > > e.g. it looks like type=source doesn't use the Java sourcefile to > > > download the wrapper. > > > now that the plugin and wrapper are combined in one project, the ITs > are > > > incomplete. > > > They should call both the wrapper-goal and something like 'mvnw > > > --version' to ensure it is working (this used to be done in > > > maven-integration-testing) > > > > > > thanks, > > > Robert > > > > > > -- Origineel bericht -- > > > Van: "Hervé BOUTEMY" > > > Aan: "Maven Developers List" > > > Verzonden: 10-12-2021 08:08:57 > > > Onderwerp: Re: reviewing Maven Wrapper before releasing > > > > > > >thank you to everybody who reviewed, discussed, contributed > > > > > > > >we now have 16 issues fixed, everything seems stable > > > > > > > >if nobody objects, I'll start a release over the week-end > > > > > > > >Regards, > > > > > > > >Hervé > > > > > > > >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : > > > >> Hi, > > > >> > > > >> Maven Wrapper has been donated to Apache Maven, imported to > > > >> > > > >>https://github.com/apache/maven-wrapper > > > >> > > > >> Documentation published to https://maven.apache.org/wrapper/ > > > > > > >> Here is the list of fixes from previous 0.5.6 release: > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > > > ve> > > > >> rsion=12350068 > > > >> > > > >> > > > >> Please test and review so we can do a release soon > > > >> > > > >> Regards, > > > >> > > > >> Hervé > > > >> > > > >> > > > >> > > > >> > - > > > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > >- > > > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > >For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Sławomir Jaranowski
Re: reviewing Maven Wrapper before releasing
I'm trying an "exec:exec" approach https://github.com/apache/maven-wrapper/tree/it_run_mvnw the only tricky case is for source distribution type to download the wrapper that is not available on central perhaps I'll simply skip that one for now: we'll have time to improve later Le vendredi 10 décembre 2021, 12:56:23 CET Slawomir Jaranowski a écrit : > In order to run proper IT test by maven-invoker-plugin we should provide > invoker.properties like: > > invoker.goals.1 = wraper:wrapper > > invoker.goals.2 = validate > invoker.mavenExecutable.2 = ./mvnw > invoker.os.family.2 = unix, mac > > invoker.goals.3 = validate > invoker.mavenExecutable.3 = ./mvnw.cmd > invoker.os.family.3 = windows > > but > - mavenExecutable - can be set on global configuration only > - invoker.os.family - not support indexing ... > > So first improvement on maven-invoker-plugin will be needed ... > or switch to another tools for IT testing > or try to complicate maven-invoker configuration - I don't sure if will be > posible > > I can take care about changes in maven-invoker-plugin if you wish > > pt., 10 gru 2021 o 11:03 Robert Scholte napisał(a): > > I need more time. > > > > e.g. it looks like type=source doesn't use the Java sourcefile to > > download the wrapper. > > now that the plugin and wrapper are combined in one project, the ITs are > > incomplete. > > They should call both the wrapper-goal and something like 'mvnw > > --version' to ensure it is working (this used to be done in > > maven-integration-testing) > > > > thanks, > > Robert > > > > -- Origineel bericht -- > > Van: "Hervé BOUTEMY" > > Aan: "Maven Developers List" > > Verzonden: 10-12-2021 08:08:57 > > Onderwerp: Re: reviewing Maven Wrapper before releasing > > > > >thank you to everybody who reviewed, discussed, contributed > > > > > >we now have 16 issues fixed, everything seems stable > > > > > >if nobody objects, I'll start a release over the week-end > > > > > >Regards, > > > > > >Hervé > > > > > >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : > > >> Hi, > > >> > > >> Maven Wrapper has been donated to Apache Maven, imported to > > >> > > >>https://github.com/apache/maven-wrapper > > >> > > >> Documentation published to https://maven.apache.org/wrapper/ > > > > >> Here is the list of fixes from previous 0.5.6 release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > > ve> > > >> rsion=12350068 > > >> > > >> > > >> Please test and review so we can do a release soon > > >> > > >> Regards, > > >> > > >> Hervé > > >> > > >> > > >> > > >> - > > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > >- > > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > >For additional commands, e-mail: dev-h...@maven.apache.org > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
+1 On Fri, Dec 10, 2021, 20:58 Manfred Moser wrote: > I totally agree with finally just shipping this. We got this all donated > about two years ago now and there is still nothing shipping. > > I used to just manually do the testing and thousands of projects are > happy. I assume the new project is at least manually testing and works as > before or better. Let's not wait nay more and let perfection get into our > way. It surely is good enough for a release. > > The beauty is that if you find an issue.. you just ship again ... no > reason to wait. > > manfred > > Hervé BOUTEMY wrote on 2021-12-10 04:13 (GMT -08:00): > > > the current 3.1.0-SNAPSHOT works like 0.5.6 as donated: I confess I did > not > > test, I just did not change anything using the general approach "people > were > > happy before, just continue step by step improvements" :) > > > > reading the mvnw script (*nix), compiling+running the .java is executed > only if > > neither wget nor curl are available on your machine > > > > reading the mvnw.cmd, it seems .java is not supported > > > > looking at Git history confirms: > > > https://github.com/apache/maven-wrapper/commit/570bc50afe07bff696a097cd7746d01b00e70337 > > > > > > Don't hesitate to create a Jira issue and corresponding fix to add .java > > support for Windows: future 3.1.0 will have one more fix over previous > 0.5.6 > > > > Regards, > > > > Hervé > > > > Le vendredi 10 décembre 2021, 10:40:41 CET Robert Scholte a écrit : > >> I need more time. > >> > >> e.g. it looks like type=source doesn't use the Java sourcefile to > >> download the wrapper. > >> now that the plugin and wrapper are combined in one project, the ITs are > >> incomplete. > >> They should call both the wrapper-goal and something like 'mvnw > >> --version' to ensure it is working (this used to be done in > >> maven-integration-testing) > >> > >> thanks, > >> Robert > >> > >> -- Origineel bericht -- > >> Van: "Hervé BOUTEMY" > >> Aan: "Maven Developers List" > >> Verzonden: 10-12-2021 08:08:57 > >> Onderwerp: Re: reviewing Maven Wrapper before releasing > >> > >> >thank you to everybody who reviewed, discussed, contributed > >> > > >> >we now have 16 issues fixed, everything seems stable > >> > > >> >if nobody objects, I'll start a release over the week-end > >> > > >> >Regards, > >> > > >> >Hervé > >> > > >> >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : > >> >> Hi, > >> >> > >> >> Maven Wrapper has been donated to Apache Maven, imported to > >> >> > >> >>https://github.com/apache/maven-wrapper > >> >> > >> >> Documentation published to https://maven.apache.org/wrapper/ > >> >> > >> >> Here is the list of fixes from previous 0.5.6 release: > >> >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > >> >>ve>> > >> >> rsion=12350068 > >> >> > >> >> > >> >> Please test and review so we can do a release soon > >> >> > >> >> Regards, > >> >> > >> >> Hervé > >> >> > >> >> > >> >> > >> >> > - > >> >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> >> For additional commands, e-mail: dev-h...@maven.apache.org > >> > > >> >- > >> >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> >For additional commands, e-mail: dev-h...@maven.apache.org > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: reviewing Maven Wrapper before releasing
I totally agree with finally just shipping this. We got this all donated about two years ago now and there is still nothing shipping. I used to just manually do the testing and thousands of projects are happy. I assume the new project is at least manually testing and works as before or better. Let's not wait nay more and let perfection get into our way. It surely is good enough for a release. The beauty is that if you find an issue.. you just ship again ... no reason to wait. manfred Hervé BOUTEMY wrote on 2021-12-10 04:13 (GMT -08:00): > the current 3.1.0-SNAPSHOT works like 0.5.6 as donated: I confess I did not > test, I just did not change anything using the general approach "people were > happy before, just continue step by step improvements" :) > > reading the mvnw script (*nix), compiling+running the .java is executed only > if > neither wget nor curl are available on your machine > > reading the mvnw.cmd, it seems .java is not supported > > looking at Git history confirms: > https://github.com/apache/maven-wrapper/commit/570bc50afe07bff696a097cd7746d01b00e70337 > > > Don't hesitate to create a Jira issue and corresponding fix to add .java > support for Windows: future 3.1.0 will have one more fix over previous 0.5.6 > > Regards, > > Hervé > > Le vendredi 10 décembre 2021, 10:40:41 CET Robert Scholte a écrit : >> I need more time. >> >> e.g. it looks like type=source doesn't use the Java sourcefile to >> download the wrapper. >> now that the plugin and wrapper are combined in one project, the ITs are >> incomplete. >> They should call both the wrapper-goal and something like 'mvnw >> --version' to ensure it is working (this used to be done in >> maven-integration-testing) >> >> thanks, >> Robert >> >> -- Origineel bericht -- >> Van: "Hervé BOUTEMY" >> Aan: "Maven Developers List" >> Verzonden: 10-12-2021 08:08:57 >> Onderwerp: Re: reviewing Maven Wrapper before releasing >> >> >thank you to everybody who reviewed, discussed, contributed >> > >> >we now have 16 issues fixed, everything seems stable >> > >> >if nobody objects, I'll start a release over the week-end >> > >> >Regards, >> > >> >Hervé >> > >> >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : >> >> Hi, >> >> >> >> Maven Wrapper has been donated to Apache Maven, imported to >> >> >> >>https://github.com/apache/maven-wrapper >> >> >> >> Documentation published to https://maven.apache.org/wrapper/ >> >> >> >> Here is the list of fixes from previous 0.5.6 release: >> >>https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; >> >>ve>> >> >> rsion=12350068 >> >> >> >> >> >> Please test and review so we can do a release soon >> >> >> >> Regards, >> >> >> >> Hervé >> >> >> >> >> >> >> >> - >> >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> >> For additional commands, e-mail: dev-h...@maven.apache.org >> > >> >- >> >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> >For additional commands, e-mail: dev-h...@maven.apache.org >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
To me there's a very important piece missing. For the maven-wrapper-plugin I wrote several ITs to proof that downloading and unpacking works with all kinds of combinations of parameters. With the maven-wrapper code moved to this project, there no coverage at all to the actual wrapper code. Unlike maven-integration-testing there's no proof that mvnw works, because maven-invoker-plugin will keep using mvn. It needs to be improved like done with maven-verifier[1] (which is used by maven-integration-testing) IMO we should not release this maven-wrapper under pressure until this is solved: we should automatically verify that the scripts work now, as with any feature change. At its current state we've dropped in reliability compared to the maven-wrapper module in Maven Core. thanks, Robert [1] https://issues.apache.org/jira/browse/MSHARED-855 -- Origineel bericht -- Van: "Hervé BOUTEMY" Aan: "Maven Developers List" Verzonden: 10-12-2021 13:13:41 Onderwerp: Re: reviewing Maven Wrapper before releasing the current 3.1.0-SNAPSHOT works like 0.5.6 as donated: I confess I did not test, I just did not change anything using the general approach "people were happy before, just continue step by step improvements" :) reading the mvnw script (*nix), compiling+running the .java is executed only if neither wget nor curl are available on your machine reading the mvnw.cmd, it seems .java is not supported looking at Git history confirms: https://github.com/apache/maven-wrapper/commit/570bc50afe07bff696a097cd7746d01b00e70337 Don't hesitate to create a Jira issue and corresponding fix to add .java support for Windows: future 3.1.0 will have one more fix over previous 0.5.6 Regards, Hervé Le vendredi 10 décembre 2021, 10:40:41 CET Robert Scholte a écrit : I need more time. e.g. it looks like type=source doesn't use the Java sourcefile to download the wrapper. now that the plugin and wrapper are combined in one project, the ITs are incomplete. They should call both the wrapper-goal and something like 'mvnw --version' to ensure it is working (this used to be done in maven-integration-testing) thanks, Robert -- Origineel bericht -- Van: "Hervé BOUTEMY" Aan: "Maven Developers List" Verzonden: 10-12-2021 08:08:57 Onderwerp: Re: reviewing Maven Wrapper before releasing >thank you to everybody who reviewed, discussed, contributed > >we now have 16 issues fixed, everything seems stable > >if nobody objects, I'll start a release over the week-end > >Regards, > >Hervé > >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : >> Hi, >> >> Maven Wrapper has been donated to Apache Maven, imported to >> >>https://github.com/apache/maven-wrapper >> >> Documentation published to https://maven.apache.org/wrapper/ >> >> Here is the list of fixes from previous 0.5.6 release: >>https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; >>ve>> >> rsion=12350068 >> >> >> Please test and review so we can do a release soon >> >> Regards, >> >> Hervé >> >> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org > >- >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
the current 3.1.0-SNAPSHOT works like 0.5.6 as donated: I confess I did not test, I just did not change anything using the general approach "people were happy before, just continue step by step improvements" :) reading the mvnw script (*nix), compiling+running the .java is executed only if neither wget nor curl are available on your machine reading the mvnw.cmd, it seems .java is not supported looking at Git history confirms: https://github.com/apache/maven-wrapper/commit/570bc50afe07bff696a097cd7746d01b00e70337 Don't hesitate to create a Jira issue and corresponding fix to add .java support for Windows: future 3.1.0 will have one more fix over previous 0.5.6 Regards, Hervé Le vendredi 10 décembre 2021, 10:40:41 CET Robert Scholte a écrit : > I need more time. > > e.g. it looks like type=source doesn't use the Java sourcefile to > download the wrapper. > now that the plugin and wrapper are combined in one project, the ITs are > incomplete. > They should call both the wrapper-goal and something like 'mvnw > --version' to ensure it is working (this used to be done in > maven-integration-testing) > > thanks, > Robert > > -- Origineel bericht -- > Van: "Hervé BOUTEMY" > Aan: "Maven Developers List" > Verzonden: 10-12-2021 08:08:57 > Onderwerp: Re: reviewing Maven Wrapper before releasing > > >thank you to everybody who reviewed, discussed, contributed > > > >we now have 16 issues fixed, everything seems stable > > > >if nobody objects, I'll start a release over the week-end > > > >Regards, > > > >Hervé > > > >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : > >> Hi, > >> > >> Maven Wrapper has been donated to Apache Maven, imported to > >> > >>https://github.com/apache/maven-wrapper > >> > >> Documentation published to https://maven.apache.org/wrapper/ > >> > >> Here is the list of fixes from previous 0.5.6 release: > >>https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > >>ve>> > >> rsion=12350068 > >> > >> > >> Please test and review so we can do a release soon > >> > >> Regards, > >> > >> Hervé > >> > >> > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > >- > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >For additional commands, e-mail: dev-h...@maven.apache.org > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
In order to run proper IT test by maven-invoker-plugin we should provide invoker.properties like: invoker.goals.1 = wraper:wrapper invoker.goals.2 = validate invoker.mavenExecutable.2 = ./mvnw invoker.os.family.2 = unix, mac invoker.goals.3 = validate invoker.mavenExecutable.3 = ./mvnw.cmd invoker.os.family.3 = windows but - mavenExecutable - can be set on global configuration only - invoker.os.family - not support indexing ... So first improvement on maven-invoker-plugin will be needed ... or switch to another tools for IT testing or try to complicate maven-invoker configuration - I don't sure if will be posible I can take care about changes in maven-invoker-plugin if you wish pt., 10 gru 2021 o 11:03 Robert Scholte napisał(a): > I need more time. > > e.g. it looks like type=source doesn't use the Java sourcefile to > download the wrapper. > now that the plugin and wrapper are combined in one project, the ITs are > incomplete. > They should call both the wrapper-goal and something like 'mvnw > --version' to ensure it is working (this used to be done in > maven-integration-testing) > > thanks, > Robert > > -- Origineel bericht -- > Van: "Hervé BOUTEMY" > Aan: "Maven Developers List" > Verzonden: 10-12-2021 08:08:57 > Onderwerp: Re: reviewing Maven Wrapper before releasing > > >thank you to everybody who reviewed, discussed, contributed > > > >we now have 16 issues fixed, everything seems stable > > > >if nobody objects, I'll start a release over the week-end > > > >Regards, > > > >Hervé > > > >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : > >> Hi, > >> > >> Maven Wrapper has been donated to Apache Maven, imported to > >>https://github.com/apache/maven-wrapper > >> > >> Documentation published to https://maven.apache.org/wrapper/ > >> > >> Here is the list of fixes from previous 0.5.6 release: > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721 > >> rsion=12350068 > >> > >> > >> Please test and review so we can do a release soon > >> > >> Regards, > >> > >> Hervé > >> > >> > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > > >- > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >For additional commands, e-mail: dev-h...@maven.apache.org > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Sławomir Jaranowski
Re: reviewing Maven Wrapper before releasing
I need more time. e.g. it looks like type=source doesn't use the Java sourcefile to download the wrapper. now that the plugin and wrapper are combined in one project, the ITs are incomplete. They should call both the wrapper-goal and something like 'mvnw --version' to ensure it is working (this used to be done in maven-integration-testing) thanks, Robert -- Origineel bericht -- Van: "Hervé BOUTEMY" Aan: "Maven Developers List" Verzonden: 10-12-2021 08:08:57 Onderwerp: Re: reviewing Maven Wrapper before releasing thank you to everybody who reviewed, discussed, contributed we now have 16 issues fixed, everything seems stable if nobody objects, I'll start a release over the week-end Regards, Hervé Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : Hi, Maven Wrapper has been donated to Apache Maven, imported to https://github.com/apache/maven-wrapper Documentation published to https://maven.apache.org/wrapper/ Here is the list of fixes from previous 0.5.6 release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721 rsion=12350068 Please test and review so we can do a release soon Regards, Hervé - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
thank you to everybody who reviewed, discussed, contributed we now have 16 issues fixed, everything seems stable if nobody objects, I'll start a release over the week-end Regards, Hervé Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : > Hi, > > Maven Wrapper has been donated to Apache Maven, imported to > https://github.com/apache/maven-wrapper > > Documentation published to https://maven.apache.org/wrapper/ > > Here is the list of fixes from previous 0.5.6 release: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721 > rsion=12350068 > > > Please test and review so we can do a release soon > > Regards, > > Hervé > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
awesome. Thanks On Thu, Dec 9, 2021 at 12:43 AM Hervé BOUTEMY wrote: > this is the fix in https://issues.apache.org/jira/browse/MWRAPPER-18 > > with wrapper 0.5.6, there was a fixed Maven version hard coded in maven- > wrapper.jar and inconsistent local installation directory name (see Jira > issue > for detailed description) > > with MWRAPPER-18, from the distributionUrl in maven-wrapper.properties, it > replaces the repository prefix: see the commit > > Regards, > > Hervé > > Le jeudi 9 décembre 2021, 09:19:09 CET Dan Tran a écrit : > > That works, but how does it figure out the maven version to compute the > > full URL to download? > > > > Thanks > > > > -D > > > > On Wed, Dec 8, 2021 at 11:10 PM Hervé BOUTEMY > wrote: > > > there is MVNW_REPOURL system property > > > https://maven.apache.org/wrapper/#Using_a_Maven_Repository_Manager > > > > > > with a fix done in https://issues.apache.org/jira/browse/MWRAPPER-18 > > > (showing concrete usage output) > > > > > > Is it what you expected? > > > > > > Regards, > > > > > > Hervé > > > > > > Le jeudi 9 décembre 2021, 00:59:41 CET Dan Tran a écrit : > > > > sorry for hi-jack this thread. is it possible to configure mvnw to > use > > > > a > > > > new location of distributionUrl on the fly? (without touching > > > > maven-wrapper.properties) > > > > > > > > Thanks > > > > > > > > -D > > > > > > > > On Wed, Dec 8, 2021 at 11:31 AM Slawomir Jaranowski < > > > > > > s.jaranow...@gmail.com> > > > > > > > wrote: > > > > > In current project configuration it is a bug rather ... We can use > a > > > > > wrapper with java 5 but we can't install it because the plugin > > > > > requires > > > > > java 8 ... > > > > > > > > > > śr., 8 gru 2021 o 20:18 Xeno Amess > napisał(a): > > > > > > +1 for forcing more people quit java 5,6,7， as even 17 is out. > > > > > > 8 is the minimum version normal people can accept，others be > zombies > > > > > > who > > > > > > > > do > > > > > > > > > > > not need to be maintained IMO. They can use original wrapper > plugin > > > > > > > > > > anyway. > > > > > > > > > > > If we do not force them when beginning，it is harder to add the > > > > > > liminition > > > > > > later. > > > > > > > > > > > > XenoAmess > > > > > > > > > > > > From: Slawomir Jaranowski > > > > > > Sent: Thursday, December 9, 2021 3:11:42 AM > > > > > > To: Maven Developers List > > > > > > Subject: Re: reviewing Maven Wrapper before releasing > > > > > > > > > > > > I created issues with the proposition of improvement: > > > > > > > > > > > > https://issues.apache.org/jira/browse/MWRAPPER-31 > > > > > > https://issues.apache.org/jira/browse/MWRAPPER-32 > > > > > > https://issues.apache.org/jira/browse/MWRAPPER-33 > > > > > > > > > > > > please assign a version to fix ... if it is applicable. > > > > > > > > > > > > śr., 8 gru 2021 o 19:47 Hervé BOUTEMY > > > > > > > > > > napisał(a): > > > > > > > because it's as it was imported: > > > > > > > > https://github.com/takari/maven-wrapper/blob/master/pom.xml#L21 > > > > > > > I refactored but kept everything as equivalent as possible > > > > > > > > > > > > > > we can update the value if it has an interest, with associated > > > > > > > Jira > > > > > > > > > > issue > > > > > > > > > > > > Regards, > > > > > > > > > > > > > > Hervé > > > > > > > > > > > > > > Le mercredi 8 décembre 2021, 19:14:55 CET Slawomir Jaranowski a > > > > > > écrit > > > > > > > > > > > Next question: > > > > > > > > - why use java 5 in maven-wrapper module .. it is not > possible > > > > > > > > build > >
Re: reviewing Maven Wrapper before releasing
this is the fix in https://issues.apache.org/jira/browse/MWRAPPER-18 with wrapper 0.5.6, there was a fixed Maven version hard coded in maven- wrapper.jar and inconsistent local installation directory name (see Jira issue for detailed description) with MWRAPPER-18, from the distributionUrl in maven-wrapper.properties, it replaces the repository prefix: see the commit Regards, Hervé Le jeudi 9 décembre 2021, 09:19:09 CET Dan Tran a écrit : > That works, but how does it figure out the maven version to compute the > full URL to download? > > Thanks > > -D > > On Wed, Dec 8, 2021 at 11:10 PM Hervé BOUTEMY wrote: > > there is MVNW_REPOURL system property > > https://maven.apache.org/wrapper/#Using_a_Maven_Repository_Manager > > > > with a fix done in https://issues.apache.org/jira/browse/MWRAPPER-18 > > (showing concrete usage output) > > > > Is it what you expected? > > > > Regards, > > > > Hervé > > > > Le jeudi 9 décembre 2021, 00:59:41 CET Dan Tran a écrit : > > > sorry for hi-jack this thread. is it possible to configure mvnw to use > > > a > > > new location of distributionUrl on the fly? (without touching > > > maven-wrapper.properties) > > > > > > Thanks > > > > > > -D > > > > > > On Wed, Dec 8, 2021 at 11:31 AM Slawomir Jaranowski < > > > > s.jaranow...@gmail.com> > > > > > wrote: > > > > In current project configuration it is a bug rather ... We can use a > > > > wrapper with java 5 but we can't install it because the plugin > > > > requires > > > > java 8 ... > > > > > > > > śr., 8 gru 2021 o 20:18 Xeno Amess napisał(a): > > > > > +1 for forcing more people quit java 5,6,7， as even 17 is out. > > > > > 8 is the minimum version normal people can accept，others be zombies > > > > who > > > > > > do > > > > > > > > > not need to be maintained IMO. They can use original wrapper plugin > > > > > > > > anyway. > > > > > > > > > If we do not force them when beginning，it is harder to add the > > > > > liminition > > > > > later. > > > > > > > > > > XenoAmess > > > > > > > > > > From: Slawomir Jaranowski > > > > > Sent: Thursday, December 9, 2021 3:11:42 AM > > > > > To: Maven Developers List > > > > > Subject: Re: reviewing Maven Wrapper before releasing > > > > > > > > > > I created issues with the proposition of improvement: > > > > > > > > > > https://issues.apache.org/jira/browse/MWRAPPER-31 > > > > > https://issues.apache.org/jira/browse/MWRAPPER-32 > > > > > https://issues.apache.org/jira/browse/MWRAPPER-33 > > > > > > > > > > please assign a version to fix ... if it is applicable. > > > > > > > > > > śr., 8 gru 2021 o 19:47 Hervé BOUTEMY > > > > > > > > napisał(a): > > > > > > because it's as it was imported: > > > > > > https://github.com/takari/maven-wrapper/blob/master/pom.xml#L21 > > > > > > I refactored but kept everything as equivalent as possible > > > > > > > > > > > > we can update the value if it has an interest, with associated > > > > > > Jira > > > > > > > > issue > > > > > > > > > > Regards, > > > > > > > > > > > > Hervé > > > > > > > > > > > > Le mercredi 8 décembre 2021, 19:14:55 CET Slawomir Jaranowski a > > > > écrit > > > > > > > > > Next question: > > > > > > > - why use java 5 in maven-wrapper module .. it is not possible > > > > > > > build > > > > > > > > > > > > with > > > > > > > > > > > > > java > 8 [1] > > > > > > > > > > > > > > [1] > > > > https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-wrapper/job/ > > > > > > ma> > > > > > > > > > > > ster/ > > > > > > > śr., 8 gru 2021 o 19:05 Hervé BOUTEMY > > > > > > > > > > > > napisał(a): > > > > > > > > Le mercredi 8 décembre 202
Re: reviewing Maven Wrapper before releasing
That works, but how does it figure out the maven version to compute the full URL to download? Thanks -D On Wed, Dec 8, 2021 at 11:10 PM Hervé BOUTEMY wrote: > there is MVNW_REPOURL system property > https://maven.apache.org/wrapper/#Using_a_Maven_Repository_Manager > > with a fix done in https://issues.apache.org/jira/browse/MWRAPPER-18 > (showing concrete usage output) > > Is it what you expected? > > Regards, > > Hervé > > Le jeudi 9 décembre 2021, 00:59:41 CET Dan Tran a écrit : > > sorry for hi-jack this thread. is it possible to configure mvnw to use a > > new location of distributionUrl on the fly? (without touching > > maven-wrapper.properties) > > > > Thanks > > > > -D > > > > On Wed, Dec 8, 2021 at 11:31 AM Slawomir Jaranowski < > s.jaranow...@gmail.com> > > wrote: > > > In current project configuration it is a bug rather ... We can use a > > > wrapper with java 5 but we can't install it because the plugin requires > > > java 8 ... > > > > > > śr., 8 gru 2021 o 20:18 Xeno Amess napisał(a): > > > > +1 for forcing more people quit java 5,6,7， as even 17 is out. > > > > 8 is the minimum version normal people can accept，others be zombies > who > > > > > > do > > > > > > > not need to be maintained IMO. They can use original wrapper plugin > > > > > > anyway. > > > > > > > If we do not force them when beginning，it is harder to add the > > > > liminition > > > > later. > > > > > > > > XenoAmess > > > > > > > > From: Slawomir Jaranowski > > > > Sent: Thursday, December 9, 2021 3:11:42 AM > > > > To: Maven Developers List > > > > Subject: Re: reviewing Maven Wrapper before releasing > > > > > > > > I created issues with the proposition of improvement: > > > > > > > > https://issues.apache.org/jira/browse/MWRAPPER-31 > > > > https://issues.apache.org/jira/browse/MWRAPPER-32 > > > > https://issues.apache.org/jira/browse/MWRAPPER-33 > > > > > > > > please assign a version to fix ... if it is applicable. > > > > > > > > śr., 8 gru 2021 o 19:47 Hervé BOUTEMY > > > > > > napisał(a): > > > > > because it's as it was imported: > > > > > https://github.com/takari/maven-wrapper/blob/master/pom.xml#L21 > > > > > I refactored but kept everything as equivalent as possible > > > > > > > > > > we can update the value if it has an interest, with associated Jira > > > > > > issue > > > > > > > > Regards, > > > > > > > > > > Hervé > > > > > > > > > > Le mercredi 8 décembre 2021, 19:14:55 CET Slawomir Jaranowski a > écrit > : > > > > > > Next question: > > > > > > - why use java 5 in maven-wrapper module .. it is not possible > > > > > > build > > > > > > > > > > with > > > > > > > > > > > java > 8 [1] > > > > > > > > > > > > [1] > > > > > > > https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-wrapper/job/ > > > ma> > > > > > > ster/ > > > > > > śr., 8 gru 2021 o 19:05 Hervé BOUTEMY > > > > > > > > > > napisał(a): > > > > > > > Le mercredi 8 décembre 2021, 15:52:46 CET Robert Scholte a > écrit : > > > > > > > > With mvn verify -Prun-its all ITs fail on my system. This > should > > > > > > > > work > > > > > > > > > > > > out-of-the-box, so I'll need to investigate the issue. > > > > > > > > > > > > > > > > And I'm pretty sure we can remove the cli package: you can't > > > > > > > > pass > > > > > > > > > > System > > > > > > > > > > > > > properties to Maven, only arguments. And they should be > passed > > > > > > > > as > > > > > > > > is > > > > > > > > > to > > > > > > > > > > > > > mvn. > > > > > > > > > > > > > > I must admit I don't know: I suppose that if the code is here > from > > > > > > > > the &
Re: reviewing Maven Wrapper before releasing
there is MVNW_REPOURL system property https://maven.apache.org/wrapper/#Using_a_Maven_Repository_Manager with a fix done in https://issues.apache.org/jira/browse/MWRAPPER-18 (showing concrete usage output) Is it what you expected? Regards, Hervé Le jeudi 9 décembre 2021, 00:59:41 CET Dan Tran a écrit : > sorry for hi-jack this thread. is it possible to configure mvnw to use a > new location of distributionUrl on the fly? (without touching > maven-wrapper.properties) > > Thanks > > -D > > On Wed, Dec 8, 2021 at 11:31 AM Slawomir Jaranowski > wrote: > > In current project configuration it is a bug rather ... We can use a > > wrapper with java 5 but we can't install it because the plugin requires > > java 8 ... > > > > śr., 8 gru 2021 o 20:18 Xeno Amess napisał(a): > > > +1 for forcing more people quit java 5,6,7， as even 17 is out. > > > 8 is the minimum version normal people can accept，others be zombies who > > > > do > > > > > not need to be maintained IMO. They can use original wrapper plugin > > > > anyway. > > > > > If we do not force them when beginning，it is harder to add the > > > liminition > > > later. > > > > > > XenoAmess > > > ____________ > > > From: Slawomir Jaranowski > > > Sent: Thursday, December 9, 2021 3:11:42 AM > > > To: Maven Developers List > > > Subject: Re: reviewing Maven Wrapper before releasing > > > > > > I created issues with the proposition of improvement: > > > > > > https://issues.apache.org/jira/browse/MWRAPPER-31 > > > https://issues.apache.org/jira/browse/MWRAPPER-32 > > > https://issues.apache.org/jira/browse/MWRAPPER-33 > > > > > > please assign a version to fix ... if it is applicable. > > > > > > śr., 8 gru 2021 o 19:47 Hervé BOUTEMY > > > > napisał(a): > > > > because it's as it was imported: > > > > https://github.com/takari/maven-wrapper/blob/master/pom.xml#L21 > > > > I refactored but kept everything as equivalent as possible > > > > > > > > we can update the value if it has an interest, with associated Jira > > > > issue > > > > > > Regards, > > > > > > > > Hervé > > > > > > > > Le mercredi 8 décembre 2021, 19:14:55 CET Slawomir Jaranowski a écrit : > > > > > Next question: > > > > > - why use java 5 in maven-wrapper module .. it is not possible > > > > > build > > > > > > > > with > > > > > > > > > java > 8 [1] > > > > > > > > > > [1] > > > > https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-wrapper/job/ > > ma> > > > > > ster/ > > > > > śr., 8 gru 2021 o 19:05 Hervé BOUTEMY > > > > > > > > napisał(a): > > > > > > Le mercredi 8 décembre 2021, 15:52:46 CET Robert Scholte a écrit : > > > > > > > With mvn verify -Prun-its all ITs fail on my system. This should > > > > > > work > > > > > > > > > > out-of-the-box, so I'll need to investigate the issue. > > > > > > > > > > > > > > And I'm pretty sure we can remove the cli package: you can't > > > > > > > pass > > > > > > > > System > > > > > > > > > > > properties to Maven, only arguments. And they should be passed > > > > > > > as > > > > > > is > > > > > > > to > > > > > > > > > > > mvn. > > > > > > > > > > > > I must admit I don't know: I suppose that if the code is here from > > > > > > the > > > > > > > > > beginning, it's for some use, it's just me who did not imagine the > > > > > > use > > > > > > > > > case > > > > > > > > > > > > if everybody is confident that it's never used, no problem to > > > > remove > > > > > it > > > > > > > > > > IT's should confirm that. > > > > > > > > > > > > > > Robert > > > > > > > > > > > > > > -- Origineel bericht -- > > > > > > > Van: "Jason van Zyl" > > > > > > > Aan: "Maven Deve
Re: reviewing Maven Wrapper before releasing
sorry for hi-jack this thread. is it possible to configure mvnw to use a new location of distributionUrl on the fly? (without touching maven-wrapper.properties) Thanks -D On Wed, Dec 8, 2021 at 11:31 AM Slawomir Jaranowski wrote: > In current project configuration it is a bug rather ... We can use a > wrapper with java 5 but we can't install it because the plugin requires > java 8 ... > > śr., 8 gru 2021 o 20:18 Xeno Amess napisał(a): > > > +1 for forcing more people quit java 5,6,7， as even 17 is out. > > 8 is the minimum version normal people can accept，others be zombies who > do > > not need to be maintained IMO. They can use original wrapper plugin > anyway. > > If we do not force them when beginning，it is harder to add the liminition > > later. > > > > XenoAmess > > > > From: Slawomir Jaranowski > > Sent: Thursday, December 9, 2021 3:11:42 AM > > To: Maven Developers List > > Subject: Re: reviewing Maven Wrapper before releasing > > > > I created issues with the proposition of improvement: > > > > https://issues.apache.org/jira/browse/MWRAPPER-31 > > https://issues.apache.org/jira/browse/MWRAPPER-32 > > https://issues.apache.org/jira/browse/MWRAPPER-33 > > > > please assign a version to fix ... if it is applicable. > > > > śr., 8 gru 2021 o 19:47 Hervé BOUTEMY > napisał(a): > > > > > because it's as it was imported: > > > https://github.com/takari/maven-wrapper/blob/master/pom.xml#L21 > > > I refactored but kept everything as equivalent as possible > > > > > > we can update the value if it has an interest, with associated Jira > issue > > > > > > Regards, > > > > > > Hervé > > > > > > Le mercredi 8 décembre 2021, 19:14:55 CET Slawomir Jaranowski a écrit : > > > > Next question: > > > > > > > > - why use java 5 in maven-wrapper module .. it is not possible build > > > with > > > > java > 8 [1] > > > > > > > > [1] > > > > > > > > > > https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-wrapper/job/ma > > > > ster/ > > > > śr., 8 gru 2021 o 19:05 Hervé BOUTEMY > > > napisał(a): > > > > > Le mercredi 8 décembre 2021, 15:52:46 CET Robert Scholte a écrit : > > > > > > With mvn verify -Prun-its all ITs fail on my system. This should > > work > > > > > > out-of-the-box, so I'll need to investigate the issue. > > > > > > > > > > > > And I'm pretty sure we can remove the cli package: you can't pass > > > System > > > > > > properties to Maven, only arguments. And they should be passed as > > is > > > to > > > > > > mvn. > > > > > > > > > > I must admit I don't know: I suppose that if the code is here from > > the > > > > > beginning, it's for some use, it's just me who did not imagine the > > use > > > > > case > > > > > > > > > > if everybody is confident that it's never used, no problem to > remove > > it > > > > > > > > > > > IT's should confirm that. > > > > > > > > > > > > Robert > > > > > > > > > > > > -- Origineel bericht -- > > > > > > Van: "Jason van Zyl" > > > > > > Aan: "Maven Developers List" > > > > > > Verzonden: 7-12-2021 14:55:32 > > > > > > Onderwerp: Re: reviewing Maven Wrapper before releasing > > > > > > > > > > > > >Everything builds and it generates the wrapper for a project in > a > > > way > > > > > > > > > > will > > > > > > > > > > > >be familiar to existing users. The switch for current users > > should, > > > > > > >hopefully, be painless and transparent. > > > > > > > > > > > > > >Nice work Robert and Hervé. I put a notice on the GitHub page > for > > > the > > > > > > >Takari version about the impending release at Apache, and > provided > > > > > > >pointers to the new Git repository and JIRA project. > > > > > > > > > > > > > >jvz > > > > > > > > > > > > > >> On Dec 6, 2021, at 6:07 PM, Hervé BOUTEMY < > > herve.bout...
Re: reviewing Maven Wrapper before releasing
In current project configuration it is a bug rather ... We can use a wrapper with java 5 but we can't install it because the plugin requires java 8 ... śr., 8 gru 2021 o 20:18 Xeno Amess napisał(a): > +1 for forcing more people quit java 5,6,7， as even 17 is out. > 8 is the minimum version normal people can accept，others be zombies who do > not need to be maintained IMO. They can use original wrapper plugin anyway. > If we do not force them when beginning，it is harder to add the liminition > later. > > XenoAmess > > From: Slawomir Jaranowski > Sent: Thursday, December 9, 2021 3:11:42 AM > To: Maven Developers List > Subject: Re: reviewing Maven Wrapper before releasing > > I created issues with the proposition of improvement: > > https://issues.apache.org/jira/browse/MWRAPPER-31 > https://issues.apache.org/jira/browse/MWRAPPER-32 > https://issues.apache.org/jira/browse/MWRAPPER-33 > > please assign a version to fix ... if it is applicable. > > śr., 8 gru 2021 o 19:47 Hervé BOUTEMY napisał(a): > > > because it's as it was imported: > > https://github.com/takari/maven-wrapper/blob/master/pom.xml#L21 > > I refactored but kept everything as equivalent as possible > > > > we can update the value if it has an interest, with associated Jira issue > > > > Regards, > > > > Hervé > > > > Le mercredi 8 décembre 2021, 19:14:55 CET Slawomir Jaranowski a écrit : > > > Next question: > > > > > > - why use java 5 in maven-wrapper module .. it is not possible build > > with > > > java > 8 [1] > > > > > > [1] > > > > > > https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-wrapper/job/ma > > > ster/ > > > śr., 8 gru 2021 o 19:05 Hervé BOUTEMY > > napisał(a): > > > > Le mercredi 8 décembre 2021, 15:52:46 CET Robert Scholte a écrit : > > > > > With mvn verify -Prun-its all ITs fail on my system. This should > work > > > > > out-of-the-box, so I'll need to investigate the issue. > > > > > > > > > > And I'm pretty sure we can remove the cli package: you can't pass > > System > > > > > properties to Maven, only arguments. And they should be passed as > is > > to > > > > > mvn. > > > > > > > > I must admit I don't know: I suppose that if the code is here from > the > > > > beginning, it's for some use, it's just me who did not imagine the > use > > > > case > > > > > > > > if everybody is confident that it's never used, no problem to remove > it > > > > > > > > > IT's should confirm that. > > > > > > > > > > Robert > > > > > > > > > > -- Origineel bericht -- > > > > > Van: "Jason van Zyl" > > > > > Aan: "Maven Developers List" > > > > > Verzonden: 7-12-2021 14:55:32 > > > > > Onderwerp: Re: reviewing Maven Wrapper before releasing > > > > > > > > > > >Everything builds and it generates the wrapper for a project in a > > way > > > > > > > > will > > > > > > > > > >be familiar to existing users. The switch for current users > should, > > > > > >hopefully, be painless and transparent. > > > > > > > > > > > >Nice work Robert and Hervé. I put a notice on the GitHub page for > > the > > > > > >Takari version about the impending release at Apache, and provided > > > > > >pointers to the new Git repository and JIRA project. > > > > > > > > > > > >jvz > > > > > > > > > > > >> On Dec 6, 2021, at 6:07 PM, Hervé BOUTEMY < > herve.bout...@free.fr > > > > > > > > > > > wrote: > > > > > >> Hi, > > > > > >> > > > > > >> Maven Wrapper has been donated to Apache Maven, imported to > > > > > >> > > > > > >>https://github.com/apache/maven-wrapper > > > > > >> > > > > > >> Documentation published to https://maven.apache.org/wrapper/ > > > > > > > > > >> Here is the list of fixes from previous 0.5.6 release: > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > > > > > > > &
Re: reviewing Maven Wrapper before releasing
+1 for forcing more people quit java 5,6,7， as even 17 is out. 8 is the minimum version normal people can accept，others be zombies who do not need to be maintained IMO. They can use original wrapper plugin anyway. If we do not force them when beginning，it is harder to add the liminition later. XenoAmess From: Slawomir Jaranowski Sent: Thursday, December 9, 2021 3:11:42 AM To: Maven Developers List Subject: Re: reviewing Maven Wrapper before releasing I created issues with the proposition of improvement: https://issues.apache.org/jira/browse/MWRAPPER-31 https://issues.apache.org/jira/browse/MWRAPPER-32 https://issues.apache.org/jira/browse/MWRAPPER-33 please assign a version to fix ... if it is applicable. śr., 8 gru 2021 o 19:47 Hervé BOUTEMY napisał(a): > because it's as it was imported: > https://github.com/takari/maven-wrapper/blob/master/pom.xml#L21 > I refactored but kept everything as equivalent as possible > > we can update the value if it has an interest, with associated Jira issue > > Regards, > > Hervé > > Le mercredi 8 décembre 2021, 19:14:55 CET Slawomir Jaranowski a écrit : > > Next question: > > > > - why use java 5 in maven-wrapper module .. it is not possible build > with > > java > 8 [1] > > > > [1] > > > https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-wrapper/job/ma > > ster/ > > śr., 8 gru 2021 o 19:05 Hervé BOUTEMY > napisał(a): > > > Le mercredi 8 décembre 2021, 15:52:46 CET Robert Scholte a écrit : > > > > With mvn verify -Prun-its all ITs fail on my system. This should work > > > > out-of-the-box, so I'll need to investigate the issue. > > > > > > > > And I'm pretty sure we can remove the cli package: you can't pass > System > > > > properties to Maven, only arguments. And they should be passed as is > to > > > > mvn. > > > > > > I must admit I don't know: I suppose that if the code is here from the > > > beginning, it's for some use, it's just me who did not imagine the use > > > case > > > > > > if everybody is confident that it's never used, no problem to remove it > > > > > > > IT's should confirm that. > > > > > > > > Robert > > > > > > > > -- Origineel bericht -- > > > > Van: "Jason van Zyl" > > > > Aan: "Maven Developers List" > > > > Verzonden: 7-12-2021 14:55:32 > > > > Onderwerp: Re: reviewing Maven Wrapper before releasing > > > > > > > > >Everything builds and it generates the wrapper for a project in a > way > > > > > > will > > > > > > > >be familiar to existing users. The switch for current users should, > > > > >hopefully, be painless and transparent. > > > > > > > > > >Nice work Robert and Hervé. I put a notice on the GitHub page for > the > > > > >Takari version about the impending release at Apache, and provided > > > > >pointers to the new Git repository and JIRA project. > > > > > > > > > >jvz > > > > > > > > > >> On Dec 6, 2021, at 6:07 PM, Hervé BOUTEMY > > > > > > > wrote: > > > > >> Hi, > > > > >> > > > > >> Maven Wrapper has been donated to Apache Maven, imported to > > > > >> > > > > >>https://github.com/apache/maven-wrapper > > > > >> > > > > >> Documentation published to https://maven.apache.org/wrapper/ > > > > > > > >> Here is the list of fixes from previous 0.5.6 release: > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > > > > > > > >>version=12350068>> > > > > >> > > > > >> Please test and review so we can do a release soon > > > > >> > > > > >> Regards, > > > > >> > > > > >> Hervé > > > > >> > > > > >> > > > > >> > > > > >> > > > > > >> - > > > > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > >- > > > > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > >For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Sławomir Jaranowski
Re: reviewing Maven Wrapper before releasing
I created issues with the proposition of improvement: https://issues.apache.org/jira/browse/MWRAPPER-31 https://issues.apache.org/jira/browse/MWRAPPER-32 https://issues.apache.org/jira/browse/MWRAPPER-33 please assign a version to fix ... if it is applicable. śr., 8 gru 2021 o 19:47 Hervé BOUTEMY napisał(a): > because it's as it was imported: > https://github.com/takari/maven-wrapper/blob/master/pom.xml#L21 > I refactored but kept everything as equivalent as possible > > we can update the value if it has an interest, with associated Jira issue > > Regards, > > Hervé > > Le mercredi 8 décembre 2021, 19:14:55 CET Slawomir Jaranowski a écrit : > > Next question: > > > > - why use java 5 in maven-wrapper module .. it is not possible build > with > > java > 8 [1] > > > > [1] > > > https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-wrapper/job/ma > > ster/ > > śr., 8 gru 2021 o 19:05 Hervé BOUTEMY > napisał(a): > > > Le mercredi 8 décembre 2021, 15:52:46 CET Robert Scholte a écrit : > > > > With mvn verify -Prun-its all ITs fail on my system. This should work > > > > out-of-the-box, so I'll need to investigate the issue. > > > > > > > > And I'm pretty sure we can remove the cli package: you can't pass > System > > > > properties to Maven, only arguments. And they should be passed as is > to > > > > mvn. > > > > > > I must admit I don't know: I suppose that if the code is here from the > > > beginning, it's for some use, it's just me who did not imagine the use > > > case > > > > > > if everybody is confident that it's never used, no problem to remove it > > > > > > > IT's should confirm that. > > > > > > > > Robert > > > > > > > > -- Origineel bericht -- > > > > Van: "Jason van Zyl" > > > > Aan: "Maven Developers List" > > > > Verzonden: 7-12-2021 14:55:32 > > > > Onderwerp: Re: reviewing Maven Wrapper before releasing > > > > > > > > >Everything builds and it generates the wrapper for a project in a > way > > > > > > will > > > > > > > >be familiar to existing users. The switch for current users should, > > > > >hopefully, be painless and transparent. > > > > > > > > > >Nice work Robert and Hervé. I put a notice on the GitHub page for > the > > > > >Takari version about the impending release at Apache, and provided > > > > >pointers to the new Git repository and JIRA project. > > > > > > > > > >jvz > > > > > > > > > >> On Dec 6, 2021, at 6:07 PM, Hervé BOUTEMY > > > > > > > wrote: > > > > >> Hi, > > > > >> > > > > >> Maven Wrapper has been donated to Apache Maven, imported to > > > > >> > > > > >>https://github.com/apache/maven-wrapper > > > > >> > > > > >> Documentation published to https://maven.apache.org/wrapper/ > > > > > > > >> Here is the list of fixes from previous 0.5.6 release: > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > > > > > > > >>version=12350068>> > > > > >> > > > > >> Please test and review so we can do a release soon > > > > >> > > > > >> Regards, > > > > >> > > > > >> Hervé > > > > >> > > > > >> > > > > >> > > > > >> > > > > > >> - > > > > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > >- > > > > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > >For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Sławomir Jaranowski
Re: reviewing Maven Wrapper before releasing
because it's as it was imported: https://github.com/takari/maven-wrapper/blob/master/pom.xml#L21 I refactored but kept everything as equivalent as possible we can update the value if it has an interest, with associated Jira issue Regards, Hervé Le mercredi 8 décembre 2021, 19:14:55 CET Slawomir Jaranowski a écrit : > Next question: > > - why use java 5 in maven-wrapper module .. it is not possible build with > java > 8 [1] > > [1] > https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-wrapper/job/ma > ster/ > śr., 8 gru 2021 o 19:05 Hervé BOUTEMY napisał(a): > > Le mercredi 8 décembre 2021, 15:52:46 CET Robert Scholte a écrit : > > > With mvn verify -Prun-its all ITs fail on my system. This should work > > > out-of-the-box, so I'll need to investigate the issue. > > > > > > And I'm pretty sure we can remove the cli package: you can't pass System > > > properties to Maven, only arguments. And they should be passed as is to > > > mvn. > > > > I must admit I don't know: I suppose that if the code is here from the > > beginning, it's for some use, it's just me who did not imagine the use > > case > > > > if everybody is confident that it's never used, no problem to remove it > > > > > IT's should confirm that. > > > > > > Robert > > > > > > -- Origineel bericht -- > > > Van: "Jason van Zyl" > > > Aan: "Maven Developers List" > > > Verzonden: 7-12-2021 14:55:32 > > > Onderwerp: Re: reviewing Maven Wrapper before releasing > > > > > > >Everything builds and it generates the wrapper for a project in a way > > > > will > > > > > >be familiar to existing users. The switch for current users should, > > > >hopefully, be painless and transparent. > > > > > > > >Nice work Robert and Hervé. I put a notice on the GitHub page for the > > > >Takari version about the impending release at Apache, and provided > > > >pointers to the new Git repository and JIRA project. > > > > > > > >jvz > > > > > > > >> On Dec 6, 2021, at 6:07 PM, Hervé BOUTEMY > > > > wrote: > > > >> Hi, > > > >> > > > >> Maven Wrapper has been donated to Apache Maven, imported to > > > >> > > > >>https://github.com/apache/maven-wrapper > > > >> > > > >> Documentation published to https://maven.apache.org/wrapper/ > > > > > >> Here is the list of fixes from previous 0.5.6 release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > > > > > >>version=12350068>> > > > >> > > > >> Please test and review so we can do a release soon > > > >> > > > >> Regards, > > > >> > > > >> Hervé > > > >> > > > >> > > > >> > > > >> > > > >> - > > > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > >- > > > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > >For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
Next question: - why use java 5 in maven-wrapper module .. it is not possible build with java > 8 [1] [1] https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-wrapper/job/master/ śr., 8 gru 2021 o 19:05 Hervé BOUTEMY napisał(a): > Le mercredi 8 décembre 2021, 15:52:46 CET Robert Scholte a écrit : > > With mvn verify -Prun-its all ITs fail on my system. This should work > > out-of-the-box, so I'll need to investigate the issue. > > > > And I'm pretty sure we can remove the cli package: you can't pass System > > properties to Maven, only arguments. And they should be passed as is to > > mvn. > I must admit I don't know: I suppose that if the code is here from the > beginning, it's for some use, it's just me who did not imagine the use case > > if everybody is confident that it's never used, no problem to remove it > > > IT's should confirm that. > > > > Robert > > > > -- Origineel bericht -- > > Van: "Jason van Zyl" > > Aan: "Maven Developers List" > > Verzonden: 7-12-2021 14:55:32 > > Onderwerp: Re: reviewing Maven Wrapper before releasing > > > > >Everything builds and it generates the wrapper for a project in a way > will > > >be familiar to existing users. The switch for current users should, > > >hopefully, be painless and transparent. > > > > > >Nice work Robert and Hervé. I put a notice on the GitHub page for the > > >Takari version about the impending release at Apache, and provided > > >pointers to the new Git repository and JIRA project. > > > > > >jvz > > > > > >> On Dec 6, 2021, at 6:07 PM, Hervé BOUTEMY > wrote: > > >> > > >> Hi, > > >> > > >> Maven Wrapper has been donated to Apache Maven, imported to > > >> > > >>https://github.com/apache/maven-wrapper > > >> > > >> Documentation published to https://maven.apache.org/wrapper/ > > >> > > >> Here is the list of fixes from previous 0.5.6 release: > > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > > >>version=12350068>> > > >> Please test and review so we can do a release soon > > >> > > >> Regards, > > >> > > >> Hervé > > >> > > >> > > >> > > >> - > > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > >- > > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > >For additional commands, e-mail: dev-h...@maven.apache.org > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Sławomir Jaranowski
Re: reviewing Maven Wrapper before releasing
Le mercredi 8 décembre 2021, 15:52:46 CET Robert Scholte a écrit : > With mvn verify -Prun-its all ITs fail on my system. This should work > out-of-the-box, so I'll need to investigate the issue. > > And I'm pretty sure we can remove the cli package: you can't pass System > properties to Maven, only arguments. And they should be passed as is to > mvn. I must admit I don't know: I suppose that if the code is here from the beginning, it's for some use, it's just me who did not imagine the use case if everybody is confident that it's never used, no problem to remove it > IT's should confirm that. > > Robert > > -- Origineel bericht -- > Van: "Jason van Zyl" > Aan: "Maven Developers List" > Verzonden: 7-12-2021 14:55:32 > Onderwerp: Re: reviewing Maven Wrapper before releasing > > >Everything builds and it generates the wrapper for a project in a way will > >be familiar to existing users. The switch for current users should, > >hopefully, be painless and transparent. > > > >Nice work Robert and Hervé. I put a notice on the GitHub page for the > >Takari version about the impending release at Apache, and provided > >pointers to the new Git repository and JIRA project. > > > >jvz > > > >> On Dec 6, 2021, at 6:07 PM, Hervé BOUTEMY wrote: > >> > >> Hi, > >> > >> Maven Wrapper has been donated to Apache Maven, imported to > >> > >>https://github.com/apache/maven-wrapper > >> > >> Documentation published to https://maven.apache.org/wrapper/ > >> > >> Here is the list of fixes from previous 0.5.6 release: > >>https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > >>version=12350068>> > >> Please test and review so we can do a release soon > >> > >> Regards, > >> > >> Hervé > >> > >> > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > >- > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >For additional commands, e-mail: dev-h...@maven.apache.org > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
MWRAPPER-29 and MWRAPPER-30 merged: thank you Slawomir Le mercredi 8 décembre 2021, 16:07:48 CET Slawomir Jaranowski a écrit : > https://issues.apache.org/jira/browse/MWRAPPER-29 > > śr., 8 gru 2021 o 15:52 Robert Scholte napisał(a): > > With mvn verify -Prun-its all ITs fail on my system. This should work > > out-of-the-box, so I'll need to investigate the issue. > > > > And I'm pretty sure we can remove the cli package: you can't pass System > > properties to Maven, only arguments. And they should be passed as is to > > mvn. > > IT's should confirm that. > > > > Robert > > > > -- Origineel bericht -- > > Van: "Jason van Zyl" > > Aan: "Maven Developers List" > > Verzonden: 7-12-2021 14:55:32 > > Onderwerp: Re: reviewing Maven Wrapper before releasing > > > > >Everything builds and it generates the wrapper for a project in a way > > > > will be familiar to existing users. The switch for current users should, > > hopefully, be painless and transparent. > > > > >Nice work Robert and Hervé. I put a notice on the GitHub page for the > > > > Takari version about the impending release at Apache, and provided > > pointers > > to the new Git repository and JIRA project. > > > > >jvz > > > > > >> On Dec 6, 2021, at 6:07 PM, Hervé BOUTEMY > > > > wrote: > > >> Hi, > > >> > > >> Maven Wrapper has been donated to Apache Maven, imported to > > >> > > >>https://github.com/apache/maven-wrapper > > >> > > >> Documentation published to https://maven.apache.org/wrapper/ > > > > >> Here is the list of fixes from previous 0.5.6 release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721; > > version=12350068> > > >> Please test and review so we can do a release soon > > >> > > >> Regards, > > >> > > >> Hervé > > >> > > >> > > >> > > >> - > > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > >- > > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > >For additional commands, e-mail: dev-h...@maven.apache.org > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
https://issues.apache.org/jira/browse/MWRAPPER-29 śr., 8 gru 2021 o 15:52 Robert Scholte napisał(a): > With mvn verify -Prun-its all ITs fail on my system. This should work > out-of-the-box, so I'll need to investigate the issue. > > And I'm pretty sure we can remove the cli package: you can't pass System > properties to Maven, only arguments. And they should be passed as is to > mvn. > IT's should confirm that. > > Robert > > -- Origineel bericht -- > Van: "Jason van Zyl" > Aan: "Maven Developers List" > Verzonden: 7-12-2021 14:55:32 > Onderwerp: Re: reviewing Maven Wrapper before releasing > > >Everything builds and it generates the wrapper for a project in a way > will be familiar to existing users. The switch for current users should, > hopefully, be painless and transparent. > > > >Nice work Robert and Hervé. I put a notice on the GitHub page for the > Takari version about the impending release at Apache, and provided pointers > to the new Git repository and JIRA project. > > > >jvz > > > >> On Dec 6, 2021, at 6:07 PM, Hervé BOUTEMY > wrote: > >> > >> Hi, > >> > >> Maven Wrapper has been donated to Apache Maven, imported to > >>https://github.com/apache/maven-wrapper > >> > >> Documentation published to https://maven.apache.org/wrapper/ > >> > >> Here is the list of fixes from previous 0.5.6 release: > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12350068 > >> > >> > >> Please test and review so we can do a release soon > >> > >> Regards, > >> > >> Hervé > >> > >> > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> For additional commands, e-mail: dev-h...@maven.apache.org > >> > > > > > > > > > >- > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >For additional commands, e-mail: dev-h...@maven.apache.org > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Sławomir Jaranowski
Re: reviewing Maven Wrapper before releasing
With mvn verify -Prun-its all ITs fail on my system. This should work out-of-the-box, so I'll need to investigate the issue. And I'm pretty sure we can remove the cli package: you can't pass System properties to Maven, only arguments. And they should be passed as is to mvn. IT's should confirm that. Robert -- Origineel bericht -- Van: "Jason van Zyl" Aan: "Maven Developers List" Verzonden: 7-12-2021 14:55:32 Onderwerp: Re: reviewing Maven Wrapper before releasing Everything builds and it generates the wrapper for a project in a way will be familiar to existing users. The switch for current users should, hopefully, be painless and transparent. Nice work Robert and Hervé. I put a notice on the GitHub page for the Takari version about the impending release at Apache, and provided pointers to the new Git repository and JIRA project. jvz On Dec 6, 2021, at 6:07 PM, Hervé BOUTEMY wrote: Hi, Maven Wrapper has been donated to Apache Maven, imported to https://github.com/apache/maven-wrapper Documentation published to https://maven.apache.org/wrapper/ Here is the list of fixes from previous 0.5.6 release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12350068 Please test and review so we can do a release soon Regards, Hervé - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: reviewing Maven Wrapper before releasing
Everything builds and it generates the wrapper for a project in a way will be familiar to existing users. The switch for current users should, hopefully, be painless and transparent. Nice work Robert and Hervé. I put a notice on the GitHub page for the Takari version about the impending release at Apache, and provided pointers to the new Git repository and JIRA project. jvz > On Dec 6, 2021, at 6:07 PM, Hervé BOUTEMY wrote: > > Hi, > > Maven Wrapper has been donated to Apache Maven, imported to > https://github.com/apache/maven-wrapper > > Documentation published to https://maven.apache.org/wrapper/ > > Here is the list of fixes from previous 0.5.6 release: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12350068 > > > Please test and review so we can do a release soon > > Regards, > > Hervé > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
reviewing Maven Wrapper before releasing
Hi, Maven Wrapper has been donated to Apache Maven, imported to https://github.com/apache/maven-wrapper Documentation published to https://maven.apache.org/wrapper/ Here is the list of fixes from previous 0.5.6 release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12350068 Please test and review so we can do a release soon Regards, Hervé - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
