Build failed in Jenkins: mesos-reviewbot #4553

See https://builds.apache.org/job/mesos-reviewbot/4553/ -- [...truncated 5617 lines...] Removing 3rdparty/libprocess/3rdparty/Makefile Removing 3rdparty/libprocess/3rdparty/Makefile.in Removing 3rdparty/libprocess/3rdparty/gmock_sources.cc Removing

Re: Review Request 31503: (2/5) Add the FlowId action

On March 4, 2015, 10:01 p.m., Chi Zhang wrote: src/linux/routing/filter/action.hpp, line 87 https://reviews.apache.org/r/31503/diff/1-2/?file=879070#file879070line87 could be just parent and child directly. Cong Wang wrote: What is mesos preferred coding style here? I think

Re: Review Request 31897: Add a MountInfoTable for per-process mount information.

On March 10, 2015, 8:05 p.m., Timothy Chen wrote: src/linux/fs.cpp, line 83 https://reviews.apache.org/r/31897/diff/1/?file=890351#file890351line83 log error? Ian Downes wrote: As in LOG()? I added more detail to the message, following Jie's comments above, but don't think

Re: Review Request 31440: Add os::getmode() wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31440/ --- (Updated March 10, 2015, 10:23 a.m.) Review request for mesos, Dominic Hamon

Re: Review Request 31443: Accept dummy arguments for fs::mount().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31443/ --- (Updated March 10, 2015, 10:24 a.m.) Review request for mesos, Dominic Hamon

Re: Review Request 31677: stout: Make the counting of netmask set bits more efficient.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31677/#review75898 --- 3rdparty/libprocess/3rdparty/stout/tests/bits_tests.cpp

Re: Review Request 31905: Fixed protobuf comparisons by accounting for new fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31905/#review75936 --- is there a way to add tests for all of these so we don't regress

Re: Review Request 31677: stout: Make the counting of netmask set bits more efficient.

On March 10, 2015, 5:28 p.m., Dominic Hamon wrote: 3rdparty/libprocess/3rdparty/stout/tests/bits_tests.cpp, line 7 https://reviews.apache.org/r/31677/diff/4/?file=890083#file890083line7 add some pathological cases: 0, 0x +1 - Jie

Re: Review Request 31894: Move stat related functions to os/stat.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31894/#review75937 --- Ship it! Ship It! - Jie Yu On March 10, 2015, 5:22 p.m., Ian

Re: Review Request 31775: Removed Master::Flags dependency from Allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31775/#review75893 --- Ship it! src/master/allocator/mesos/allocator.hpp

Re: Review Request 31977: Fixed the race in MasterTest.MasterFailoverLongLivedExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31977/#review76218 --- Ship it! Looks like a solid fix. Is there a JIRA associated with

Re: Review Request 31473: mesos: Make fromLinkDevice method member of the IPNetwork class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31473/#review75913 --- Ship it! Ship It! - Jie Yu On March 10, 2015, 8:36 a.m.,

Review Request 31977: Fixed the race in MasterTest.MasterFailoverLongLivedExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31977/ --- Review request for mesos, Adam B and Niklas Nielsen. Repository: mesos

Re: Review Request 31977: Fixed the race in MasterTest.MasterFailoverLongLivedExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31977/ --- (Updated March 12, 2015, 7:53 a.m.) Review request for mesos, Adam B and

Review Request 31904: Fixed comparison of protobufs with optional fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31904/ --- Review request for mesos, Ben Mahler, Jie Yu, and Joerg Schad. Bugs:

Re: Review Request 31897: Add a MountInfoTable for per-process mount information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31897/#review75945 --- src/linux/fs.hpp https://reviews.apache.org/r/31897/#comment123273

Jenkins build is back to normal : mesos-reviewbot #4530

See https://builds.apache.org/job/mesos-reviewbot/4530/

Re: Review Request 31889: Updated Hooks to fix failure during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31889/ --- (Updated March 11, 2015, 3:38 p.m.) Review request for mesos, Adam B, Ben

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2525

See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2525/changes

Jenkins build is back to normal : mesos-reviewbot #4554

See https://builds.apache.org/job/mesos-reviewbot/4554/

Re: Review Request 31889: Updated Hooks to fix failure during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31889/#review76079 --- One high-level note: Let's get the long lived executor test wired

Call for MesosCon 2015 Sponsors

Hello Mesos community! We're in the process of planning MesosCon 2015 http://events.linuxfoundation.org/events/mesoscon for this August and are super thankful to our current list of sponsors: Cisco, eBay, Hubspot, Mesosphere, Twitter and VMWare. We are still looking for sponsors! if you're

Re: Review Request 31977: Fixed the race in MasterTest.MasterFailoverLongLivedExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31977/#review76222 --- Patch looks great! Reviews applied: [31977] All tests passed. -

Re: Review Request 31677: stout: Make the counting of netmask set bits more efficient.

On March 11, 2015, noon, Ben Mahler wrote: I'm curious, what prompted this change? a comment on the original version in a review that it wasn't the best way of counting bits. it seems like a generally useful thing to do. On March 11, 2015, noon, Ben Mahler wrote:

Re: Review Request 31951: Added test for long lived executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31951/#review76108 --- Ship it! src/tests/master_tests.cpp

Re: Review Request 31677: stout: Make the counting of netmask set bits more efficient.

On March 11, 2015, 7 p.m., Ben Mahler wrote: I'm curious, what prompted this change? Dominic Hamon wrote: a comment on the original version in a review that it wasn't the best way of counting bits. it seems like a generally useful thing to do. Evelina Dumitrescu wrote:

Build failed in Jenkins: mesos-reviewbot #4537

See https://builds.apache.org/job/mesos-reviewbot/4537/ -- [...truncated 5586 lines...] make[2]: Leaving directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.23.0/_build/src' Making distclean in ec2 make[2]: Entering directory

Re: Review Request 16111: Fixed the zookeeper client wrappers to use the negotiated session timeout value as their local reconnect timeout.

On Dec. 13, 2013, 12:09 a.m., Ben Mahler wrote: This is now committed! http://www.fixithere.net/ebay-customer-service/ - lissa --- This is an automatically generated e-mail. To reply, visit:

Review Request 31988: Do not have search filter input field disappear when query yields no results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31988/ --- Review request for mesos. Bugs: MESOS-2479

Build failed in Jenkins: mesos-reviewbot #4556

See https://builds.apache.org/job/mesos-reviewbot/4556/ -- [...truncated 5613 lines...] Removing .reviewboardrc Removing 3rdparty/Makefile Removing 3rdparty/Makefile.in Removing 3rdparty/libprocess/.deps/ Removing 3rdparty/libprocess/3rdparty/.deps/

Re: Review Request 31930: Introduced an http::Pipe abstraction to simplify streaming HTTP Responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31930/#review76236 --- 3rdparty/libprocess/include/process/http.hpp

Build failed in Jenkins: mesos-reviewbot #4574

See https://builds.apache.org/job/mesos-reviewbot/4574/ -- [...truncated 5600 lines...] == mesos-0.23.0 archives ready for distribution: mesos-0.23.0.tar.gz == real

Jenkins build is back to normal : mesos-reviewbot #4575

See https://builds.apache.org/job/mesos-reviewbot/4575/

Build failed in Jenkins: mesos-reviewbot #4557

See https://builds.apache.org/job/mesos-reviewbot/4557/ -- [URLTrigger] A change within the response URL invocation (log) Building remotely on ubuntu-4 (docker Ubuntu ubuntu4 ubuntu) in workspace https://builds.apache.org/job/mesos-reviewbot/ws/ git

Build failed in Jenkins: mesos-reviewbot #4558

See https://builds.apache.org/job/mesos-reviewbot/4558/ -- [...truncated 5582 lines...] rm -f watcher/*.o rm -f watcher/*.lo rm -f zookeeper/*.o rm -f zookeeper/*.lo rm -rf ./.deps authentication/.deps authentication/cram_md5/.deps authorizer/.deps

Review Request 31992: Added a TODO for readability reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31992/ --- Review request for mesos, Bernd Mathiske and Ben Mahler. Repository: mesos

Review Request 31990: Added initial readability code review/comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31990/ --- Review request for mesos, Bernd Mathiske and Ben Mahler. Repository: mesos

Re: Review Request 31988: Do not have search filter input field disappear when query yields no results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31988/#review76250 --- Patch looks great! Reviews applied: [31988] All tests passed. -

Re: Review Request 31479: Add missing deletes in stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31479/#review76252 --- Tim, is this still relevant? - Niklas Nielsen On Feb. 26, 2015,

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review76246 --- src/master/http.cpp

Jenkins build is back to normal : mesos-reviewbot #4559

See https://builds.apache.org/job/mesos-reviewbot/4559/

Re: Review Request 30546: MemIsolator: expose memory pressures for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30546/#review76245 --- src/slave/containerizer/isolators/cgroups/mem.cpp

Re: Review Request 31993: Corrected constant naming rule in the style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31993/#review76253 --- Ship it! Ship It! - Benjamin Hindman On March 12, 2015, 4:11

Re: Review Request 31276: Added cgroup memory pressure listening tests.

On March 11, 2015, 9:59 p.m., Jie Yu wrote: src/tests/memory_test_helper_child.hpp, line 42 https://reviews.apache.org/r/31276/diff/4/?file=890585#file890585line42 Do you really need this extra file? Can you move this subcommand definition to memory_test_helper.hpp? The con is

Re: Review Request 31990: Added initial readability code review/comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31990/#review76262 --- Patch looks great! Reviews applied: [31990] All tests passed. -

Review Request 31997: Cleanup waiter timers so we don't send an event to a dead waiter

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31997/ --- Review request for mesos, Ben Mahler and Joris Van Remoortere. Bugs:

Re: Review Request 31324: Updated changelog for 0.22.0

On March 12, 2015, 4:09 a.m., Adam B wrote: CHANGELOG, line 177 https://reviews.apache.org/r/31324/diff/9/?file=891845#file891845line177 Similarly, do we want to call out the new Accept(offerIds, Operation) API, or wait until DiskInfo/DynamicReservations are ready before we try

Re: Review Request 31992: Added a TODO for readability reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31992/#review76281 --- Patch looks great! Reviews applied: [31992] All tests passed. -

Review Request 32002: Add doc for slave_removal_rate_limit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32002/ --- Review request for mesos and Niklas Nielsen. Repository: mesos Description

Review Request 32001: Required a period in trailing comments in the style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32001/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 31700: Reserved memory for JSON arrays where appropriate.

On March 12, 2015, 7:27 p.m., Ben Mahler wrote: src/common/http.cpp, line 128 https://reviews.apache.org/r/31700/diff/3/?file=891730#file891730line128 Let's end all of these comments with a period. I'll take care of this before committing. Alexander Rukletsov wrote:

Re: Review Request 32001: Required a period in trailing comments in the style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32001/#review76286 --- docs/mesos-c++-style-guide.md

Re: Review Request 32002: Add doc for slave_removal_rate_limit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32002/#review76287 --- Patch looks great! Reviews applied: [32002] All tests passed. -

Jenkins build is back to normal : mesos-reviewbot #4564

See https://builds.apache.org/job/mesos-reviewbot/4564/

Re: Review Request 31977: Fixed the race in MasterTest.MasterFailoverLongLivedExecutor.

On March 12, 2015, 8:36 a.m., Adam B wrote: Looks like a solid fix. Is there a JIRA associated with this patch? I'm not sure, I searched for `MasterFailoverLongLivedExecutor` but couldn't seem to find it in JIRA. On March 12, 2015, 8:36 a.m., Adam B wrote: src/tests/master_tests.cpp,

Review Request 31993: Corrected constant naming rule in the style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31993/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Build failed in Jenkins: mesos-reviewbot #4563

See https://builds.apache.org/job/mesos-reviewbot/4563/changes Changes: [benjamin.mahler] Reserved memory for JSON arrays in the master's http endpoints. -- [...truncated 5637 lines...] rm -rf .libs _libs rm -f *.lo test -z || rm -f test . = ../../ec2

Re: Review Request 31997: Cleanup waiter timers so we don't send an event to a dead waiter

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31997/#review76278 --- Patch looks great! Reviews applied: [31997] All tests passed. -

Jenkins build is back to normal : mesos-reviewbot #4562

See https://builds.apache.org/job/mesos-reviewbot/4562/changes

Re: Review Request 31700: Reserved memory for JSON arrays where appropriate.

On March 12, 2015, 7:27 p.m., Ben Mahler wrote: src/common/http.cpp, line 128 https://reviews.apache.org/r/31700/diff/3/?file=891730#file891730line128 Let's end all of these comments with a period. I'll take care of this before committing. Thanks, Ben; I'll update the style

Re: Review Request 31276: Added cgroup memory pressure listening tests.

On March 11, 2015, 9:59 p.m., Jie Yu wrote: src/tests/memory_test_helper.cpp, line 49 https://reviews.apache.org/r/31276/diff/4/?file=890584#file890584line49 s/allocateRSSMemory/increaseRSS/ Let's remove the 'lock' parameter and assume all page will be locked. We can

Re: Review Request 31324: Updated changelog for 0.22.0

On March 11, 2015, 9:09 p.m., Adam B wrote: CHANGELOG, lines 39-40 https://reviews.apache.org/r/31324/diff/9/?file=891845#file891845line39 Where should users look for this information now? The JIRA leads me to believe '/metrics/snapshot', but we need to have a clear answer. Is

Re: Review Request 31276: Added cgroup memory pressure listening tests.

On March 11, 2015, 9:59 p.m., Jie Yu wrote: src/tests/memory_test_helper_child.hpp, line 42 https://reviews.apache.org/r/31276/diff/4/?file=890585#file890585line42 Do you really need this extra file? Can you move this subcommand definition to memory_test_helper.hpp? Chi Zhang

Re: Review Request 31324: Updated changelog for 0.22.0

On March 11, 2015, 9:09 p.m., Adam B wrote: CHANGELOG, line 176 https://reviews.apache.org/r/31324/diff/9/?file=891845#file891845line176 Are we leaving DiskInfo (Persistent Volumes) in silent mode as well, presumably due to a few missing pieces? That is my understanding. On

Re: Review Request 31997: Cleanup waiter timers so we don't send an event to a dead waiter

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31997/#review76266 --- 3rdparty/libprocess/src/process.cpp

Re: Review Request 31992: Added a TODO for readability reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31992/#review76271 --- * Braces: placed on separate line for class / struct / function

Re: Review Request 31324: Updated changelog for 0.22.0

On March 11, 2015, 9:09 p.m., Adam B wrote: CHANGELOG, line 177 https://reviews.apache.org/r/31324/diff/9/?file=891845#file891845line177 Similarly, do we want to call out the new Accept(offerIds, Operation) API, or wait until DiskInfo/DynamicReservations are ready before we try

Build failed in Jenkins: mesos-reviewbot #4561

See https://builds.apache.org/job/mesos-reviewbot/4561/ -- Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change [URLTrigger] A change within the response URL invocation (log) [URLTrigger] A change within the

Re: Review Request 31988: Do not have search filter input field disappear when query yields no results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31988/#review76270 --- I'd love to help land this for you. Would you mind describing how

Re: Review Request 31992: Added a TODO for readability reviews.

On March 12, 2015, 6:53 p.m., Ben Mahler wrote: * Braces: placed on separate line for class / struct / function definitions. Same line otherwise. Do we want to tackle higher level style here that is currently missing from the style guide? * Use Try / Result to describe

Re: Review Request 31700: Reserved memory for JSON arrays where appropriate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31700/#review76276 --- Ship it! Thanks Alex! Let's look at using std::move as well if

Re: Review Request 31276: Added cgroup memory pressure listening tests.

On March 11, 2015, 9:59 p.m., Jie Yu wrote: src/tests/memory_test_helper.cpp, line 96 https://reviews.apache.org/r/31276/diff/4/?file=890584#file890584line96 Hum, this makes the page cache increasing depend on the memory allocation. Can we simply construct a 4K buffer on the

Re: Review Request 31997: Cleanup waiter timers so we don't send an event to a dead waiter

On March 12, 2015, 6:29 p.m., Dominic Hamon wrote: 3rdparty/libprocess/src/process.cpp, line 2875 https://reviews.apache.org/r/31997/diff/1/?file=892303#file892303line2875 CHECK_SOME(timer)? Added, Should be impossible to get there without timer being set because of libprocess

Re: Review Request 31776: Moved allocator to public headers.

On March 10, 2015, 9:09 p.m., Niklas Nielsen wrote: src/local/local.hpp, lines 26-46 https://reviews.apache.org/r/31776/diff/2/?file=886202#file886202line26 Can we include the allocator and master header instead? Let's include allocator header and leave fwd decl master to keep

Re: Review Request 31905: Fixed protobuf comparisons by accounting for new fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31905/#review76311 --- Ship it! Ship It! src/common/type_utils.cpp

Review Request 32008: Use LDADD to add unbundled libraries to all command line programs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32008/ --- Review request for mesos, Niklas Nielsen and Timothy St. Clair. Bugs:

Re: Review Request 32002: Add doc for slave_removal_rate_limit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32002/#review76315 --- Ship it! Ship It! - Vinod Kone On March 12, 2015, 8:42 p.m.,

Re: Review Request 32008: Use LDADD to add unbundled libraries to all command line programs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32008/#review76316 --- Patch looks great! Reviews applied: [32008] All tests passed. -

Re: Review Request 32001: Required a period in trailing comments in the style guide.

On March 12, 2015, 9:20 p.m., Ben Mahler wrote: docs/mesos-c++-style-guide.md, line 30 https://reviews.apache.org/r/32001/diff/1/?file=892420#file892420line30 Hm, isn't this captured by ending each sentence with a period above? Yes and no. Trailing comments are not always sentences

Re: Review Request 32001: Required a period in trailing comments in the style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32001/#review76293 --- Patch looks great! Reviews applied: [32001] All tests passed. -

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

On Feb. 27, 2015, 7:35 p.m., Jay Buffington wrote: src/slave/containerizer/mesos/launch.cpp, line 218 https://reviews.apache.org/r/31444/diff/1/?file=876502#file876502line218 This is pretty invasive. Jie suggested doing a private bind mount of flags.chroot.get() in

Re: Review Request 32001: Required a period in trailing comments in the style guide.

On March 12, 2015, 9:20 p.m., Ben Mahler wrote: docs/mesos-c++-style-guide.md, line 30 https://reviews.apache.org/r/32001/diff/1/?file=892420#file892420line30 Hm, isn't this captured by ending each sentence with a period above? Alexander Rukletsov wrote: Yes and no. Trailing

Re: Review Request 31905: Fixed protobuf comparisons by accounting for new fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31905/ --- (Updated March 12, 2015, 11:20 p.m.) Review request for mesos, Ben Mahler, Jie

Re: Review Request 31905: Fixed protobuf comparisons by accounting for new fields.

On March 11, 2015, 6:01 p.m., Jie Yu wrote: src/common/type_utils.cpp, lines 145-160 https://reviews.apache.org/r/31905/diff/2/?file=890906#file890906line145 Looks like we have the same logic for many repeated fields here. I am wondering if we can have a helper function:

Re: Review Request 31905: Fixed protobuf comparisons by accounting for new fields.

On March 10, 2015, 6:40 p.m., Zameer Manji wrote: src/common/type_utils.cpp, line 56 https://reviews.apache.org/r/31905/diff/1/?file=890459#file890459line56 Would it be possible to add some sort of test or tooling to prevent regressions? Vinod Kone wrote: Not sure, what

Re: Review Request 31775: Removed Master::Flags dependency from Allocator.

On March 10, 2015, 9:09 p.m., Niklas Nielsen wrote: src/master/allocator/mesos/allocator.hpp, line 46 https://reviews.apache.org/r/31775/diff/1/?file=886126#file886126line46 Let's move to JIRA It already exists: https://issues.apache.org/jira/browse/MESOS-2285. - Alexander

Re: Review Request 31905: Fixed protobuf comparisons by accounting for new fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31905/#review76310 --- Patch looks great! Reviews applied: [31904, 31905] All tests

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

On Feb. 28, 2015, 9:03 a.m., Jay Buffington wrote: src/slave/containerizer/mesos/launch.cpp, line 262 https://reviews.apache.org/r/31444/diff/1/?file=876502#file876502line262 I was curious how you came up with this list. I did man MAKEDEV and read this:

Re: Review Request 32001: Required a period in trailing comments in the style guide.

On March 12, 2015, 9:20 p.m., Ben Mahler wrote: docs/mesos-c++-style-guide.md, line 30 https://reviews.apache.org/r/32001/diff/1/?file=892420#file892420line30 Hm, isn't this captured by ending each sentence with a period above? Alexander Rukletsov wrote: Yes and no. Trailing

Re: Review Request 31905: Fixed protobuf comparisons by accounting for new fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31905/#review76321 --- Ship it! Ship It! - Jie Yu On March 12, 2015, 11:20 p.m., Vinod

Re: Review Request 31930: Introduced an http::Pipe abstraction to simplify streaming HTTP Responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31930/#review76268 --- 3rdparty/libprocess/include/process/http.hpp

Re: Review Request 30774: Fetcher Cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review75754 --- include/mesos/fetcher/fetcher.proto

Re: Requesting ability to contribute for issue MESOS-2479

Added you as a contributor. Thanks for finding and fixing the bug! You should ask around IRC/dev@ for a Shepherd (reviewer) for your fix. On Wed, Mar 11, 2015 at 3:48 PM, Joseph Lee joe.lee.three.thous...@gmail.com wrote: Greetings! I just filed

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2531

See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2531/changes