Re: Review Request 30112: Added ::protobuf::write - ::protobuf::read round-trip test for RepeatedPtrField.

2015-01-23 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30112/ --- (Updated Jan. 23, 2015, 6:15 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 30112: Added ::protobuf::write - ::protobuf::read round-trip test for RepeatedPtrField.

2015-01-23 Thread Michael Park
On Jan. 23, 2015, 6:04 p.m., Jie Yu wrote: src/tests/protobuf_io_tests.cpp, line 157 https://reviews.apache.org/r/30112/diff/3/?file=828922#file828922line157 No need for this temp variable. s/read/actual But this is up to you:) I do have `read =

Re: Review Request 30112: Added ::protobuf::write - ::protobuf::read round-trip test for RepeatedPtrField.

2015-01-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30112/#review69421 --- Ship it! src/tests/protobuf_io_tests.cpp

Re: Review Request 30112: Added ::protobuf::write - ::protobuf::read round-trip test for RepeatedPtrField.

2015-01-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30112/#review69507 --- Patch looks great! Reviews applied: [30143, 30109, 30110, 30143,

Re: Review Request 30112: Added ::protobuf::write - ::protobuf::read round-trip test for RepeatedPtrField.

2015-01-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30112/#review68989 --- src/tests/protobuf_io_tests.cpp

Re: Review Request 30112: Added ::protobuf::write - ::protobuf::read round-trip test for RepeatedPtrField.

2015-01-21 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30112/ --- (Updated Jan. 21, 2015, 10:08 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 30112: Added ::protobuf::write - ::protobuf::read round-trip test for RepeatedPtrField.

2015-01-21 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30112/ --- (Updated Jan. 21, 2015, 10:32 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 30112: Added ::protobuf::write - ::protobuf::read round-trip test for RepeatedPtrField.

2015-01-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30112/#review69057 --- Patch looks great! Reviews applied: [30111, 30110, 30112] All

Re: Review Request 30112: Added ::protobuf::write - ::protobuf::read round-trip test for RepeatedPtrField.

2015-01-21 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30112/ --- (Updated Jan. 21, 2015, 10:23 a.m.) Review request for mesos, Ben Mahler and

Review Request 30112: Added ::protobuf::write - ::protobuf::read round-trip test for RepeatedPtrField.

2015-01-21 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30112/ --- Review request for mesos. Repository: mesos-git Description --- Added

Re: Review Request 30112: Added ::protobuf::write - ::protobuf::read round-trip test for RepeatedPtrField.

2015-01-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30112/#review68911 --- Patch looks great! Reviews applied: [30111, 30110, 30112] All