Re: Review Request 30580: Updated the graceful shutdown documentation and naming.

2015-02-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30580/#review71975 --- Ship it! Ship It! - Alexander Rukletsov On Feb. 4, 2015, 2:14

Re: Review Request 30580: Updated the graceful shutdown documentation and naming.

2015-02-10 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30580/#review71855 --- Ship it! Ship It! - Niklas Nielsen On Feb. 3, 2015, 6:14 p.m.,

Re: Review Request 30580: Updated the graceful shutdown documentation and naming.

2015-02-09 Thread Ben Mahler
On Feb. 4, 2015, 11:55 p.m., Niklas Nielsen wrote: src/slave/flags.hpp, lines 133-136 https://reviews.apache.org/r/30580/diff/1/?file=846974#file846974line133 Could we include that this is the inner most, first and/or the effective grace period (taken that we have a hierarchy of

Re: Review Request 30580: Updated the graceful shutdown documentation and naming.

2015-02-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30580/#review71694 --- Ship it! Ship It! - Vinod Kone On Feb. 4, 2015, 2:14 a.m., Ben

Re: Review Request 30580: Updated the graceful shutdown documentation and naming.

2015-02-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30580/#review71493 --- src/exec/exec.cpp

Re: Review Request 30580: Updated the graceful shutdown documentation and naming.

2015-02-08 Thread Ben Mahler
On Feb. 6, 2015, 8:44 p.m., Vinod Kone wrote: src/exec/exec.cpp, line 736 https://reviews.apache.org/r/30580/diff/1/?file=846971#file846971line736 mention that you are using the default value? I tackled these in my subsequent patches already, this initial patch was just a code

Re: Review Request 30580: Updated the graceful shutdown documentation and naming.

2015-02-05 Thread Alexander Rukletsov
On Feb. 4, 2015, 11:47 a.m., Alexander Rukletsov wrote: Ben, I like the refactor you've done. A special thanks goes for updating comments for clarity and brevity. Below are my 2¢ on naming. In general, the naming of executors and executor drivers in our codebase is a bit ambiguous.

Re: Review Request 30580: Updated the graceful shutdown documentation and naming.

2015-02-05 Thread Ben Mahler
On Feb. 4, 2015, 11:55 p.m., Niklas Nielsen wrote: src/slave/graceful_shutdown.cpp, line 64 https://reviews.apache.org/r/30580/diff/1/?file=846976#file846976line64 Maybe this should be a Try in the future :) One step at a time.. :) First thing is we need a check in place for the

Re: Review Request 30580: Updated the graceful shutdown documentation and naming.

2015-02-04 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30580/#review71060 --- src/slave/flags.hpp

Re: Review Request 30580: Updated the graceful shutdown documentation and naming.

2015-02-04 Thread Ben Mahler
On Feb. 4, 2015, 11:47 a.m., Alexander Rukletsov wrote: Ben, I like the refactor you've done. A special thanks goes for updating comments for clarity and brevity. Below are my 2¢ on naming. In general, the naming of executors and executor drivers in our codebase is a bit ambiguous.

Re: Review Request 30580: Updated the graceful shutdown documentation and naming.

2015-02-04 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30580/#review70949 --- Ben, I like the refactor you've done. A special thanks goes for

Review Request 30580: Updated the graceful shutdown documentation and naming.

2015-02-03 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30580/ --- Review request for mesos, Alexander Rukletsov, Niklas Nielsen, and Vinod Kone.