/
Testing
---
make check
Thanks,
Michael Park
6b4489276d9f72f3bd99066bf7e48dba5ebe537e
src/tests/hierarchical_allocator_tests.cpp
f44d9e98d6d9db9621f5361cddb6134f90277180
src/tests/resources_tests.cpp 4744e872b082553046ecc0e344403754ee685842
Diff: https://reviews.apache.org/r/30654/diff/
Testing
---
make check.
Thanks,
Michael Park
/30361/#review70066
---
On Feb. 5, 2015, 12:58 a.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30361
On Feb. 4, 2015, 1:36 a.m., switched to 'mcypark' wrote:
src/tests/master_tests.cpp, line 2880
https://reviews.apache.org/r/29727/diff/3/?file=846895#file846895line2880
style nit: should be indented 4 spaces here
Sorry for the mess regarding switched to 'mcypark' above, I messed up
., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29742/
---
(Updated Jan. 29, 2015, 5:27 a.m.)
Review request
Hello,
TL;DR: There has been a few review comments suggesting to shadow variable
names in order to avoid the leading/trailing underscore in the name. In
general, this only leads to stupid bugs that waste developers' time, we can
eliminate these bugs and also the need to reevaluate if the names of
://reviews.apache.org/r/29736/diff/
Testing
---
make check
Thanks,
Michael Park
://reviews.apache.org/r/29736/diff/
Testing
---
make check
Thanks,
Michael Park
68f64213c47be4700bcb22cd5b76ba6ff616960d
Diff: https://reviews.apache.org/r/28698/diff/
Testing
---
make check
Thanks,
Michael Park
/#comment115329
Just wondering, how come the braces were removed for the `default` case?
- Michael Park
On Jan. 29, 2015, 7:03 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30386/
---
(Updated Jan. 29, 2015, 12:12 a.m.)
Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
Repository: mesos-git
Description
On Jan. 29, 2015, 5:50 p.m., Alexander Rukletsov wrote:
src/master/contender.cpp, line 82
https://reviews.apache.org/r/30395/diff/1/?file=839643#file839643line82
You can safely omit trailing underscores.
In this case, yes that is true. This topic has come up before and perhaps it's
src/tests/master_allocator_tests.cpp 2430622d09c7ef1e020e2eb8f97444e7efc7c8ea
Diff: https://reviews.apache.org/r/28775/diff/
Testing
---
Thanks,
Michael Park
---
Implemented logic to handle dynamic reservation operations in Master::_accept.
Diffs
-
src/master/master.cpp ab6d1d17367f199191b7c77bccec73ec3b112d4f
Diff: https://reviews.apache.org/r/30361/diff/
Testing
---
Thanks,
Michael Park
: mesos-git
Description
---
Implemented logic to handle dynamic reservation operations in Master::_accept.
Diffs
-
src/master/master.cpp ab6d1d17367f199191b7c77bccec73ec3b112d4f
Diff: https://reviews.apache.org/r/30361/diff/
Testing
---
Thanks,
Michael Park
)
---
make check
Thanks,
Michael Park
3b57568c10233a0c692787de6464f21af5eaadf4
src/common/resources.cpp 68f64213c47be4700bcb22cd5b76ba6ff616960d
Diff: https://reviews.apache.org/r/29742/diff/
Testing
---
make check
Thanks,
Michael Park
68f64213c47be4700bcb22cd5b76ba6ff616960d
Diff: https://reviews.apache.org/r/29742/diff/
Testing
---
make check
Thanks,
Michael Park
68f64213c47be4700bcb22cd5b76ba6ff616960d
Diff: https://reviews.apache.org/r/28698/diff/
Testing
---
make check
Thanks,
Michael Park
: https://reviews.apache.org/r/29748/diff/
Testing
---
make check
Thanks,
Michael Park
/master.cpp ab6d1d17367f199191b7c77bccec73ec3b112d4f
src/tests/master_allocator_tests.cpp 2430622d09c7ef1e020e2eb8f97444e7efc7c8ea
Diff: https://reviews.apache.org/r/28775/diff/
Testing
---
Thanks,
Michael Park
src/tests/master_allocator_tests.cpp 2430622d09c7ef1e020e2eb8f97444e7efc7c8ea
Diff: https://reviews.apache.org/r/28775/diff/
Testing
---
Thanks,
Michael Park
Hindman, Ben Mahler, Jie Yu, and
Vinod Kone.
Repository: mesos-git
Description
---
See summary.
Diffs
-
src/tests/master_allocator_tests.cpp 2430622d09c7ef1e020e2eb8f97444e7efc7c8ea
Diff: https://reviews.apache.org/r/29748/diff/
Testing
---
make check
Thanks,
Michael
68f64213c47be4700bcb22cd5b76ba6ff616960d
src/tests/resources_tests.cpp 9fd2135a7545268e2f81915ed0a019de36f3d6e1
Diff: https://reviews.apache.org/r/29736/diff/
Testing (updated)
---
make check
Thanks,
Michael Park
9fd2135a7545268e2f81915ed0a019de36f3d6e1
Diff: https://reviews.apache.org/r/29736/diff/
Testing
---
make check
Thanks,
Michael Park
: mesos-git
Description
---
Implemented logic to handle dynamic reservation operations in Master::_accept.
Diffs
-
src/master/master.cpp ab6d1d17367f199191b7c77bccec73ec3b112d4f
Diff: https://reviews.apache.org/r/30361/diff/
Testing
---
Thanks,
Michael Park
: mesos-git
Description
---
Implemented logic to handle dynamic reservation operations in Master::_accept.
Diffs
-
src/master/master.cpp ab6d1d17367f199191b7c77bccec73ec3b112d4f
Diff: https://reviews.apache.org/r/30361/diff/
Testing
---
Thanks,
Michael Park
., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28775/
---
(Updated Jan. 28, 2015, 8:34 p.m.)
Review request
src/tests/master_allocator_tests.cpp 2430622d09c7ef1e020e2eb8f97444e7efc7c8ea
Diff: https://reviews.apache.org/r/28775/diff/
Testing
---
make check
Thanks,
Michael Park
ab6d1d17367f199191b7c77bccec73ec3b112d4f
src/tests/master_allocator_tests.cpp 2430622d09c7ef1e020e2eb8f97444e7efc7c8ea
src/tests/resource_offers_tests.cpp ffad1f8a2348a772c4e76859844b724018e4629c
Diff: https://reviews.apache.org/r/28775/diff/
Testing
---
make check
Thanks,
Michael Park
On Dec. 19, 2014, 2:05 a.m., Adam B wrote:
src/common/resources.cpp, line 492
https://reviews.apache.org/r/28698/diff/2/?file=793362#file793362line492
Is CHECK appropriate here, or should we instead return a TryResources?
Michael Park wrote:
I think returning a `TryResources
68f64213c47be4700bcb22cd5b76ba6ff616960d
Diff: https://reviews.apache.org/r/29742/diff/
Testing
---
make check
Thanks,
Michael Park
,
Michael Park
68f64213c47be4700bcb22cd5b76ba6ff616960d
Diff: https://reviews.apache.org/r/29742/diff/
Testing
---
make check
Thanks,
Michael Park
68f64213c47be4700bcb22cd5b76ba6ff616960d
Diff: https://reviews.apache.org/r/28698/diff/
Testing
---
make check
Thanks,
Michael Park
: mesos-git
Description
---
Implemented logic to handle dynamic reservation operations in Master::_accept.
Diffs
-
src/master/master.cpp ab6d1d17367f199191b7c77bccec73ec3b112d4f
Diff: https://reviews.apache.org/r/30361/diff/
Testing
---
make check
Thanks,
Michael Park
,
Michael Park
54f26900ac8c63e79a1f89562a988c9a2567d209
src/tests/master_allocator_tests.cpp ff025fa0f21a2409db0aaedd60333967d42162d5
src/tests/resource_offers_tests.cpp ec86e3dca7348c8e0f47c1ff032257f7dda0ca7a
Diff: https://reviews.apache.org/r/28775/diff/
Testing
---
make check
Thanks,
Michael Park
`, `reservation_type`. This is used to test
the success of dynamic reservations for example.
Diffs (updated)
-
src/tests/mesos.hpp 17c2d8f0cb6326b08fc506143e823ee2c3a32e09
Diff: https://reviews.apache.org/r/29737/diff/
Testing
---
make check
Thanks,
Michael Park
://reviews.apache.org/r/29736/diff/
Testing
---
make check
Thanks,
Michael Park
/29737/diff/
Testing
---
make check
Thanks,
Michael Park
to support dynamic reservations.
Diffs
-
include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
Diff: https://reviews.apache.org/r/28697/diff/
Testing
---
make check
Thanks,
Michael Park
54f26900ac8c63e79a1f89562a988c9a2567d209
src/tests/resource_offers_tests.cpp ec86e3dca7348c8e0f47c1ff032257f7dda0ca7a
Diff: https://reviews.apache.org/r/28775/diff/
Testing
---
make check
Thanks,
Michael Park
54f26900ac8c63e79a1f89562a988c9a2567d209
src/tests/master_allocator_tests.cpp ff025fa0f21a2409db0aaedd60333967d42162d5
src/tests/resource_offers_tests.cpp ec86e3dca7348c8e0f47c1ff032257f7dda0ca7a
Diff: https://reviews.apache.org/r/28775/diff/
Testing
---
make check
Thanks,
Michael Park
src/tests/resource_offers_tests.cpp ec86e3dca7348c8e0f47c1ff032257f7dda0ca7a
Diff: https://reviews.apache.org/r/28775/diff/
Testing
---
make check
Thanks,
Michael Park
54f26900ac8c63e79a1f89562a988c9a2567d209
src/tests/resource_offers_tests.cpp ec86e3dca7348c8e0f47c1ff032257f7dda0ca7a
Diff: https://reviews.apache.org/r/28775/diff/
Testing
---
make check
Thanks,
Michael Park
/diff/
Testing
---
make check
Thanks,
Michael Park
src/master/master.cpp 54f26900ac8c63e79a1f89562a988c9a2567d209
src/tests/resource_offers_tests.cpp ec86e3dca7348c8e0f47c1ff032257f7dda0ca7a
Diff: https://reviews.apache.org/r/28775/diff/
Testing
---
make check
Thanks,
Michael Park
/
Testing
---
make check
Thanks,
Michael Park
Hindman, Ben Mahler, Jie Yu, and
Vinod Kone.
Repository: mesos-git
Description
---
See summary.
Diffs
-
src/common/resources.cpp 68f64213c47be4700bcb22cd5b76ba6ff616960d
Diff: https://reviews.apache.org/r/29856/diff/
Testing
---
make check
Thanks,
Michael Park
/diff/
Testing
---
make check
Thanks,
Michael Park
/
Testing
---
make check
Thanks,
Michael Park
src/tests/master_allocator_tests.cpp 2430622d09c7ef1e020e2eb8f97444e7efc7c8ea
Diff: https://reviews.apache.org/r/28775/diff/
Testing (updated)
---
make check
Thanks,
Michael Park
src/tests/master_allocator_tests.cpp 2430622d09c7ef1e020e2eb8f97444e7efc7c8ea
Diff: https://reviews.apache.org/r/28775/diff/
Testing
---
Thanks,
Michael Park
,
Michael Park
/#comment114743
We should have a `allocator-updateAllocation` call somewhere in here.
- Michael Park
On Jan. 27, 2015, 11:02 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
On Jan. 27, 2015, 11:05 p.m., Jie Yu wrote:
src/master/master.cpp, line 2909
https://reviews.apache.org/r/28781/diff/3/?file=837178#file837178line2909
I guess here I need to consider dynamic reservation as well. It's
likely that the resources has already been persisted since it's
/
Testing
---
make check
Thanks,
Michael Park
.
- Michael
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29918/#review69435
---
On Jan. 24, 2015, 1:21 a.m., Michael Park wrote
---
make check
Thanks,
Michael Park
On Jan. 23, 2015, 7:16 a.m., Michael Park wrote:
include/mesos/resources.hpp, lines 160-161
https://reviews.apache.org/r/30131/diff/1/?file=828568#file828568line160
Rather than taking a template type `F`, we can take a `bool
(*predicate)(const Resource)` or `const lambda
On Jan. 5, 2015, 10:47 p.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/url.hpp, lines 70-71
https://reviews.apache.org/r/29533/diff/1/?file=805385#file805385line70
Shouldn't this be an output stream operator instead of stringify? (e.g.
Duration / Bytes).
---
On Jan. 23, 2015, 6:15 p.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30112
On Jan. 23, 2015, 6 p.m., Jie Yu wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, lines 156-157
https://reviews.apache.org/r/30111/diff/5/?file=828992#file828992line156
Move this comments to the public read interface.
Michael Park wrote:
I'm not sure why
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30111/#review69417
---
On Jan. 23, 2015, 6:45 p.m., Michael Park wrote
/
Testing
---
make check
Thanks,
Michael Park
/
Testing
---
make check
Thanks,
Michael Park
/slave_recovery_tests.cpp 809822e63b05a21418cd9297c927d656d6fd871d
Diff: https://reviews.apache.org/r/29918/diff/
Testing
---
make check
Thanks,
Michael Park
/
Testing
---
make check
Thanks,
Michael Park
7935e7f9bfe66d1900594dcdcb800c4593a3940f
src/common/resources.cpp 214e441fb86aa0c094c28ed5801089051468137b
Diff: https://reviews.apache.org/r/29742/diff/
Testing
---
make check
Thanks,
Michael Park
?
- Michael Park
On Jan. 21, 2015, 6:12 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30131/
---
(Updated Jan. 21
Diff: https://reviews.apache.org/r/29913/diff/
Testing
---
make check
Thanks,
Michael Park
On Jan. 23, 2015, 6:52 a.m., Michael Park wrote:
Looks good overall to me, a few minor comments.
One question: did you not like the generalized logic of `result -= source;
result += target;`?
I'm asking so that I know whether I should generalize it when I go to implement
the dynamic
input.
- Michael Park
On Jan. 22, 2015, 11:20 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30130
/state.cpp a36fa53099300ee03f051b0f5eaaafe9f1da68d1
src/tests/slave_recovery_tests.cpp 809822e63b05a21418cd9297c927d656d6fd871d
Diff: https://reviews.apache.org/r/29918/diff/
Testing
---
make check
Thanks,
Michael Park
---
make check
Thanks,
Michael Park
```?
Michael Park wrote:
Probably a good idea. I'm not sure if I should just update this patch or
make a pass at the codebase since I see this pattern all over from a quick
grep. What do you think?
Jie Yu wrote:
Yeah, please follow up with a patch to get those corrected. Maybe create
/#comment113592
`s/values/messages/`?
- Michael Park
On Jan. 20, 2015, 6:49 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29974
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29973/#review69022
---
LGTM.
- Michael Park
On Jan. 20, 2015, 6:49 p.m., Jie Yu wrote
4d304fe42fce749ffdf65f1c2412f2a01172c4e6
3rdparty/libprocess/src/tests/subprocess_tests.cpp
c2c9a5e47d37b5a3ac4b3326bde0548b5d0cbb29
Diff: https://reviews.apache.org/r/30144/diff/
Testing
---
make check
Thanks,
Michael Park
3033b7d857592c89fdb7cd2d702eb0c74e7d5647
Diff: https://reviews.apache.org/r/30143/diff/
Testing (updated)
---
make check
Thanks,
Michael Park
/diff/
Testing
---
Thanks,
Michael Park
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30129/#review69048
---
LGTM.
- Michael Park
On Jan. 21, 2015, 6:09 p.m., Jie Yu wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29975/#review69024
---
LGTM.
- Michael Park
On Jan. 20, 2015, 6:49 p.m., Jie Yu wrote
---
make check
Thanks,
Michael Park
:
https://reviews.apache.org/r/30109/#review68948
---
On Jan. 21, 2015, 10:18 a.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
src/slave/state.cpp a36fa53099300ee03f051b0f5eaaafe9f1da68d1
src/tests/slave_recovery_tests.cpp 809822e63b05a21418cd9297c927d656d6fd871d
Diff: https://reviews.apache.org/r/29918/diff/
Testing
---
make check
Thanks,
Michael Park
/
Testing
---
make check
Thanks,
Michael Park
/
Testing
---
make check
Thanks,
Michael Park
4fe3f22915cbc11df3f4424e3bd8acaf45509e19
Diff: https://reviews.apache.org/r/30109/diff/
Testing
---
make check
Thanks,
Michael Park
/
Testing
---
make check
Thanks,
Michael Park
/
Testing
---
make check
Thanks,
Michael Park
---
make check
Thanks,
Michael Park
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29918/#review69076
---
On Jan. 21, 2015, 10:08 p.m., Michael Park wrote
/slave_recovery_tests.cpp 809822e63b05a21418cd9297c927d656d6fd871d
Diff: https://reviews.apache.org/r/29918/diff/
Testing
---
make check
Thanks,
Michael Park
/protobuf.hpp
b4f5f172d0ea21fbd56dde1eb43d95f9cddad44b
Diff: https://reviews.apache.org/r/30110/diff/
Testing
---
make check
Thanks,
Michael Park
Description
---
Added support for `RepeatedPtrField` to `::protobuf::write`.
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp
ff494c3da35a44ada703fa3997d89b4237495ef9
Diff: https://reviews.apache.org/r/30110/diff/
Testing
---
make check
Thanks,
Michael Park
/slave/state.cpp a36fa53099300ee03f051b0f5eaaafe9f1da68d1
src/tests/slave_recovery_tests.cpp 809822e63b05a21418cd9297c927d656d6fd871d
Diff: https://reviews.apache.org/r/29918/diff/
Testing
---
make check
Thanks,
Michael Park
Thanks,
Michael Park
/#comment113423
`template` implies `inline`.
- Michael Park
On Jan. 20, 2015, 6:49 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29974
501 - 600 of 837 matches
Mail list logo
