Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/656
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/620#discussion_r129431043
--- Diff:
metron-interface/metron-alerts/src/app/service/elasticsearch-localstorage-impl.ts
---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/656
+1 Thanks, @nickwallen , looks great!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user BlackHatJohnDoe commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r129420943
--- Diff:
metron-maven-archetypes/metron-maven-parser-extension-archetype/src/main/resources/archetype-resources/metron-parser-__parserName__/README.md
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/620
@iraghumitra I really like what you've done. There is a ton of
functionality here and it works great. I did not find any functional problems
beyond what you've already called out. I think we
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/669
METRON-1064: Make init script OS-agnostic
## Contributor Comments
This PR makes the init scripts for metron-rest and metron-config
OS-agnostic by:
- moving the metron env file to
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/620
Ran a license check on all dependencies, including transitive.
```
$ npm -g license-checker
$ cd metron-interface/metron-alerts
$ license-checker | grep licenses | sort | uniq
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/620#discussion_r129347174
--- Diff: metron-interface/metron-alerts/README.md ---
@@ -0,0 +1,80 @@
+- [Caveats](#caveats)
+- [Prerequisites](#prerequisites)
+-
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/620#discussion_r129382584
--- Diff:
metron-interface/metron-alerts/e2e/alerts-list/alerts-list.e2e-spec.ts ---
@@ -0,0 +1,119 @@
+///
--- End diff --
We are
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/650#discussion_r129375098
--- Diff: metron-stellar/stellar-common/README.md ---
@@ -581,6 +634,24 @@ In the core language functions, we support basic
functional programming
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/650#discussion_r129384031
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/math/MathOperation.java
---
@@ -0,0 +1,39 @@
+/*
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/650#discussion_r129375196
--- Diff: metron-stellar/stellar-common/README.md ---
@@ -581,6 +634,24 @@ In the core language functions, we support basic
functional programming
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/650#discussion_r129379794
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/math/StellarMathFunction.java
---
@@ -0,0 +1,64 @@
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/650#discussion_r129374680
--- Diff: metron-stellar/stellar-common/README.md ---
@@ -238,6 +249,18 @@ In the core language functions, we support basic
functional programming
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/650#discussion_r129375260
--- Diff: metron-stellar/stellar-common/README.md ---
@@ -613,6 +684,12 @@ In the core language functions, we support basic
functional programming
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/650#discussion_r129384644
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/MathFunctionsTest.java
---
@@ -38,10 +46,156 @@ public
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/650#discussion_r129374250
--- Diff: metron-stellar/stellar-common/README.md ---
@@ -110,6 +110,8 @@ In the core language functions, we support basic
functional programming
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/650#discussion_r129374210
--- Diff: metron-stellar/stellar-common/README.md ---
@@ -110,6 +110,8 @@ In the core language functions, we support basic
functional programming
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/650#discussion_r129378858
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/math/MathOperations.java
---
@@ -0,0 +1,66 @@
+/*
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/622#discussion_r129370546
--- Diff:
metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/hbase/DecodableRowKeyBuilder.java
---
@@ -0,0 +1,402 @@
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/622
@cestella ,
> Would this approach require scans on read in the critical path?
I don't perceive that decoding rowkeys is on any critical path. You only
need to look up Profile by
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/655
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/622
@nickwallen brought up the issue of wildcard queries on our rowkeys. It
has always bothered me that we can't do wildcard queries on groups. If you
have, for example, a single groupBy based on
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/659
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kylerichardson commented on the issue:
https://github.com/apache/metron/pull/659
+1, thanks for taking this on
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/622
@mattf-horton Would this approach require scans on read in the critical
path?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/622
@cestella , tl;dr: The discussion of serial numbers is a distraction.
Let's just use the profileHash and forget the serial number. It was a
micro-optimization.
Answer to your
Github user BlackHatJohnDoe commented on a diff in the pull request:
https://github.com/apache/metron/pull/620#discussion_r129361903
--- Diff: metron-interface/metron-alerts/scripts/start-dev.sh ---
@@ -0,0 +1,19 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/622
@mattf-horton Wouldn't you have to use the serial number to retrieve
profiles?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/664
Please resolve conflicts in this PR, then we should be on track to commit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/663
@dbist please be sure to take care of the jira
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/622#discussion_r129356740
--- Diff:
metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/hbase/DecodableRowKeyBuilder.java
---
@@ -0,0 +1,382 @@
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/622#discussion_r129356631
--- Diff:
metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/hbase/DecodableRowKeyBuilder.java
---
@@ -0,0 +1,402 @@
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/663
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/622
@cestella , we would not need to keep an index resident in memory. Most of
the time we would just have the active Profiles in memory, exactly as we do
today. You only need to retrieve the
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/620
It seems the end-to-end tests are failing for me. This is what I did to
run them. The README is not totally clear to me on how these should be run.
1. `cd
Github user simonellistonball commented on a diff in the pull request:
https://github.com/apache/metron/pull/643#discussion_r129352107
--- Diff:
metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/nonbulk/taxii/TaxiiLoader.java
---
@@ -165,6 +167,19
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/663
+1, Thanks for the contribution
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user BlackHatJohnDoe commented on the issue:
https://github.com/apache/metron/pull/620
When doing an `npm install` I got:
```
node-pre-gyp info check checked for
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/620
Thanks @iraghumitra . That fixed the build. Will continue taking a look
at it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/577
Can I +1 this a second time?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/659
+1, I think this will help cut down what we are seeing on the user list.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/607
Hey @ottobackwards, list has been on my todo list for a while. I'll spin
it up today or tomorrow. Sorry for the delay.
---
If your project is set up for it, you can reply to this email and have
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/655
+1 by inspection
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/659
Merged in @kylerichardson 's changes. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/620
@nickwallen I fixed the build issue. Looks like the package-lock.json
didn't do its job I will check it.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/667
Oh ProfilerIntegrationTest you've done it again!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user ottobackwards reopened a pull request:
https://github.com/apache/metron/pull/667
METRON-1061 Add FUZZY_SCORE STELLAR function
[Apache Commons Text
GitHub user dbist opened a pull request:
https://github.com/apache/metron/pull/668
Metron 1063 address javadoc warnings in metron-stellar
## Contributor Comments
[Please place any comments here. A description of the problem/enhancement,
how to reproduce the issue, your testing
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/622#discussion_r129319336
--- Diff:
metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/hbase/DecodableRowKeyBuilder.java
---
@@ -0,0 +1,402 @@
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/622#discussion_r129318110
--- Diff:
metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/hbase/DecodableRowKeyBuilder.java
---
@@ -0,0 +1,382 @@
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/622#discussion_r129309663
--- Diff:
metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/hbase/SaltyRowKeyBuilder.java
---
@@ -81,20 +99,19 @@ public
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/665#discussion_r129308721
--- Diff:
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/bolt/GenericEnrichmentBolt.java
---
@@ -179,6 +180,7 @@ public void
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/622#discussion_r129306225
--- Diff:
metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/hbase/DecodableRowKeyBuilder.java
---
@@ -0,0 +1,402 @@
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/642
@cestella are we still OK with this? I'd like to get it in
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron/pull/667
METRON-1061 Add FUZZY_SCORE STELLAR function
[Apache Commons Text
Github user simonellistonball commented on the issue:
https://github.com/apache/metron/pull/650
I would like it to be committed to make it much easier for me to port my PR
to it so +1 (non-binding)
---
If your project is set up for it, you can reply to this email and have your
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/451
Hey @Ravi0204 you might have better luck sending an email to the Metron
user@ list with that question. This PR is closed and the range of people
paying attention to it is constrained.
---
If
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/665#discussion_r129279181
--- Diff:
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/bolt/GenericEnrichmentBolt.java
---
@@ -179,6 +180,7 @@ public
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/635
I'm +1 by inspection. Thanks for the contribution, it's really nice to not
have the potential source of error from these being different.
---
If your project is set up for it, you can reply to
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/649
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/650
Any comments or review here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/652
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/622#discussion_r129252984
--- Diff:
metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/hbase/DecodableRowKeyBuilder.java
---
@@ -0,0 +1,402 @@
+/*
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/622#discussion_r129252678
--- Diff:
metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/hbase/DecodableRowKeyBuilder.java
---
@@ -0,0 +1,402 @@
+/*
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/622#discussion_r129252112
--- Diff:
metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/hbase/DecodableRowKeyBuilder.java
---
@@ -0,0 +1,402 @@
+/*
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/656#discussion_r129232374
--- Diff: metron-analytics/metron-profiler/README.md ---
@@ -275,27 +280,105 @@ The Profiler runs as an independent Storm topology.
The configuration
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/656#discussion_r129232188
--- Diff: metron-analytics/metron-profiler/README.md ---
@@ -275,27 +280,105 @@ The Profiler runs as an independent Storm topology.
The configuration
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/656#discussion_r129229395
--- Diff: metron-analytics/metron-profiler/README.md ---
@@ -129,23 +129,28 @@ This section will describe the steps required to get
your first "Hello,
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/656#discussion_r129219973
--- Diff: metron-analytics/metron-profiler/README.md ---
@@ -17,7 +17,7 @@ Any field contained within a message can be used to
generate a profile. A
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/656#discussion_r129220852
--- Diff: metron-analytics/metron-profiler/README.md ---
@@ -83,9 +83,9 @@ At this point the Profiler is running and consuming
telemetry messages. We
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/656#discussion_r129230420
--- Diff: metron-analytics/metron-profiler/README.md ---
@@ -275,27 +280,105 @@ The Profiler runs as an independent Storm topology.
The configuration
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/656#discussion_r129230326
--- Diff: metron-analytics/metron-profiler/README.md ---
@@ -129,23 +129,28 @@ This section will describe the steps required to get
your first "Hello,
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/622#discussion_r129227588
--- Diff:
metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/hbase/DecodableRowKeyBuilder.java
---
@@ -0,0 +1,402 @@
74 matches
Mail list logo
