Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/718
+1, thanks for the contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/718
Ok, I updated the docs with a summary of what we talked about and some
discussion of gotchas. Hope that is sufficient; if not, let me know.
---
If your project is set up for it, you can reply to
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/718
ok, I'm +1 pending the doc change. Thanks for explaining.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/718
@ottobackwards Definitely there should and I'll make it as part of this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/718
Currently you cannot have two statements in stellar field transformations
with the same variable, so
```
{
"transformation" : "STELLAR"
,"output" : [ "better_title", "title"]
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/718
Ok, I think I see the point of confusion. Here's the issue; in every other
place where we use stellar (i.e. enrichments) assignment to null implies a
variable removal. In field transformations,
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/718
Ok, the question here is this. I have 3 statements in the transform
{
"title" : "casey is stellar"
}
{
"transformation" : "STELLAR"
,"output" : [
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/718
if(outputs.contains(oField)) {
ret.put(oField, o);
}
if( o != null ) {
intermediateVariables.put(oField, o);
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/718
So, the problem with the old way was that it's confusing and just wrong.
Perhaps an example would help here. For the message
```
{
"title" : "otto is great"
}
```
If I
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/718
Would it not be better to have different transformers to specify the
behavior here? What is here is correct, but what if the old behavior was fine?
What if they don't want the fields
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/667#discussion_r135336896
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/TextFunctionsTest.java
---
@@ -0,0 +1,103 @@
+/**
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/667#discussion_r135336880
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/TextFunctionsTest.java
---
@@ -0,0 +1,103 @@
+/**
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/667#discussion_r135336803
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/TextFunctions.java
---
@@ -0,0 +1,114 @@
+/**
+
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/667#discussion_r135336818
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/TextFunctionsTest.java
---
@@ -0,0 +1,103 @@
+/**
Does anyone else have any comments? I would like to get the ball rolling
on this, maybe this weekend.
On August 23, 2017 at 14:28:57, Nick Allen (n...@nickallen.org) wrote:
I propose that we go forward with our first feature branch without
guideline changes up-front. We can use this as a
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/717
#post-777
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/717
METRON-1134: Allow parser command line options to be specified in the
zookeeper parser config.
## Contributor Comments
It would be useful to maintain sensible defaults for various properties
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/709#discussion_r135279804
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/status_params.py
---
@@
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/709#discussion_r135279546
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/params_linux.py
---
@@
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/709#discussion_r135279244
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/themes/metron_theme.json
---
@@ -214,6 +214,73
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/709#discussion_r135264143
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/params_linux.py
---
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/667#discussion_r135263000
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/TextFunctions.java
---
@@ -0,0 +1,63 @@
+/**
+ *
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/667#discussion_r135262339
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/TextFunctionsTest.java
---
@@ -0,0 +1,103 @@
+/**
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/667#discussion_r135262378
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/TextFunctionsTest.java
---
@@ -0,0 +1,103 @@
+/**
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/667#discussion_r135262450
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/TextFunctionsTest.java
---
@@ -0,0 +1,103 @@
+/**
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/667#discussion_r135262542
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/TextFunctionsTest.java
---
@@ -0,0 +1,103 @@
+/**
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/667#discussion_r135256040
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/TextFunctions.java
---
@@ -0,0 +1,114 @@
+/**
+ *
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/709#discussion_r135262154
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/params_linux.py
---
@@
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/709#discussion_r135261317
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/status_params.py
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/709#discussion_r135261379
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/params_linux.py
---
@@
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/709#discussion_r135259877
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/status_params.py
---
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/709#discussion_r135258100
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-profiler-env.xml
---
@@
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/709#discussion_r135256865
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/params_linux.py
---
@@
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/709#discussion_r135256262
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/params_linux.py
---
@@
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/715
@ottobackwards no apology necessary, man :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/715
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/709#discussion_r135255635
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/status_params.py
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/667#discussion_r135246886
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/TextFunctions.java
---
@@ -0,0 +1,63 @@
+/**
+
38 matches
Mail list logo
