[GitHub] metron pull request #811: METRON-1272: Hide child alerts from searches and g...

Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/811#discussion_r146715818 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDao.java --- @@ -295,19 +341,199

[GitHub] metron pull request #811: METRON-1272: Hide child alerts from searches and g...

Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/811#discussion_r146712417 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/files/bro_index.template --- @@

[GitHub] metron pull request #811: METRON-1272: Hide child alerts from searches and g...

Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/811#discussion_r146712573 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java --- @@ -174,21 +175,34 @@

[GitHub] metron issue #811: METRON-1272: Hide child alerts from searches and grouping...

Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/811 Thanks @justinleet . This is working well with @iraghumitra UI work in #803. The metalerts show-up in the left-side "Filters" panel, which provides a decent short-cut to retrieve the

[GitHub] metron pull request #813: METRON-1274: Master has failure in StormController...

Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/813 ---

[GitHub] metron issue #796: METRON-1224: Add time range selection to search control

Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/796 This issue is still not fixed: - The first is related to time-range selections that include 'Now' as part of the range (Last 7 days, Last 5 minutes, Today so far, etc). This should be a

[GitHub] metron issue #687: METRON-1090 Add Assignment to Stellar Language

Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/687 @cestella ---

[GitHub] metron issue #687: METRON-1090 Add Assignment to Stellar Language

Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/687 It is fair to say that this PR is more for conceptual review than anything else. ---

[GitHub] metron issue #687: METRON-1090 Add Assignment to Stellar Language

Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/687 should be set @JonZeolla ---

[GitHub] metron issue #690: METRON-1091 Package STELLAR shell as stand alone

Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/690 Hopefully it is all set @JonZeolla ---

Re: [DISCUSS] Release Process Update

The release wouldn’t have been made if the build didn’t succeed. And the Release Manager doesn’t need one more fiddly manual edit to do. I recommend the Release Process instructions be put back, and instead we incorporate https://github.com/apache/metron/pull/815 Rational in

[GitHub] metron pull request #815: METRON-1278 Strip "Build Status" widget from root ...

GitHub user mattf-horton opened a pull request: https://github.com/apache/metron/pull/815 METRON-1278 Strip "Build Status" widget from root README.md in site-book build ## Contributor Comments See https://issues.apache.org/jira/browse/METRON-1278 ## Pull Request

[GitHub] metron pull request #813: METRON-1274: Master has failure in StormController...

Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/813 ---

[GitHub] metron pull request #813: METRON-1274: Master has failure in StormController...

GitHub user merrimanr reopened a pull request: https://github.com/apache/metron/pull/813 METRON-1274: Master has failure in StormControllerIntegrationTest ## Contributor Comments This PR fixes an intermittently failing integration test. I believe the root cause is the test is

[GitHub] metron pull request #814: METRON-1277 Add match statement to Stellar languag...

GitHub user ottobackwards opened a pull request: https://github.com/apache/metron/pull/814 METRON-1277 Add match statement to Stellar language as discussed on the dev list: [Stellar support for switch/case style

[GitHub] metron pull request #813: METRON-1274: Master has failure in StormController...

GitHub user merrimanr reopened a pull request: https://github.com/apache/metron/pull/813 METRON-1274: Master has failure in StormControllerIntegrationTest ## Contributor Comments This PR fixes an intermittently failing integration test. I believe the root cause is the test is

[GitHub] metron pull request #813: METRON-1274: Master has failure in StormController...

Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/813 ---

Re: Stellar support for switch/case style conditionals

Sorry my examples where so lambda heavy, I did that support first, because LambdaExpression is ‘special’, as you know Casey. On October 24, 2017 at 11:30:33, Casey Stella (ceste...@gmail.com) wrote: So, I do like it. My only issue is the explicit lambda syntax in the values there (e.g. foo ==

[GitHub] metron issue #796: METRON-1224: Add time range selection to search control

Github user james-sirota commented on the issue: https://github.com/apache/metron/pull/796 @iraghumitra looks like everything has been addressed. I am +1 on my side, but lets have @merrimanr chime in ---

Re: Stellar support for switch/case style conditionals

@Test @SuppressWarnings("unchecked") public void testShortCircut() { Assert.assertEquals("ok", run("match{ foo > 100 : THROW('oops'), foo > 200 : THROW('oh no'), default : 'ok' }", new HashMap() {{ put("foo", 50); }})); } On October 24, 2017 at 11:59:31, Otto

Re: Stellar support for switch/case style conditionals

I will also add explicit tests for proving non-execution of non-matching clauses ;) On October 24, 2017 at 11:52:25, Otto Fowler (ottobackwa...@gmail.com) wrote: I did implement short circuiting. I am going to submit, with the additional outstanding issue that using the MAP() function in the

Re: Stellar support for switch/case style conditionals

Gotcha. Yes, that makes perfect sense. -Kyle On Tue, Oct 24, 2017 at 11:39 AM, Casey Stella wrote: > Right. My point is that you never want the values of the match statement > to be evaluated prior to evaluating the match (otherwise you cannot short > circuit them).

Re: Stellar support for switch/case style conditionals

I did implement short circuiting. I am going to submit, with the additional outstanding issue that using the MAP() function in the evaluation is broken. I may need some help with that. I fear that it may be do to my syntax, which may work for other cases, but is still not fundamentally correct,

Re: Stellar support for switch/case style conditionals

Right. My point is that you never want the values of the match statement to be evaluated prior to evaluating the match (otherwise you cannot short circuit them). Consider the following: match {foo == 0 : CHEAP_FUNC(), foo != 0 : EXPENSIVE_FUNC() } you don't want CHEAP_FUNC() AND

Re: Stellar support for switch/case style conditionals

I guess I read it as supporting both. As a user, I certainly would prefer to use the less explicit syntax ( e.g. match { foo == 0: true, bar == 1: false, default: false } ). -Kyle On Tue, Oct 24, 2017 at 11:30 AM, Casey Stella wrote: > So, I do like it. My only issue is

Re: Stellar support for switch/case style conditionals

I like the way you have this laid out. Very useful to see it in test cases. I'm +1 for this syntax addition. -Kyle On Mon, Oct 23, 2017 at 4:16 PM, Otto Fowler wrote: > What I would like to do for the first PR is introduce match with the > following syntax > > > match{

[GitHub] metron pull request #813: METRON-1274: Master has failure in StormController...

GitHub user merrimanr reopened a pull request: https://github.com/apache/metron/pull/813 METRON-1274: Master has failure in StormControllerIntegrationTest ## Contributor Comments This PR fixes an intermittently failing integration test. I believe the root cause is the test is

[GitHub] metron pull request #813: METRON-1274: Master has failure in StormController...

Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/813 ---

[GitHub] metron issue #811: METRON-1272: Hide child alerts from searches and grouping...

Github user justinleet commented on the issue: https://github.com/apache/metron/pull/811 @nickwallen It's not a perfect solution, but I added the "source:type" field for consistency and to allow for filtering and retrieval of just meta alerts in an obvious way. Should just be

[GitHub] metron pull request #813: METRON-1274: Master has failure in StormController...

Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/813 ---

[GitHub] metron pull request #813: METRON-1274: Master has failure in StormController...

GitHub user merrimanr reopened a pull request: https://github.com/apache/metron/pull/813 METRON-1274: Master has failure in StormControllerIntegrationTest ## Contributor Comments This PR fixes an intermittently failing integration test. I believe the root cause is the test is

[GitHub] metron issue #813: METRON-1274: Master has failure in StormControllerIntegra...

Github user cestella commented on the issue: https://github.com/apache/metron/pull/813 Awesome work, @merrimanr Have this get through 5 runs in travis and I'm +1. ---

[GitHub] metron pull request #813: METRON-1274: Master has failure in StormController...

Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/813 ---

[GitHub] metron pull request #813: METRON-1274: Master has failure in StormController...

GitHub user merrimanr reopened a pull request: https://github.com/apache/metron/pull/813 METRON-1274: Master has failure in StormControllerIntegrationTest ## Contributor Comments This PR fixes an intermittently failing integration test. I believe the root cause is the test is

[GitHub] metron issue #796: METRON-1224: Add time range selection to search control

Github user iraghumitra commented on the issue: https://github.com/apache/metron/pull/796 @merrimanr @james-sirota There was a bug in handling the recent searches that were in old format can you check it now. Sorry for the trouble ---

Re: [DISCUSS] Release Process Update

Hmm, I kind of like it as a historical validation/confirmation of build success, but I can see where you are coming from. Here is the wiki diff, feel free to critique/alter. Jon On Tue, Oct 24, 2017 at

Re: [DISCUSS] Release Process Update

+1 I agree with Matt and Justin. The Travis build widget doesn't make sense in the published release documentation. No sense in fixing retrospectively. -Kyle On Mon, Oct 23, 2017 at 3:13 PM Matt Foley wrote: > I agree with Justin. This micro-feature is intended as a