[GitHub] metron issue #831: METRON-1302: Split up Indexing Topology into batch and ra...

2017-11-09 Thread mraliagha
Github user mraliagha commented on the issue: https://github.com/apache/metron/pull/831 That sounds great. We had a huge headache to find good tuning parameters for "indexing" topology. ---

[GitHub] metron issue #840: METRON-939: Upgrade ElasticSearch and Kibana

2017-11-09 Thread mraliagha
Github user mraliagha commented on the issue: https://github.com/apache/metron/pull/840 It might not be completely related to this PR, but since _timestamp is removed in ES 5.x, can we add a specific time of indexing at indexing bolt to capture time of indexing. It is useful for the

[GitHub] metron issue #824: METRON-1289: Alert fields are lost when a MetaAlert is cr...

2017-11-09 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/824 The 2nd most recent commits updates the MetaAlertDao interface by adding additional methods for interacting with metaalerts. This should make it easier to use and make the underlying

[GitHub] metron pull request #774: METRON-1212 The bundle system and maven plugin

2017-11-09 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/774#discussion_r150106587 --- Diff: bundles-maven-plugin/README.md --- @@ -0,0 +1,230 @@ + +# Apache Metron Bundle Maven Plugin + +Apache Metron Bundles Maven

[GitHub] metron pull request #774: METRON-1212 The bundle system and maven plugin

2017-11-09 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/774#discussion_r150092533 --- Diff: bundles-maven-plugin/README.md --- @@ -0,0 +1,230 @@ + +# Apache Metron Bundle Maven Plugin + +Apache Metron Bundles Maven

[GitHub] metron pull request #838: METRON-1310 "Template Delete" Action Deletes Searc...

2017-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/838 ---

[GitHub] metron pull request #837: METRON-1309: Change metron-deployment to pull the ...

2017-11-09 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/837#discussion_r150056693 --- Diff: metron-deployment/other-examples/manual-install/Manual_Install_CentOS6.md --- @@ -638,15 +638,15 @@ Edit crontab with `# crontab -e` and add:

[GitHub] metron issue #838: METRON-1310 "Template Delete" Action Deletes Search Indic...

2017-11-09 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/838 yeesh, good catch @nickwallen +1 by inspection. ---

[GitHub] metron pull request #838: METRON-1310 "Template Delete" Action Deletes Searc...

2017-11-09 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/838#discussion_r150038381 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/params_linux.py ---

[GitHub] metron pull request #838: METRON-1310 "Template Delete" Action Deletes Searc...

2017-11-09 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/838 METRON-1310 "Template Delete" Action Deletes Search Indices The "Elasticsearch Template Delete" action within the Indexing service in Ambari, actually deletes the search indices. Per the name

[GitHub] metron pull request #838: METRON-1310 "Template Delete" Action Deletes Searc...

2017-11-09 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/838#discussion_r150038546 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_master.py --- @@

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-11-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/774 Bringing over this from #530, https://github.com/apache/nifi/commit/d90cf846b9dcd49acdeac7bb5fcd13ee80dcdba6#diff-83e1afb34470ca47809f82aa1caf2138 is the commit in nifi for

[GitHub] metron issue #827: METRON-1294: IP addresses are not formatted correctly in ...

2017-11-09 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/827 I submitted a PR against branch that adds a specific test case in the integration tests for this defect. I validated that this test fails in master, but passes with your fix. Feel free to

[GitHub] metron issue #824: METRON-1289: Alert fields are lost when a MetaAlert is cr...

2017-11-09 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/824 No problem. I am still actively working on this PR and will add the HBaseDao.findAllLatest implementation task to my list. ---

[GitHub] metron issue #824: METRON-1289: Alert fields are lost when a MetaAlert is cr...

2017-11-09 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/824 I agree with @justinleet. I think this is well within the scope of this PR since you're introducing a new method at an interface level. In that situation, we should have either a default

[GitHub] metron issue #824: METRON-1289: Alert fields are lost when a MetaAlert is cr...

2017-11-09 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/824 @merrimanr For the findAllLatest, can we add a default implementation to the interface that would cover HBase (i.e. just do a for loop lookup), even if it's not efficient. Otherwise, it should

[GitHub] metron pull request #774: METRON-1212 The bundle system and maven plugin

2017-11-09 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/774#discussion_r150003217 --- Diff: bundles-maven-plugin/README.md --- @@ -0,0 +1,230 @@ + +# Apache Metron Bundle Maven Plugin + +Apache Metron Bundles Maven

[GitHub] metron pull request #774: METRON-1212 The bundle system and maven plugin

2017-11-09 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/774#discussion_r150002599 --- Diff: bundles-maven-plugin/README.md --- @@ -0,0 +1,230 @@ + +# Apache Metron Bundle Maven Plugin + +Apache Metron Bundles Maven

[GitHub] metron pull request #774: METRON-1212 The bundle system and maven plugin

2017-11-09 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/774#discussion_r15166 --- Diff: bundles-maven-plugin/README.md --- @@ -0,0 +1,230 @@ + +# Apache Metron Bundle Maven Plugin + +Apache Metron Bundles Maven

[GitHub] metron pull request #774: METRON-1212 The bundle system and maven plugin

2017-11-09 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/774#discussion_r14458 --- Diff: bundles-maven-plugin/README.md --- @@ -0,0 +1,230 @@ + +# Apache Metron Bundle Maven Plugin + +Apache Metron Bundles Maven

[GitHub] metron pull request #774: METRON-1212 The bundle system and maven plugin

2017-11-09 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/774#discussion_r149994944 --- Diff: bundles-maven-plugin/README.md --- @@ -0,0 +1,230 @@ + +# Apache Metron Bundle Maven Plugin + +Apache Metron Bundles Maven

[GitHub] metron pull request #837: METRON-1309: Change metron-deployment to pull the ...

2017-11-09 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/837#discussion_r149994245 --- Diff: metron-deployment/other-examples/manual-install/Manual_Install_CentOS6.md --- @@ -638,15 +638,15 @@ Edit crontab with `# crontab -e` and

[GitHub] metron pull request #774: METRON-1212 The bundle system and maven plugin

2017-11-09 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/774#discussion_r149993579 --- Diff: bundles-maven-plugin/README.md --- @@ -0,0 +1,230 @@ + +# Apache Metron Bundle Maven Plugin + +Apache Metron Bundles Maven

[GitHub] metron pull request #774: METRON-1212 The bundle system and maven plugin

2017-11-09 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/774#discussion_r149989360 --- Diff: bundles-maven-plugin/README.md --- @@ -0,0 +1,230 @@ + +# Apache Metron Bundle Maven Plugin + +Apache Metron Bundles Maven

[GitHub] metron pull request #774: METRON-1212 The bundle system and maven plugin

2017-11-09 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/774#discussion_r149985390 --- Diff: bundles-maven-plugin/README.md --- @@ -0,0 +1,230 @@ + +# Apache Metron Bundle Maven Plugin + +Apache Metron Bundles Maven

[GitHub] metron issue #810: METRON-1270 fix for warnings missing @return tag argument...

2017-11-09 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/810 @dbist Looks like this did get merged in (commit cf404f77d16daca5692f6197575bcc56c58fc2a9), but the PR is still open. I don't see anything wrong with the commit. Can you just close this PR

[GitHub] metron issue #812: METRON-1273: Website documentation link should point to t...

2017-11-09 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/812 +1 @JonZeolla You should be good to go, if you're still going to be the one to push it through. ---

[GitHub] metron issue #837: METRON-1309: Change metron-deployment to pull the plugin ...

2017-11-09 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/837 This is ready for review. ---

Re: Committing to the metron-bro-plugin-kafka repo

2017-11-09 Thread zeo...@gmail.com
Whups, here is a correctly updated roadmap. Also, the METRON-1309 PR is out and I've completed my testing so it's ready for review: 1. *DONE* - Move the bro-plugin-kafka to its own repository (Prereq to METRON-813). 2. *PR OPEN* - Update metron-deployment to pull the plugin from