Github user cestella commented on the issue:
https://github.com/apache/metron/pull/797
and by downstream, I mean in whatever UI we have.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/797
So, I did think about this and decided to include it. It is an index in ES
with data. If we think it should be filtered, I can certainly do so, but
thought the decision really should be best done
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/813
Awesome work, @merrimanr Have this get through 5 runs in travis and I'm +1.
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/813#discussion_r146276684
--- Diff:
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/StormControllerIntegrationTest.java
---
@@ -187,9 +187,9 @@ public
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/813
Could you also add an `assertEventually` to
`SensorParserConfigControllerIntegrationTest.test:294` ? Looks like it also
failed in https://travis-ci.org/apache/metron/builds/290806887
Also
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/810
+1 by inspection
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/804
+1 by inspection, great job here.
---
Github user cestella closed the pull request at:
https://github.com/apache/metron/pull/797
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/795
Alright, changes included. Did I miss anything @nickwallen ?
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/795#discussion_r146031435
--- Diff:
metron-platform/metron-zookeeper/src/main/java/org/apache/metron/zookeeper/ZKCache.java
---
@@ -0,0 +1,141 @@
+/**
+ * Licensed
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/795#discussion_r146020712
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/zookeeper/configurations/IndexingUpdater.java
---
@@ -0,0 +1,88
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/795#discussion_r146020428
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/zookeeper/configurations/ProfilerUpdater.java
---
@@ -0,0 +1,114
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/795
Alright, great reviews. I think I have reacted to the comments; let me
know if I missed anything.
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/795#discussion_r146012465
--- Diff:
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/StormControllerIntegrationTest.java
---
@@ -179,6 +181,8 @@ public
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/796
I definitely like the testing section @merrimanr I'd like to see the test
in existence in the PR split into the test cases that you suggest. Testing
those time range quicklinks turn into sensible
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/805
As usual, I really love your test scripts. Well done, @JonZeolla !
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/785#discussion_r145423853
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/util/ParserIndex.java
---
@@ -0,0 +1,92 @@
+/**
+ * Licensed
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/800
can you kick travis, @JonZeolla ? I think it ran at a weird time and the
test failure is due to that. We should look into what caused that.
---
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/801
METRON-1254: Conditionals as map keys do not function in Stellar
## Contributor Comments
We currently cannot represent map literals in stellar where the keys are
conditionals. For instance
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/682
Sorry otto, I didn't see that comment, I'll admit. I apologize. Let me
take a look at them and if there's further notices work to do, I'll make a
follow-on PR. Again, sorry, ignoring your
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/794
+1 by inspection. Sorry this slipped through the cracks!
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/799#discussion_r144896412
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/enrichment_commands.py
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/682
+1 by inspection
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/799
Really, what I'd like to see is a status on the parsers in the management
UI that indicates that those parsers should be running all the time and a REST
call to validate that they are running
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/799
Yes, that's right. In my opinion, though, we should probably stop managing
parsers in ambari and just focus on the management UI to have one place to
manage all parsers.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/799
I really like this. Modulo a couple of very minor nits, I'm +1 by
inspection.
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/799#discussion_r144868387
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/metron_service.py
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/798
+1 by inspection, good job!
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/795
Looks ok. I also ran it in my personal travis and the tests stabilized
with the latest commit.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/797
# Testing Plan
## Basic Functionality
* Ensure you can retrieve the elasticsearch indices set up in Metron and
they include the default sensors:
`curl -u user:password -X GET
GitHub user cestella reopened a pull request:
https://github.com/apache/metron/pull/795
METRON-1241: Enable the REST API to use a cache for the zookeeper config
similar to the Bolts
## Contributor Comments
Currently, our bolts use a TreeCache to capture and update internal
Github user cestella closed the pull request at:
https://github.com/apache/metron/pull/795
---
GitHub user cestella reopened a pull request:
https://github.com/apache/metron/pull/795
METRON-1241: Enable the REST API to use a cache for the zookeeper config
similar to the Bolts
## Contributor Comments
Currently, our bolts use a TreeCache to capture and update internal
Github user cestella closed the pull request at:
https://github.com/apache/metron/pull/795
---
Github user cestella closed the pull request at:
https://github.com/apache/metron/pull/795
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/795
I'm going to close and reopen this a few times to see if the instability in
the tests are worked out.
---
GitHub user cestella reopened a pull request:
https://github.com/apache/metron/pull/795
METRON-1241: Enable the REST API to use a cache for the zookeeper config
similar to the Bolts
## Contributor Comments
Currently, our bolts use a TreeCache to capture and update internal
Github user cestella closed the pull request at:
https://github.com/apache/metron/pull/795
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/793
I'm +1 by inspection but will hold it until @mmiklavc gives his.
---
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/797
METRON-1243: Add a REST endpoint which allows us to get a list of all
indices
## Contributor Comments
The Alerts UI currently hard-codes the set of indices. It would be
preferred to use
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/795
TESTING PLAN
# Preliminaries
Setup some environment variables for convenience:
* `export METRON_HOME=/usr/metron/0.4.1`
* `export ZOOKEEPER=node1:2181`
* `export
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/795
METRON-1241: Enable the REST API to use a cache for the zookeeper config
similar to the Bolts
## Contributor Comments
Currently, our bolts use a TreeCache to capture and update internal state
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/785#discussion_r143555806
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/MergeAndShadeTransformer.java
---
@@ -0,0 +1,90
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/785#discussion_r143555784
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/MergeAndShadeTransformer.java
---
@@ -0,0 +1,90
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/785#discussion_r143555770
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/MergeAndShadeTransformer.java
---
@@ -0,0 +1,90
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/785#discussion_r143555004
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/ParserTopologyCLI.java
---
@@ -285,7 +285,14 @@ public static
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/785#discussion_r143554494
--- Diff: metron-interface/metron-rest/src/main/scripts/metron-rest.sh ---
@@ -47,6 +55,15 @@ rest_jar_pattern="${METRON_HOME}/lib/metron-rest
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/785#discussion_r143554015
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/MergeAndShadeTransformer.java
---
@@ -0,0 +1,90
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/785#discussion_r143553954
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/ParserTopologyCLI.java
---
@@ -285,7 +285,14 @@ public static
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/785#discussion_r143552937
--- Diff: metron-interface/metron-rest/pom.xml ---
@@ -163,6 +163,7 @@
org.apache.metron
metron-parsers
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/793#discussion_r143473906
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/utils/ElasticsearchUtils.java
---
@@ -45,15 +49,30 @@ public
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/793#discussion_r143473489
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java
---
@@ -154,9 +134,9 @@ protected
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/793
cool, just making sure :)
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/793
Does this cause any issues in the alerts UI?
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/790
+1 by inspection. Great catch and thanks for the contribution!
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/791#discussion_r143059336
--- Diff: metron-platform/metron-enrichment/README.md ---
@@ -25,9 +25,26 @@ defined by JSON documents stored in zookeeper.
There are two types
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/791#discussion_r143058876
--- Diff: metron-platform/metron-enrichment/README.md ---
@@ -25,9 +25,26 @@ defined by JSON documents stored in zookeeper.
There are two types
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/791#discussion_r143058984
--- Diff: metron-platform/metron-enrichment/README.md ---
@@ -25,9 +25,26 @@ defined by JSON documents stored in zookeeper.
There are two types
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/791
Thanks @justinleet I added and provided some color; let me know what you
think!
---
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/791
METRON-1235: Document the properties pulled from the global configuration
## Contributor Comments
Our global config is very flexible and multiple parts of the system pull
configuration from
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/780
Three things IMO:
1. Could we add a link to the documentation you have from the front page
README.md under the heading "Notes on Adding a New Sensor"
2. Could we also
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/785
The only real change here is the addition of a Transformer that hooks into
Storm's `storm jar` command and will merge the dependent jars. This was done
so that we could avoid touching the Parser
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/785
METRON-1230: As a stopgap prior to METRON-777, add more simplistic
sideloading of custom Parsers
## Contributor Comments
Until we get METRON-777 in, it'd be nice to have a simple ability using
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/783
+1 this has been pissing me off for days
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/737
+1 by inspection. This looks good to me. Great job!
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r142672128
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -35,7 +36,7
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/779
+1, great job
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r142471360
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -35,7 +36,7
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/737
Wait, I'm confused, the current behavior is to default to the storm config.
Why did you pull that into the SensorParserConfig?
The issue with what you've done here is that when you save
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r142407343
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -35,7 +36,7
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/772
It does not and should not. If that's what you're seeing, @nickwallen
then it's a bug and I should fix it.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/780
Also, should be linked from metron-parsers makes sense IMO as any time you
are adding a new sensor, you're going to need to add this field. This is the
use-case that keeps biting us in the butt
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/780
Honestly, I think it should at the very least be linked from the
documentation which tells people how to create their own parsers...which we do
not seem to have. ;)
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/737
So, I do believe the default values for num workers and ackers should be
taken from the storm config if unspecified by us. Providing defaults when
storm already has defaults for these properties
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/771
+1 by inspection, great job @merrimanr
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r142147088
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -45,4 +45,14 @@ private HttpStatus
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/772
Oh, sorry, forgot to respond here @ottobackwards You can test it by passing
in a log4j properties (let's say something that turns on DEBUG logging) file
via -l and ensure that the REPL shows debug
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r141991874
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -45,4 +45,14 @@ private HttpStatus
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r141971685
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -45,4 +45,14 @@ private HttpStatus
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r141971177
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -45,4 +45,14 @@ private HttpStatus
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/681
me too, +1
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/681
Yeah, I'm ok with that.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/781
Let me write up a step-by-step use-case doc and I'll call this one done.
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/781#discussion_r141944809
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/hashing/TLSHHasher.java
---
@@ -0,0 +1,203
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/781#discussion_r141933534
--- Diff: metron-stellar/stellar-common/pom.xml ---
@@ -51,6 +52,11 @@
--- End diff --
Yep, added
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/781#discussion_r141931953
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/hashing/TLSHHasher.java
---
@@ -0,0 +1,203
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/781
METRON-1052:
## Contributor Comments
This is a follow-on to METRON-539. Currently we have Stellar functions to
perform cryptographic hashing operations. It would be useful to expand
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/779
sorry, one small nit.
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r141797749
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -45,4 +45,14 @@ private HttpStatus
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/779
+1 this one bit me today and this fixes it; great job!
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/732
Awesome, +1 by inspection Thanks for the contribution!
---
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/772
METRON-1209: Make stellar repl take logging properties, like other CLI apps
in metron
## Contributor Comments
Right now we don't have an ability to specify the logging settings. We
should
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/733
+1 this is useful work; thanks @nickwallen
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/770
Damn, I missed my opportunity to mock ;) +1 for posterity!
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/760
Why would those .j2 files be in gitignore?
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/764
+1. The release bits seem correct, the site book is correct. Please keep
this +1 in your pocket for 24 hours while the mirrors sync before committing,
@mattf-horton Great job!
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/755
@ottobackwards and @nickwallen any issues?
---
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/758
METRON-1186: Profiler Functions use classutils from shaded storm
## Contributor Comments
We should not depend on classutils from the shaded storm jar.
## Pull Request Checklist
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/755
So, I tested this on a kerberized multi-node cluster and full-dev. I
ensured that I tried with and without the management functions jar and
with/without kerberos as well.
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/755#discussion_r138777894
--- Diff: metron-stellar/stellar-common/src/main/scripts/stellar ---
@@ -28,7 +28,8 @@ elif [ -e /usr/lib/bigtop-utils/bigtop-detect-javahome
301 - 400 of 729 matches
Mail list logo
