[GitHub] metron issue #692: METRON-1107 add support for handling epoch dates in secon...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/692 I'm going to close this. We need more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] metron issue #692: METRON-1107 add support for handling epoch dates in secon...

2017-08-14 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/692 > can I ask why? Because that is 9x `9`s in epoch (`9`, assuming seconds). > for < 10, we don't know if it is millis or timestamps, at least that is my thinking. adding a 0

[GitHub] metron issue #692: METRON-1107 add support for handling epoch dates in secon...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/692 *[metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/EpochUtils.java, line 36 at r1](https://reviewable.io:443/reviews/a

[GitHub] metron issue #692: METRON-1107 add support for handling epoch dates in secon...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/692 *[metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/DateFunctionsTest.java, line 248 at r1](https://reviewable.io:443/

[GitHub] metron issue #692: METRON-1107 add support for handling epoch dates in secon...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/692 *[metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/EpochUtils.java, line 41 at r1](https://reviewable.io:443/reviews/a

[GitHub] metron issue #692: METRON-1107 add support for handling epoch dates in secon...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/692 This is due to our time stuff being java Calendar based. We should have a new jira to convert to the new java.time concepts. --- *Comments from

[GitHub] metron issue #692: METRON-1107 add support for handling epoch dates in secon...

2017-08-13 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/692 Also, I did notice a couple of things when poking around that probably fit best into some new JIRAs that I at least wanted to mention here: * It's somewhat unintuitive that we count [starting at