[GitHub] metron issue #717: METRON-1134: Allow parser command line options to be spec...

2017-08-31 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/717 Looks good +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] metron issue #717: METRON-1134: Allow parser command line options to be spec...

2017-08-30 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/717 Alright, I've added both a comment about the supplier abstraction and support for num workers and num ackers. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] metron issue #717: METRON-1134: Allow parser command line options to be spec...

2017-08-29 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/717 I tested this in full dev and everything worked as advertised. The only major issue I see is that the num workers property is missing from SensorParserConfig. I feel like this is one of the most

[GitHub] metron issue #717: METRON-1134: Allow parser command line options to be spec...

2017-08-29 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/717 I am +1 on this. Though I think it should be documented in the tuning guide as well at some point. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] metron issue #717: METRON-1134: Allow parser command line options to be spec...

2017-08-29 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/717 Ok, I think maybe a better explanation is in order then. Currently, when you start a topology, you can specify certain properties of the topology via the CLI. These are things like the spout

[GitHub] metron issue #717: METRON-1134: Allow parser command line options to be spec...

2017-08-29 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/717 Maybe I'm miss understanding. Does this introduce per parser configuration? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] metron issue #717: METRON-1134: Allow parser command line options to be spec...

2017-08-29 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/717 So, correct me if I'm wrong, but it should be independent of the archetype and extensions. They define the operation of the parser, this would be entirely specifying the configs for the storm

[GitHub] metron issue #717: METRON-1134: Allow parser command line options to be spec...

2017-08-29 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/717 I need to think of how this need to integrate with the archetype and extension installer --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] metron issue #717: METRON-1134: Allow parser command line options to be spec...

2017-08-29 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/717 We will need to integrate this in with 1136, maybe we should make it 'part' of it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] metron issue #717: METRON-1134: Allow parser command line options to be spec...

2017-08-29 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/717 Also, to my knowledge, the other value it provides is being able to set these configs in such a way that ambari starting parsers actually is configurable (just not configurable directly from the

[GitHub] metron issue #717: METRON-1134: Allow parser command line options to be spec...

2017-08-29 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/717 Yeah, we would need a UI JIRA to have people set this for the sensors. It provides some value by itself and it should not be a regression, but in order to change it in the UI, it'd need a hook.

[GitHub] metron issue #717: METRON-1134: Allow parser command line options to be spec...

2017-08-29 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/717 Or Rest? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] metron issue #717: METRON-1134: Allow parser command line options to be spec...

2017-08-29 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/717 Testing Instructions beyond the normal smoke test (i.e. letting data flow through to the indices and checking them). # Preliminaries Set an environment variable to indicate

[GitHub] metron issue #717: METRON-1134: Allow parser command line options to be spec...

2017-08-25 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/717 #post-777 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or