[GitHub] metron issue #857: METRON-1340: Improve e2e tests for metron alerts

2018-02-16 Thread iraghumitra
Github user iraghumitra commented on the issue: https://github.com/apache/metron/pull/857 Got busy with too many things happening around me, will yield this a conclusion next week. ---

[GitHub] metron issue #857: METRON-1340: Improve e2e tests for metron alerts

2018-01-31 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/857 What is the status of this pr? it is 29 day without comment, and conflicted, literally, and perhaps figuratively ---

[GitHub] metron issue #857: METRON-1340: Improve e2e tests for metron alerts

2018-01-02 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/857 @justinleet I believe @iraghumitra is still working on the SELENIUM_PROMISE_MANAGER change proposed above but I will defer to him. ---

[GitHub] metron issue #857: METRON-1340: Improve e2e tests for metron alerts

2018-01-02 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/857 @merrimanr @mmiklavc @iraghumitra What are the next steps towards being able to have this stable? It sounds like there was some playing around with versions, and that there may be some more

[GitHub] metron issue #857: METRON-1340: Improve e2e tests for metron alerts

2017-12-13 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/857 Follow up from @merrimanr and my work yesterday. We upped the versions of Node to 9.2.1. Per the doc, >8 is required to work with async/await. For good measure, I also set the NPM version to 5.6.0.

[GitHub] metron issue #857: METRON-1340: Improve e2e tests for metron alerts

2017-12-12 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/857 OK, I was able to get the tests to run. First run I get a single error. @merrimanr and I are talking through it now. ``` [INFO] Test spec for login page [INFO] ✗ should

[GitHub] metron issue #857: METRON-1340: Improve e2e tests for metron alerts

2017-12-12 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/857 Should we also run the tests using the new Maven profile? `mvn test -Pe2e` The README should probably be updated to reflect this as well. ---

[GitHub] metron issue #857: METRON-1340: Improve e2e tests for metron alerts

2017-12-12 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/857 A couple notes for the community - if your node/npm versions are out of date and you've already built the project, you'll run into trouble with versions not matching against the expected node

[GitHub] metron issue #857: METRON-1340: Improve e2e tests for metron alerts

2017-12-12 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/857 Seems that my NodeJS and npm versions got mangled since last time I ran this. Perhaps migrating laptops, upgrading to High Sierra, and switching from MacPorts to HomeBrew might have something to do

[GitHub] metron issue #857: METRON-1340: Improve e2e tests for metron alerts

2017-12-11 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/857 I've hit the same intermittent errors trying this, e.g. ``` [INFO] - Failed: unknown error: Element ... is not clickable at point (1279, 95). Other element would receive the

[GitHub] metron issue #857: METRON-1340: Improve e2e tests for metron alerts

2017-12-06 Thread iraghumitra
Github user iraghumitra commented on the issue: https://github.com/apache/metron/pull/857 @merrimanr renamed the variable POLLING_DEFAULT_STATE to DISABLE_POLLING ---

[GitHub] metron issue #857: METRON-1340: Improve e2e tests for metron alerts

2017-12-06 Thread iraghumitra
Github user iraghumitra commented on the issue: https://github.com/apache/metron/pull/857 @merrimanr - I removed the node version check in the ui code - The browser.sleep is used in following areas - When we are using methods like waitForText, few times I see the

[GitHub] metron issue #857: METRON-1340: Improve e2e tests for metron alerts

2017-12-05 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/857 Took a first pass at this and I feel like the e2e tests are much improved. Great progress and good job so far. I was able to get several successful runs whereas before it was difficult to get a

[GitHub] metron issue #857: METRON-1340: Improve e2e tests for metron alerts

2017-12-04 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/857 I haven't looked at the code yet, but I was able to pull this down and run the e2e tests repeatedly without failures, so this is definitely great stuff. ---