Github user anandsubbu commented on the issue:
https://github.com/apache/metron/pull/723
Closing this pull request, since it is the same as
https://github.com/apache/metron/pull/722
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user anandsubbu closed the pull request at:
https://github.com/apache/metron/pull/723
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Also a Why? section, which has children discussing design questions (WIP)
On August 30, 2017 at 18:22:19, Otto Fowler (ottobackwa...@gmail.com) wrote:
I would like to use this thread to describe and discuss what is being done
or tried in the parser extension feature branch effort. This is our
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/717#discussion_r136208967
--- Diff: metron-platform/metron-parsers/README.md ---
@@ -103,6 +103,15 @@ then it is assumed to be a regex and will match any
topic matching the pattern
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/717#discussion_r136208891
--- Diff:
metron-platform/metron-management/src/test/java/org/apache/metron/management/ConfigurationFunctionsTest.java
---
@@ -81,7 +81,15 @@ private
I would like to use this thread to describe and discuss what is being done
or tried in the parser extension feature branch effort. This is our first
time doing this, and there are some differences with reviewing pull
requests that we will have to work through, such as there not always being
a pull
I have created an area in confluence for feedback when there is no PR to
comment on:
https://cwiki.apache.org/confluence/display/METRON/Review+Feedback
On August 30, 2017 at 11:59:21, Otto Fowler (ottobackwa...@gmail.com) wrote:
Ok.
The initial PR is landed and the branch is up to date, with a
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/719
+1
I launched Full Dev, built the RPMs and then installed the MaaS RPM on Full
Dev. The contents of the RPM matched what @anandsubbu documented. I then
started MaaS to make sure
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/724
METRON-1142: Add Geo Hashing functions to stellar
## Contributor Comments
Adding geo hashing functions to stellar would be a nice complement to the
geo enrichment. Furthermore, geo hashing
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/722
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/722
+1 by inspection
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/717
Alright, I've added both a comment about the supplier abstraction and
support for num workers and num ackers.
---
If your project is set up for it, you can reply to this email and have your
reply
Ok.
The initial PR is landed and the branch is up to date, with a clean commit
log etc and ready for reviews, new or old.
On August 30, 2017 at 10:39:55, Nick Allen (n...@nickallen.org) wrote:
Just to be safe (and not to violate any community bylaws) I would say yes,
for any PR. But maybe I
I have some work around fixing how we handle config with Ambari that I'd
like to see go in. No PR yet, but coming soon. I expect to have this by the
RC deadline.
Mike
On Wed, Aug 30, 2017 at 8:57 AM, Nick Allen wrote:
> The following PRs are usability enhancements for the
Yeah, I'm not sure we need to hold up the release necessarily, but I think
it'd be a nice capability. I expect it'll get done prior to friday as it's
pretty close.
On Tue, Aug 29, 2017 at 8:59 PM, Matt Foley wrote:
> Okay, just to be clear, you’re requesting we wait until
I think opening PRs is the way to go. We're going to have maybe three
kinds of merges when we sync a feature branch with master.
- The *good* kind when there are no conflicts. Yay! Easy review, no
problems, quick +1.
- The *bad* kind when there are conflicts. This will take some
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/720
https://github.com/apache/metron/commit/ffcb91ed09c36d25008cfe57f06a9568d278f2f4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user ottobackwards closed the pull request at:
https://github.com/apache/metron/pull/720
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
The following PRs are usability enhancements for the Profiler. They are
fairly simple and I think are very helpful for troubleshooting. I don't
want to hold up the release, but it would be a "nice to have" to get these
in.
If anyone has cycles, I would appreciate some reviews of these PRs.
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/720
Thanks, @ottobackwards . This looks ready to commit to our new feature
branch. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
How are we going to keep Feature Branches up to date with master?
Do we need a PR? Is it just a behind the scenes commit from a committer?
Can a committer also optionally update master as part of landing another PR?
We are trailblazing here, so we can work with this to get an idea before we
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/711
@ottobackwards Those are all important points to consider. I just don't
know that we need to think through all of that right now. I am thinking of
this PR as a very basic, first pass. Let's
Right, I mean the initial PR that moves the other branches in. I don’t
think we expect that pr to get reviewed.
On August 30, 2017 at 10:26:00, Nick Allen (n...@nickallen.org) wrote:
Yes, I think you still need +1s. The same PR rules apply to the feature
branch PRs.
The only difference
Yes, I think you still need +1s. The same PR rules apply to the feature
branch PRs.
The only difference being that as a reviewer/committer I won't expect the
same level of quality, documentation, etc to get my +1 for a PR that is
destined for a feature branch. And of course, each
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/711
part of the issue is there is no use case for how this is going to be used
beyond the general. How often do analysts that have possibly 1000s of alerts
find the one magic alert?
I
Github user simonellistonball commented on the issue:
https://github.com/apache/metron/pull/711
@ottobackwards agreed, this is very separate from the management ui (won't
touch, or be used by anything in the management ui). Also agreed this is a
separate entity, but one that will be
So the question is: Can I commit the PR or do I need some +1’s to rubber
stamp it?
On August 29, 2017 at 10:01:13, Otto Fowler (ottobackwa...@gmail.com) wrote:
And finally : https://github.com/apache/metron/pull/720
On August 28, 2017 at 10:24:43, Otto Fowler (ottobackwa...@gmail.com) wrote:
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/700
@merrimanr I moved the rest-api calls to services
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/723
+1 by inspection, my bad!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user anandsubbu opened a pull request:
https://github.com/apache/metron/pull/723
METRON-1141: NameError: metronProfilerHost is not defined in
stack_advisor.py
## Contributor Comments
** Testing Done **
- Modified `service_advisor.py` on the Ambari host with the mpack
30 matches
Mail list logo