[GitHub] metron pull request #641: METRON-539: added HASH function for stellar.

2017-07-11 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/641#discussion_r126849833 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/HashFunctionsTest.java --- @@ -0,0 +1,169 @@ +/*

[GitHub] metron pull request #641: METRON-539: added HASH function for stellar.

2017-07-11 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/641#discussion_r126849654 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/HashFunctionsTest.java --- @@ -0,0 +1,169 @@ +/*

[GitHub] metron pull request #641: METRON-539: added HASH function for stellar.

2017-07-11 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/641#discussion_r126848506 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/HashFunctionsTest.java --- @@ -0,0 +1,169 @@ +/*

Re: [VOTE][PROPOSAL] minor changes to release process

2017-07-11 Thread Matt Foley
Hi, the below changes have been implemented. I also wrote a new page, how to “Change the Build Version Number” (since that’s not so simple to do), and I moved “Website PR Merge” under “Release Process” in the wiki page hierarchy. Please review. If anyone feels I overstepped with editorial

[GitHub] metron pull request #641: METRON-539: added HASH function for stellar.

2017-07-11 Thread jjmeyer0
Github user jjmeyer0 commented on a diff in the pull request: https://github.com/apache/metron/pull/641#discussion_r126841963 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/HashFunctionsTest.java --- @@ -0,0 +1,169 @@ +/* + *

[GitHub] metron issue #646: METRON-1030: Metron JDBC platform REST option should acce...

2017-07-11 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/646 I don't think we need any major changes here. Just something more descriptive. > Keep it like it is now, provide a convenient way to initialize MySQL with other databases requiring

[GitHub] metron pull request #641: METRON-539: added HASH function for stellar.

2017-07-11 Thread jjmeyer0
Github user jjmeyer0 commented on a diff in the pull request: https://github.com/apache/metron/pull/641#discussion_r126838847 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/HashFunctionsTest.java --- @@ -0,0 +1,169 @@ +/* + *

[GitHub] metron pull request #641: METRON-539: added HASH function for stellar.

2017-07-11 Thread jjmeyer0
Github user jjmeyer0 commented on a diff in the pull request: https://github.com/apache/metron/pull/641#discussion_r126838736 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/HashFunctionsTest.java --- @@ -0,0 +1,169 @@ +/* + *

[GitHub] metron pull request #641: METRON-539: added HASH function for stellar.

2017-07-11 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/641#discussion_r126836524 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/HashFunctions.java --- @@ -0,0 +1,85 @@ +/* + *

[GitHub] metron pull request #641: METRON-539: added HASH function for stellar.

2017-07-11 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/641#discussion_r126836440 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/HashFunctions.java --- @@ -0,0 +1,85 @@ +/* + *

[GitHub] metron pull request #641: METRON-539: added HASH function for stellar.

2017-07-11 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/641#discussion_r126835535 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/HashFunctions.java --- @@ -0,0 +1,85 @@ +/* + *

[GitHub] metron pull request #641: METRON-539: added HASH function for stellar.

2017-07-11 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/641#discussion_r126834205 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/HashFunctions.java --- @@ -0,0 +1,85 @@ +/* + *

[GitHub] metron issue #646: METRON-1030: Metron JDBC platform REST option should acce...

2017-07-11 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/646 Hive provides a list of supported databases: https://cwiki.apache.org/confluence/display/Hive/AdminManual+MetastoreAdmin#AdminManualMetastoreAdmin-Local/EmbeddedMetastoreDatabase(Derby) --- If

[GitHub] metron issue #646: METRON-1030: Metron JDBC platform REST option should acce...

2017-07-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/646 Your fix, plus some clarity in the documentation / ambari label etc + some idea that we need to think of something long term would be good right? --- If your project is set up for it, you

[GitHub] metron pull request #641: METRON-539: added HASH function for stellar.

2017-07-11 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/641#discussion_r126828810 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/HashFunctions.java --- @@ -0,0 +1,85 @@ +/* + *

[GitHub] metron issue #646: METRON-1030: Metron JDBC platform REST option should acce...

2017-07-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/646 What do other HDP / ambari configured services do to support multiple databases? There are other services/projects we can look to for ideas --- If your project is set up for it, you can

[GitHub] metron issue #646: METRON-1030: Metron JDBC platform REST option should acce...

2017-07-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/646 this is a general problem I think --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] metron issue #646: METRON-1030: Metron JDBC platform REST option should acce...

2017-07-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/646 It needs to be documented in the ambari ui, if it needs clarification. The user in ambari isn't going to be using the readme --- If your project is set up for it, you can reply to this email

[GitHub] metron issue #646: METRON-1030: Metron JDBC platform REST option should acce...

2017-07-11 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/646 @ottobackwards it's in metron-rest README but I can expand it a little bit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] metron pull request #641: METRON-539: added HASH function for stellar.

2017-07-11 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/641#discussion_r126810315 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/HashFunctions.java --- @@ -0,0 +1,85 @@ +/* + *

[GitHub] metron pull request #641: METRON-539: added HASH function for stellar.

2017-07-11 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/641#discussion_r126810010 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/HashFunctions.java --- @@ -0,0 +1,85 @@ +/* + *

[GitHub] metron issue #646: METRON-1030: Metron JDBC platform REST option should acce...

2017-07-11 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/646 The comment "This is needed when configuring MySQL for Metron REST because this property must be" is actually incorrect now that I go back and look at it. The schema-mysql.sql was initially

[GitHub] metron issue #646: METRON-1030: Metron JDBC platform REST option should acce...

2017-07-11 Thread lvets
Github user lvets commented on the issue: https://github.com/apache/metron/pull/646 "This is needed when configuring MySQL for Metron REST because this property must be '' and not 'mysql'.". So this needs to be empty when you use mysql? I'm not following... :) --- If your project

[GitHub] metron issue #646: METRON-1030: Metron JDBC platform REST option should acce...

2017-07-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/646 That seems like a configuration that is rather confusing... Is there a way we can clarify that? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] metron issue #646: METRON-1030: Metron JDBC platform REST option should acce...

2017-07-11 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/646 Spring provides a mechanism for running sql scripts for different databases on startup. This is useful for initializing tables and such. We provide 2 right now: schema-h2.sql and

[GitHub] metron issue #646: METRON-1030: Metron JDBC platform REST option should acce...

2017-07-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/646 ^^^ " This is needed when configuring MySQL for Metron REST because this property must be '' and not 'mysql'." --- If your project is set up for it, you can reply to this email and

[GitHub] metron issue #646: METRON-1030: Metron JDBC platform REST option should acce...

2017-07-11 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/646 When would a user want to set this property to an empty string? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] metron issue #634: METRON-1017: Ambari components should be separate

2017-07-11 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/634 +1 Looks sharp! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] metron pull request #634: METRON-1017: Ambari components should be separate

2017-07-11 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/634#discussion_r126802506 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-enrichment-env.xml ---

[GitHub] metron pull request #634: METRON-1017: Ambari components should be separate

2017-07-11 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/634#discussion_r126802519 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -77,132

[GitHub] metron issue #636: METRON-1022: Elasticsearch REST endpoint

2017-07-11 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/636 The latest commit enforces a maximum page size. A value of 1000 is set by default. As it currently stands, you would need to add this property to the rest_application.yml file manually if it

[GitHub] metron pull request #634: METRON-1017: Ambari components should be separate

2017-07-11 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/634#discussion_r126789624 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-enrichment-env.xml ---

[GitHub] metron pull request #634: METRON-1017: Ambari components should be separate

2017-07-11 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/634#discussion_r126788288 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_commands.py --- @@

[GitHub] metron pull request #638: METRON-933 New stellar function for regex group ca...

2017-07-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/638 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Metron REST - Logging Config

2017-07-11 Thread Nick Allen
How do I configure logging for Metron REST on a deployed host? Right now a log4j.properties file gets packaged into the metron-rest JAR itself. Is there is an easy way that I am missing?

[GitHub] metron pull request #638: METRON-933 New stellar function for regex group ca...

2017-07-11 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/638#discussion_r126778701 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/RegExFunctionsTest.java --- @@ -0,0 +1,70 @@ +/** +

[GitHub] metron issue #638: METRON-933 New stellar function for regex group capture

2017-07-11 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/638 +1 via inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] metron pull request #638: METRON-933 New stellar function for regex group ca...

2017-07-11 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/638#discussion_r126778367 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/RegExFunctions.java --- @@ -0,0 +1,103 @@ +/**

[GitHub] metron pull request #638: METRON-933 New stellar function for regex group ca...

2017-07-11 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/638#discussion_r126778032 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/RegExFunctionsTest.java --- @@ -0,0 +1,70 @@ +/**

Upgrade from 0.4.0-rc to 0.4.0-release

2017-07-11 Thread Laurens Vets
Can someone confirm that the following instructions are correct for upgrading from 0.4.0-rc to 0.4.0-release? They seem to work for me, but my testing is rather limited. # cd metron # git checkout Metron_0.4.0 # mvn clean package -DskipTests -T 2C -P HDP-2.5.0.0,mpack # cd

[GitHub] metron pull request #646: METRON-1030: Metron JDBC platform REST option shou...

2017-07-11 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/646 METRON-1030: Metron JDBC platform REST option should accept a blank value ## Contributor Comments Ambari should allow the metron_jdbc_platform option to be set to '' which it currently does

[GitHub] metron pull request #638: METRON-933 New stellar function for regex group ca...

2017-07-11 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/638#discussion_r126739325 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/RegExFunctions.java --- @@ -0,0 +1,103 @@ +/** + *

[GitHub] metron pull request #645: METRON-1029: Topology worker opts are not being se...

2017-07-11 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/645 METRON-1029: Topology worker opts are not being set when Kerberos is enabled ## Contributor Comments This PR properly sets the topology worker opts property for enrichment and indexing

[GitHub] metron pull request #621: METRON-1001: Allow metron to ingest parser metadat...

2017-07-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/621 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] metron issue #621: METRON-1001: Allow metron to ingest parser metadata along...

2017-07-11 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/621 @cestella Nope, I'm good, +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] metron pull request #641: METRON-539: added HASH function for stellar.

2017-07-11 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/641#discussion_r126752781 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/HashFunctions.java --- @@ -0,0 +1,85 @@ +/* + *

[GitHub] metron issue #621: METRON-1001: Allow metron to ingest parser metadata along...

2017-07-11 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/621 @justinleet any other comments or concerns? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] metron pull request #644: METRON-1027: Errant Log Message When No GeoIP Hit ...

2017-07-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/644 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] metron issue #644: METRON-1027: Errant Log Message When No GeoIP Hit on Vali...

2017-07-11 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/644 Also, ran this up on Full Dev and did some quick validation on `GEO_GET` just to be sure. ``` [Stellar]>>> GEO_GET("192.168.0.1") 2017-07-11 15:11:13,401 INFO [AeshProcess: 3]

[GitHub] metron pull request #634: METRON-1017: Ambari components should be separate

2017-07-11 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/634#discussion_r126689168 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-enrichment-env.xml ---

[GitHub] metron pull request #634: METRON-1017: Ambari components should be separate

2017-07-11 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/634#discussion_r126687833 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_commands.py --- @@

[GitHub] metron pull request #634: METRON-1017: Ambari components should be separate

2017-07-11 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/634#discussion_r126687126 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -77,132

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-07-11 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r126672638 --- Diff: metron-interface/metron-alerts/src/app/model/alert.ts --- @@ -0,0 +1,44 @@ +export class Alert { --- End diff -- I haven't been

[GitHub] metron issue #620: Metron-988: UI for viewing alerts generated by Metron

2017-07-11 Thread mraliagha
Github user mraliagha commented on the issue: https://github.com/apache/metron/pull/620 @iraghumitra I've tested your latest commit and it is much better now. However, I cannot see all the fields in the customise visible fields panel.