Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/840
The only issue with it, is if we did that in the old version, then this
would be a regression. Other than that, I'm just waiting to review the docs ;)
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/840
Whew, that's great news!
Hahahahaha, that's the default colors from the Kibana widgets... I usually
refrain from bringing it up, but I'm partially colorblind (even though I used
to do a
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/840
@ottobackwards You should be good to try it now.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/824
The latest commits address some outstanding tasks and address a couple
other issues:
- disabling updates to meta alert objects means we can't update a meta
alert name or comments (or other
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/831#discussion_r150336506
--- Diff:
metron-platform/metron-indexing/src/main/scripts/start_hdfs_topology.sh ---
@@ -0,0 +1,22 @@
+#!/bin/bash
+#
+# Licensed to the
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/831#discussion_r150317133
--- Diff:
metron-platform/metron-indexing/src/main/scripts/start_hdfs_topology.sh ---
@@ -0,0 +1,22 @@
+#!/bin/bash
+#
+# Licensed to the
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/831#discussion_r150316808
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_commands.py
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/840
I got full_dev failure on connecting to metron web. Can you post when you
think full dev is ready and I'll try again then?
---
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/831#discussion_r150315275
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-indexing-env.xml
---
@@
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/831#discussion_r150314839
--- Diff:
metron-platform/metron-indexing/src/main/scripts/start_hdfs_topology.sh ---
@@ -0,0 +1,22 @@
+#!/bin/bash
+#
+# Licensed to the
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/831#discussion_r150314308
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-indexing-env.xml
---
@@
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/831#discussion_r150314117
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_commands.py
---
@@
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/840
Ok, looks like 2 more minor issues.
1. params.py missing the kibana_server_host, so it's not making its way to
kibana.yml
2. The default index mapping template that ES creates when I index
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/837
+1 LGTM. Thanks!
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/839
I ran this through another full test after merge with master. Everything
looks good to me.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/840
Thanks @mmiklavc, those changes look good. Running up in full dev
---
Github user dbist closed the pull request at:
https://github.com/apache/metron/pull/810
---
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/840#discussion_r150282327
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/KIBANA/5.6.2/package/scripts/kibana_master.py
---
@@ -24,6
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/840#discussion_r150281496
--- Diff:
metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/bulk/ElasticsearchImportExportTest.java
---
@@ -0,0 +1,69 @@
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/839
Thanks @anandsubbu . I resolved the merge conflicts from master.
---
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/840#discussion_r150274541
--- Diff: metron-platform/elasticsearch-shaded/pom.xml ---
@@ -99,7 +148,15 @@
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/840#discussion_r150274108
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/KIBANA/5.6.2/package/scripts/kibana_master.py
---
@@ -24,6
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/840
@mraliagha @cestella agreed on timestamp.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/840
Can you call the curator stuff out in your checklist above?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/840
Ok, killing my vagrant up then, until your commit
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/840
@ottobackwards Oh, afa the data pruner, I believe we can use Curator now as
a built-in mechanism for pruning data. Steps will be added to the documentation.
Github user anandsubbu commented on the issue:
https://github.com/apache/metron/pull/839
+1 (non-binding) works fine, and a much needed fix as well ! If for some
reason, we were not able to install the templates during the startup, it would
be caught by the service check.
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/840#discussion_r150269845
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/ELASTICSEARCH/5.6.2/package/scripts/slave.py
---
@@ -48,19
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/840
@ottobackwards thanks for the review! The templates themselves changed, but
the deployment of those templates is the same. I discovered that with a host
change in Kibana, I broke the Ambari
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/810
It's merged. The commit message looks acceptable too. Not sure why it
didn't automatically close. Please close @dbist
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/840
Are there any required changes to the ansible roles? I thought we injected
the templates from there. Or has the indexing service injection landed?
---
Github user dbist commented on the issue:
https://github.com/apache/metron/pull/810
@justinleet thanks for looking into this, as soon as I get a confirmation,
I'll close it.
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/840#discussion_r150264674
--- Diff: metron-platform/elasticsearch-shaded/pom.xml ---
@@ -99,7 +148,15 @@
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/840#discussion_r150262722
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/ELASTICSEARCH/5.6.2/package/scripts/slave.py
---
@@
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/840#discussion_r150263736
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/KIBANA/5.6.2/package/scripts/kibana_master.py
---
@@
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/840#discussion_r150264904
--- Diff: metron-platform/metron-data-management/pom.xml ---
@@ -231,11 +231,11 @@
httpclient
${httpcore.version}
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/840#discussion_r150259383
--- Diff: dependencies_with_url.csv ---
@@ -310,6 +310,29 @@
org.springframework.security.kerberos:spring-security-kerberos-core:jar:1.0.1.RE
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/840#discussion_r150266275
--- Diff:
metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/bulk/ElasticsearchImportExportTest.java
---
@@ -0,0
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/840#discussion_r150265577
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java
---
@@ -139,13 +141,17 @@
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/840#discussion_r150265417
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/bulk/ElasticsearchImportExport.java
---
@@ -0,0 +1,76 @@
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/840
@mraliagha Yeah, absolutely. This task purposefully leaves out major
changes that we could do to improve things (e.g. moving back to `.` separated
fields instead of `:`). The attempt is to touch
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/824#discussion_r150239607
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/MetaAlertController.java
---
@@ -60,5 +63,37 @@
) throws
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/824#discussion_r150239332
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java
---
@@ -256,59 +256,91 @@ public
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/824#discussion_r150230733
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java
---
@@ -256,59 +256,91 @@ public
44 matches
Mail list logo
