Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/961
@JonZeolla @cestella Are you guys good with this?
---
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/966
METRON-1493 Unhelpful Error Message When Assignment Expressions Fail
When executing an assignment expression that fails, the error message is
less than helpful. Prior to this PR the error
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/965
METRON-590 Enable Use of Event Time in Profiler
This enables the use of event time processing in the Profiler.
By default, the Profiler will still use processing time. If you configure
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/963
+1 LGTM
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/962
+1 looks good. thanks
---
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/961#discussion_r174772238
--- Diff: metron-platform/metron-enrichment/Performance.md ---
@@ -0,0 +1,527 @@
+
+
+# Enrichment Performance
+
+This guide defines a
Github user nickwallen commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/6
+1 Looks great. Thanks @dcode
---
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/961#discussion_r173963284
--- Diff: metron-platform/metron-enrichment/Performance.md ---
@@ -0,0 +1,522 @@
+
+
+# Enrichment Performance
+
+This guide defines a
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/961#discussion_r173963096
--- Diff: metron-platform/metron-enrichment/Performance.md ---
@@ -0,0 +1,522 @@
+
+
+# Enrichment Performance
+
+This guide defines a
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/961
METRON-1487 Define Performance Benchmarks for Enrichment Topology
I created a markdown document that defines a set of performance benchmarks
for the Enrichment topology. These benchmarks should
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/947#discussion_r172888378
--- Diff:
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/bolt/JoinBolt.java
---
@@ -89,29 +91,25 @@ public void prepare
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/947
+1 LGTM
---
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/947#discussion_r172866140
--- Diff:
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/bolt/JoinBolt.java
---
@@ -89,29 +91,25 @@ public void prepare
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/940
+1 The unified topology works great.
---
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/940#discussion_r172694248
--- Diff:
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/parallel/ParallelEnricher.java
---
@@ -0,0 +1,281
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/940#discussion_r172595029
--- Diff:
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/parallel/ParallelEnricher.java
---
@@ -0,0 +1,281
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/948
+1
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/942
The first point here is around semantics. I am assuming the semantics of
this would be a "max of maxes". So if I have a list of stats objects, I
compare the max of each one. Whiche
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/942
I would like to address the issue somehow or at least garner more community
feedback on this change.
As it stands, usage of the function is not very consistent. For example, I
can pass
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/948
Other than that little nit, it works great though. Thanks @JonZeolla
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/948
When I got to the point of selecting the repo, I was unsure of what to type
for the Bro Plugin repo.
```
$ ./metron-pr948/dev-utilities/committer-utils/prepare-commit
...using
Github user nickwallen commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/6
@dcode
1. The JIRA created for this is
https://issues.apache.org/jira/browse/METRON-1469.
1. Please change the PR title to "METRON-1469: Kafka Plugin fo
Github user nickwallen commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/7
+1 Thanks, @JonZeolla !
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/936
Thanks @MohanDV . Will merge this now.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/942
@MohanDV - It looks like some care was taken previously so that getting the
max of a list of mixed elements will just work. For example `MAX([1, 2d, 3f])
== 3f`.
Did you consider an
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/940
That's great @cestella . Many thanks. I will run it up in the lab. No
problem.
---
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/940#discussion_r172359339
--- Diff:
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/parallel/Strategy.java
---
@@ -0,0 +1,47
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/940#discussion_r172353404
--- Diff:
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/bolt/UnifiedEnrichmentBolt.java
---
@@ -0,0 +1,415
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/940#discussion_r172363362
--- Diff:
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/parallel/EnrichmentStrategies.java
---
@@ -0,0 +1,79
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/940
I completed some fairly extensive performance testing comparing this new
Unified topology against the existing Split-Join implementation. The
difference was dramatic.
- The Unified
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/6#discussion_r172240860
--- Diff: src/KafkaWriter.cc ---
@@ -54,20 +66,49 @@ KafkaWriter::KafkaWriter(WriterFrontend* frontend):
WriterBackend(frontend), for
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/6#discussion_r172187861
--- Diff: README.md ---
@@ -37,10 +37,11 @@ The following examples highlight different ways that
the plugin can be used. Si
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/6#discussion_r172192869
--- Diff: src/KafkaWriter.cc ---
@@ -54,20 +66,49 @@ KafkaWriter::KafkaWriter(WriterFrontend* frontend):
WriterBackend(frontend), for
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/6#discussion_r172193204
--- Diff: src/KafkaWriter.cc ---
@@ -54,20 +66,49 @@ KafkaWriter::KafkaWriter(WriterFrontend* frontend):
WriterBackend(frontend), for
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/944
+1 These corrections should greatly improve performance.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/940
I'd hold on merging this until we can get this tested at some decent scale.
Unless it already has been? Otherwise, I don't see a need to merge this until
we know it actually addresses a problem.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/936
+1 Thanks for correcting this @MohanDV. This looks good.
Let's give @JonZeolla a chance to respond before we merge this.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/933
FYI - After the last commit, I spun-up the CentOS environment again;
validated the Alerts UI is receiving data, ran the Metron Service Check
successfully. All is well.
---
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/942#discussion_r170597762
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/OrdinalFunctions.java
---
@@ -37,17 +35,23
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/942#discussion_r170595688
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/OrdinalFunctions.java
---
@@ -37,17 +35,23
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/942#discussion_r170598354
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/Ordinal.java
---
@@ -0,0 +1,24
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/933
When creating the Ubuntu environment a while back, I created an Ansible
role that enables swap space. (In the base Ubuntu image, swap space is not
enabled.) It was easy enough to reuse that in
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/6#discussion_r170469201
--- Diff: src/KafkaWriter.cc ---
@@ -54,20 +66,51 @@ KafkaWriter::KafkaWriter(WriterFrontend* frontend):
WriterBackend(frontend), for
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/6#discussion_r170470107
--- Diff: src/KafkaWriter.cc ---
@@ -54,20 +66,51 @@ KafkaWriter::KafkaWriter(WriterFrontend* frontend):
WriterBackend(frontend), for
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/6#discussion_r170471879
--- Diff: scripts/Apache/Kafka/logs-to-kafka.bro ---
@@ -22,7 +22,7 @@ event bro_init() &priority=-5
{
for (stream_id in
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/933
I did not notice any issues, but I'll spin it up again and compare the
difference in swap space just so we know what we're getting into.
Thanks for the info @dlyle65535 !
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/933
> what are we doing in the current special metron cut of centos 6? I'm not
familiar enough with why we forked to understand what we're possibly giving up
or exchanging by switchin
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/619
This functionality was completed in #840. As mentioned in #840 this
inspired much of that work. Is there anything else needed from this PR? If
not, can you close this PR @wardbekker
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/933
METRON-1452 Rebase Dev Environment on Latest CentOS 6
Currently the CentOS development environment
(`metron-deployment/development/centos6`) is based on an image
[metron/centos_base](https
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/930
+1 Thanks @wardbekker !
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/932
+1 Works great. This was an annoying one to track down. Great detective
work @anandsubbu
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/932
Thanks @anandsubbu . This looks like a solid fix. Spinning it up now.
---
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/931
METRON-1449 Set Zookeeper URL for Stellar Running in Zeppelin Notebook
## Changes
* This enhances the Stellar interpreter for Zeppelin to allow the user to
set a `zookeeper.url
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/927
Thanks for the review @mmiklavc and making sure the merge was solid.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/928
+1 Ran this up on Ubuntu. Thanks for the fix!
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/928
I disagree @ottobackwards . The core problem is that there is a bug in
Ambari that prevented us from loading the repos directly in the Mpack. The
only way to fix this is to upgrade
Github user nickwallen closed the pull request at:
https://github.com/apache/metron/pull/622
---
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/927
METRON-1447 Heap Size Not Set Correctly by MPack for ES 5.x
The preferred way in which the heap size and other JVM options are set
changed between ES 2.x and ES 5.x. The project upgraded to ES
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/926
+1 LGTM. I have not been able to replicate this problem, which I am really
confused about. Although this seems harmless enough of a change.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/926
Was this tested against Vagrant 2.0.2 or 1.8.1 ?
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/925
https://issues.apache.org/jira/browse/METRON-1444
---
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/925
METRON-1443 Missing Critical MPack Install Instruction for Ubuntu
When installing Elasticsearch with the MPack on Ubuntu, you must manually
install the Elasticsearch repositories. The Mpack
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/920
+1 Thanks @ottobackwards
---
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/920#discussion_r165663581
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/ShellFunctionsTest.java
---
@@ -40,8 +45,8
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/920#discussion_r165660358
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/shell/cli/PausableInput.java
---
@@ -36,8 +37,8
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/920#discussion_r165654991
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/shell/cli/PausableInput.java
---
@@ -36,8 +37,8
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/920#discussion_r165653517
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/ShellFunctionsTest.java
---
@@ -40,8 +45,8
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/919
> Sidenote, do we want to move this script to the dev-utilities dir?
I do think it would be good to move that script. Not sure where under
dev-utilities though. And we can tackle
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/919
+1 works great for me. Thanks
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/907
+1 Ran it up with all of our fixes in the Ubuntu dev environment. Works
great. Thanks!
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/907
I also just merged #913 so I will run this up just to be sure the whole
package is working in the Ubuntu dev environment.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/907
FYI @cestella I submitted a fix against your PR branch that should address
the issue with the embedded handlebars in the Ambari response.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/907
For (2), the problem is that the HDFS configuration in Ambari has embedded
'mustache handlebars' (see `{{major_stack_version}}`) that when returned from
an API call confuses Ansible
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/913
METRON-1432 JDK Install Fails on Ubuntu Development Environment
The Ansible role used to install the JDK does not work correctly on Ubuntu.
This fixes the problem and ensures that the JDK can
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/907
Running this up on Ubuntu, I ran into two issues.
(1) JDK Install Failed on Ubuntu - I do not think this was caused by this
PR. This is something that I should have hit in #903, but the
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/903
Ok, I renamed the development environments.
I went with a slightly different name than I previously mentioned, but it
still matches the suggestions that I received earlier. I thought
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/903
I am liking a combination of the suggestions from @lvets and @cestella.
Something like this maybe?
* `dev-on-centos6`
* `dev-on-ubuntu14`
I like the name because of points made
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/903
> @lvets: Just for my understanding, but why Ubuntu Trusty? In April that
will be 2 full Ubuntu LTS versions behind the then current one...
Because that's the requirement that I
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/903
Thanks @ottobackwards . I'll see if we can get any more reviewers before I
merge this.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/903
> @ottobackwards : Do we expect there to be issues with 2.6? Is this PR and
Casey's 2.6 pr going to conflict or have issues?
Yes, we will need to retest one or the other. I am
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/903
I spun this up again on both Ubuntu and CentOS. Both worked successfully.
I am happy with it now @ottobackwards . Give her another go when you can.
Thanks.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/902
I merged with master, so I expect Travis to be happy now. Just need +1s
and I'll get this in to allow for any follow-ons.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/901
+1 Looks good @ottobackwards. Thanks for fixing this!
I have not tested this myself, but it looks solid. Let me know if you'd
prefer me to spin this up to get a second test r
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/903
> @ottobackwards : Failure during vagrant up for metron-on-ubuntu
Thanks, Otto. Yep, I messed that up. I pushed the fix, but I am going to
run through full CentOS and Ubuntu deployme
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/902
> @ottobackwards: I think of there being two users for these scripts...
That makes perfect sense to me. Can we tackle that in a follow-on?
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/905
I should also say, #903 certainly doesn't preclude this. This has a +1
from me.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/905
I one-up'd you in #903 by just removing Monit all-together. There is
really no need for it any longer. It was useful before the MPack; now not so
much.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/888
+1 by inspection. Nice work @anandsubbu .
We'll need to figure out this intermittent test failure (impacting all PRs,
not just yours) before we merge.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/903
I am continuing a final round of testing to make sure these changes are
solid. I wanted to get the PR open so I could start getting feedback as soon
as possible.
---
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/903
METRON-1370 Create Full Dev Equivalent for Ubuntu
This PR adds a single node, VM based deployment mechanism based on Ubuntu
Trusty. This has feature parity with the existing CentOS
GitHub user nickwallen reopened a pull request:
https://github.com/apache/metron/pull/902
METRON-1413 Add Metron Commit Tool
This PR contributes the `prepare-merge` tool that many (some?) contributors
use. Up until now, it has been managed in a separate repo.
I didn&#
Github user nickwallen closed the pull request at:
https://github.com/apache/metron/pull/902
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/902
> @JonZeolla: ... the curl command HTML encodes the JIRA description but I
don't know of a clean bash-native way to decode it.
Yes, I have noticed, especially with apostrophes. W
Github user nickwallen closed the pull request at:
https://github.com/apache/metron/pull/902
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/902
Also, I've never liked the name `prepare-commit`. If you guys can think of
something better, please let me know.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/902
Travis had a hickup... Doing the "close/reopen" dance to trigger the CI
build.
---
GitHub user nickwallen reopened a pull request:
https://github.com/apache/metron/pull/902
METRON-1413 Add Metron Commit Tool
This PR contributes the `prepare-merge` tool that many (some?) contributors
use. Up until now, it has been managed in a separate repo.
I didn&#
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/902
The Apache ID isn't really necessary to use `prepare-commit`. What if I
just changed the docs to note that it is not required? I could document how
you could use the script to review
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/902
I don't see the value in `checkout-pr` any longer. You can just use
`prepare-commit` which gives you the exact view of what the code would
look-like when its merged.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/902
Thanks @mattf-horton. Either of those suggestions works for me;
'dev-support' or 'dev-utilities'. I'll let others chime in with their
preference and then update it accordingly.
---
1 - 100 of 832 matches
Mail list logo
