[GitHub] incubator-metron issue #542: METRON-873: Stellar string literals do not supp...

2017-04-21 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/542 We need a stellar guide, more suited to learning stellar, than just documenting the facts of it. Something that gets you in the shell and gives you some exercises. --- If your

[GitHub] metron issue #674: METRON-681 CSVConverter should trim key and values

2017-07-31 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/674 Yes. Does X with incoming .. trims all values --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] metron pull request #667: METRON-1061 Add FUZZY_SCORE STELLAR function

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/667#discussion_r131155065 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/TextFunctions.java --- @@ -0,0 +1,63

[GitHub] metron issue #675: METRON-379 STELLAR can differentiate between a value pass...

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/675 I'll create a Jira for the NaN thing, unless you have already coded it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] metron pull request #681: METRON-1079 Add NaN as a keyword in STELLAR langua...

2017-08-03 Thread ottobackwards
GitHub user ottobackwards opened a pull request: https://github.com/apache/metron/pull/681 METRON-1079 Add NaN as a keyword in STELLAR language Add "NaN" to STELLAR as a keyword. Add NaN, and tests to verify that it works in line with the java spe

[GitHub] metron issue #682: METRON-1081: Fix Alerts and Ops UI Notices file

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/682 Are the modules/versions pulled in dependent on the version of node or something? My list is different. I have more things, and different versions for some. [licenses.txt](https

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 hey @mmiklavc . Looking back at my logs above, no matter that the maven-archetype-plugin was 2.4 in the pom at the time, it shows 3.0.1 in the output. Can you check what version it shows

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 I also may have a fix for the missing catalog file issue ( or a way to run the command differently ) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 thanks @mmiklavc. I don't think I've stated this in the actual PR As a 3rd party ( or whatever you want to call it ) developer, who only makes Parser or possibly other extensions

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 I DO think that the archetype's input variables could use refactoring. For example, I force the artifact name, and maybe I should not. I do not know why the bundle plugin is looking

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 I hate to ask but are you sure you have the latest code? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 I'm going to try with a new .m2 dir --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 Ok, I tried with a new M2 directory and the can't find local archetype issue returned. maven-archetype-plugin 3.0.1

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 ok - so mvn archetype:generate uses the newer version of the plugin if run in an empty directory. If run in a directory where there is a pom with plugin setting for 2.4 and it will honor

[GitHub] metron issue #682: METRON-1081: Fix Alerts and Ops UI Notices file

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/682 I am not sure how to verify or review this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 ```bash ┌─[ottofowler@Winterfell] - [~/.m2/repository/org/apache/metron/metron-maven-parser-extension-archetype/0.4.1] - [Thu Aug 03, 18:42] └─[$]> ll total 80 -rw-r

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 WRT: the archetype directories: I don't see that ( but I'm going to re-build and try again ). I don't use the same options you are using though. Importantly -> the parser vers

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 ```bash ┌─[ottofowler@Winterfell] - [~/tmp] - [Thu Aug 03, 18:36] └─[$]> mvn archetype:generate -DarchetypeCatalog=local [INFO] Scanning for projects... [I

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 I'm not done the build, so I'll try this again, but this is what I get: ( Note, I don't know how you are getting the packageInPathFormat option ): ┌─[ottofowler@Winterfell

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 Ok - I think you are running find from /usr/metron/$V/ So - to explain the other config/zookeeper So let's pretend there are two things here: 1. metron-parsers 2. parser

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 I left the Parser off of the HelloParser input, sorry --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 ```bash ┌─[ottofowler@Winterfell] - [~/tmp/HelloParser] - [Thu Aug 03, 19:12] └─[$]> cat ~/.m2/repository/archetype-catalog.xml http://maven.apache.org/plugins/ma

[GitHub] metron issue #679: METRON-1075: Add faceted search capabilities

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/679 +1 works as described. Great Job! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] metron pull request #667: METRON-1061 Add FUZZY_SCORE STELLAR function

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/667#discussion_r131142516 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/TextFunctions.java --- @@ -0,0 +1,63

[GitHub] metron pull request #667: METRON-1061 Add FUZZY_SCORE STELLAR function

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/667#discussion_r131143225 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/TextFunctions.java --- @@ -0,0 +1,63

[GitHub] metron pull request #667: METRON-1061 Add FUZZY_SCORE STELLAR function

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/667#discussion_r131146245 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/TextFunctions.java --- @@ -0,0 +1,63

[GitHub] metron issue #686: METRON-711 STELLAR SHELL Do not set variables when except...

2017-08-15 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/686 @cestella do you have any inputs to the questions posed in the pr description? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] metron issue #681: METRON-1079 Add NaN as a keyword in STELLAR language

2017-08-15 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/681 We are not 'doing' the math here. What we are doing is introducing the ability to use NaN in an expression correctly. Java is doing the math. The tests are to verify that through stellar

[GitHub] metron pull request #667: METRON-1061 Add FUZZY_SCORE STELLAR function

2017-08-15 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/667#discussion_r133247450 --- Diff: metron-stellar/stellar-common/README.md --- @@ -411,6 +412,14 @@ In the core language functions, we support basic functional programming

[GitHub] metron pull request #667: METRON-1061 Add FUZZY_SCORE STELLAR function

2017-08-15 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/667#discussion_r133273527 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/TextFunctions.java --- @@ -0,0 +1,95

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-13 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 *[bundles-lib/src/main/java/org/apache/metron/bundles/BundleThreadContextClassLoader.java, line 43 at r2](https://reviewable.io:443/reviews/apache

[GitHub] metron issue #690: METRON-1091 Package STELLAR shell as stand alone

2017-08-13 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/690 @JonZeolla Thanks for the review! There are several questions in the description that I think need to fall out of the review, one of them is where or how to document this. Any

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 @mmiklavc keep in mind that the proper scope for the document is building new parsers that are 'part' of metron for METRON-777. METRON-942 has the capability to actually install

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 We discussed this higher up in the pr and decided not to --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] metron issue #439: METRON-571 add stellar external functions feature - code ...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/439 HI do we have an update on the status of this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133061877 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,436 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133050916 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionMapping.java --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache

[GitHub] metron issue #439: METRON-571 add stellar external functions feature - code ...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/439 As pointed out these should be in the management package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 @mattf-horton I really like how this is evolving. One thing I have been thinking of since adding the BundleSystem interface ( which should be the main external interface ) is that I would

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133033031 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionMapping.java --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133083369 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleSystem.java --- @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133077758 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleThreadContextClassLoader.java --- @@ -0,0 +1,213 @@ +/* + * Licensed

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133078904 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleSystem.java --- @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133079542 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,540 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133079502 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,540 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133079554 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,540 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133079476 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,540 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133079524 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,540 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133079584 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionMapping.java --- @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133079513 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,540 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133079462 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,540 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133076687 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleThreadContextClassLoader.java --- @@ -0,0 +1,213 @@ +/* + * Licensed

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133078228 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,540 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133079379 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleThreadContextClassLoader.java --- @@ -0,0 +1,213 @@ +/* + * Licensed

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133079324 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java --- @@ -0,0 +1,376 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133079362 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java --- @@ -0,0 +1,376 @@ +/* + * Licensed to the Apache

[GitHub] metron issue #681: METRON-1079 Add NaN as a keyword in STELLAR language

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/681 @cestella and I were talking about null variables and how NaN was being used, and that we probably needed NaN as a keyword. So I took a stab at it. --- If your project is set up for it, you

[GitHub] metron pull request #667: METRON-1061 Add FUZZY_SCORE STELLAR function

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/667#discussion_r133117091 --- Diff: metron-stellar/stellar-common/README.md --- @@ -411,6 +412,14 @@ In the core language functions, we support basic functional programming

[GitHub] metron issue #689: METRON-1102: Add support for ingesting cybox URI observab...

2017-08-10 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/689 As for where... over in METRON-777 @mmiklavc is talking about a better documentation area... this may fall into that --- If your project is set up for it, you can reply to this email and have

[GitHub] metron issue #689: METRON-1102: Add support for ingesting cybox URI observab...

2017-08-10 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/689 > Can we handle just Cybox What I mean is, can we import a file that is **ONLY** cybox observables, without Stix. Stix supports cybox. But they are separate thi

[GitHub] metron issue #689: METRON-1102: Add support for ingesting cybox URI observab...

2017-08-10 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/689 I would like to see at least the version of Stix and Cybox that is supported documented. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] metron issue #689: METRON-1102: Add support for ingesting cybox URI observab...

2017-08-10 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/689 +1 by inspection. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 The management ui works with zookeeper. You will be able to work with it. Adding support for installing extensions through the UI is a follow on, but I am not sure that I can do

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 in fact, you will see more in the management ui, since the extension parsers all have default configurations and will be present :) --- If your project is set up for it, you can reply

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-11 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r132808084 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionMapping.java --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 Thanks Matt. I will go through and reply later tonight. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 I will also post the review issues that I do not think have been touched on yet --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-11 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r132808147 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,436 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-12 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r132820984 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,436 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-12 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r132820993 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,436 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-12 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r132820881 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/VFSBundleClassLoader.java --- @@ -0,0 +1,515 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #692: METRON-1107 add support for handling epoch dates i...

2017-08-12 Thread ottobackwards
GitHub user ottobackwards opened a pull request: https://github.com/apache/metron/pull/692 METRON-1107 add support for handling epoch dates in seconds or milliseconds This PR adds the capability for the Stellar Date functions which take Long times to handle both seconds

[GitHub] metron pull request #690: METRON-1091 Package STELLAR shell as stand alone

2017-08-11 Thread ottobackwards
GitHub user ottobackwards opened a pull request: https://github.com/apache/metron/pull/690 METRON-1091 Package STELLAR shell as stand alone This PR adds metron-deployment/packaging/archive, and the metron-stellar-shell module. This module packages a stellar shell environment

[GitHub] metron issue #690: METRON-1091 Package STELLAR shell as stand alone

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/690 Casey, this adds a new packaging subfolder -> archive, and generates a new artifact ( the tar.gz ). It does not effect the current deployment of the stellar shell as a part of met

[GitHub] metron pull request #692: METRON-1107 add support for handling epoch dates i...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/692#discussion_r132958368 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/EpochUtils.java --- @@ -0,0 +1,44

[GitHub] metron pull request #692: METRON-1107 add support for handling epoch dates i...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/692#discussion_r132958347 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/EpochUtils.java --- @@ -0,0 +1,44

[GitHub] metron issue #692: METRON-1107 add support for handling epoch dates in secon...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/692 This is due to our time stuff being java Calendar based. We should have a new jira to convert to the new java.time concepts. --- *Comments from

[GitHub] metron issue #692: METRON-1107 add support for handling epoch dates in secon...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/692 *[metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/EpochUtils.java, line 41 at r1](https://reviewable.io:443/reviews

[GitHub] metron issue #692: METRON-1107 add support for handling epoch dates in secon...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/692 I'm going to close this. We need more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] metron pull request #692: METRON-1107 add support for handling epoch dates i...

2017-08-14 Thread ottobackwards
Github user ottobackwards closed the pull request at: https://github.com/apache/metron/pull/692 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] metron issue #692: METRON-1107 add support for handling epoch dates in secon...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/692 *[metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/DateFunctionsTest.java, line 248 at r1](https://reviewable.io:443

[GitHub] metron issue #692: METRON-1107 add support for handling epoch dates in secon...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/692 *[metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/EpochUtils.java, line 36 at r1](https://reviewable.io:443/reviews

[GitHub] metron issue #641: METRON-539: added HASH function for stellar.

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/641 https://reviewable.io/lgtm.png; height="20" width="61"/> --- *Comments from [Reviewable](https://reviewable.io:443/re

[GitHub] metron issue #278: Metron 451 SerDeUtils - java.lang.ClassNotFoundException:...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/278 What is the status of this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] metron pull request #667: METRON-1061 Add FUZZY_SCORE STELLAR function

2017-08-16 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/667#discussion_r133621065 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/TextFunctions.java --- @@ -0,0 +1,95

[GitHub] metron issue #681: METRON-1079 Add NaN as a keyword in STELLAR language

2017-08-16 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/681 I have added IS_NAN() --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-16 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133619468 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java --- @@ -121,33 +109,18 @@ private void unInit

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-16 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133619456 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java --- @@ -95,19 +91,11 @@ public static BundleClassLoaders

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-16 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133619481 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -103,61 +104,52 @@ private ExtensionManager

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-16 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133619506 --- Diff: bundles-lib/src/test/java/org/apache/metron/bundles/BundleThreadContextClassLoaderTest.java --- @@ -27,11 +27,21 @@ import

[GitHub] metron pull request #638: METRON-933 New stellar function for regex group ca...

2017-07-07 Thread ottobackwards
GitHub user ottobackwards opened a pull request: https://github.com/apache/metron/pull/638 METRON-933 New stellar function for regex group capture New Stellar function for capturing a group from a Regex Pattern. I created a new RegExFunctions in Stellar for this, and moved

[GitHub] metron pull request #652: METRON-1039: Add ZIP function to Stellar

2017-07-13 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/652#discussion_r127230597 --- Diff: metron-stellar/stellar-common/README.md --- @@ -711,6 +713,18 @@ In the core language functions, we support basic functional programming

[GitHub] metron issue #642: METRON-984 Stellar functions to decode encoded fields or ...

2017-07-13 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/642 Will do --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] metron issue #636: METRON-1022: Elasticsearch REST endpoint

2017-07-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/636 @cestella https://issues.apache.org/jira/browse/METRON-956 Is the jira I had created on this topic. --- If your project is set up for it, you can reply to this email and have your

[GitHub] metron pull request #650: METRON-1038: Stellar should have a better collecti...

2017-07-13 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/650#discussion_r127220966 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/MathFunctions.java --- @@ -25,17 +25,39 @@ import

[GitHub] metron pull request #650: METRON-1038: Stellar should have a better collecti...

2017-07-13 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/650#discussion_r127220715 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/MathFunctions.java --- @@ -25,17 +25,39 @@ import

[GitHub] metron pull request #652: METRON-1039: Add ZIP function to Stellar

2017-07-13 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/652#discussion_r127245708 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/FunctionalFunctionsTest.java --- @@ -24,13 +24,124

[GitHub] metron pull request #652: METRON-1039: Add ZIP function to Stellar

2017-07-13 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/652#discussion_r127245624 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/FunctionalFunctionsTest.java --- @@ -24,13 +24,124

[GitHub] metron issue #652: METRON-1039: Add ZIP function to Stellar

2017-07-13 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/652 +1 - built + test travis style, ran stellar cli. Nice work @cestella --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] metron pull request #650: METRON-1038: Stellar should have a better collecti...

2017-07-13 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/650#discussion_r127245372 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/MathFunctions.java --- @@ -25,17 +25,39 @@ import

  1   2   3   4   5   6   7   8   9   10   >