[
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12998022#comment-12998022
]
Sai Pullabhotla commented on FTPSERVER-357:
---
Can this marked as done and
[
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12856533#action_12856533
]
Sai Pullabhotla commented on FTPSERVER-357:
---
Niklas,
Any preference on the
[
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12856729#action_12856729
]
Niklas Gustavsson commented on FTPSERVER-357:
-
Oh, and let's create an issue
[
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12854506#action_12854506
]
Sai Pullabhotla commented on FTPSERVER-357:
---
I've refactored all classes to
[
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12853427#action_12853427
]
Sai Pullabhotla commented on FTPSERVER-357:
---
I'm wondering if we need to
[
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12853469#action_12853469
]
Sai Pullabhotla commented on FTPSERVER-357:
---
may not be a bad idea to just
[
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12853501#action_12853501
]
Niklas Gustavsson commented on FTPSERVER-357:
-
If we pass the entire
[
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12853515#action_12853515
]
Sai Pullabhotla commented on FTPSERVER-357:
---
How about calling the interface
[
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12853520#action_12853520
]
Niklas Gustavsson commented on FTPSERVER-357:
-
I think passing IoSession
[
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12853522#action_12853522
]
Sai Pullabhotla commented on FTPSERVER-357:
---
I like those. I will go ahead and
[
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12853524#action_12853524
]
Niklas Gustavsson commented on FTPSERVER-357:
-
Probably good to be
[
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12853525#action_12853525
]
Sai Pullabhotla commented on FTPSERVER-357:
---
Cool, I can do that. I will check
[
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12847289#action_12847289
]
David Latorre commented on FTPSERVER-357:
-
About the metho names... We are
[
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12847365#action_12847365
]
Sai Pullabhotla commented on FTPSERVER-357:
---
Okay guys, I think I updated the
[
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12847373#action_12847373
]
Niklas Gustavsson commented on FTPSERVER-357:
-
Yeah, since the Listener
[
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12847377#action_12847377
]
Sai Pullabhotla commented on FTPSERVER-357:
---
Well, I thought about that
[
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12847379#action_12847379
]
Niklas Gustavsson commented on FTPSERVER-357:
-
I think that makes perfect
[
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12847396#action_12847396
]
Sai Pullabhotla commented on FTPSERVER-357:
---
Well, I don't think we can
[
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12847397#action_12847397
]
Niklas Gustavsson commented on FTPSERVER-357:
-
So, if the user constructs
[
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12847084#action_12847084
]
Niklas Gustavsson commented on FTPSERVER-357:
-
Some comments on the patch:
*
[
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12847102#action_12847102
]
Sai Pullabhotla commented on FTPSERVER-357:
---
Oh, BTW, I missed an else block
[
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12847103#action_12847103
]
Sai Pullabhotla commented on FTPSERVER-357:
---
I think I can get it to work with
[
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12847107#action_12847107
]
Sai Pullabhotla commented on FTPSERVER-357:
---
I think I can get it to work with
[
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12847115#action_12847115
]
Niklas Gustavsson commented on FTPSERVER-357:
-
Yes, besides those details
24 matches
Mail list logo