[GitHub] [mina-sshd] benhumphreys commented on pull request #205: Set output and input encodings separately at end of KEX

2021-10-17 Thread GitBox
benhumphreys commented on pull request #205: URL: https://github.com/apache/mina-sshd/pull/205#issuecomment-945356928 Thanks @tomaswolf. I've also tested this branch and have found no problems. I expanded my testing a little to include OpenSSH 6.6.1p1, 8.1p, 8.2p1 and 8.8p1.

[GitHub] [mina-sshd] tomaswolf commented on pull request #205: Set output and input encodings separately at end of KEX

2021-10-17 Thread GitBox
tomaswolf commented on pull request #205: URL: https://github.com/apache/mina-sshd/pull/205#issuecomment-945151072 @benhumphreys since this changes sending of `server-sig-algs` and you apparently want to use that in Bitbucket Server you might want to double-check this change, too. (It

[GitHub] [mina-sshd] tomaswolf opened a new pull request #205: Set output and input encodings separately at end of KEX

2021-10-17 Thread GitBox
tomaswolf opened a new pull request #205: URL: https://github.com/apache/mina-sshd/pull/205 Once SSH_MSG_NEWKEYS is sent any subsequent packet sent must use the new encoding settings. Once SSH_MSG_NEWKEYS is received, the new encoding settings are to be used for any message received.

[GitHub] [mina-sshd] benhumphreys commented on pull request #204: [SSHD-1216] Server-side server-sig-algs KEX extension

2021-10-16 Thread GitBox
benhumphreys commented on pull request #204: URL: https://github.com/apache/mina-sshd/pull/204#issuecomment-944823080 Many thanks for this @tomaswolf I've dropped a snapshot build of your branch into Bitbucket Server to do some testing and it looks great! I've tested with OpenSSH 8.1p1

[GitHub] [mina-sshd] tomaswolf merged pull request #204: [SSHD-1216] Server-side server-sig-algs KEX extension

2021-10-16 Thread GitBox
tomaswolf merged pull request #204: URL: https://github.com/apache/mina-sshd/pull/204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mina-sshd] tomaswolf opened a new pull request #204: [SSHD-1216] Server-side server-sig-algs KEX extension

2021-10-16 Thread GitBox
tomaswolf opened a new pull request #204: URL: https://github.com/apache/mina-sshd/pull/204 Provide a default implementation for the server-side SSH_MSG_EXT_INFO message sending including the server-sig-algs KEX extension.[1] A server that implements the rsa-sha2-512 or

[GitHub] [mina-sshd] tomaswolf commented on pull request #204: [SSHD-1216] Server-side server-sig-algs KEX extension

2021-10-16 Thread GitBox
tomaswolf commented on pull request #204: URL: https://github.com/apache/mina-sshd/pull/204#issuecomment-944997065 Thanks for double-checking, @benhumphreys . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [mina-vysper] PrivacyDragon edited a comment on issue #21: TLS-handshake fails and certificates not recognized

2021-10-12 Thread GitBox
PrivacyDragon edited a comment on issue #21: URL: https://github.com/apache/mina-vysper/issues/21#issuecomment-940991704 I did something with keytools to create another, selfsigned, certificate that has a password and that kinda worked. I was able to get a client connected. But I had yo

[GitHub] [mina-vysper] PrivacyDragon commented on issue #21: TLS-handshake fails and certificates not recognized

2021-10-12 Thread GitBox
PrivacyDragon commented on issue #21: URL: https://github.com/apache/mina-vysper/issues/21#issuecomment-940991704 I did something with keytools to create another, selfsigned, certificate that has a password and that kinda worked. I was able to get a client connected. But I had yo

[GitHub] [mina-vysper] PrivacyDragon commented on issue #21: TLS-handshake fails and certificates not recognized

2021-10-12 Thread GitBox
PrivacyDragon commented on issue #21: URL: https://github.com/apache/mina-vysper/issues/21#issuecomment-940988682 With my own certificate : `Exception in thread "main" org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'server' defined in class path

[GitHub] [mina-vysper] PrivacyDragon removed a comment on issue #21: TLS-handshake fails and certificates not recognized

2021-10-12 Thread GitBox
PrivacyDragon removed a comment on issue #21: URL: https://github.com/apache/mina-vysper/issues/21#issuecomment-940983118 This is the error with my own certificate `12:50:00,723 | WARN | org.apache.vysper.mina.XmppIoHandlerAdapter | error caught on transportation layer: {}

[GitHub] [mina-vysper] PrivacyDragon commented on issue #21: TLS-handshake fails and certificates not recognized

2021-10-12 Thread GitBox
PrivacyDragon commented on issue #21: URL: https://github.com/apache/mina-vysper/issues/21#issuecomment-940983118 This is the error with my own certificate `12:50:00,723 | WARN | org.apache.vysper.mina.XmppIoHandlerAdapter | error caught on transportation layer: {}

[GitHub] [mina-vysper] PrivacyDragon commented on issue #21: TLS-handshake fails and certificates not recognized

2021-10-12 Thread GitBox
PrivacyDragon commented on issue #21: URL: https://github.com/apache/mina-vysper/issues/21#issuecomment-940888478 This is the error with the standard settings `06:38:18,115 | WARN | org.apache.vysper.mina.XmppIoHandlerAdapter | error caught on transportation layer: {}

[GitHub] [mina-vysper] PrivacyDragon opened a new issue #21: TLS-handshake fails and certificates not recognized

2021-10-12 Thread GitBox
PrivacyDragon opened a new issue #21: URL: https://github.com/apache/mina-vysper/issues/21 When I run the server with the standard certificate stuff, the server successfully starts and is reachable. Though the TLS-handshakes fail. And when I try to configure vysper to use my

[GitHub] [mina-sshd] tomaswolf opened a new pull request #203: [SSHD-1215] Treat ACE4_APPEND_DATA as a hint only

2021-10-09 Thread GitBox
tomaswolf opened a new pull request #203: URL: https://github.com/apache/mina-sshd/pull/203 Some SFTP clients in SFTP version >= V5 set the NFS desired-access flag ACE4_APPEND_DATA even when they only open the file for normal write access. SFTP append mode should be active only if the

[GitHub] [mina-sshd] gnodet merged pull request #202: [SSHD-1213] Update tarLongFileMode to use POSIX

2021-09-16 Thread GitBox
gnodet merged pull request #202: URL: https://github.com/apache/mina-sshd/pull/202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mina-sshd] rgdoliveira opened a new pull request #202: [SSHD-1213] Update tarLongFileMode to use POSIX

2021-09-15 Thread GitBox
rgdoliveira opened a new pull request #202: URL: https://github.com/apache/mina-sshd/pull/202 issue: https://issues.apache.org/jira/browse/SSHD-1213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [mina-sshd] smilesometimes commented on pull request #195: [SSHD-1163] Identify server key type by negotiation kex result parameters

2021-07-30 Thread GitBox
smilesometimes commented on pull request #195: URL: https://github.com/apache/mina-sshd/pull/195#issuecomment-889720855 yes, this can fix your case. > @smilesometimes can you have a look at this below issue, > > https://issues.apache.org/jira/browse/SSHD-1163 >

[GitHub] [mina-sshd] Susmit07 edited a comment on pull request #195: [SSHD-1163] Identify server key type by negotiation kex result parameters

2021-07-27 Thread GitBox
Susmit07 edited a comment on pull request #195: URL: https://github.com/apache/mina-sshd/pull/195#issuecomment-887511142 @smilesometimes can you have a look at this below issue, https://issues.apache.org/jira/browse/SSHD-1163 Will this fix can fix my use case as well? --

[GitHub] [mina-sshd] Susmit07 commented on pull request #195: [SSHD-1163] Identify server key type by negotiation kex result parameters

2021-07-27 Thread GitBox
Susmit07 commented on pull request #195: URL: https://github.com/apache/mina-sshd/pull/195#issuecomment-887511142 @smilesometimes can you have a look to this below issue, https://issues.apache.org/jira/browse/SSHD-1163 Will this fix can fix my use case as well? -- This is

[GitHub] [mina-sshd] tomaswolf merged pull request #201: [SSHD-1197] Fix race condition in KEX

2021-07-15 Thread GitBox
tomaswolf merged pull request #201: URL: https://github.com/apache/mina-sshd/pull/201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #201: [SSHD-1197] Fix race condition in KEX

2021-07-15 Thread GitBox
lgoldstein commented on a change in pull request #201: URL: https://github.com/apache/mina-sshd/pull/201#discussion_r670289418 ## File path: sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java ## @@ -109,6 +109,16 @@ */ public static

[GitHub] [mina-sshd] tomaswolf commented on a change in pull request #201: [SSHD-1197] Fix race condition in KEX

2021-07-15 Thread GitBox
tomaswolf commented on a change in pull request #201: URL: https://github.com/apache/mina-sshd/pull/201#discussion_r670204650 ## File path: sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java ## @@ -109,6 +109,16 @@ */ public static

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #201: [SSHD-1197] Fix race condition in KEX

2021-07-14 Thread GitBox
lgoldstein commented on a change in pull request #201: URL: https://github.com/apache/mina-sshd/pull/201#discussion_r670119533 ## File path: sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java ## @@ -109,6 +109,16 @@ */ public static

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #201: [SSHD-1197] Fix race condition in KEX

2021-07-14 Thread GitBox
lgoldstein commented on a change in pull request #201: URL: https://github.com/apache/mina-sshd/pull/201#discussion_r670119533 ## File path: sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java ## @@ -109,6 +109,16 @@ */ public static

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #201: [SSHD-1197] Fix race condition in KEX

2021-07-14 Thread GitBox
lgoldstein commented on a change in pull request #201: URL: https://github.com/apache/mina-sshd/pull/201#discussion_r670119533 ## File path: sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java ## @@ -109,6 +109,16 @@ */ public static

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #201: [SSHD-1197] Fix race condition in KEX

2021-07-14 Thread GitBox
lgoldstein commented on a change in pull request #201: URL: https://github.com/apache/mina-sshd/pull/201#discussion_r670119533 ## File path: sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java ## @@ -109,6 +109,16 @@ */ public static

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #201: [SSHD-1197] Fix race condition in KEX

2021-07-14 Thread GitBox
lgoldstein commented on a change in pull request #201: URL: https://github.com/apache/mina-sshd/pull/201#discussion_r670119533 ## File path: sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java ## @@ -109,6 +109,16 @@ */ public static

[GitHub] [mina-sshd] tomaswolf commented on a change in pull request #201: [SSHD-1197] Fix race condition in KEX

2021-07-13 Thread GitBox
tomaswolf commented on a change in pull request #201: URL: https://github.com/apache/mina-sshd/pull/201#discussion_r668998134 ## File path: sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java ## @@ -109,6 +109,16 @@ */ public static

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #201: [SSHD-1197] Fix race condition in KEX

2021-07-13 Thread GitBox
lgoldstein commented on a change in pull request #201: URL: https://github.com/apache/mina-sshd/pull/201#discussion_r668995415 ## File path: sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java ## @@ -109,6 +109,16 @@ */ public static

[GitHub] [mina-sshd] tomaswolf commented on a change in pull request #201: [SSHD-1197] Fix race condition in KEX

2021-07-13 Thread GitBox
tomaswolf commented on a change in pull request #201: URL: https://github.com/apache/mina-sshd/pull/201#discussion_r668992125 ## File path: sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java ## @@ -696,7 +702,18 @@ protected void

[GitHub] [mina-sshd] tomaswolf commented on a change in pull request #201: [SSHD-1197] Fix race condition in KEX

2021-07-13 Thread GitBox
tomaswolf commented on a change in pull request #201: URL: https://github.com/apache/mina-sshd/pull/201#discussion_r668991711 ## File path: sshd-sftp/src/test/java/org/apache/sshd/sftp/client/SftpTransferTest.java ## @@ -23,22 +23,39 @@ import java.io.InputStream; import

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #201: [SSHD-1197] Fix race condition in KEX

2021-07-13 Thread GitBox
lgoldstein commented on a change in pull request #201: URL: https://github.com/apache/mina-sshd/pull/201#discussion_r668893454 ## File path: sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java ## @@ -696,7 +702,18 @@ protected void

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #201: [SSHD-1197] Fix race condition in KEX

2021-07-13 Thread GitBox
lgoldstein commented on a change in pull request #201: URL: https://github.com/apache/mina-sshd/pull/201#discussion_r668893454 ## File path: sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java ## @@ -696,7 +702,18 @@ protected void

[GitHub] [mina-sshd] tomaswolf commented on pull request #201: [SSHD-1197] Fix race condition in KEX

2021-07-12 Thread GitBox
tomaswolf commented on pull request #201: URL: https://github.com/apache/mina-sshd/pull/201#issuecomment-878484411 @lgoldstein , do you agree with this way of fixing this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [mina-sshd] tomaswolf opened a new pull request #201: [SSHD-1197] Fix race condition in KEX

2021-07-12 Thread GitBox
tomaswolf opened a new pull request #201: URL: https://github.com/apache/mina-sshd/pull/201 There was a window in AbstractSession.requestNewKeyExchange() during which the KEX state was set already to INIT, but the caller's proposal not set yet. If the peer had also decided to start

[GitHub] [mina-sshd] jvz commented on pull request #176: [SSHD-1017] Add support for chacha20-poly1...@openssh.com

2021-07-11 Thread GitBox
jvz commented on pull request #176: URL: https://github.com/apache/mina-sshd/pull/176#issuecomment-877880570 Oh good to hear that because I was never able to figure out why anything wasn't working. Since I started these PRs, I've switched jobs where we use TLS instead of SSH as the secure

[GitHub] [mina-sshd] tomaswolf commented on pull request #176: [SSHD-1017] Add support for chacha20-poly1...@openssh.com

2021-07-11 Thread GitBox
tomaswolf commented on pull request #176: URL: https://github.com/apache/mina-sshd/pull/176#issuecomment-877871488 And it's in again. Chacha20-poly1305 has a block size of 8, and `AbstractSession` computed rekey limits for ciphers with block sizes < 16 wrongly, which caused

[GitHub] [mina-sshd] tomaswolf edited a comment on pull request #176: [SSHD-1017] Add support for chacha20-poly1...@openssh.com

2021-07-09 Thread GitBox
tomaswolf edited a comment on pull request #176: URL: https://github.com/apache/mina-sshd/pull/176#issuecomment-877242484 @jvz , I had to revert this. The hang in `SftpTransportTest`is caused by a KEX failure that occurs only if this chacha20-poly1305 implementation is used. A debug

[GitHub] [mina-sshd] tomaswolf commented on pull request #176: [SSHD-1017] Add support for chacha20-poly1...@openssh.com

2021-07-09 Thread GitBox
tomaswolf commented on pull request #176: URL: https://github.com/apache/mina-sshd/pull/176#issuecomment-877242484 @jvz , I had to revert this. The hang in `SftpTransportTest`is caused by a KEX failure that occurs only if this chacha20-poly1305 implementation is used. A debug log I

[GitHub] [mina-sshd] tomaswolf commented on pull request #176: [SSHD-1017] Add support for chacha20-poly1...@openssh.com

2021-07-08 Thread GitBox
tomaswolf commented on pull request #176: URL: https://github.com/apache/mina-sshd/pull/176#issuecomment-876663547 CI build still unstable; problems with that `LoadTest`. Works locally, so in it goes. Thanks a lot, Matt! -- This is an automated message from the Apache Git

[GitHub] [mina-sshd] tomaswolf merged pull request #176: [SSHD-1017] Add support for chacha20-poly1...@openssh.com

2021-07-08 Thread GitBox
tomaswolf merged pull request #176: URL: https://github.com/apache/mina-sshd/pull/176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mina-sshd] jvz commented on pull request #176: [SSHD-1017] Add support for chacha20-poly1...@openssh.com

2021-07-08 Thread GitBox
jvz commented on pull request #176: URL: https://github.com/apache/mina-sshd/pull/176#issuecomment-876618618 Go ahead! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [mina-sshd] tomaswolf commented on pull request #176: [SSHD-1017] Add support for chacha20-poly1...@openssh.com

2021-07-08 Thread GitBox
tomaswolf commented on pull request #176: URL: https://github.com/apache/mina-sshd/pull/176#issuecomment-876589754 `SftpTransferTest` hanging is now issue [SSHD-1191](https://issues.apache.org/jira/browse/SSHD-1191). It took a while, but I finally managed to get a clean test run

[GitHub] [mina-sshd] tomaswolf closed pull request #200: [SSHD-1182] skip() doesn't work properly in SftpInputStreamAsync

2021-07-08 Thread GitBox
tomaswolf closed pull request #200: URL: https://github.com/apache/mina-sshd/pull/200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mina-sshd] tomaswolf commented on pull request #200: [SSHD-1182] skip() doesn't work properly in SftpInputStreamAsync

2021-07-08 Thread GitBox
tomaswolf commented on pull request #200: URL: https://github.com/apache/mina-sshd/pull/200#issuecomment-876175197 Squashed and merged as commit 6a8e2eec3. Thank you, Pavel! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [mina-sshd] tomaswolf commented on pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-07-08 Thread GitBox
tomaswolf commented on pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#issuecomment-876153230 Merged. Thanks a lot, Alex! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [mina-sshd] tomaswolf merged pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-07-08 Thread GitBox
tomaswolf merged pull request #198: URL: https://github.com/apache/mina-sshd/pull/198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mina-vysper] kkawai commented on issue #15: Startup script fails: "Could not find or load main class org.apache.vysper.spring.ServerMain"

2021-07-07 Thread GitBox
kkawai commented on issue #15: URL: https://github.com/apache/mina-vysper/issues/15#issuecomment-875457357 i got the same issue Error: Could not find or load main class org.apache.vysper.spring.ServerMain -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [mina-sshd] alex-sherwin commented on pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-07-06 Thread GitBox
alex-sherwin commented on pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#issuecomment-875080514 @tomaswolf The changes you pushed LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [mina-sshd] alex-sherwin commented on pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-07-03 Thread GitBox
alex-sherwin commented on pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#issuecomment-873407761 @tomaswolf Sure that would be fine with me Thanks for that, apologies I didn't get to it myself yet -- This is an automated message from the Apache Git Service. To

[GitHub] [mina-sshd] tomaswolf commented on pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-07-03 Thread GitBox
tomaswolf commented on pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#issuecomment-873403363 @alex-sherwin I got now a version of this change with all this fixed (builder still in sshd-core, though), plus with a problem in signature verification fixed. Would it be

[GitHub] [mina-sshd] tomaswolf commented on pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-07-02 Thread GitBox
tomaswolf commented on pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#issuecomment-873227084 In the `GenerateOpenSSHClientCertificateTest` the generated certificate apparently always uses rsa-sha2-512 for signing with RSA CA keys. Does the `OpenSshCertificateBuilder`

[GitHub] [mina-sshd] pstetsuk opened a new pull request #200: [SSHD-1182] skip() doesn't work properly in SftpInputStreamAsync

2021-06-15 Thread GitBox
pstetsuk opened a new pull request #200: URL: https://github.com/apache/mina-sshd/pull/200 modified `SftpTest.testInputStreamSkipAndReset()` to reproduce this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [mina-sshd] gnodet merged pull request #199: Sshd 1181

2021-06-14 Thread GitBox
gnodet merged pull request #199: URL: https://github.com/apache/mina-sshd/pull/199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [mina-sshd] gnodet opened a new pull request #199: Sshd 1181

2021-06-14 Thread GitBox
gnodet opened a new pull request #199: URL: https://github.com/apache/mina-sshd/pull/199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [mina-sshd] gnodet commented on pull request #199: Sshd 1181

2021-06-14 Thread GitBox
gnodet commented on pull request #199: URL: https://github.com/apache/mina-sshd/pull/199#issuecomment-859611076 I think the number of requests sent for downloading small files is not really optimal. This could be improved. -- This is an automated message from the Apache Git Service. To

[GitHub] [mina-sshd] alex-sherwin commented on pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-06-09 Thread GitBox
alex-sherwin commented on pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#issuecomment-858040806 This PR should be ready for re-review, all the suggestions have been implemented -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mina-ftpserver] avnerw74 commented on issue #1: Is there a way to configure ftpserver to limit SSL level only to TLS 1.2 or later?

2021-06-08 Thread GitBox
avnerw74 commented on issue #1: URL: https://github.com/apache/mina-ftpserver/issues/1#issuecomment-856564681 - -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [mina-ftpserver] avnerw74 closed issue #1: Is there a way to configure ftpserver to limit SSL level only to TLS 1.2 or later?

2021-06-08 Thread GitBox
avnerw74 closed issue #1: URL: https://github.com/apache/mina-ftpserver/issues/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [mina-sshd] alex-sherwin commented on a change in pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-06-04 Thread GitBox
alex-sherwin commented on a change in pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#discussion_r645085978 ## File path: sshd-common/src/main/java/org/apache/sshd/common/config/keys/OpenSshCertificate.java ## @@ -52,26 +57,34 @@ Collection

[GitHub] [mina-sshd] alex-sherwin commented on a change in pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-06-03 Thread GitBox
alex-sherwin commented on a change in pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#discussion_r645088251 ## File path: sshd-common/src/main/java/org/apache/sshd/common/config/keys/OpenSshCertificate.java ## @@ -52,26 +57,34 @@ Collection

[GitHub] [mina-sshd] alex-sherwin commented on a change in pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-06-03 Thread GitBox
alex-sherwin commented on a change in pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#discussion_r645086073 ## File path: sshd-core/src/main/java/org/apache/sshd/certificate/OpenSshCertificateSignRequest.java ## @@ -0,0 +1,136 @@ +/* + * Licensed to the

[GitHub] [mina-sshd] alex-sherwin commented on a change in pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-06-03 Thread GitBox
alex-sherwin commented on a change in pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#discussion_r645085978 ## File path: sshd-common/src/main/java/org/apache/sshd/common/config/keys/OpenSshCertificate.java ## @@ -52,26 +57,34 @@ Collection

[GitHub] [mina-site] gnodet merged pull request #4: Added Jenkinsfile to put deployment configuration in version control

2021-05-31 Thread GitBox
gnodet merged pull request #4: URL: https://github.com/apache/mina-site/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [mina-sshd] smilesometimes edited a comment on pull request #195: [SSHD-1163] Identify server key type by negotiation kex result parameters

2021-05-30 Thread GitBox
smilesometimes edited a comment on pull request #195: URL: https://github.com/apache/mina-sshd/pull/195#issuecomment-851009117 The latter. it was wrong before, but with this correction it's good. maxTraydakalo's commit is right. Today I have met this bug, my ssh server can not

[GitHub] [mina-sshd] smilesometimes edited a comment on pull request #195: [SSHD-1163] Identify server key type by negotiation kex result parameters

2021-05-30 Thread GitBox
smilesometimes edited a comment on pull request #195: URL: https://github.com/apache/mina-sshd/pull/195#issuecomment-851009117 The latter. it was wrong before, but with this correction it's good. maxTraydakalo's commit is right. Today I have met this bug, my ssh server can not

[GitHub] [mina-sshd] smilesometimes edited a comment on pull request #195: [SSHD-1163] Identify server key type by negotiation kex result parameters

2021-05-30 Thread GitBox
smilesometimes edited a comment on pull request #195: URL: https://github.com/apache/mina-sshd/pull/195#issuecomment-851009117 The latter. it was wrong before, but with this correction it's good. maxTraydakalo's commit is right. Today I have met this bug, my ssh server can not

[GitHub] [mina-sshd] smilesometimes edited a comment on pull request #195: [SSHD-1163] Identify server key type by negotiation kex result parameters

2021-05-30 Thread GitBox
smilesometimes edited a comment on pull request #195: URL: https://github.com/apache/mina-sshd/pull/195#issuecomment-851009117 Oh ,maxTraydakalo's commit is right. Today I have met this bug, my ssh server can not connect, i modify the client sshd config like this: `

[GitHub] [mina-sshd] smilesometimes edited a comment on pull request #195: [SSHD-1163] Identify server key type by negotiation kex result parameters

2021-05-30 Thread GitBox
smilesometimes edited a comment on pull request #195: URL: https://github.com/apache/mina-sshd/pull/195#issuecomment-851009117 Oh ,maxTraydakalo's commit is right. Today I have met this bug, my device can not connect. ` // client config like this, cannot connet

[GitHub] [mina-sshd] smilesometimes commented on pull request #195: [SSHD-1163] Identify server key type by negotiation kex result parameters

2021-05-30 Thread GitBox
smilesometimes commented on pull request #195: URL: https://github.com/apache/mina-sshd/pull/195#issuecomment-851009117 Oh ,maxTraydakalo's commit is right. Today I have met this bug, my device can not connect. ` // client config like this, cannot connet KexAlgorithms =

[GitHub] [mina-sshd] tomaswolf commented on pull request #195: [SSHD-1163] Identify server key type by negotiation kex result parameters

2021-05-30 Thread GitBox
tomaswolf commented on pull request #195: URL: https://github.com/apache/mina-sshd/pull/195#issuecomment-851007205 @smilesometimes : I don't understand what you are writing. Are you saying this correction is wrong? Or are you saying it was wrong before, but with this correction it's good?

[GitHub] [mina-sshd] smilesometimes edited a comment on pull request #195: [SSHD-1163] Identify server key type by negotiation kex result parameters

2021-05-30 Thread GitBox
smilesometimes edited a comment on pull request #195: URL: https://github.com/apache/mina-sshd/pull/195#issuecomment-850988381 HAHHA, I find this commit , this is a bug . At begining i was wondering why the method of getting keyAlgin

[GitHub] [mina-sshd] smilesometimes edited a comment on pull request #195: [SSHD-1163] Identify server key type by negotiation kex result parameters

2021-05-30 Thread GitBox
smilesometimes edited a comment on pull request #195: URL: https://github.com/apache/mina-sshd/pull/195#issuecomment-850988381 HAHHA, I find this commit , this is a bug . At begining i was wondering why the method of getting keyAlgin

[GitHub] [mina-sshd] smilesometimes edited a comment on pull request #195: [SSHD-1163] Identify server key type by negotiation kex result parameters

2021-05-30 Thread GitBox
smilesometimes edited a comment on pull request #195: URL: https://github.com/apache/mina-sshd/pull/195#issuecomment-850988381 HAHHA, I find this commit , this is a bug . At begining i was wondering why the method of getting keyAlgin

[GitHub] [mina-sshd] smilesometimes edited a comment on pull request #195: [SSHD-1163] Identify server key type by negotiation kex result parameters

2021-05-30 Thread GitBox
smilesometimes edited a comment on pull request #195: URL: https://github.com/apache/mina-sshd/pull/195#issuecomment-850988381 HAHHA, I find this commit , this is a bug . At begining i was wondering why the method of getting keyAlgin

[GitHub] [mina-sshd] smilesometimes commented on pull request #195: [SSHD-1163] Identify server key type by negotiation kex result parameters

2021-05-30 Thread GitBox
smilesometimes commented on pull request #195: URL: https://github.com/apache/mina-sshd/pull/195#issuecomment-850988381 HAHHA, I find this commit , this is a bug . At begining i was wondering why the method of getting keyAlgin

[GitHub] [mina-sshd] tomaswolf closed pull request #195: [SSHD-1163] Identify server key type by negotiation kex result parameters

2021-05-29 Thread GitBox
tomaswolf closed pull request #195: URL: https://github.com/apache/mina-sshd/pull/195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [mina-sshd] tomaswolf commented on pull request #195: [SSHD-1163] Identify server key type by negotiation kex result parameters

2021-05-29 Thread GitBox
tomaswolf commented on pull request #195: URL: https://github.com/apache/mina-sshd/pull/195#issuecomment-850904287 Rebase and merged as commit 67eadba1. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [mina-sshd] tomaswolf closed pull request #196: [SSHD-1164] - fixed parsing of sshd_config "Host" lines to collapse spaces

2021-05-29 Thread GitBox
tomaswolf closed pull request #196: URL: https://github.com/apache/mina-sshd/pull/196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [mina-sshd] tomaswolf commented on pull request #196: [SSHD-1164] - fixed parsing of sshd_config "Host" lines to collapse spaces

2021-05-29 Thread GitBox
tomaswolf commented on pull request #196: URL: https://github.com/apache/mina-sshd/pull/196#issuecomment-850886601 I've merged this as commit 267887a8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [mina-sshd] tomaswolf commented on a change in pull request #196: [SSHD-1164] - fixed parsing of sshd_config "Host" lines to collapse spaces

2021-05-29 Thread GitBox
tomaswolf commented on a change in pull request #196: URL: https://github.com/apache/mina-sshd/pull/196#discussion_r641974333 ## File path: sshd-common/src/main/java/org/apache/sshd/common/util/GenericUtils.java ## @@ -196,6 +196,49 @@ public static boolean

[GitHub] [mina-sshd] alex-sherwin commented on a change in pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-05-28 Thread GitBox
alex-sherwin commented on a change in pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#discussion_r641730192 ## File path: sshd-common/src/main/java/org/apache/sshd/common/config/keys/OpenSshCertificate.java ## @@ -52,26 +57,34 @@ Collection

[GitHub] [mina-sshd] alex-sherwin commented on a change in pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-05-28 Thread GitBox
alex-sherwin commented on a change in pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#discussion_r641729258 ## File path: sshd-core/src/main/java/org/apache/sshd/certificate/OpenSshCertificateSignRequest.java ## @@ -0,0 +1,136 @@ +/* + * Licensed to the

[GitHub] [mina-sshd] tomaswolf commented on a change in pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-05-28 Thread GitBox
tomaswolf commented on a change in pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#discussion_r641727530 ## File path: sshd-common/src/main/java/org/apache/sshd/common/config/keys/OpenSshCertificate.java ## @@ -52,26 +57,34 @@ Collection

[GitHub] [mina-sshd] alex-sherwin commented on a change in pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-05-28 Thread GitBox
alex-sherwin commented on a change in pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#discussion_r641715721 ## File path: sshd-common/src/main/java/org/apache/sshd/common/config/keys/OpenSshCertificate.java ## @@ -52,26 +57,34 @@ Collection

[GitHub] [mina-sshd] tomaswolf commented on a change in pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-05-28 Thread GitBox
tomaswolf commented on a change in pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#discussion_r641700724 ## File path: sshd-common/src/main/java/org/apache/sshd/common/config/keys/OpenSshCertificate.java ## @@ -52,26 +57,34 @@ Collection

[GitHub] [mina-sshd] alex-sherwin commented on a change in pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-05-28 Thread GitBox
alex-sherwin commented on a change in pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#discussion_r641669298 ## File path: sshd-common/src/main/java/org/apache/sshd/common/config/keys/OpenSshCertificate.java ## @@ -52,26 +57,34 @@ Collection

[GitHub] [mina-sshd] alex-sherwin commented on a change in pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-05-28 Thread GitBox
alex-sherwin commented on a change in pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#discussion_r641669298 ## File path: sshd-common/src/main/java/org/apache/sshd/common/config/keys/OpenSshCertificate.java ## @@ -52,26 +57,34 @@ Collection

[GitHub] [mina-sshd] alex-sherwin commented on a change in pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-05-28 Thread GitBox
alex-sherwin commented on a change in pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#discussion_r641662142 ## File path: sshd-common/src/main/java/org/apache/sshd/common/config/keys/OpenSshCertificate.java ## @@ -52,26 +57,34 @@ Collection

[GitHub] [mina-sshd] alex-sherwin commented on a change in pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-05-28 Thread GitBox
alex-sherwin commented on a change in pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#discussion_r641662142 ## File path: sshd-common/src/main/java/org/apache/sshd/common/config/keys/OpenSshCertificate.java ## @@ -52,26 +57,34 @@ Collection

[GitHub] [mina-sshd] alex-sherwin commented on a change in pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-05-28 Thread GitBox
alex-sherwin commented on a change in pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#discussion_r641662142 ## File path: sshd-common/src/main/java/org/apache/sshd/common/config/keys/OpenSshCertificate.java ## @@ -52,26 +57,34 @@ Collection

[GitHub] [mina-sshd] alex-sherwin commented on a change in pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-05-28 Thread GitBox
alex-sherwin commented on a change in pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#discussion_r641662142 ## File path: sshd-common/src/main/java/org/apache/sshd/common/config/keys/OpenSshCertificate.java ## @@ -52,26 +57,34 @@ Collection

[GitHub] [mina-sshd] alex-sherwin commented on a change in pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-05-28 Thread GitBox
alex-sherwin commented on a change in pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#discussion_r641662142 ## File path: sshd-common/src/main/java/org/apache/sshd/common/config/keys/OpenSshCertificate.java ## @@ -52,26 +57,34 @@ Collection

[GitHub] [mina-sshd] alex-sherwin commented on a change in pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-05-28 Thread GitBox
alex-sherwin commented on a change in pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#discussion_r641662142 ## File path: sshd-common/src/main/java/org/apache/sshd/common/config/keys/OpenSshCertificate.java ## @@ -52,26 +57,34 @@ Collection

[GitHub] [mina-sshd] alex-sherwin commented on a change in pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-05-28 Thread GitBox
alex-sherwin commented on a change in pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#discussion_r641642577 ## File path: sshd-common/src/main/java/org/apache/sshd/common/config/keys/OpenSshCertificateImpl.java ## @@ -229,8 +228,81 @@ public String

[GitHub] [mina-sshd] tomaswolf commented on a change in pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-05-28 Thread GitBox
tomaswolf commented on a change in pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#discussion_r641633383 ## File path: sshd-common/src/main/java/org/apache/sshd/common/config/keys/OpenSshCertificate.java ## @@ -52,26 +57,34 @@ Collection

[GitHub] [mina-sshd] alex-sherwin commented on a change in pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-05-28 Thread GitBox
alex-sherwin commented on a change in pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#discussion_r641627958 ## File path: sshd-common/src/main/java/org/apache/sshd/common/config/keys/OpenSshCertificate.java ## @@ -52,26 +57,34 @@ Collection

[GitHub] [mina-sshd] tomaswolf commented on a change in pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-05-28 Thread GitBox
tomaswolf commented on a change in pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#discussion_r641363368 ## File path: sshd-common/src/main/java/org/apache/sshd/common/config/keys/OpenSshCertificate.java ## @@ -91,7 +104,83 @@ */ static boolean

[GitHub] [mina-sshd] tomaswolf commented on a change in pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

2021-05-28 Thread GitBox
tomaswolf commented on a change in pull request #198: URL: https://github.com/apache/mina-sshd/pull/198#discussion_r641321729 ## File path: sshd-common/src/main/java/org/apache/sshd/common/config/keys/OpenSshCertificate.java ## @@ -35,6 +36,10 @@ int SSH_CERT_TYPE_USER =

<    3   4   5   6   7   8   9   10   11   12   >