pnicolucci commented on code in PR #484:
URL: https://github.com/apache/myfaces/pull/484#discussion_r1081647278
##
impl/src/main/java/org/apache/myfaces/component/validate/ValidateWholeBeanComponent.java:
##
@@ -55,6 +62,79 @@ public void addValidator(Validator validator)
melloware commented on code in PR #484:
URL: https://github.com/apache/myfaces/pull/484#discussion_r1081643678
##
impl/src/main/java/org/apache/myfaces/component/validate/ValidateWholeBeanComponent.java:
##
@@ -55,6 +62,79 @@ public void addValidator(Validator validator)
volosied commented on code in PR #484:
URL: https://github.com/apache/myfaces/pull/484#discussion_r1081638859
##
impl/src/main/java/org/apache/myfaces/component/validate/ValidateWholeBeanComponent.java:
##
@@ -55,6 +62,79 @@ public void addValidator(Validator validator)
[
https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678824#comment-17678824
]
Volodymyr Siedlecki commented on MYFACES-4533:
--
viewRoot is null at this point, so we
[
https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678818#comment-17678818
]
Volodymyr Siedlecki commented on MYFACES-4533:
--
Thanks for your work on this! I looked
[
https://issues.apache.org/jira/browse/MYFACES-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678816#comment-17678816
]
Thomas Andraschko commented on MYFACES-4547:
if you have time, sure, why not
>
tandraschko commented on code in PR #484:
URL: https://github.com/apache/myfaces/pull/484#discussion_r1081560352
##
impl/src/main/java/org/apache/myfaces/component/validate/ValidateWholeBeanComponent.java:
##
@@ -55,6 +62,79 @@ public void addValidator(Validator validator)
[
https://issues.apache.org/jira/browse/MYFACES-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678808#comment-17678808
]
Paul Nicolucci commented on MYFACES-4547:
-
[~tandraschko] [~melloware] do you guys want this
[
https://issues.apache.org/jira/browse/MYFACES-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678803#comment-17678803
]
Melloware commented on MYFACES-4497:
[~tandraschko] should we mark this as wontfix? This is just
[
https://issues.apache.org/jira/browse/MYFACES-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Melloware resolved MYFACES-4547.
Resolution: Fixed
> FacesContext.getCurrentInstance().getELContext().getVariableMapper() returns
melloware commented on PR #490:
URL: https://github.com/apache/myfaces/pull/490#issuecomment-1397284105
Yep will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
volosied commented on PR #484:
URL: https://github.com/apache/myfaces/pull/484#issuecomment-1397250048
We would need to address that via a TCK challenge since Mojarra checks it by
default.
But I agree that that this check makes sense during development, not
production.
--
This
tandraschko commented on PR #490:
URL: https://github.com/apache/myfaces/pull/490#issuecomment-1397247618
@melloware if you merge PRs, please always update the JIRA issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
tandraschko commented on PR #484:
URL: https://github.com/apache/myfaces/pull/484#issuecomment-1397245565
i should we should also only check this if projecstage == development
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dependabot[bot] opened a new pull request, #3690:
URL: https://github.com/apache/myfaces-tobago/pull/3690
Bumps `spring-boot.version` from 2.7.7 to 2.7.8.
Updates `spring-boot` from 2.7.7 to 2.7.8
Release notes
Sourced from
volosied commented on PR #484:
URL: https://github.com/apache/myfaces/pull/484#issuecomment-1397208218
Indented some of the nested statements / blocks so it should look better.
Will merge once the CI build completes.
--
This is an automated message from the Apache Git Service.
To
volosied commented on PR #484:
URL: https://github.com/apache/myfaces/pull/484#issuecomment-1397205447
Not a fan of the formatting either, but I get check style exceptions if the
bracket's aren't on a new line.
--
This is an automated message from the Apache Git Service.
To respond to
melloware merged PR #490:
URL: https://github.com/apache/myfaces/pull/490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tandraschko commented on PR #490:
URL: https://github.com/apache/myfaces/pull/490#issuecomment-1397171224
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
[
https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678756#comment-17678756
]
Werner Punz edited comment on MYFACES-4533 at 1/19/23 3:17 PM:
---
I have
[
https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678756#comment-17678756
]
Werner Punz commented on MYFACES-4533:
--
I have added my current state
werpu closed pull request #491: Feature/myfaces 4466 tck790
URL: https://github.com/apache/myfaces/pull/491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
werpu commented on PR #491:
URL: https://github.com/apache/myfaces/pull/491#issuecomment-1397127792
closing it... a pr is not what is needed for further work on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
werpu opened a new pull request, #491:
URL: https://github.com/apache/myfaces/pull/491
Do not merge this pull request, but use it for further changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
pnicolucci opened a new pull request, #490:
URL: https://github.com/apache/myfaces/pull/490
https://issues.apache.org/jira/browse/MYFACES-4547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678723#comment-17678723
]
Werner Punz commented on MYFACES-4533:
--
I have everything except the named nav case working now,
tandraschko commented on PR #484:
URL: https://github.com/apache/myfaces/pull/484#issuecomment-1396901570
yep but IMO the myfaces checkstyle is not configured hard enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
melloware commented on PR #484:
URL: https://github.com/apache/myfaces/pull/484#issuecomment-1396897303
@tandraschko i thought we had checkstyle on this project? Shouldn't it
catch indention issues?
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678634#comment-17678634
]
Werner Punz edited comment on MYFACES-4533 at 1/19/23 11:16 AM:
Ok I
[
https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678634#comment-17678634
]
Werner Punz commented on MYFACES-4533:
--
Ok I did quickly all the needed changes on my 4466 branch
bohmber merged PR #489:
URL: https://github.com/apache/myfaces/pull/489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tandraschko commented on PR #484:
URL: https://github.com/apache/myfaces/pull/484#issuecomment-1396634133
the indentations are looking bit weird/to small? otherwise +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678526#comment-17678526
]
Werner Punz edited comment on MYFACES-4533 at 1/19/23 8:40 AM:
---
I
bohmber commented on PR #356:
URL: https://github.com/apache/myfaces/pull/356#issuecomment-1396619947
I would like to see this merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678526#comment-17678526
]
Werner Punz edited comment on MYFACES-4533 at 1/19/23 8:39 AM:
---
I
Hi Paul,
there is no harm to leave it but there is also no benefit AFAICS as
getFeatureDescriptors isnt really used.
It was just a idea to cleanup code.
But we can leave it as it is for now and do it in EE11.
Am Mi., 18. Jan. 2023 um 20:31 Uhr schrieb Paul Nicolucci <
pnicolu...@gmail.com>:
>
36 matches
Mail list logo
