Re: Assembling LICENSE and NOTICE

2017-09-19 Thread Jan Lahoda
So far, when I was thinking of this, my thoughts regarding external libraries were like this: AFAIK, currently, every external library is expected to have a "-license.txt" file attached (with the license of the given library), and the build is then merging them into a single file for the given

Sample code license [WAS: Re: NetBeans has landed in Apache Git]

2017-09-19 Thread Emilian Bold
> As a side note, some files in the repository (typically samples) are using > 3-clause (if I get that correctly) BSD license Last time this was a talking point you couldn't tweak the installer without changing the source code that was under the standard CDDL + GPL w/ CPE license. So each custom

[GitHub] incubator-netbeans pull request #2: Allow custom authenticator

2017-09-19 Thread phansson
Github user phansson commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/2#discussion_r139604336 --- Diff: o.n.core/src/org/netbeans/core/NbAuthenticator.java --- @@ -71,7 +74,19 @@ private NbAuthenticator() { static void

[GitHub] incubator-netbeans pull request #2: Allow custom authenticator

2017-09-19 Thread emilianbold
Github user emilianbold commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/2#discussion_r139607093 --- Diff: o.n.core/src/org/netbeans/core/NbAuthenticator.java --- @@ -71,7 +74,19 @@ private NbAuthenticator() { static void

Re: NetBeans has landed in Apache Git

2017-09-19 Thread Jan Lahoda
I can try to categorize the files a little, but I was hoping we could switch to using Rat to do the checks (after the bulk of the changes are done). So if e.g. the META-INF files would be OK to not have a header, we could simply exclude them in the Rat configuration, and they would be ignored (but

[GitHub] incubator-netbeans pull request #2: Allow custom authenticator

2017-09-19 Thread phansson
Github user phansson commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/2#discussion_r139614856 --- Diff: o.n.core/src/org/netbeans/core/NbAuthenticator.java --- @@ -71,7 +74,19 @@ private NbAuthenticator() { static void

Re: Assembling LICENSE and NOTICE

2017-09-19 Thread Geertjan Wielenga
I believe that's correct based on the comments in this thread. Gj On Tue, 19 Sep 2017 at 12:10, Jan Lahoda wrote: > On Tue, Sep 19, 2017 at 3:31 PM, Bertrand Delacretaz < > bdelacre...@apache.org > > wrote: > > > Hi, > > > > On Tue, Sep 19, 2017 at 9:36 AM, Jan Lahoda

Re: NetBeans has landed in Apache Git

2017-09-19 Thread Geertjan Wielenga
Sounds like a plan -- I'll use the tool to convert the licenses to Apache, push that to Git, and then we'll use Rat to narrow down the remainder. How does that sound to everyone? Gj On Tue, 19 Sep 2017 at 08:50, Jan Lahoda wrote: > I can try to categorize the files a

[GitHub] incubator-netbeans issue #1: Feature/248233 - Shortcuts for document splitti...

2017-09-19 Thread jlahoda
Github user jlahoda commented on the issue: https://github.com/apache/incubator-netbeans/pull/1 Chris, as was discussed elsewhere, the patches change line endings to Windows line endings (CRLF), and so look like deletion and addition of each line in the file (including the license

Re: NetBeans has landed in Apache Git

2017-09-19 Thread Geertjan Wielenga
Good idea. Can you do this, Jan? Gj On Tue, 19 Sep 2017 at 14:25, Bertrand Delacretaz wrote: > Hi, > > On Sun, Sep 17, 2017 at 5:06 PM, Jan Lahoda wrote: > > ...I've uploaded an updated version of the tool... > > You mean the tool is not in Git? I

Re: NetBeans has landed in Apache Git

2017-09-19 Thread Geertjan Wielenga
Could it be a subfolder in this incubator-netbeans? Or a new repo since the tool will be useful for other NetBeans repos too: incubator-netbeans-tools. There may be more scripts and things we'll be needing. Gj On Tue, 19 Sep 2017 at 15:08, Jaroslav Tulach wrote: >

[GitHub] incubator-netbeans issue #1: Feature/248233 - Shortcuts for document splitti...

2017-09-19 Thread tusharvjoshi
Github user tusharvjoshi commented on the issue: https://github.com/apache/incubator-netbeans/pull/1 I verified the steps provided in JIRA ticket as follows: 1. Open any document what you want 2. Hit ctrl + shift + h to split the document horizontally 3. Hit ctrl + shift +

Re: Sample code license [WAS: Re: NetBeans has landed in Apache Git]

2017-09-19 Thread Bertrand Delacretaz
Hi, On Tue, Sep 19, 2017 at 9:58 AM, Emilian Bold wrote: >> ...some files in the repository (typically samples) are using 3-clause (if I >> get that correctly) BSD license... If those files have been donated to Apache they can be relicensed, and IMO they should, in

Re: NetBeans has landed in Apache Git

2017-09-19 Thread Jan Lahoda
Hi Bertrand, The tool is currently a zip attached to the wiki - but the zip contains a git repository, so no history is lost. I just tried to create a new repository (incubator-netbeans-tools) using: https://reporeq.apache.org/ but it seems I cannot create such a repository. Aside for this, any

Re: Assembling LICENSE and NOTICE

2017-09-19 Thread Bertrand Delacretaz
Hi, On Tue, Sep 19, 2017 at 9:36 AM, Jan Lahoda wrote: > ...I think we could enhance this with adding a > "-notice.txt" attached to each library and adjusting the build to produce a > composite LICENSE and NOTICE files based on data from modules that are > being built into the

Re: NetBeans has landed in Apache Git

2017-09-19 Thread Jaroslav Tulach
On úterý 19. září 2017 11:33:03 CEST Geertjan Wielenga wrote: > PS: re the samples, I propse we remove the NetBeans Platform samples, e.g., > FeedReader. These samples are old and include code and approaches that one > wouldn't use anymore, e.g., TopComponents manually registered in layer >

Re: NetBeans has landed in Apache Git

2017-09-19 Thread Jaroslav Tulach
On úterý 19. září 2017 15:24:53 CEST Bertrand Delacretaz wrote: > Hi, > > On Sun, Sep 17, 2017 at 5:06 PM, Jan Lahoda wrote: > > ...I've uploaded an updated version of the tool... > > You mean the tool is not in Git? I think it should, maybe using a > specific "tools"

Re: Assembling LICENSE and NOTICE

2017-09-19 Thread Ate Douma
On 2017-09-19 06:16, Geertjan Wielenga wrote: Many thanks for all these details. Two things jump out at me: 1. "those NOTICE and LICENSE files *only* refer and apply to what has been checked into the (that!) git/subversion source tree, *nothing else*. So no references to 3rd party dependencies

Re: Assembling LICENSE and NOTICE

2017-09-19 Thread Jan Lahoda
On Tue, Sep 19, 2017 at 3:31 PM, Bertrand Delacretaz wrote: > Hi, > > On Tue, Sep 19, 2017 at 9:36 AM, Jan Lahoda wrote: > > ...I think we could enhance this with adding a > > "-notice.txt" attached to each library and adjusting the build to > produce