GitHub user jlahoda opened a pull request:
https://github.com/apache/incubator-netbeans/pull/130
Cache external binaries downloaded from maven in NetBeans' cache.
Currently for maven external dependencies, the build is downloading them
from the internet each time it is missing in th
Three modules have external binaries that are not available in Maven, so
I opened issue #86 for this.
https://issues.apache.org/jira/projects/NETBEANS/issues/NETBEANS-86
I'm not sure how issues should be created in JIRA, don't know if we're
using all fields there, so here're some questions:
Hi all,
The "lib.terminalemulator" module has some _example_ zip files with
platform specific executables that can start processes in the host os.
These are "process_start-linux-intel.zip" & friends. I think these are
here just for historical purposes as a demonstration of the capabilities
of
Github user junichi11 commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/117#discussion_r144196133
--- Diff: j2ee.persistence/test/unit/data/invalid_persistence.xml ---
@@ -1,8 +1,25 @@
-http://java.sun.com/xml/ns/persistence";
xmln
Github user junichi11 commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/117#discussion_r144195286
--- Diff:
j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/wizard/jpacontroller/resources/IllegalOrphanException.java.txt
---
@@ -1,
Github user junichi11 commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/117#discussion_r144195169
--- Diff:
j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/ui/resources/persistence-1.0.xml
---
@@ -1,5 +1,24 @@
+
---
Github user junichi11 commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/117#discussion_r144196190
--- Diff:
j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/wizard/jpacontroller/resources/PreexistingEntityException.java.txt
---
@@
Github user junichi11 commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/117#discussion_r144196199
--- Diff:
j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/wizard/jpacontroller/resources/RollbackFailureException.java.txt
---
@@ -
Github user junichi11 commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/117#discussion_r144195184
--- Diff:
j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/ui/resources/persistence-2.0.xml
---
@@ -1,5 +1,24 @@
+
---
Github user junichi11 commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/117#discussion_r144195122
--- Diff: j2ee.persistence/l10n.list ---
@@ -1,3 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contr
Github user junichi11 commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/117#discussion_r144195193
--- Diff:
j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/ui/resources/persistence-2.1.xml
---
@@ -1,5 +1,24 @@
+
---
Github user junichi11 commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/117#discussion_r144195299
--- Diff:
j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/wizard/jpacontroller/resources/NonexistentEntityException.java.txt
---
@@
Fair enough indeed. It would be good if someone from infra or a mentor
could tell us if PR merges work well enough from the Github side, unless
you all have already been merging by clicking merge on them there, or if
those merges have to be done through the ASF repositories and locally.
Since I am
Hello Bertrand,
thanks for the review. Here is how I am addressing your comments:
> I have reviewed SHA1(incubating-netbeans-html4j-1.5.zip)=
> eaa3a5a784f56fd1a20674ef5b59eed2be99d2fe
>
> I'm -1 on the release due to the missing DISCLAIMER which is easy to
> fix, details below.
>
> Once t
Hi,
I was looking into failing Test Cases of Incubator NetBeans build . Most
of the test cases failures are due to dependency on resources which were
deleted during Apache Code Donation as they were violating licensing terms.
link:
https://builds.apache.org/job/incubator-netbeans-linux/lastCo
Github user junichi11 commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/129#discussion_r144185514
--- Diff: nbbuild/build.xml ---
@@ -1985,7 +1985,6 @@ It is possible to use -Ddebug.port=3234
-Ddebug.pause=y to start the system in d
GitHub user junichi11 opened a pull request:
https://github.com/apache/incubator-netbeans/pull/129
Sort rat excludes alphabetically
To prevent to add duplicate one, rat excludes should be sorted
alphabetically. Actually, there was one duplicate line.
You can merge this pull reques
All,
Below is the revised draft. Not much has changed. For mentors receiving
this, we have 5 podlings needing sign off. If you are not sure about
signing off please let the podling know. Otherwise please try to sign off
at your convenience.
Incubator PMC report for October 2017
The Apache In
Hi,
> discussing this with Geertjan it seems the Oracle header was only added in
> for the donation - eg. in 8.2 you don't see a header in the IDE, now you do.
The commit that it was added is [1]. But probably, it was not merged
into the release82 branch. So, it seems that we don't see the licens
Github user vieiro commented on the issue:
https://github.com/apache/incubator-netbeans/pull/116
Please don't commit yet, I think there's a typo here.
---
Github user ebarboni commented on the issue:
https://github.com/apache/incubator-netbeans/pull/70
@jtulach rebased again but rat task have more than only fileset from a PR
by @matthiasblaesing
---
Github user mcdonnell-john commented on the issue:
https://github.com/apache/incubator-netbeans/pull/99
@matthiasblaesing I've checked out the PR and it builds fine on my machine.
After running it I've not seen any issues with the menu. Been able to open
projects. Look at th
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/114
Sorry! I overlooked the patch case. I did not know it yet, but you can add
comments to diff patches:
https://stackoverflow.com/questions/18979120/is-it-possible-to-add-a
Github user vieiro commented on the issue:
https://github.com/apache/incubator-netbeans/pull/113
Thanks Matthias. If you ever happen to visit Madrid you know you have some
free beers here.
---
>
> This concerns me, particularly adding user viewable headers in them. *If*
> template output is a derivative work then it's hard to see how Bertrand's
> point 5 applies.
>
A FAQ entry like the following is something I'd very much like to avoid!
> It's why some projects deliberately put templat
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/113
---
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/113
I squashed your two commits together and merged this.
---
On Wed, 11 Oct 2017, 17:45 Matthias Bläsing,
wrote:
>
> and to be clear: The templates will never be Public Domain, even if
> there is no license header they stay ALv2.
>
This concerns me, particularly adding user viewable headers in them. *If*
template output is a derivative work then it's hard
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/113
For the record: The content of the two binaries is identical, the files
from maven central and the original netbeans file were zipped with different
timestamps and differing dire
Github user jtulach commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/70#discussion_r144094565
--- Diff: nbbuild/antsrc/org/netbeans/nbbuild/RatReportTask.java ---
@@ -0,0 +1,319 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user jtulach commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/70#discussion_r144095084
--- Diff: nbbuild/antsrc/org/netbeans/nbbuild/RatReportTask.java ---
@@ -0,0 +1,319 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user jtulach commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/70#discussion_r144094299
--- Diff: nbbuild/antsrc/org/netbeans/nbbuild/RatReportTask.java ---
@@ -0,0 +1,319 @@
+/**
+ * Licensed to the Apache Software Foundation
I only like squashing because I'm merging single commits and I don't
want another 'merge' commit.
Sure, if a feature is implemented and it has 20 commits, it does have
some importance to preserve those since, if they are well made, there
is some logical progression there that you will need for fut
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/52
The remarks were fixed (templates lost their headers again) and the result
merged into master.
---
Thanks Emmanuel, comments inline...
On Oct 11, 2017, at 12:11, ehsavoie wrote:
>
> Hi,
> About squashing : having a single commit makes it easier to
> - backport for maintenance
> - revert
Agree to a point there; it is definitely “easier”, having a single value, but
cherry picking a range is p
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/52
---
GitHub user mcdonnell-john opened a pull request:
https://github.com/apache/incubator-netbeans/pull/128
[NETBEANS-54] Module Review javafx2.sample
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcdonnell-john/incubator-netbeans
Hey,
Am Mittwoch, den 11.10.2017, 16:38 + schrieb Neil C Smith:
> Hi,
>
> On Wed, Oct 11, 2017 at 3:54 PM Jaroslav Tulach
> wrote:
>
> > One option that I haven't seem discussed in this thread is to:
> >
> > Have the license in the template files, but remove it during build.
> >
> >
>
Hi,
On Wed, Oct 11, 2017 at 3:54 PM Jaroslav Tulach
wrote:
> One option that I haven't seem discussed in this thread is to:
>
> Have the license in the template files, but remove it during build.
>
>
That might also be a good option. I've just put in a PR to replace the
Oracle header with the A
GitHub user mcdonnell-john opened a pull request:
https://github.com/apache/incubator-netbeans/pull/127
[NETBEANS-54] Module Review javafx2.kit
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcdonnell-john/incubator-netbeans
fe
Github user ebarboni commented on the issue:
https://github.com/apache/incubator-netbeans/pull/70
@JaroslavTulach I think the WIP is in now in a stable state.
Unit report
are done for unaprouverd license
external library with no maven pattern
GitHub user neilcsmith-net opened a pull request:
https://github.com/apache/incubator-netbeans/pull/126
[NETBEANS-54] Replace Oracle license in form module templates; add
palette-item exclude
Replace Oracle license in form module templates; add palette-item exclude.
This do
Hi,
About squashing : having a single commit makes it easier to
- backport for maintenance
- revert
- review : you don't review some code that might disappear in the next
commit
Maybe the task should be divided into multiple sub task thus allowing
multiple PRs
My 2 cents
Emmanuel
--
Emm
GitHub user mcdonnell-john opened a pull request:
https://github.com/apache/incubator-netbeans/pull/125
[NETBEANS-54] Module Review javafx2.editor
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcdonnell-john/incubator-netbeans
All
We are using PRs and Git. I have not seen discussions of the git flow we
might use beyond PRs; maybe I missed it.
My teams and I use PRs, and that is the atomic operation for merging code.
We do not squash because it obscures the path of how the logic came into
being from our point of view.
One option that I haven't seem discussed in this thread is to:
Have the license in the template files, but remove it during build.
-jt
2017-10-11 16:02 GMT+02:00 Emilian Bold :
> If it's not user-visible, I say use the script to add them everywhere.
>
> --emi
>
>
> On Wed, Oct 11, 2017 at 4:58 P
GitHub user mcdonnell-john opened a pull request:
https://github.com/apache/incubator-netbeans/pull/124
[NETBEANS-54] Module Review o.apache.tools.ant.module
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcdonnell-john/incubato
>For the rest (templates), Emi are you taking this back now? Happy to have
a look now if you're not.
Please take whatever modules you feel need attention.
I have too much to do with #hacktoberfest so I don't mind if my commit
quota goes down or something.
--emi
On Wed, Oct 11, 2017 at 5:01 PM
If it's not user-visible, I say use the script to add them everywhere.
--emi
On Wed, Oct 11, 2017 at 4:58 PM, Neil C Smith
wrote:
> Hi Emi,
>
> On Wed, Oct 11, 2017 at 1:48 PM Emilian Bold wrote:
>
>> I believe most *.template files qualify here, that's why I've been
>> excluding them from Rat
Hi,
On Wed, Oct 11, 2017 at 2:46 PM Geertjan Wielenga <
geertjan.wiele...@googlemail.com> wrote:
> So, adding a license to these wouldn't be a problem in terms of the
> functionality being broken as a result? If so, getting licenses into that
> huge list of files is going to clean up the Rat repo
Hi Emi,
On Wed, Oct 11, 2017 at 1:48 PM Emilian Bold wrote:
> I believe most *.template files qualify here, that's why I've been
> excluding them from Rat in every module I've reviewed.
>
>
I noticed while talking through this with Geertjan that the templates in
the Form module do have a license
Does the Apache process allow merge from the PR itself on the GH side? If
so, that seems a better approach to me. Too, considering a PR, from a
submitters POV is generally an atomic operation, the logic in the PR should
be addressed then merged as a whole. It would keep magic PR closing from
happen
Hi,
Thank you for your explanation.
Junichi
2017-10-11 17:01 GMT+09:00 Bertrand Delacretaz :
> Hi,
>
> There's been a number of discussions around this, here's my position
> as an incubation mentor.
>
> 1. The ASF's policy for license headers is at
> https://www.apache.org/legal/src-headers.html
So, adding a license to these wouldn't be a problem in terms of the
functionality being broken as a result? If so, getting licenses into that
huge list of files is going to clean up the Rat report in a big way.
Gj
On Wed, Oct 11, 2017 at 2:40 PM, Emilian Bold
wrote:
> Yes, I've also noticed her
Yes, I've also noticed here
https://github.com/emilianbold/incubator-netbeans/issues/61 the huge
list of files. Not sure why I didn't pick them up the 1st time. Just
closed that issue so somebody else doesn't start work on it but I'll
reopen it and also remove Done from the wiki.
--emi
On Wed, O
GitHub user mcdonnell-john opened a pull request:
https://github.com/apache/incubator-netbeans/pull/123
[NETBEANS-54] Module Review hudson.subversion
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcdonnell-john/incubator-netbea
Hi Emilian, especially,
You have the 'form' module marked as done:
https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review
But in the Rat report, Neil (sitting next to me here in London) and I see
lots of files (i.e., palette items and so on) still being listed there.
Eit
If you merge with —no-ff, it prevents a “fast-forward” commit, and creates a
merge commit, where you can add a commit comment and the identity of the person
doing the merge will be recorded.
It may be possible to setup automatic rejection of fast-forward commits in the
ASF repository. Check wi
Hi,
On Wed, Oct 11, 2017 at 2:46 PM, Jaroslav Tulach
wrote:
> The content (after filtering Apache and
> Eclipse licenses) is...
That looks good to me, thanks! Snipped that content below, [2].
[1] is the reference for such third-party dependencies.
BSD is fine in all cases.
CDDL is fine for an
Do note that Eclipse doesn't really use Maven Central but
https://repo.eclipse.org/content/groups/releases/
Take a look there too.
--emi
On Wed, Oct 11, 2017 at 3:51 PM, John McDonnell
wrote:
> Okay cool.
>
> The same will apply for the following modules:
>
> o.eclipse.mylyn.commons.core
> o.e
Github user geertjanw commented on the issue:
https://github.com/apache/incubator-netbeans/pull/122
The second branch was accidentally made off the first, instead of from
master.
---
Okay cool.
The same will apply for the following modules:
o.eclipse.mylyn.commons.core
o.eclipse.mylyn.commons.net
o.eclipse.mylyn.commons.repositories.core
o.eclipse.mylyn.commons.xmlrpc
o.eclipse.mylyn.tasks.core
o.eclipse.mylyn.wikitext.confluence.core
o.eclipse.mylyn.wikitext.core
o.eclipse.m
GitHub user geertjanw opened a pull request:
https://github.com/apache/incubator-netbeans/pull/122
Netbeans 54 review java.completion
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/geertjanw/incubator-netbeans
netbeans-54-revie
GitHub user neilcsmith-net opened a pull request:
https://github.com/apache/incubator-netbeans/pull/121
[NETBEANS-54] Add l10n.list to Rat excludes.
Remove translation registration files from Rat report.
You can merge this pull request into a Git repository by running:
$ git pu
> OTOH if there's a good reason (such as "makes the product better") to
omit license headers for a category of files that's easy to identify
and does not have creative content, it's possible to make a documented
decision to omit those headers.
I believe most *.template files qualify here, that's w
Thanks Bertrand for taking a look. Here is what I found about dependencies:
2017-10-11 11:47 GMT+02:00 Bertrand Delacretaz :
>
> 3) Having a DEPENDENCIES file would make it much easier to validate
> third-party dependencies, see this recent thread:
>
> https://lists.apache.org/thread.html/b82a116
There is no need for such a list. We can easily extract external
binaries without Maven coordinates.
Right now we can just rely on http://hg.netbeans.org/binaries/ but
going forward we'll have to find another place where to store our
dependencies. Perhaps publish them ourselves to Maven Central un
Looking at the module o.eclipse.mylyn.bugzilla.core and I cannot find
the external binary:
org.eclipse.mylyn.bugzilla.core_3.17.0.v20150828-2026.jar
I've checked https://search.maven.org and the last/only version of
this is: 2.0.0-v20070627-1400
I can't seem to find the binary to download, excep
On 10/11/2017 02:06 PM, Geertjan Wielenga wrote:
> I think that would be handy -- are there any disadvantages?
Other than 'github could go away', not really.
but it's an opt-in service, so the PPMC has to formally request a move :)
>
> Gj
>
> On Wed, Oct 11, 2017 at 1:04 PM, Daniel Gruno wrote
I think that would be handy -- are there any disadvantages?
Gj
On Wed, Oct 11, 2017 at 1:04 PM, Daniel Gruno wrote:
> On 10/11/2017 02:00 PM, Geertjan Wielenga wrote:
> > Hi all,
> >
> > I have permissions for Apache NetBeans Git -- how do I connect my GitHub
> > account to those permissions so
On 10/11/2017 02:00 PM, Geertjan Wielenga wrote:
> Hi all,
>
> I have permissions for Apache NetBeans Git -- how do I connect my GitHub
> account to those permissions so that I can do merges of pull requests?
>
> Or is that not possible and should merges be done to Git, with asfgit doing
> the sy
Hi all,
I have permissions for Apache NetBeans Git -- how do I connect my GitHub
account to those permissions so that I can do merges of pull requests?
Or is that not possible and should merges be done to Git, with asfgit doing
the sync from Git to GitHub?
Thanks,
Gj
Great! Something like this would be good to know for every JAR where
the Maven hash is different.
--emi
On Wed, Oct 11, 2017 at 12:11 PM, John McDonnell
wrote:
> Hi,
>
> I took a look using a tool called DeltaWalker and the only differences
> between the 2 are:
> The new version contains 2 addi
GitHub user geertjanw opened a pull request:
https://github.com/apache/incubator-netbeans/pull/120
[NETBEANS-54] Module Review junitlib
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/geertjanw/incubator-netbeans
netbeans-54-rev
GitHub user mcdonnell-john opened a pull request:
https://github.com/apache/incubator-netbeans/pull/119
[NETBEANS-54] Module Review org.eclipse.jgit.java7
Had to change from using a jar called:
org.eclipse.jgit.java7-3.6.2.201501210735-r-nosignature.jar to
org.eclipse.jgit.ja
Excellent! That's a relief. :-)
But it would be good if we could see who did the merge, is there a way to
see that.
Gj
On Wed, Oct 11, 2017 at 11:38 AM, Matthias Bläsing <
mblaes...@doppel-helix.eu> wrote:
> Hey,
>
> asfgit is a bot, that synchronizes the github and Apache git repositories.
>
>
Hey,
asfgit is a bot, that synchronizes the github and Apache git repositories.
There was no automatic merge, I merged your changes, if I saw no problem. For
problematic changes I added a comment to the PR and die not merge
Greetings
Matthias
Am 11. Oktober 2017 12:28:35 MESZ schrieb Geert
But I did the same with this one:
https://github.com/apache/incubator-netbeans/pull/104
The only difference between that and
https://github.com/apache/incubator-netbeans/pull/103 is that 104 has a
comment, while 103 was uncommented on.
Aside from that, does this mean that we should not be committ
On 10/11/2017 12:31 PM, Geertjan Wielenga wrote:
> OK, so I did a PR (https://github.com/apache/incubator-netbeans/pull/103),
> expecting it to be reviewed before someone would manually merge it.
>
> AFAIK, I never merged it myself, I only created a PR. How come was it
> merged?
https://github.co
OK, so I did a PR (https://github.com/apache/incubator-netbeans/pull/103),
expecting it to be reviewed before someone would manually merge it.
AFAIK, I never merged it myself, I only created a PR. How come was it
merged?
Gj
On Wed, Oct 11, 2017 at 11:29 AM, Daniel Gruno wrote:
> On 10/11/2017
On 10/11/2017 12:28 PM, Geertjan Wielenga wrote:
> Hi all,
>
> Someone appears to automatically (I guess a bot) be merging PRs after a
> couple of days of inactivity, i.e., if there are no comments etc, such as
> this one of mine:
>
> https://github.com/apache/incubator-netbeans/pull/103
>
> Is
Hi all,
Someone appears to automatically (I guess a bot) be merging PRs after a
couple of days of inactivity, i.e., if there are no comments etc, such as
this one of mine:
https://github.com/apache/incubator-netbeans/pull/103
Is that correct and what we want? I.e., nobody reviewed the above nor
Hi,
On Wed, Oct 11, 2017 at 12:02 PM, Neil C Smith
wrote:
> ...Would it not be better if all template files were explicitly public
> domain if we want end users to have full control of the license for the
> resulting file?...
As an Apache project, NetBeans cannot release public domain files, the
Hi,
On Wed, 11 Oct 2017, 09:01 Bertrand Delacretaz,
wrote:
>
> 5. If tools provided by NetBeans generate code, the result should
> obviously *not* contain an Apache license header. I suppose user
> settings can define which header the current user wants, if any.
>
> 6. If 5. is problematic for s
Hi,
I have reviewed SHA1(incubating-netbeans-html4j-1.5.zip)=
eaa3a5a784f56fd1a20674ef5b59eed2be99d2fe
I'm -1 on the release due to the missing DISCLAIMER which is easy to
fix, details below.
Once that's fixed, if others (including at least one other mentor)
agree I'd be ok to promote the fixed
Hi,
PMC members which might sign releases need to add their PGP keys at
https://id.apache.org : add fingerprints to the "OpenPGP Public Key
Primary Fingerprint" field(s) and upload your keys to public key
servers.
The goal is for https://people.apache.org/keys/group/netbeans.asc to
provide those
Hi,
I took a look using a tool called DeltaWalker and the only differences
between the 2 are:
The new version contains 2 additional files META-INF/ECLIPSE_.SF and
META-INF/ECLIPSE_.RSA and the file META-INF/MANIFEST.MF has SHA-1
signatures for each class found in the JAR.
The class files themselv
Hi,
There's been a number of discussions around this, here's my position
as an incubation mentor.
1. The ASF's policy for license headers is at
https://www.apache.org/legal/src-headers.html
2. As mentioned there, headers are not required for files "without any
degree of creativity in either its
Hello,
It seems important to me to double-check binary dependencies where only the
Maven hash changes, especially for code that's support to talk to remote
servers.
So an actual diff between JAR should be reviewed and posted.
For this particular git JAR were only some META-INF signatures added
GitHub user mcdonnell-john opened a pull request:
https://github.com/apache/incubator-netbeans/pull/118
[NETBEANS-54] Module Review o.eclipse.jgit
Had to change from using a jar called:
org.eclipse.jgit-3.6.2.201501210735-r-nosignature.jar to
org.eclipse.jgit-3.6.2.2015012107
90 matches
Mail list logo
