[GitHub] nifi pull request: Nifi 631

2015-11-03 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/113#discussion_r43814471 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFile.java --- @@ -0,0 +1,378

[GitHub] nifi pull request: NIFI-1328 Explicitly setting the parameters bas...

2015-12-23 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/146 NIFI-1328 Explicitly setting the parameters based on type in PutSQL NIFI-1241 was to address adding support for BOOLEAN, NUMERIC, and DECIMAL to PutSQL. In that ticket we removed the case statement

[GitHub] nifi pull request: NIFI-1289 added support for refreshing properti...

2015-12-23 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/142#issuecomment-166975525 +1 This looks good, will merge shortly --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #473: NIFI-1916 Updating FileAuthorizer to extend AbstractPolicyB...

2016-06-02 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/473 @mcgilman updated the PR to address the thread-safety, a summary of the changes... - Created a single data structure to encapsulate all data structures used by the FileAuthorizer so there can

[GitHub] nifi issue #489: NIFI-1951: Custom UIs

2016-06-03 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/489 +1 full build passed contrib-check, ran the app and verified custom UIs still work --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #499: NIFI-1052: Added "Ghost" Processors, Reporting Tasks, Contr...

2016-06-08 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/499 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #499: NIFI-1052: Added "Ghost" Processors, Reporting Tasks, Contr...

2016-06-08 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/499 +1 code looks good, build passes, tested a missing processor, controller service, and reporting task and the app still starts up, awesome stuff! Will merge into master shortly. --- If your project

[GitHub] nifi issue #509: NIFI-1982: Use Compressed check box value.

2016-06-09 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/509 +1 looks good, will merge to 0.x... I am assuming this was only meant for 0.x and the same fix is in your other PR for http site-to-site --- If your project is set up for it, you can reply

[GitHub] nifi issue #503: NIFI-1978: Restore RPG yield duration.

2016-06-08 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/503 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #503: NIFI-1978: Restore RPG yield duration.

2016-06-08 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/503 +1 good find, verified the yield duration is maintained across restarts, will merge to 0.x --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi issue #503: NIFI-1978: Restore RPG yield duration.

2016-06-08 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/503 @ijokarumawak I merged to 0.x but GitHub doesn't auto-close from that branch, can you close this PR when you have a chance? Thanks. --- If your project is set up for it, you can reply to this email

[GitHub] nifi pull request #507: NIFI-1804 Adding ability for FileAuthorizer to autom...

2016-06-07 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/507 NIFI-1804 Adding ability for FileAuthorizer to automatically convert … …existing authorized-users.xml to new model You can merge this pull request into a Git repository by running: $ git pull

[GitHub] nifi issue #513: PutHBaseJSON processor treats all values as Strings

2016-06-09 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/513 Ryan, thanks for submitting this PR! Is it possible that we could remove the dependency on hbase-client here? The reason being is that the hbase processor bundle purposely didn't

[GitHub] nifi issue #509: NIFI-1982: Use Compressed check box value.

2016-06-09 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/509 @ijokarumawak you can close this when you get a chance since it has been merged, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #513: PutHBaseJSON processor treats all values as Strings

2016-06-09 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/513 Thats a great point about leveraging any changes they make to the Bytes class... I'm now thinking, what if we added simple methods to the HBaseClientService interface [1] that wrapped the calls

[GitHub] nifi issue #507: NIFI-1804 Adding ability for FileAuthorizer to automaticall...

2016-06-13 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/507 @mcgilman good call, I pushed a new commit that addresses your comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi pull request: NIFI-1916 Updating FileAuthorizer to extend Abs...

2016-05-27 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/473 NIFI-1916 Updating FileAuthorizer to extend AbstractPolicyBasedAuthor… …izer and adding intial loading of data users, groups, and policies - Implementing CRUD operations and unit tests

[GitHub] nifi issue #482: NIFI-1928: Remove registration

2016-06-02 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/482 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #482: NIFI-1928: Remove registration

2016-06-02 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/482 +1 looks good, verified registration form no longer exists and access denied page is presented instead --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi issue #483: NIFI-1899 - Introduce ExtractEmailAttachments processor

2016-06-01 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/483 @trixpan if you want to add the UUDI of the original FlowFile you would get it from the attributes: `String parentUuid = originalFlowFile.getAttribute(CoreAttributes.UUID.key

[GitHub] nifi issue #483: NIFI-1899 - Introduce ExtractEmailAttachments processor

2016-06-01 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/483 Sorry that second line should have been something like: `split = session.putAttribute(split, "split.parent.uuid", parentUUID);` You wouldn't want to overwrite the re

[GitHub] nifi issue #483: NIFI-1899 - Introduce ExtractEmailAttachments processor

2016-06-01 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/483 @joewitt @trixpan I think the provenance linkage should already be happening automatically with the following line: `FlowFile split = session.create(originalFlowFile);` With that call

[GitHub] nifi pull request #556: NIFI-615 - Create a processor to extract WAV file ch...

2016-06-22 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/556#discussion_r68075384 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java --- @@ -0,0 +1,311

[GitHub] nifi issue #535: NIFI-2041: Unable to refresh Controller Services when scope...

2016-06-16 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/535 +1 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #513: PutHBaseJSON processor treats all values as Strings

2016-06-17 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/513 Reviewing and going to merge into 0.x and master if all looks good... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi pull request #542: NIFI-1895 for 0.x

2016-06-20 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/542#discussion_r67718748 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseJSON.java --- @@ -89,6 +89,25

[GitHub] nifi issue #543: NIFI-1834 Create PutTCP Processor

2016-06-17 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/543 I think the intent behind this processor was to send data over a connection, but not to read anything back. Essentially doing what PutSyslog and PutSplunk are doing when in TCP mode

[GitHub] nifi pull request #542: NIFI-1895 for 0.x

2016-06-17 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/542 NIFI-1895 for 0.x This pull request contains @rtempleton 's work from PR 513, but rebased for the 0.x branch. In addition, there is another commit by me which adds a new property

[GitHub] nifi pull request #566: NIFI-2061 Ensure nodes in a cluster use consistent a...

2016-06-23 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/566 NIFI-2061 Ensure nodes in a cluster use consistent authorizations - Added methods to AbstractPolicyBasedAuthorizer to generate and inherit a fingerprint - Updated StandardFlowSynchronizer

[GitHub] nifi pull request #543: NIFI-1834 Create PutTCP Processor

2016-06-20 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/543#discussion_r67698814 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java --- @@ -0,0 +1,270

[GitHub] nifi pull request #543: NIFI-1834 Create PutTCP Processor

2016-06-20 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/543#discussion_r67698292 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java --- @@ -0,0 +1,270

[GitHub] nifi pull request #543: NIFI-1834 Create PutTCP Processor

2016-06-20 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/543#discussion_r67696982 --- Diff: nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/put/AbstractPutEventProcessor.java --- @@ -119,7 +119,24

[GitHub] nifi pull request #543: NIFI-1834 Create PutTCP Processor

2016-06-20 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/543#discussion_r67700294 --- Diff: nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/put/AbstractPutEventProcessor.java --- @@ -126,8 +127,9

[GitHub] nifi pull request #543: NIFI-1834 Create PutTCP Processor

2016-06-20 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/543#discussion_r67697377 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java --- @@ -0,0 +1,270

[GitHub] nifi issue #543: NIFI-1834 Create PutTCP Processor

2016-06-20 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/543 Looks good to me +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #513: PutHBaseJSON processor treats all values as Strings

2016-06-20 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/513 @rtempleton just merged this work as part of PR 542, thanks for the contribution! can we close this PR? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi issue #567: NIFI-1554: Continuing to incorporate component based author...

2016-06-23 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/567 Will start reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #567: NIFI-1554: Continuing to incorporate component based author...

2016-06-23 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/567 +1 looks good, verified full build passes with contrib-check and the new integration test pass, ran the app a bit and verified basic functionality --- If your project is set up for it, you can reply

[GitHub] nifi issue #513: PutHBaseJSON processor treats all values as Strings

2016-06-17 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/513 @rtempleton please take a look at https://github.com/apache/nifi/pull/542 I've incorporated your work there with some additional changes which I explained in the PR description. Let me know

[GitHub] nifi issue #518: NIFI-1901: Component based access control tests

2016-06-17 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/518 +1 looks good, verified a full build with contrib-check passes locally --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi pull request #581: NIFI-1916 Improvements to FileAuthorizer to not pars...

2016-06-24 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/581 NIFI-1916 Improvements to FileAuthorizer to not parse flow when unnce… …ssary and to recreate missing authorizations.xml You can merge this pull request into a Git repository by running

[GitHub] nifi issue #579: NIFI-1554: Changing process for cluster detection

2016-06-24 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/579 +1 verified build passes contrib-check and was able to get into a secured NiFi instance --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #579: NIFI-1554: Changing process for cluster detection

2016-06-24 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/579 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request: NIFI-1417 Exposing several connection settings ...

2016-01-29 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/194 NIFI-1417 Exposing several connection settings on the Solr processors… I was not able to reproduce the exact scenario described in this ticket, but based on the stack trace I believe exposing some

[GitHub] nifi pull request: NIFI-1417 Exposing several connection settings ...

2016-02-01 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/194#issuecomment-178209934 @markap14 thanks for reviewing! Good point about the isSet(). I was thinking someone could remove the default value, but didn't realize that isn't possible. I'll

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

2016-02-02 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/200#issuecomment-178920339 @olegz I think this is good to go from a review perspective. There appears to be some conflicts in pom files now because another bundle just got added. Can you rebase

[GitHub] nifi pull request: NIFI-1420 Adding Splunk bundle

2016-02-25 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/233#discussion_r54134136 --- Diff: nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/put/sender/ChannelSender.java --- @@ -0,0 +1,103

[GitHub] nifi pull request: NIFI-1420 Adding Splunk bundle

2016-02-25 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/233#discussion_r54134089 --- Diff: nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/put/AbstractPutEventProcessor.java --- @@ -0,0 +1,474

[GitHub] nifi pull request: NIFI-1420 Adding Splunk bundle

2016-02-27 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/233#issuecomment-189659132 @trixpan You are right that ListenSplunkForwarder is essentially a ListenTCP. I started out thinking we might be able to do acknowledgements, but was unable to find any

[GitHub] nifi pull request: NIFI-1273 Adding ListenRELP Processor

2016-01-19 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/179 NIFI-1273 Adding ListenRELP Processor This pull request adds a ListenRELP processor which includes refactoring code that was previously part of ListenSyslog into a reusable framework for implementing

[GitHub] nifi pull request: NIFI-1273 Adding ListenRELP Processor

2016-01-22 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/179#issuecomment-174049864 Just a quick update on the scenario where some messages get resent... I turned on rsyslog debug and I noticed that rsyslog seemed to be queueing up responses

[GitHub] nifi pull request: NIFI-1436 Fixing race condition in SocketChanne...

2016-01-25 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/189#issuecomment-174575236 So I originally thought about removing the loop in close() which would avoid the locking as you suggested, but I wasn't 100% sure if selector.close() also closed

[GitHub] nifi pull request: NIFI-1436 Fixing race condition in SocketChanne...

2016-01-25 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/189#issuecomment-174615789 Pushed up a new commit that combines stop() and close() into a single call for simplicity, basically preventing someone from calling close() without calling stop

[GitHub] nifi pull request: NIFI-1273 Adding ListenRELP Processor

2016-01-22 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/179#issuecomment-173968940 @trkurc thanks for the review, i liked your idea about the AsyncChannelDispatcher extending ChannelDispatcher so I went ahead and did that, and addressed the other stuff

[GitHub] nifi pull request: NIFI-1521 Allows use of SSL in AMQP Processor

2016-02-17 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/232#issuecomment-185322119 Have we considered using the SSLContextService here rather than specifying all of the keystore/truststore properties in the processor? Usually the processor

[GitHub] nifi pull request: NIFI-899 Rewrite of ListenUDP to use new listen...

2016-03-10 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/266 NIFI-899 Rewrite of ListenUDP to use new listener framework, includes… … the following changes: - Adding Network Interface property to AbstractListenEventProcessor and ListenSyslog

[GitHub] nifi pull request: NIFI-1599 Changing DatagramChannelDispatcher, s...

2016-03-10 Thread bbende
Github user bbende closed the pull request at: https://github.com/apache/nifi/pull/262 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request: NIFI-1607 Fixing issue in ListenRELP where it c...

2016-03-08 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/264 NIFI-1607 Fixing issue in ListenRELP where it could commit the session before all flow files were transferred Was able to reproduce this exception by writing a unit test that simulated data coming

[GitHub] nifi pull request: NIFI-1607 Fixing issue in ListenRELP where it c...

2016-03-09 Thread bbende
Github user bbende closed the pull request at: https://github.com/apache/nifi/pull/264 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request: NIFI-1488 Refactoring HBase Kerberos support

2016-03-15 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/281 NIFI-1488 Refactoring HBase Kerberos support - Storing UGI so we can support multiple HBaseClientServices with different configs - Creating nifi-hadoop-utils to hold utility code shared between

[GitHub] nifi pull request: NIFI-1698 Improving customValidate in AbstractH...

2016-03-30 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/313 NIFI-1698 Improving customValidate in AbstractHadoopProcessor and HBa… …seClient service to not reload Configuration unless it changed You can merge this pull request into a Git repository

[GitHub] nifi pull request: NIFI-1630 Making TestPutUDP select an open port...

2016-04-06 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/332 NIFI-1630 Making TestPutUDP select an open port for testing to avoid conflicts You can merge this pull request into a Git repository by running: $ git pull https://github.com/bbende/nifi NIFI

[GitHub] nifi pull request: NIFI-1420 Fixing minor bugs in GetSplunk

2016-03-22 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/299 NIFI-1420 Fixing minor bugs in GetSplunk - Adding a Time Zone property so the Managed time ranges use the provided time zone when formatting the date strings - Adding a Time Field Strategy

[GitHub] nifi pull request: NIFI-1420 Adding Splunk bundle

2016-03-03 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/233#issuecomment-192008077 @JPercivall I pushed up three commits, one for each processor, that I believe address all your comments/suggestions. Let me know if anything is missing or not addressed

[GitHub] nifi pull request: NIFI-1420 Adding Splunk bundle

2016-03-05 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/233#issuecomment-192800737 @JPercivall Pushed up a commit that addresses your comment about Client Auth being required, and I think I also fixed the race condition on the RELP test. If you are good

[GitHub] nifi pull request: NIFI-1420 Adding Splunk bundle

2016-03-04 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/233#issuecomment-192466857 @JPercivall Pushed up another commit that addresses the additional comments from today. Part of this change I decided to go the route that @trixpan suggested

[GitHub] nifi pull request: Nifi 1516 - AWS DynamoDB Get/Put/Delete Process...

2016-03-06 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/224#issuecomment-193064977 @mans2singh I think a commit I made on Friday exposed a race condition in TestListenRELP that was always there, but we were getting lucky before and it was never happening

[GitHub] nifi pull request: NIFI-1599 Changing DatagramChannelDispatcher, s...

2016-03-08 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/262#issuecomment-193929305 @olegz I didn't want to get into a complete refactoring of the different handlers/dispatchers, as there are some complicated subtleties there, but I took another shot

[GitHub] nifi pull request: NIFI-1488 Added hbase kerb auth with ugi

2016-03-08 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/253#issuecomment-193920825 @rickysaltzer if you rebase to master I think the RELP failures should go away. Regarding testing, a couple of thoughts... 1) Could we update

[GitHub] nifi pull request: NIFI-1697 Ensuring FlowController appropriately...

2016-03-30 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/312 NIFI-1697 Ensuring FlowController appropriately wraps code with NarClosable From debugging this issue it was noticed that the problem only occurred while a PutHDFS processor was enabled (running

[GitHub] nifi pull request: NIFI-1691: Add Fetch Size property to QueryData...

2016-03-29 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/307#issuecomment-202935582 This looks good, tested against a Postgres DB and works as expected, code looks good, will merge to master. --- If your project is set up for it, you can reply

[GitHub] nifi pull request: NIFI-1554: Introducing new REST endpoints to al...

2016-04-21 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/374#issuecomment-213080400 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: NIFI-1554: Introducing new REST endpoints to al...

2016-04-21 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/374#issuecomment-213121166 Pulled down the latest and tested again, all looks good now, app seems to function properly in standalone and clustered mode. I'm a +1 to merge this. --- If your

[GitHub] nifi pull request: NIFI-1554: Introducing new REST endpoints to al...

2016-04-21 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/374#issuecomment-213101837 I was testing a 2 node cluster locally and noticed that the part in the toolbar that says Connected Nodes didn't show anything after it, but in the cluster view it showed

[GitHub] nifi pull request: NIFI-981: Added ExecuteHiveQL and PutHiveQL pro...

2016-04-27 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/384#discussion_r61316112 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/ExecuteHiveQL.java --- @@ -0,0 +1,178

[GitHub] nifi pull request: NIFI-981: Added ExecuteHiveQL and PutHiveQL pro...

2016-04-27 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/384#discussion_r61317929 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/util/hive/HiveJdbcCommon.java --- @@ -0,0 +1,272

[GitHub] nifi pull request: NIFI-981: Added ExecuteHiveQL and PutHiveQL pro...

2016-04-27 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/384#discussion_r61343688 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/ExecuteHiveQL.java --- @@ -0,0 +1,178

[GitHub] nifi pull request: NIFI-1554: Introduction of access controls on c...

2016-04-29 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/393#issuecomment-215872920 I'm a +1... reviewed and looks good, ran the application in secure and un-secure modes to verify functionality, passes contrib-check. --- If your project is set up

[GitHub] nifi pull request: NIFI-981: Added ExecuteHiveQL and PutHiveQL pro...

2016-04-28 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/384#discussion_r61502555 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/ExecuteHiveQL.java --- @@ -152,8 +152,23

[GitHub] nifi pull request: NIFI-1884 Defining API for Users, Groups, and P...

2016-05-20 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/452#discussion_r64076734 --- Diff: nifi-api/src/main/java/org/apache/nifi/authorization/AccessPolicy.java --- @@ -0,0 +1,291 @@ +/* + * Licensed to the Apache Software

[GitHub] nifi pull request: NIFI-1884 Defining API for Users, Groups, and P...

2016-05-23 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/452#issuecomment-221046683 @mcgilman @jtstorck @alopresto pushed two new commits, the first contains minor changes to address some of Matt's comments, the second is an attempt at what Matt suggested

[GitHub] nifi pull request: NIFI-1884 Defining API for Users, Groups, and P...

2016-05-18 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/452#issuecomment-220121052 @alopresto The intent was for the relationship to be bi-directional, meaning you could add a user to a group by adding/updating a User with a new group id in the set

[GitHub] nifi pull request: NIFI-1884 Defining API for Users, Groups, and P...

2016-05-18 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/452#discussion_r63760082 --- Diff: nifi-api/src/main/java/org/apache/nifi/authorization/AccessPolicy.java --- @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software

[GitHub] nifi pull request: NIFI-1884 Defining API for Users, Groups, and P...

2016-05-18 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/452#discussion_r63759950 --- Diff: nifi-api/src/main/java/org/apache/nifi/authorization/AccessPolicy.java --- @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software

[GitHub] nifi pull request: NIFI-1907 Moving lazy init of SSLContext...

2016-05-24 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/457#issuecomment-221268368 Going to merge this in since Joe was a +1... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request: NIFI-1907 Moving lazy init of SSLContext...

2016-05-20 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/457 NIFI-1907 Moving lazy init of SSLContext... to StandardSiteToSiteClientConfig rather than the builder. Tested secure SiteToSite still working between two NiFi nodes, and now example Storm

[GitHub] nifi pull request: NIFI-1858 Adding SiteToSiteProvenanceReportingT...

2016-05-12 Thread bbende
Github user bbende closed the pull request at: https://github.com/apache/nifi/pull/419 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request: NIFI-1858 Adding site-to-site reporting bundle

2016-05-12 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/436#issuecomment-218766817 @markap14 here is the corresponding PR for merging the site-to-site reporting bundle into master --- If your project is set up for it, you can reply to this email

[GitHub] nifi pull request: NIFI-1742: Initial support for component level ...

2016-05-12 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/435#issuecomment-218805610 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: NIFI-1858 Adding site-to-site reporting bundle

2016-05-12 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/436 NIFI-1858 Adding site-to-site reporting bundle PR for merging this into master. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bbende/nifi NIFI

[GitHub] nifi pull request: NIFI-1858 Adding site-to-site reporting bundle

2016-05-17 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/436#issuecomment-219738116 Since @markap14 has already reviewed this and merged it into 0.x branch, I am going to merge this into master myself so we don't lose track of this. --- If your project

[GitHub] nifi pull request: NIFI-1554: Introducing component level revision...

2016-05-17 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/448#issuecomment-219736438 +1 Full build passes with contrib-check, was able to create a flow with controller services working as expected. Ran into an issue importing a template with a controller

[GitHub] nifi pull request: NIFI-1884 Defining API for Users, Groups, and P...

2016-05-17 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/452 NIFI-1884 Defining API for Users, Groups, and Policies This pull request introduces the concept of a MutableAuthorizer which is an interface that extends the recently introduced Authorizer

[GitHub] nifi pull request: NIFI-981: Added ExecuteHiveQL and PutHiveQL pro...

2016-05-02 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/384#discussion_r61832445 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/SelectHiveQL.java --- @@ -52,15 +54,27

[GitHub] nifi pull request: NIFI-981: Added ExecuteHiveQL and PutHiveQL pro...

2016-05-02 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/384#discussion_r61832456 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/SelectHiveQL.java --- @@ -52,15 +54,27

[GitHub] nifi pull request: NIFI-1781: First pass through updating canvas f...

2016-05-06 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/417#issuecomment-217541758 +1 Looks good, was able to run the app secured and unsecured to verify basic functionality, and build passes contrib-check. --- If your project is set up for it, you can

[GitHub] nifi pull request: NIFI-981: Added ExecuteHiveQL and PutHiveQL pro...

2016-05-02 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/384#issuecomment-216246029 Latest commits look good, I am a +1 and going to merge to 0.x and master --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi pull request: NIFI-981: Added ExecuteHiveQL and PutHiveQL pro...

2016-05-03 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/384#issuecomment-216595481 Latest changes look good, I am a +1 again :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request: NIFI-1858 Adding SiteToSiteProvenanceReportingT...

2016-05-09 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/419#discussion_r62505576 --- Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting

[GitHub] nifi pull request: NIFI-1858 Adding SiteToSiteProvenanceReportingT...

2016-05-09 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/419#discussion_r62548156 --- Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting

  1   2   >