No probs, most of those items should be fine for next release.
I'd consider fixing the location of the KEYS file straight away since that
might cause -1 votes in the next round of voting by IPMC or may cause Infra
to require it to be fixed. The duplicate within the jar shouldn't matter,
just the
Paul,
Your feedback is captured in [1] and will be addressed in the next point
release.
Thank you,
1. https://issues.apache.org/jira/browse/NLPCRAFT-38
--
Aaron Radzinski
On Tue, Apr 14, 2020 at 1:55 AM Paul King wrote:
> +1 (with some comments below):
>
> Tested:
> - signature okay
> -
Hi,
+1 from me.
I checked:
- Incubating in name
- DISCLAIMER exists
- LICENSE and NOTICE are fine
- No unexpected binary files
- Checked PGP signatures
- Checked Checksums
- Code compiles and tests successfully run
Kind Regards,
Furkan KAMACI
On Wed, Apr 15, 2020 at 8:53 PM Nikita Ivanov
NLPCraft-ers,
The vote's timeline is over but we still need more votes. Can some of the
mentors please vote? We need to move this forward...
Thank you,
--
Nikita Ivanov
On Tue, Apr 14, 2020 at 1:55 AM Paul King wrote:
> +1 (with some comments below):
>
> Tested:
> - signature okay
> -
+1 (with some comments below):
Tested:
- signature okay
- checksums okay
- LICENSE, DISCLAIMER okay
- NOTICE has more than needed (lines 6-95 should be deleted for source zip,
I don't believe a showstopper but fix for next time)
- incubating in name
- mvn clean package (okay on Windows and Linux
+1
Tested on mac only:
- mvn clean verify
- ZIP signatures check
Regards,
Sergey
On Sun, Apr 12, 2020 at 9:26 PM Nikita Ivanov wrote:
>
> +1
>
> Tested (mac only):
> - mvn clean package
> - mvn verify
> - mvn apache-rat:check -Prelease
> - Rat check: Summary over all files. Unapproved: 0,
+1
Tested (mac only):
- mvn clean package
- mvn verify
- mvn apache-rat:check -Prelease
- Rat check: Summary over all files. Unapproved: 0, unknown: 0,
generated: 0, approved: 318 licenses.
- ZIP signatures check
- DISCLAIMER, KEYS, LICENSE, NOTE files are present
--
Nikita Ivanov.
On Sat,
Hi
+1
(Files checked, tests and examples checked (under mac and win))
11.04.2020 23:23, Aaron Radzinski пишет:
NLPCraft-ers,
We've made another round of fixes. Note that the internal version of this
release is now 0.5.0-rc1. If and when voted in - we'll simply upgrade the
version to 0.5.0.
NLPCraft-ers,
We've made another round of fixes. Note that the internal version of this
release is now 0.5.0-rc1. If and when voted in - we'll simply upgrade the
version to 0.5.0.
NOTE: the 'dist' location has double 'nlpcraft' folders which may look
suspicious. First 'nlpcraft' is a root for the
