[PATCH] drivers/sensors/sgp30.c: reset I2C in case init msg takes too long

Hi Greg, We have experimentally found out that this change helps with somewhat quirky CO2/VOC-sensor. Best Regards, Juha Niskanen From f09acf45e1c94e454e3379a165aebe601e39b22d Mon Sep 17 00:00:00 2001 From: Juha Niskanen Date: Thu, 5 Mar 2020 09:55:57 +0200 Subject: [PATCH] drivers/sensors/s

Build failed in Jenkins: NuttX-Nightly-Build #54

See Changes: -- [...truncated 1.08 MB...] Configuration/Tool: sim/configdata Cleaning... Config

Re: squashing commits or not

Hi, We do not squash commits unless they are related (Which should have been done by the OP in the firsr place). We actually encourage putting unrelated changes in separate commits. On Thu, Mar 5, 2020, 05:26 Takashi Yamamoto wrote: > hi, > > it seems that in nuttx it's common to squash commi

Re: Podling Nuttx Report Reminder - March 2020

Hi, That got fixed. Thanks. On Thu, Mar 5, 2020 at 6:25 AM Justin Mclean wrote: > > Hi, > > Looking at the report this question needed to be answered, you need to > include a date. > > "### When were the last committers or PPMC members elected?" > > Thanks, > Justin

Re: squashing commits or not

On Thu, Mar 5, 2020 at 5:10 PM Abdelatif Guettouche wrote: > > Hi, > > We do not squash commits unless they are related (Which should have been > done by the OP in the firsr place). But even the patch related each other, it's better to keep the individual small patch instead merging into one big

Re: SAMA5D27 USB support?

Adam, As suggested by Greg, I tested on USB storage. - NuttShell (NSH) NuttX-8.2 nsh> ls -l /dev /dev: crw-rw-rw- 0 console crw-rw-rw- 0 loop crw-rw-rw- 0 null crw-rw-rw- 0 ramlog cr--r--r-- 0 random brw-rw-rw- 0 sda crw-rw-rw- 0 ttyS0 crw-rw

Re: squashing commits or not

> Because if > the contributor take the time to split the change into serveral small > patch, which mean it's valuable to do so. I agree, but this isn't always the case. It is okay to have PRs with multiple commits, as you mentioned, we can even request to do so. However, some of the commits are j

RE: squashing commits or not

Agree! If you read the work flow I suggested you will see it is a rebase until review WF. Noise should always be squashed. -Original Message- From: Abdelatif Guettouche [mailto:abdelatif.guettou...@gmail.com] Sent: Thursday, March 05, 2020 4:53 AM To: dev@nuttx.apache.org Subject: Re: squa

Re: squashing commits or not

On Thu, Mar 5, 2020 at 7:58 PM Abdelatif Guettouche wrote: > > > Because if > > the contributor take the time to split the change into serveral small > > patch, which mean it's valuable to do so. > > I agree, but this isn't always the case. > It is okay to have PRs with multiple commits, as you me

Re: squashing commits or not

The decision to squash or not will be left to the best judgement of the committer.

Re: squashing commits or not

On Thu, Mar 5, 2020 at 10:22 PM Gregory Nutt wrote: > > The decision to squash or not will be left to the best judgement of the > committer. Yes, committer could give the suggestion, or even decline the PR, but it isn't good practice to directly do squash without any discussion. Even worse, commi

Re: squashing commits or not

We have to trust that committers will do the best job that they can.  We have no control over how committers do that job.  There is no mechanism for such control.  This is an area where there is no option but to trust the judgement of the committers. Discussing good practice is fine, but there

Re: squashing commits or not

Why not just leave all the commits and generate on master a single merge commit? In git CLI you can easily filter the non-merge commits using `git log --merges` (same sequence as squashed PR) and then inspect the involved commits looking at the non-master commit parent. Not sure if the problem is

RE: squashing commits or not

Isn't that is just more noise? -Original Message- From: Miguel Ángel Herranz [mailto:mig...@midokura.com.INVALID] Sent: Thursday, March 05, 2020 8:16 AM To: dev@nuttx.apache.org Subject: Re: squashing commits or not Why not just leave all the commits and generate on master a single merge

RE: squashing commits or not

How about clear to the point work steps? Do we have the interim workflow listed anywhere that it can be read, without the diatribes? -Original Message- From: Gregory Nutt [mailto:spudan...@gmail.com] Sent: Thursday, March 05, 2020 8:00 AM To: dev@nuttx.apache.org Subject: Re: squashing com

Re: squashing commits or not

On Thu, Mar 5, 2020 at 5:30 PM David Sidrane wrote: > Isn't that is just more noise? > Noise that you can filter is less noisy. If you do have a PR with B1 and B2 commits and generates in master: A1 <- B1 <- B2 <- C1 <- master you cannot filter it easily. If you generate with branch merg

Re: squashing commits or not

If you do have a PR with B1 and B2 commits and generates in master: A1 <- B1 <- B2 <- C1 <- master If B1 and B2 are part of the same change, I would probably use git rebase -i to squash only those two

RE: squashing commits or not

If you have clear work steps for a rebase work flow (prior to review). Contributors can and will do PR hygiene. -Original Message- From: Gregory Nutt [mailto:spudan...@gmail.com] Sent: Thursday, March 05, 2020 9:20 AM To: dev@nuttx.apache.org Subject: Re: squashing commits or not > If yo

Re: squashing commits or not

No one gets to set any rules.  No one gets to enforce any rules. Committers are free to do what they choose.  That is the Apache way:  It is anarchy held together by a belief in common principles and a project culture.  If you can't trust people to do that job, you are working on the wrong proj

Re: squashing commits or not

One big problem that I encounter is that people change .c and .h files but do not run nxstyle against the resulting files.  It is not really possible to verify that online (currently, hopefully soon, however).  So you don't know about the stylistic problems until you have already merged onto a

RE: squashing commits or not

I think you are over-reading this. If we do not have a clear list of instructions we are not helping, we are confusing our would be committers (Additional Committers email). If you do not think of them as Rules but more of sharing your "best engineering judgment" to educate the group, you know, Sha

RE: squashing commits or not

Why would you merge it to branch it is not ready? This is not hard. The PR will not pass CI if it fails Style check. Period! That is a simple check. We should have that by now. Also add it to the commit hooks locally. (document the work flow and add the script to download it - or put it in the b

Re: squashing commits or not

> How about clear to the point work steps? Do we have the interim workflow > listed anywhere that it can be read, without the diatribes? I just wrote something really quickly. Maybe you want to take a look [1] We can add to that section more information on how to squash WIP commits using interacti

Re: squashing commits or not

Why would you merge it to branch it is not ready? There is no way to know if it is not ready.  There is no CI for PRs now. You have to merge first, then you can see if it is ready. Let's not confuse what-I-am-doing-now with the final workflow which is NOT defined, NOT approved, and NOT in

Re: squashing commits or not

I just wrote something really quickly. Maybe you want to take a look [1] We can add to that section more information on how to squash WIP commits using interactive rebasing. I'll come back later to do more. But I need to go. Feel free to edit. 1. https://cwiki.apache.org/confluence/display/NU

RE: squashing commits or not

Abdelatif, Thank you. The link did not lad me and I have no idea what to look at there among the 10,404 words... David -Original Message- From: Abdelatif Guettouche [mailto:abdelatif.guettou...@gmail.com] Sent: Thursday, March 05, 2020 10:41 AM To: dev@nuttx.apache.org Subject: Re: squas

Re: SAMA5D27 USB support?

I did this as well. It works. I'm going to to submit a PR for this work, even though the other devices are not completely tested— that will get the SAMA5D27 USB Host support into mainline. Thanks for your help Takeyoshi and Greg! cheers adam On Thu, Mar 5, 2020 at 3:21 AM Takeyoshi Kikuchi wrot

nxstyle: invalid section for this file type?

Hi, I am getting this error message when using nxstyle to check a header file: boards/arm/sama5/sama5d2-xult/src/sama5d2-xult.h:419:3: error: Invalid > section for this file type > There is a Public Functions header in this file, and then after it there are declarations of public functions. Shou

Re: nxstyle: invalid section for this file type?

I am getting this error message when using nxstyle to check a header file: boards/arm/sama5/sama5d2-xult/src/sama5d2-xult.h:419:3: error: Invalid section for this file type There is a Public Functions header in this file, and then after it there are declarations of public functions. Should

Re: nxstyle: invalid section for this file type?

The error is correct.  Check the coding standard.  "Public Functions" is permitted only in C files, not header files.  Header files may have "Public Function Prototypes" but not public functions. References: https://cwiki.apache.org/confluence/display/NUTTX/Coding+Standard#fileorganization

Re: SAMA5D27 USB support?

Here's the PR for the SAMA5D27 USB Host support (peripheral support is there too as a work-in-progress). https://github.com/apache/incubator-nuttx/pull/444 cheers adam On Thu, Mar 5, 2020 at 12:16 PM Adam Feuer wrote: > I did this as well. It works. I'm going to to submit a PR for this work, >

Re: nxstyle: invalid section for this file type?

Greg, Perfect. I fixed the two files that had the problem. cheers adam On Thu, Mar 5, 2020 at 1:48 PM Gregory Nutt wrote: > > > The error is correct. Check the coding standard. "Public Functions" > > is permitted only in C files, not header files. Header files may have > > "Public Function

dlopen for I/D separated platform

hi, i want to make dlopen work on esp32. [1] right now, nuttx just does malloc to allocate memory to load text. however, it can't work on esp32, where instruction and data are separated. i guess it would be the most straightforward to introduce another "heap" instance for text. (according to esp32

Build failed in Jenkins: NuttX-Nightly-Build #55

See Changes: -- [...truncated 616.44 KB...] net_ipv4addr_hdrcopy(ipv4->srcipaddr, &dev->d_ipaddr); ^~~~ tcp/tcp_send.c:336:7: warning: dereferencing type-

SAMA5D2 SDMMC support?

Hi, Does anyone know if there is support for the SAMA5D2 SDMMC controller in NuttX? This is required for reading and writing to SD Cards. I think the SAMA5D2 has a different MMC controller from the D3 and D4. The D2 has SDMMC, I think the D3 and D4 have HSMCI. There's code in the Atmel software p

[GitHub] [incubator-nuttx-testing] liuguo09 opened a new pull request #13: docker: initial checkin Dockerfile for nuttx github action container

liuguo09 opened a new pull request #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13 The corresponding docker image: docker pull liuguo09/ubuntu-nuttx:tagname Now it is temporarily use personal

SAMA5 peripheral support to-do list

Hi, NuttX works on the SAMA5D27— USB 2.0 High Speed works, there is a working CDC ECM network driver, and USB Host works now too. But there is more work needed on the other peripherals. Here's my to-do list on the SAMA5D2 peripheral support: - PIO with IRQs - SPI with DMA - MMC / SDCard

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #13: docker: initial checkin Dockerfile for nuttx github action container

xiaoxiang781216 commented on a change in pull request #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13#discussion_r388753286 ## File path: docker/Dockerfile ## @@ -0,0 +1,34 @@ +FROM u

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #13: docker: initial checkin Dockerfile for nuttx github action container

xiaoxiang781216 commented on a change in pull request #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13#discussion_r388753487 ## File path: docker/Dockerfile ## @@ -0,0 +1,34 @@ +FROM u