Re: svn commit: r1304061 - /ofbiz/trunk/.classpath

2012-03-24 Thread Erwan de FERRIERES
Le 22/03/2012 22:26, J. Eckard a écrit : Do we really want to keep IDE-specific support files in the repository (and keep them updated by hand in perpetuity)? I ask because it seems like a fragile (and tedious) process… for instance, I don't use eclipse and I have no idea if or how this

[jira] [Updated] (OFBIZ-4724) Shopping Cart - One Page Checkout - not continuing

2012-03-24 Thread K Sharad Bhushan (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] K Sharad Bhushan updated OFBIZ-4724: Attachment: ecommerce-shopping-cart-script.patch Hi Jacques, Here is explanation

[jira] [Issue Comment Edited] (OFBIZ-4724) Shopping Cart - One Page Checkout - not continuing

2012-03-24 Thread K Sharad Bhushan (Issue Comment Edited) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237451#comment-13237451 ] K Sharad Bhushan edited comment on OFBIZ-4724 at 3/24/12 6:05 AM:

Re: svn commit: r1304369 - in /ofbiz/trunk: ./ framework/ tools/ tools/api-java16/ tools/src/

2012-03-24 Thread Jacopo Cappellato
Hi Hans, On Mar 24, 2012, at 5:23 AM, Hans Bakker wrote: Scott, we are using ofbiz trunk in a continuous testing environment to discover problems as quick as possible. I guess that we means your company, not the OFBiz community/project. Against blocking problems discovered there, I am

Re: Some ideas to prepare our first community roadmap

2012-03-24 Thread Paul Foxworthy
Hi Mansour, There is perhaps a code smell in your example, but IMHO your example is no improvement at all, and not more object oriented. A variable that is set once and read once like the three in your example is not pulling its weight, and it should be eliminated, so the original code is the

Re: bin folder for executable files/scripts

2012-03-24 Thread Jacopo Cappellato
Part of my changes has been reverted by Hans in rev. 1304679 and 1304687 (we are discussing this in another thread) but I would really appreciate if in the meantime you all could help to test my changes (before the revert). Thanks, Jacopo On Mar 23, 2012, at 3:15 PM, Jacopo Cappellato wrote:

Re: Some ideas to prepare our first community roadmap

2012-03-24 Thread Jacopo Cappellato
On Mar 23, 2012, at 8:15 PM, Jacques Le Roux wrote: (MOSTLY) ACTIONABLE ITEMS (currently under discussion - once finalized we will create tasks in Jira for each): Sub-tasks of Slim down, right? Rather than subtasks I would suggest to: 1) create a new Jira version for the roadmap: Slim

[jira] [Commented] (OFBIZ-4496) Quick complete Drop Shipment on purchase order causes many warning messages

2012-03-24 Thread Paul Foxworthy (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237467#comment-13237467 ] Paul Foxworthy commented on OFBIZ-4496: --- I did submit a patch in OFBIZ-4582. This

[jira] [Commented] (OFBIZ-4496) Quick complete Drop Shipment on purchase order causes many warning messages

2012-03-24 Thread Paul Foxworthy (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237471#comment-13237471 ] Paul Foxworthy commented on OFBIZ-4496: --- I think the failure, as opposed to the

[jira] [Created] (OFBIZ-4753) After session timeout, ajax popup dialogbox shows ofbiz login screen.

2012-03-24 Thread Deepak Dixit (Created) (JIRA)
After session timeout, ajax popup dialogbox shows ofbiz login screen. - Key: OFBIZ-4753 URL: https://issues.apache.org/jira/browse/OFBIZ-4753 Project: OFBiz Issue Type: Bug

[jira] [Updated] (OFBIZ-4753) After session timeout, ajax popup dialogbox shows ofbiz login screen.

2012-03-24 Thread Yashwant Dhakad (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yashwant Dhakad updated OFBIZ-4753: --- Attachment: OFBIZ-4753-Trunk.patch OFBIZ-4753-11.04.patch Here is the patch

Re: Some ideas to prepare our first community roadmap

2012-03-24 Thread Jacques Le Roux
Yes good idea. In case we could still create mains and sub-taks if needed Jacques From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com On Mar 23, 2012, at 8:15 PM, Jacques Le Roux wrote: (MOSTLY) ACTIONABLE ITEMS (currently under discussion - once finalized we will create tasks in

Re: Junit tests are failing: org.ofbiz.base.util.test.UtilPropertiesTests.testReadXmlLangNewStyle

2012-03-24 Thread Jacques Le Roux
About http://svn.apache.org/viewvc?rev=1304193view=rev I did not run the tests locally. It's a pity Buildbot is still not working. Hopefully this should be soon fixed https://issues.apache.org/jira/browse/INFRA-4562 There are indeed chances that it's related, Anne introduced LangNewStyle

Re: Junit tests are failing: org.ofbiz.base.util.test.UtilPropertiesTests.testReadXmlLangNewStyle

2012-03-24 Thread Jacopo Cappellato
I suspect that in Anne's local box the tests will be successful (the test that is failing is using en-AU as a Locale and it may be related...) Jacopo On Mar 24, 2012, at 9:43 AM, Jacques Le Roux wrote: About http://svn.apache.org/viewvc?rev=1304193view=rev I did not run the tests locally.

[jira] [Created] (OFBIZ-4754) Fixed fix me for ajax auto-completer for order entry process.

2012-03-24 Thread Nitesh Suryavanshi (Created) (JIRA)
Fixed fix me for ajax auto-completer for order entry process. - Key: OFBIZ-4754 URL: https://issues.apache.org/jira/browse/OFBIZ-4754 Project: OFBiz Issue Type: Bug

[jira] [Commented] (OFBIZ-4724) Shopping Cart - One Page Checkout - not continuing

2012-03-24 Thread Jacques Le Roux (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237480#comment-13237480 ] Jacques Le Roux commented on OFBIZ-4724: Sorry K Sharad, but your patch does not

[jira] [Updated] (OFBIZ-4754) Fixed fix me for ajax auto-completer for order entry process.

2012-03-24 Thread Nitesh Suryavanshi (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitesh Suryavanshi updated OFBIZ-4754: -- Attachment: OFBIZ-4754.patch Here is the patch for the issue. Removed fixed me comment

Re: Junit tests are failing: org.ofbiz.base.util.test.UtilPropertiesTests.testReadXmlLangNewStyle

2012-03-24 Thread Jacques Le Roux
Ha yes indeed saw that, I will check here, thanks Jacopo Jacques From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com I suspect that in Anne's local box the tests will be successful (the test that is failing is using en-AU as a Locale and it may be related...) Jacopo On Mar 24, 2012,

Re: Junit tests are failing: org.ofbiz.base.util.test.UtilPropertiesTests.testReadXmlLangNewStyle

2012-03-24 Thread Anne
Paul mentioned this to me, so I have just had a look. Something has gone wrong with the application of my patch. The commit log lists these files: Changed paths: M /ofbiz/trunk/framework/base/dtd/ofbiz-properties.xsd A

Re: svn commit: r1304369 - in /ofbiz/trunk: ./ framework/ tools/ tools/api-java16/ tools/src/

2012-03-24 Thread Jacques Le Roux
From: Hans Bakker mailingl...@antwebsystems.com Sorry Jacopo, as I already stated, start/stop.sh and perhaps also the windows ones should stay in the root. I use Windows one, though not in for CI (I rely on Buildbot for that, too bad those days). It was not a pb for me to add \tools where

Re: Junit tests are failing: org.ofbiz.base.util.test.UtilPropertiesTests.testReadXmlLangNewStyle

2012-03-24 Thread Jacques Le Roux
Indeed, it seems I did not notice this part is rejected, I will apply by hand --- framework/webtools/src/org/ofbiz/webtools/labelmanager/LabelManagerFactory.java +++ framework/webtools/src/org/ofbiz/webtools/labelmanager/LabelManagerFactory.java @@ -132,7 +132,12 @@ for

Re: Junit tests are failing: org.ofbiz.base.util.test.UtilPropertiesTests.testReadXmlLangNewStyle

2012-03-24 Thread Jacques Le Roux
Mmm., no it was already applied. So I reapplied both patches and apart this hunk all went smoothly and I have nothing new to commit: I revert r1304193 for now... Jacques From: Jacques Le Roux jacques.le.r...@les7arts.com Indeed, it seems I did not notice this part is rejected, I will apply by

Re: Junit tests are failing: org.ofbiz.base.util.test.UtilPropertiesTests.testReadXmlLangNewStyle

2012-03-24 Thread Anne
Thanks Jacques. Could you please also check that the patch hunk for UtilProperties.java, starting at line 964, applies successfully? It applies cleanly on my local copy. Cheers, Anne. On 24 March 2012 20:25, Jacques Le Roux jacques.le.r...@les7arts.comwrote: Indeed, it seems I did not notice

root svn:ignore properties

2012-03-24 Thread Jacques Le Roux
Hi Erwan, please be careful when svn:ignore properties to root ;) Jacques

Re: Junit tests are failing: org.ofbiz.base.util.test.UtilPropertiesTests.testReadXmlLangNewStyle

2012-03-24 Thread Jacques Le Roux
I reapplied both patches in the right order (I did care about this point last time I think, anyway did not get any rejects) And I have applied the resulting patch to the issue, please check Thanks Jacques From: Anne a...@cohsoft.com.au Thanks Jacques. Could you please also check that the

[jira] [Updated] (OFBIZ-4723) Support validation of resource xml files

2012-03-24 Thread Jacques Le Roux (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-4723: --- Attachment: OFBIZ-4723_both.patch I attach both patches in one when applied to trunk HEAD

[jira] [Reopened] (OFBIZ-4723) Support validation of resource xml files

2012-03-24 Thread Jacques Le Roux (Reopened) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-4723: I reverted because the test does not pass Support validation of resource xml

Re: root svn:ignore properties

2012-03-24 Thread Erwan de FERRIERES
Sorry propedit instead of add. Thanks for correcting me! On Mar 24, 2012 10:39 AM, Jacques Le Roux jacques.le.r...@les7arts.com wrote: Hi Erwan, please be careful when svn:ignore properties to root ;) Jacques

[jira] [Updated] (OFBIZ-4724) Shopping Cart - One Page Checkout - not continuing

2012-03-24 Thread K Sharad Bhushan (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] K Sharad Bhushan updated OFBIZ-4724: Attachment: ecommerce-shopping-cart-script.patch Jacques, I have updated the code and

Re: Junit tests are failing: org.ofbiz.base.util.test.UtilPropertiesTests.testReadXmlLangNewStyle

2012-03-24 Thread Anne
Jacques, The patch you added to jira does not include the changes to UtilProperties.java. When I apply my original patch to my local copy of trunk, it all applies cleanly. I can't see what is going wrong. I will create a new combined patch and add it to the jira. Maybe it will be simpler to see

[jira] [Updated] (OFBIZ-4723) Support validation of resource xml files

2012-03-24 Thread Anne Jessel (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anne Jessel updated OFBIZ-4723: --- Attachment: OFBIZ-4723_combined.patch New combined patch. Support validation of

[jira] [Assigned] (OFBIZ-4754) Fixed fix me for ajax auto-completer for order entry process.

2012-03-24 Thread Ashish Vijaywargiya (Assigned) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya reassigned OFBIZ-4754: -- Assignee: Ashish Vijaywargiya Fixed fix me for ajax auto-completer for

[jira] [Assigned] (OFBIZ-4753) After session timeout, ajax popup dialogbox shows ofbiz login screen.

2012-03-24 Thread Ashish Vijaywargiya (Assigned) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya reassigned OFBIZ-4753: -- Assignee: Ashish Vijaywargiya After session timeout, ajax popup dialogbox

Re: svn commit: r1304369 - in /ofbiz/trunk: ./ framework/ tools/ tools/api-java16/ tools/src/

2012-03-24 Thread Hans Bakker
Hi Jacques, Anything can be changed and anything can be adapted, however such basic commands like start and stop should not be moved lightly. The compromise i can offer is to have the original commit with symbolic links in the root called startofbiz.sh and stopofbiz.sh these commands are

Re: Some ideas to prepare our first community roadmap

2012-03-24 Thread Mansour Al Akeel
Paul, adding a temp variable is not object oriented, but it just makes debugging and stepping through the code easier. Thank you for pointing out that this function is called only three times in the whole code. If I am not wrong it's called in loops. May be this was bad example for introducing

Re: Some ideas to prepare our first community roadmap

2012-03-24 Thread Mansour Al Akeel
Jacques, thank you for encouraging me to contribute. I will discuss new ideas when I know I can apply them. I have a firm believe that the value of any idea, becomes useless when the idea can not become real, and remain an idea. I will be wasting everyone else time, if I discuss something, I can

[jira] [Commented] (OFBIZ-3790) email password broken

2012-03-24 Thread BREMA Dev Team (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237551#comment-13237551 ] BREMA Dev Team commented on OFBIZ-3790: --- There is no productStoreId in the session

[jira] [Updated] (OFBIZ-3790) email password broken

2012-03-24 Thread BREMA Dev Team (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BREMA Dev Team updated OFBIZ-3790: -- Attachment: emailPasswd.diff email password broken -

[jira] [Commented] (OFBIZ-4748) Add Intellij files to the .gitignore

2012-03-24 Thread Joe Eckard (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237601#comment-13237601 ] Joe Eckard commented on OFBIZ-4748: --- When creating a new project in IDEA, you can

[jira] [Created] (OFBIZ-4755) E-commerce search does not always functioning correctly

2012-03-24 Thread Jeremy Olmstead (Created) (JIRA)
E-commerce search does not always functioning correctly --- Key: OFBIZ-4755 URL: https://issues.apache.org/jira/browse/OFBIZ-4755 Project: OFBiz Issue Type: Bug Components:

Re: svn commit: r1304369 - in /ofbiz/trunk: ./ framework/ tools/ tools/api-java16/ tools/src/

2012-03-24 Thread Jacopo Cappellato
On Mar 24, 2012, at 12:32 PM, Hans Bakker wrote: Hi Jacques, Anything can be changed and anything can be adapted, however such basic commands like start and stop should not be moved lightly. The compromise i can offer is to have the original commit with symbolic links in the root

[jira] [Updated] (OFBIZ-4736) Add Product Reviews to the profile Screen

2012-03-24 Thread Markus M. May (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Markus M. May updated OFBIZ-4736: - Attachment: OFBIZ-4736-Add_product_reviews_to_the_profile_screen.patch Add the same patch, this

[jira] [Updated] (OFBIZ-4736) Add Product Reviews to the profile Screen

2012-03-24 Thread Markus M. May (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Markus M. May updated OFBIZ-4736: - Attachment: OFBIZ-4736-Add_Product_Reviews_to_the_profile_screen.patch Getting used to svn ;-(

Re: [jira] [Created] (OFBIZ-4755) E-commerce search does not always functioning correctly

2012-03-24 Thread Info Olagos
Hello , The search tool in a ecommerce website is the most important commercial tool. The search tool in the ecommerce website is a very strong tool in ofbiz. However i think also there need some details to be improved, in order to make it a complete professional tool. regards, Heidi

Re: svn commit: r1304369 - in /ofbiz/trunk: ./ framework/ tools/ tools/api-java16/ tools/src/

2012-03-24 Thread Hans Bakker
On 03/25/2012 02:19 AM, Jacopo Cappellato wrote: On Mar 24, 2012, at 12:32 PM, Hans Bakker wrote: Hi Jacques, Anything can be changed and anything can be adapted, however such basic commands like start and stop should not be moved lightly. The compromise i can offer is to have the original

[jira] [Commented] (OFBIZ-4496) Quick complete Drop Shipment on purchase order causes many warning messages

2012-03-24 Thread Kiran Gawde (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237735#comment-13237735 ] Kiran Gawde commented on OFBIZ-4496: I fixed some of those warnings. The patch was